From: David Hildenbrand <david@redhat.com>
To: Christian Brauner <brauner@kernel.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: Vlastimil Babka <vbabka@suse.cz>,
Suren Baghdasaryan <surenb@google.com>,
Matthew Bobrowski <repnop@google.com>,
Alexander Duyck <alexander.h.duyck@linux.intel.com>,
Jan Kara <jack@suse.cz>,
Christian Brauner <christian.brauner@ubuntu.com>,
Minchan Kim <minchan@kernel.org>
Subject: Re: [PATCH v2 2/2] mm: use pidfd_get_task()
Date: Tue, 12 Oct 2021 16:13:31 +0200 [thread overview]
Message-ID: <b91f642b-2b64-a60c-89e2-0317164c7b70@redhat.com> (raw)
In-Reply-To: <20211011133245.1703103-3-brauner@kernel.org>
On 11.10.21 15:32, Christian Brauner wrote:
> From: Christian Brauner <christian.brauner@ubuntu.com>
>
> Instead of duplicating the same code in two places use the newly added
> pidfd_get_task() helper. This fixes an (unimportant for now) bug where
> PIDTYPE_PID is used whereas PIDTYPE_TGID should have been used.
What would have been the effect of the BUG? Is it worth Fixes: or better
even separating out the fix?
>
> Link: https://lore.kernel.org/r/20211004125050.1153693-3-christian.brauner@ubuntu.com
> Cc: Vlastimil Babka <vbabka@suse.cz>
> Cc: Suren Baghdasaryan <surenb@google.com>
> Cc: Matthew Bobrowski <repnop@google.com>
> Cc: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Minchan Kim <minchan@kernel.org>
> Reviewed-by: Matthew Bobrowski <repnop@google.com>
> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
> ---
> /* v2 */
> unchanged
Acked-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-10-12 14:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 13:32 [PATCH v2 0/2] Introduce simple pidfd to task helper Christian Brauner
2021-10-11 13:32 ` [PATCH v2 1/2] pid: add pidfd_get_task() helper Christian Brauner
2021-10-12 14:11 ` David Hildenbrand
2021-10-11 13:32 ` [PATCH v2 2/2] mm: use pidfd_get_task() Christian Brauner
2021-10-12 14:13 ` David Hildenbrand [this message]
2021-10-13 12:12 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b91f642b-2b64-a60c-89e2-0317164c7b70@redhat.com \
--to=david@redhat.com \
--cc=alexander.h.duyck@linux.intel.com \
--cc=brauner@kernel.org \
--cc=christian.brauner@ubuntu.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=repnop@google.com \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox