From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60DEDEED60B for ; Fri, 15 Sep 2023 15:30:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF98D6B037A; Fri, 15 Sep 2023 11:30:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA9FF6B037C; Fri, 15 Sep 2023 11:30:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4A276B037D; Fri, 15 Sep 2023 11:30:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 929F06B037A for ; Fri, 15 Sep 2023 11:30:02 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6535B405F7 for ; Fri, 15 Sep 2023 15:30:02 +0000 (UTC) X-FDA: 81239217444.23.78E69F9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 1670B20035 for ; Fri, 15 Sep 2023 15:29:59 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UWZrnLiZ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694791800; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gJpaxC+7Y+75rYPpbOd56ZO18Rl2VH2cz+UAa2NMxbE=; b=fP/YXDtCNku8/XX2iX79qbyvb+pUQ5c0MSmk5FI0ud4/wwweZ+g4JGOuE01VuSL7k4nzVo ZNftpxAm+ZZ913XdDhcR0IA/KshtTiTNj3S3FfIsMBAntBhwjtr58/2EIjIXhUDm1OVsXZ /UW54S9uVupbSF0oukw4zntkRFtPcWE= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UWZrnLiZ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694791800; a=rsa-sha256; cv=none; b=i18GNwe9KsuRB1O2fzywTcaLIG5nFt+LORoPTXV+uPaKDmRcu/KjbOLTAqyEh4kjPKLFPK rM/+JyvPqmChCSSXu/PKWqAZqnAfbbbyGClql5FfBxDslW+fFLsOcpw+aCurq1AeqgtLXA RoFXZoUHelQd824oTNNwUbfHgdyuZ1o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694791799; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gJpaxC+7Y+75rYPpbOd56ZO18Rl2VH2cz+UAa2NMxbE=; b=UWZrnLiZunK7iSpgOAz9LzJzKseGKbMPvtiBz+1V2NIOOBEksizF3O7aUr0FrTwVvCMDTq W8lsjoLDqTLDffHq+g7vfuH5gWdGlhC6ffopqnttdebauMuIPhF2vHxde0LEkZwsVzwgxS c4nC5Iew79PuzqtA1J9LHvz0VOznBWw= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-650-3KQ5MV4NNxGK4z9AlMqfww-1; Fri, 15 Sep 2023 11:29:57 -0400 X-MC-Unique: 3KQ5MV4NNxGK4z9AlMqfww-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-403ca0e2112so17901305e9.0 for ; Fri, 15 Sep 2023 08:29:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694791796; x=1695396596; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gJpaxC+7Y+75rYPpbOd56ZO18Rl2VH2cz+UAa2NMxbE=; b=FfhE0EMAGhmrmS7JWWnPoZkkI2QG0daxKvWpV699FEXnIjOrIj3PIyGoQ4jMRTuPKN KA682K8X2ftK1SgCEXM/A2dBo0jnNP8gMRED3YarMRwOduFnamHDqxTc2t9SBMkNH3Cl 2W9uC9kGTS+F46c81mO97/FxN971adm//+ftqVdj1QqlJBufP5zyASDkAqFZIuRm8avK mogKyqtk5S/7ZZx5vd2J0aN2OlILAAWa3uzNIUcsHyCLnPQyidoYuARyJLJROFYU1nGM CLAJ6KgkNzo2ZAC9eNrV/cdN7v5VugdTCJGvl2j2bbTn2e8zuZ7ZC3urEDaYyu8cL3Tu Nt3A== X-Gm-Message-State: AOJu0YzwhRiqWn1vH1ZiNqmuGQr+KXdr79jB1EPPilxt4WzpWM9crwnn FnddvVW7VByJF6QUvp4s1bxeHZjEm6U5fyloFO2a8FCQZ8MGTkLuXbWuU+MqaC33r1ad50BL8Di qk9HQDyL/lV4= X-Received: by 2002:a05:600c:2293:b0:3fe:5501:d293 with SMTP id 19-20020a05600c229300b003fe5501d293mr1986142wmf.30.1694791796359; Fri, 15 Sep 2023 08:29:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFIrjtSY3mCEdjzBASUXOKYz2giyEwV+Sal1jqwjEXeA8+EAYhUpoZN7WSinZRhK3GWPQUqaw== X-Received: by 2002:a05:600c:2293:b0:3fe:5501:d293 with SMTP id 19-20020a05600c229300b003fe5501d293mr1986111wmf.30.1694791795956; Fri, 15 Sep 2023 08:29:55 -0700 (PDT) Received: from ?IPV6:2003:cb:c728:e000:a4bd:1c35:a64e:5c70? (p200300cbc728e000a4bd1c35a64e5c70.dip0.t-ipconnect.de. [2003:cb:c728:e000:a4bd:1c35:a64e:5c70]) by smtp.gmail.com with ESMTPSA id l26-20020a056000023a00b0031ff1ef7dc0sm1867385wrz.66.2023.09.15.08.29.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Sep 2023 08:29:55 -0700 (PDT) Message-ID: Date: Fri, 15 Sep 2023 17:29:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 0/6] shmem: high order folios support in write path To: Daniel Gomez , "minchan@kernel.org" , "senozhatsky@chromium.org" , "axboe@kernel.dk" , "djwong@kernel.org" , "willy@infradead.org" , "hughd@google.com" , "akpm@linux-foundation.org" , "mcgrof@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-xfs@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" Cc: "gost.dev@samsung.com" , Pankaj Raghav References: <20230915095042.1320180-1-da.gomez@samsung.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230915095042.1320180-1-da.gomez@samsung.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1670B20035 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: sh9quecnijbs7nqdpmc13eu4qst1j6fo X-HE-Tag: 1694791799-380106 X-HE-Meta: U2FsdGVkX18K/0jP/Rj8zVIlOd/Wwjd0X+yhT8F3if8IbhDkfZy7/BjGOjEImYIFs3tGWgumJRYwPSOr/94lQo9NMN7H2kA4Jy7NLj3ylYjJud0ZZiX8icGsFGlY+Y24nJGuiyUk3nbpn0v1FVaZwr8TAcRNaZxOHA/9Dzbg/5/6P4L014SHkRbWbf9H4gAosHBpZrEhTE0HyrJ3MmLeTNEOPMMW1QmWtNgJqvON6hYWsQBN2jWx0rNnIUk1CQfgcEE7BKa92KEVWf4AEOCywb3VB0TL7YL9LK0h3Cx0lNDpVxGFrwcftK62onU2AtJvrG6TwDnBbqMM4AWj45W4bTvRUngUqFOkboaD8Hz6XLvCTNUrrcnt9FYVJ5bANnHw+qoD3VSvclG5HZ7T6OSmNiaroaKxb1O8AXJCm0qYnzfAeLlbsoZpNlVT8LDLiL9KNURelcrZI0jcvs8o95ZDeFokg5IxN9ZxNTjKTL36E8qbU3DNao1ItdXE0nizPLkt7aZFXH/vAg5a2FUUj4WNiZxt3alfnHRGYW5gIbDfWS01QGLJjeWp3k5C5GJR6t8axFS7vxZ6IGGFA/8PzXPNuTOqTqim3LGxZQPE43GLJBwIZ3GXRZBkfvIGHey7rlMj9yK84Z4lTbV0ATbZo9aSa6MI8Rn3oC4b9zD1DkMu2tlXue5pEVLi2vwtk3vMSZHfzAJwnsyXKvy6pTjbQizHZ6GpZzQd5ldPHz3BF5d3anjzvy87/jCZm1/1CarDcSfogNb6skY9ZaTzBjiqFtKS+P4DjeILib9AIbbiyg0nUu94BqmA8BtVuIL+n06ZXBwUO+bjMgvb79+a3q39x7WFG0uLmMvwVSR/L5cDC0VlinaPFPtR9LATbbdIAAyVIt7RI1miN1WyQhtFwSFgw/l6n2rVj+jwth5seqGsQTqSuCw0UJJ5BOP13c8sa4X+cjd/27NbW7a4XgL9IOQHZZI kGqBnLRD UpDGH6oqeT4yHy1O6MUVUth43IvTX6h+bnLHlqNo24jDEHd+iwXtdAZCXv33kGZtDbhFDtA8tCeH3o8Ju+zm8/r2THyIgpfJP6MRm9TvLCzxgwxEfBGX+obaBqcaiTeuL9cOUCrmbs5o67F/Kh4XwEr93q5/vZxzkJ8g48OQRMFrqbYnigbnT/KU84qDDFO6LCJggMBagWWqge6envjuyZ5aF8thlYx79ttD9zF+VTqDX68ldsda4FkGJQ7dl7Pxr1x1s4/S0FE0yoPgqKANbYcFMVpQOg8wfosrbnU8Tg/MYKzIHkZw0GT+tLdyecoqPWp9OF8bcu8I7Vn6xYlkDfV6+45YaJWeHtIvIsHHh844g2S0IYpT4CTYbcRrNNl0GCS2Tudlg5eYbaGFfGseTjug2/pzjbCGKjYNX8HcN3YFAKx8Nlf5icsCRBmPrdUsMp7z2lODFb0mP5sjWSF/YaHKaz0TdMzFiegOMuEtWxBoEySg8mUo606cRcoLmhSqiSlMJJE9jUbUQaNPcFIQcbiiLwqCiRhBDRqfuO9cw5JQQzyKKHEnKqWnVoPKJw0iehDgsVqg1H5v2aEbCtgymaVaVTI8WOTzsvSgtwi22myzxhI02HBx0+ROoHw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15.09.23 11:51, Daniel Gomez wrote: > This series add support for high order folios in shmem write > path. > > This is a continuation of the shmem work from Luis here [1] > following Matthew Wilcox's suggestion [2] regarding the path to take > for the folio allocation order calculation. > > [1] RFC v2 add support for blocksize > PAGE_SIZE > https://lore.kernel.org/all/ZHBowMEDfyrAAOWH@bombadil.infradead.org/T/#md3e93ab46ce2ad9254e1eb54ffe71211988b5632 > [2] https://lore.kernel.org/all/ZHD9zmIeNXICDaRJ@casper.infradead.org/ > > Patches have been tested and sent from next-230911. They do apply > cleanly to the latest next-230914. > > fsx and fstests has been performed on tmpfs with noswap with the > following results: > - fsx: 2d test, 21,5B > - fstests: Same result as baseline for next-230911 [3][4][5] > > [3] Baseline next-230911 failures are: generic/080 generic/126 > generic/193 generic/633 generic/689 > [4] fstests logs baseline: https://gitlab.com/-/snippets/3598621 > [5] fstests logs patches: https://gitlab.com/-/snippets/3598628 > > There are at least 2 cases/topics to handle that I'd appreciate > feedback. > 1. With the new strategy, you might end up with a folio order matching > HPAGE_PMD_ORDER. However, we won't respect the 'huge' flag anymore if > THP is enabled. > 2. When the above (1.) occurs, the code skips the huge path, so > xa_find with hindex is skipped. Similar to large anon folios (but different to large non-shmem folios in the pagecache), this can result in memory waste. We discussed that topic in the last bi-weekly mm meeting, and also how to eventually configure that for shmem. Refer to of a summary. [1] [1] https://lkml.kernel.org/r/4966f496-9f71-460c-b2ab-8661384ce626@arm.com -- Cheers, David / dhildenb