From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85CFCC43334 for ; Mon, 18 Jul 2022 06:47:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0A028E0002; Mon, 18 Jul 2022 02:47:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB9666B0095; Mon, 18 Jul 2022 02:47:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A83768E0002; Mon, 18 Jul 2022 02:47:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 974506B0093 for ; Mon, 18 Jul 2022 02:47:22 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5DB5A819 for ; Mon, 18 Jul 2022 06:47:22 +0000 (UTC) X-FDA: 79699289124.03.5CA50E4 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) by imf01.hostedemail.com (Postfix) with ESMTP id 0CB0840062 for ; Mon, 18 Jul 2022 06:47:21 +0000 (UTC) Received: by mail-qt1-f174.google.com with SMTP id w29so7392552qtv.9 for ; Sun, 17 Jul 2022 23:47:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=CxwxaDVgue0TLlkqxh1Fx5Wl0sMETEThFBBYudThPAM=; b=H+UuJsNyKDvw1n9H1k+7Bzi4IfrGrJlJ+FBtYdOotBBc1Fy++8aN1z+zX38Ks+nMLU yqbepoXNUqbukUDYaENTap76agS+vPDg2qrlQS0fcX8Q3AiTboQLQafEhG0GR5d2xbbQ KEFkNkX8qchC9rSio2+EfgOSYJrUCEk3qL7X16+RIcufBF+S13t6mBomNPlVtSKxP+ek dMAPtzmL7m4Lx+H2Qm+P+Pe3/8nuXBMmxHmv989XwGiNKYglVfrt2IxKTibXdMT2JN4y lT2uiJ3ZiluA1rr52lXyCK0euw/oPeZU0q89x8UHuxuOVJdfjUv9G4FvBdXiq83U5NAU Be+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=CxwxaDVgue0TLlkqxh1Fx5Wl0sMETEThFBBYudThPAM=; b=kOLtHPZE4JRi8iWi6fnNQxnFpkVnQ+hlfxgNdUSsStf41IFkobtYkKB/zrkaiTDVpo ot/RrBkAPbLudpcaGJbCuunuVbAlgbkjbfnJ2jie15OSYlyTSnNNFimd4Z+o9AA65u76 +wyt6lpW5gArjt/CVEqa7lZl2iRFgMe1XBfgrZU1Ws3vZB15BfFmVRJWVcJ0H2d6fIHn PV9GfRORdjTF1F/Im/YSqvK1xwfcnd7GZEw9Ts+KS9phs44RszguRg6cojzNbpOy0RhL V4zIWFnVfBGif3YHEPlf07/HG+M33RPG/Fbov32mzlZEOqWfX14ARTQcgfsad3blhVX3 fQCQ== X-Gm-Message-State: AJIora/wX9hTfjT2lWUjuIgK0atNlYMufcia1knGM+3sNlWkbfc7UiJi 53XILcf13eeMiJVUnG1qkkyZ3A== X-Google-Smtp-Source: AGRyM1vZ6NSZ6iejW3cP+ma+fW6L3dwMU4IzactuBQcBEgTBGN7rsTMzQU1xDErluCeEX8ueEaVsgQ== X-Received: by 2002:a05:622a:48d:b0:31e:f1a8:61dc with SMTP id p13-20020a05622a048d00b0031ef1a861dcmr1905138qtx.129.1658126841281; Sun, 17 Jul 2022 23:47:21 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id fy19-20020a05622a5a1300b002f936bae288sm2315360qtb.87.2022.07.17.23.47.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jul 2022 23:47:20 -0700 (PDT) Date: Sun, 17 Jul 2022 23:47:08 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.anvils To: Liam Howlett cc: Hugh Dickins , David Hildenbrand , Andrew Morton , Yu Zhao , Matthew Wilcox , "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] maple_tree: Fix sparse reported issues In-Reply-To: <1098dd4d-8f12-4493-5aff-1ee489d8e7@google.com> Message-ID: References: <20220712142441.4184969-1-Liam.Howlett@oracle.com> <653cc1da-e45a-9a93-7158-cee3e710ba35@redhat.com> <20220713132926.3sl7gs67dyjj7kit@revolver> <44a478e8-2ccc-e82-bd5a-172778c01529@google.com> <20220713175013.aoemaelds45aavc4@revolver> <20220715195301.r7ozt6ph2scti7vz@revolver> <20220718022718.wtlw7grwp6dv5fcp@revolver> <1098dd4d-8f12-4493-5aff-1ee489d8e7@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658126842; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CxwxaDVgue0TLlkqxh1Fx5Wl0sMETEThFBBYudThPAM=; b=VKIQ+72woYoOp7GJsFWsuRMO3J9gsAlChkoTeNscDVovbDDIPSY7p4+LiM8SDKl9HkBFNE q+hn58jbGCr11cJZQCaAZPiT9Jtve3iHYup8s1ZCSgCWap+pQNM7ACgwONTquLL9bwdH5M nbyo7JZcChlGNzmZgK45PIaUjxBbhwk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658126842; a=rsa-sha256; cv=none; b=uy6GrdB5qSf+2kTcaA5KPX5gOtZsPtkuTKVbtSy2L+CoCK3AQD5qvtlXgE5KvL35DcGwqc csaIoCDAdcQQKxF91yIAjkIIqR1BNrTHzYVSVP3Wf/41wo5RxZnjseth7ivOhdKtZuWJf6 YdqPVzFGmI2Qc+2LdShlvO4fAt+3i+I= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=H+UuJsNy; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of hughd@google.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=hughd@google.com X-Stat-Signature: 64qhnfdkndzgfj3gt5y6dao6s7hs6fep X-Rspamd-Queue-Id: 0CB0840062 X-Rspam-User: Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=H+UuJsNy; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of hughd@google.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=hughd@google.com X-Rspamd-Server: rspam06 X-HE-Tag: 1658126841-421352 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 17 Jul 2022, Hugh Dickins wrote: > On Mon, 18 Jul 2022, Liam Howlett wrote: > > Do you have the patch > > "maple_tree-Fix-stale-data-copy-in-mas_wr_node_store.patch"? It sounds > > like your issue fits this fix exactly. I was seeing the same issue with > > gcc 9.3.1 20200408 and this bug doesn't happen for me now. The logs > > you sent also fit the situation. I went through the same exercise > > (exorcism?) of debugging the various additions and removals of the VMA > > only to find the issue in the tree itself. The fix also modified the > > test code to detect the issue - which was actually hit but not detected > > in the existing test cases from a live capture of VMA activities. It is > > difficult to spot in the tree dump as well. I am sure I sent this to > > Andrew as it is included in v11 and did not show up in his diff, but I > > cannot find it on lore, perhaps I forgot to CC you? I've attached it > > here for you in case you missed it. > > Thanks! No, I never received that patch, nor can I see it on lore > or marc.info; but I (still) haven't looked at v11, and don't know > about Andrew's diff. Anyway, sounds exciting, I'm eager to stop > writing this mail and get to testing with that in - but please > let me know whether it's the mas_dead_leaves() or the __vma_adjust() > mods you attached previously, which you want me to leave out. I just went ahead with both of those still in, my do_mas_munmap() non-fix reverted, and your "Fix stale data copy" added: looks very promising so far, been running two hours without a problem. I do expect it to hit the migration entry !PageLocked BUG soon (as it quickly did on the laptop), but that's okay: I'll switch over to thinking about that BUG, so long as tonight's run does not crash in some other way. Hugh