From: "Arnd Bergmann" <arnd@arndb.de>
To: "Andrew Morton" <akpm@linux-foundation.org>,
"Arnd Bergmann" <arnd@kernel.org>
Cc: "Johannes Weiner" <hannes@cmpxchg.org>,
"Axel Rasmussen" <axelrasmussen@google.com>,
"Yuanchu Xie" <yuanchu@google.com>, "Wei Xu" <weixugc@google.com>,
"David Hildenbrand (Red Hat)" <david@kernel.org>,
"Michal Hocko" <mhocko@kernel.org>,
"Qi Zheng" <zhengqi.arch@bytedance.com>,
"Shakeel Butt" <shakeel.butt@linux.dev>,
"Lorenzo Stoakes" <lorenzo.stoakes@oracle.com>,
"Baolin Wang" <baolin.wang@linux.alibaba.com>,
"Kairui Song" <kasong@tencent.com>,
"Davidlohr Bueso" <dave@stgolabs.net>,
"Koichiro Den" <koichiro.den@canonical.com>,
"Jiayuan Chen" <jiayuan.chen@shopee.com>,
"Bertrand Wlodarczyk" <bertrand.wlodarczyk@intel.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/vmscan: avoid false-positive -Wuninitialized warning
Date: Fri, 13 Feb 2026 18:07:04 +0100 [thread overview]
Message-ID: <b8f5244e-4ad8-4499-9cc4-c875121cdc2f@app.fastmail.com> (raw)
In-Reply-To: <20260213085842.0654f70a73ec05d88908ec25@linux-foundation.org>
On Fri, Feb 13, 2026, at 17:58, Andrew Morton wrote:
> On Fri, 13 Feb 2026 13:38:56 +0100 Arnd Bergmann <arnd@kernel.org> wrote:
>
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> When the -fsanitize=bounds sanitizer is enabled,
>
> Is this an option in current kernels?
Yes, this is CONFIG_UBSAN_ARRAY_BOUNDS. The actual warning
only shows up in some configurations with that, so either there
is some other dependency, or an element of chance based on gcc
optimizations.
> Seems a large change just to squish a compiler warning. People might
> prefer a simple
>
> - struct ctrl_pos sp, pv;
> + struct ctrl_pos sp, pv = {};
Right, that would clearly also shut up the warning.
To me this seems less intuitive without an extra comment,
since read_ctrl_pos() is meant to initialize the entire
struct, but please pick whichever you find most readable
here.
Arnd
next prev parent reply other threads:[~2026-02-13 17:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-13 12:38 Arnd Bergmann
2026-02-13 16:58 ` Andrew Morton
2026-02-13 17:07 ` Arnd Bergmann [this message]
2026-02-13 17:23 ` Andrew Morton
2026-02-17 20:55 ` Yuanchu Xie
2026-02-17 21:22 ` Axel Rasmussen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8f5244e-4ad8-4499-9cc4-c875121cdc2f@app.fastmail.com \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=arnd@kernel.org \
--cc=axelrasmussen@google.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=bertrand.wlodarczyk@intel.com \
--cc=dave@stgolabs.net \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=jiayuan.chen@shopee.com \
--cc=kasong@tencent.com \
--cc=koichiro.den@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=weixugc@google.com \
--cc=yuanchu@google.com \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox