From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4EAEC3DA6E for ; Wed, 20 Dec 2023 22:29:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 527DE8D0003; Wed, 20 Dec 2023 17:29:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D6758D0002; Wed, 20 Dec 2023 17:29:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 377C48D0003; Wed, 20 Dec 2023 17:29:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 228D68D0002 for ; Wed, 20 Dec 2023 17:29:21 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E2EE3C060E for ; Wed, 20 Dec 2023 22:29:20 +0000 (UTC) X-FDA: 81588638880.04.A7D80EB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 5BED340008 for ; Wed, 20 Dec 2023 22:29:18 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SfFeyc9U; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703111358; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=biKuMYxWNtLoc9oN17eZQHcrTRic6oxMUpNAggHYZyE=; b=iiVID3ID4t/2J5jeFCqeCj9JHVDv4BmivplkWRKyWIvFCImvg7CHLW0M+N3Ku9nh7Jo6fk 881LEQW8jHcoEU6lIxt+jWBc9mY041OL0cFXvUfz23YB20C0ewuaCPyDpxcCFIIU8BRWoc S5fh/16HZcZAxFz2ueXMfH4MMkb/frk= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SfFeyc9U; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703111358; a=rsa-sha256; cv=none; b=pS7U8gjbT7ghvqa3sNEAkWGzHg1JBEUoWlVyigjeuJrdeh0ZFPQOHE6VFUqHMp5wPDr3z/ t+GZa2q4q3leOeSSfuTK+ouTWSBjH2xCdkckYk2BEe8jRJJ6FJ/tvVaCdfiEhTjVOVgtbK OYK400KseucyfXRWlAlrE0mW1bXkzjc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703111357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=biKuMYxWNtLoc9oN17eZQHcrTRic6oxMUpNAggHYZyE=; b=SfFeyc9U8WyKaTHyh28fAcMATvRpJWHpbt1QCYuJ4LCMZPRIdqjOshhhb8PWHmCmSUTfEa g5ydU2qalOQ1tOe1Nf+pKpZt8ShL3h1lWdQ5a61ENYshltcqsxjxPtFkHjPOzoxkGbROpk 4YqpS/kHOVQVieFtqvTgveP+aHm3gFU= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-561-NP__43TkNsee7Ym4HILPGw-1; Wed, 20 Dec 2023 17:29:13 -0500 X-MC-Unique: NP__43TkNsee7Ym4HILPGw-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-336599bf7b8so50114f8f.1 for ; Wed, 20 Dec 2023 14:29:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703111351; x=1703716151; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=biKuMYxWNtLoc9oN17eZQHcrTRic6oxMUpNAggHYZyE=; b=Jr3rT1d9MqyI+1b+bDhUnU5wfrstJzwxztqJTxnTT7HbxBZX8CdoUwTbikv7mEV3lQ cN43KanKjIWllaCUrdYmma2hvmHKRQeb/QkYH1WOb6M8okwgKNgRFxYchWBZ0sDzMW+1 dJuWZFIzoshDZfjYDfxE+dP4y+swHLZpNUkUcqTVX57c5Eue5ypvgNRCZL/t9S6JJ5j6 sJz/Iipdct1MHa/Zn5ivbzrfcltAG7IxK1uIEjLESQiSl891972NuxfmR62DdnObCCjo Tyf6F4/c0qI7tfDbP0NiYL6XtV+6j2JN+0XgI1NqAJQqEtJTjMIh7WA1j2Xyo3JLrjhV Rb9A== X-Gm-Message-State: AOJu0Yy9qddPL5CowmAXU0iujlAR5l0CPI4ZZFLWA6N381UvoaoG8e01 cgbJ18VBYFhPOeoXSFNLSQxdMTuQ9w3rxI+c0Yv19GGEvWK2E1j0oEZDa1PumbTegKhGQdiejwS +8DhRcB+q7HU= X-Received: by 2002:a1c:7414:0:b0:40c:3984:4985 with SMTP id p20-20020a1c7414000000b0040c39844985mr142969wmc.79.1703111351634; Wed, 20 Dec 2023 14:29:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IGi5IOCgb2CqyS6TuCGMRfpRLigZ+qyJiYSR7LUTb3R/siOeoAuuH65SXYN0VAKfTOGT2KFRw== X-Received: by 2002:a1c:7414:0:b0:40c:3984:4985 with SMTP id p20-20020a1c7414000000b0040c39844985mr142966wmc.79.1703111351182; Wed, 20 Dec 2023 14:29:11 -0800 (PST) Received: from ?IPV6:2003:cb:c740:9d00:be3b:a58f:4d39:51e7? (p200300cbc7409d00be3ba58f4d3951e7.dip0.t-ipconnect.de. [2003:cb:c740:9d00:be3b:a58f:4d39:51e7]) by smtp.gmail.com with ESMTPSA id u4-20020a05600c138400b0040c03c3289bsm961430wmf.37.2023.12.20.14.29.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Dec 2023 14:29:10 -0800 (PST) Message-ID: Date: Wed, 20 Dec 2023 23:29:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [linux-next:master] [mm] bbcbf2a3f0: kernel_BUG_at_mm/memory.c To: Andrew Morton , kernel test robot Cc: Matthew Wilcox , oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , linux-kernel@vger.kernel.org References: <202312192319.fa8f5709-oliver.sang@intel.com> <20231220141135.cb4241442b657104f0aeae34@linux-foundation.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231220141135.cb4241442b657104f0aeae34@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5BED340008 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 6uzp6sun7pw7k4ddty896o1nxut85e4q X-HE-Tag: 1703111358-924679 X-HE-Meta: U2FsdGVkX19a7/WLkPImKBwurPzArWV7bUibi5qJ9OGiFLmkXXypVgunJ/hJ7Gb1/AaCRT5KuTd16ZK/NnE6AwvzBm8cltU5EQ3hA9fMShqYz8CUKUcT88rznAFLwpK99b+BN9tVu+pz84Slyf59qAt0ty574/7jjZf700HgX0CenpxKYuskfEyiG/sDM6nN82X7QuG7Yn7FrtLzvm0BB7LnGw+BM37BFmT64NAnFquDf3LLjs8/+ePuwxXq3v4fgXT7ja1u2eNSwW58xpOa53S6fVv2HuMFM8lfRhbHuilkA/PY2Crk3jnIJAHF9/AFKqZy8aBnQ89kftJir+wZYGpO9o2ByRGZ9QZecjBmYNw7g3fik//xhPqExGfZ+tyX08EKsetB2IBs0YQ8Dahj9rOz151hXN/PEb6EXB5PedGogDbkgozMxzgBEVF0V+I+zahDEqMuCxsurliNxpgX7RQARwXtbxhF80ZgF421tdgB4GIRERupdSt6mALy7KJuXXf0ucO7O4Iqkj7uVhAYUEN/uzLQCks+1X5GrBU7cS6Sx4tCr2nAhZH2bSFd9QNV7jNGEqK/eOfYGMA3J2j4kfrIS/mPzXveByRmud2g3ldRF6lkooMi4qFkCjlcN88/tFtjk3VUd63Te4atI55nnF9Nc1xC63qWIrDQIeSeWB1+gHsDGkkWvcNgDZ595SIj7ddD5xBWtPe5vN78RcFnomnUGPUKBjR8yqS3XWjYwk7uiBkZwZVzxEQVCDDMOZ0tBRl6nKmXvOTwSraeyTMqUBY24AQJOimGr5rDuDBd2XoGovw6uXOU5Ob5st3NpFI5vCvs+bsOMOMhIaArCNAIaWhJgMzyKqW59SaaVZNx7pmspCdjo9vJvNsddS4FmnYtl42BT0v7JxFkg2OICtaRutSmab2puaFx5U08lQ7WhMHA9Nft6TbfiMsn5NmwQnoc7sijVJx+vqTxdxFYvtX 117owQt5 LhF9KFuuUa7qq0URW/cPw9fbJZqDRlO8li/vZ5t4ZWk2vcf0iCfYepU30L7kFEG/iUb2vSV9lmpSYEVvPcaDEBvi8WNWAjz9DXtA8+vvsdk6XOSKRZcoNjDiSw1+GRg4NocOnh2CMvnrTwWvFP6RPmwCFJDOAmPCfjPFDmzya/Qan4A+m0l8b4tEwud9F2gNHWUv0bmECyQmCo0dRtJqq4TVytWQueKbBh1jUrVk/g8ea0s8HdmOgBHid96iS3gRPcKnGG8qrF0oRl6WJJ1NkITydykO2/benn5jLf8SnTdIfIsO/3C7OozWgEikKlzlbfqsUmJbyk8EuHHkcO81+BfiS4PMuDvfyYd94k9qxGuZ54D9KN1NQ0MNnAPGOH4PwbMRbDuoyEBmrAdbn5PakVfuqE158u12oYAW4j5D/hPAnHrERkzCSWjvkVd6qpnu9N4EyjVXL6vFfOePU2guA/pi7ZIDkrsGNqtZcv7Vf3QGv75aAWmqUcQJc1rhTt+O3fsfIPTryhVghpPSY3P20PiNrclVY51xzruPuNpBqSIPQ+jT5rsIvybRCMtcPP5CeOEzE8N1c8qkUbd2pvoBjF+s+/sepYMYT8SAy0A+a4RzzLM8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.12.23 23:11, Andrew Morton wrote: > On Tue, 19 Dec 2023 23:46:50 +0800 kernel test robot wrote: > >> >> >> Hello, >> >> kernel test robot noticed "kernel_BUG_at_mm/memory.c" on: >> >> commit: bbcbf2a3f05f74f9d268eab57abbdce6a65a94ad ("mm: convert ksm_might_need_to_copy() to work on folios") > > I assume this is a bisection result, so it's quite repeatable? > >> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master >> >> [test failed on linux-next/master aa4db8324c4d0e67aa4670356df4e9fae14b4d37] >> >> in testcase: vm-scalability >> version: vm-scalability-x86_64-1.0-0_20220518 >> with following parameters: >> >> runtime: 300 >> thp_enabled: always >> thp_defrag: always >> nr_task: 32 >> nr_ssd: 1 >> priority: 1 >> test: swap-w-rand >> cpufreq_governor: performance >> >> test-description: The motivation behind this suite is to exercise functions and regions of the mm/ of the Linux kernel which are of interest to us. >> test-url: https://git.kernel.org/cgit/linux/kernel/git/wfg/vm-scalability.git/ >> >> >> compiler: gcc-12 >> test machine: 128 threads 2 sockets Intel(R) Xeon(R) Platinum 8358 CPU @ 2.60GHz (Ice Lake) with 128G memory >> >> (please refer to attached dmesg/kmsg for entire log/backtrace) >> >> >> >> If you fix the issue in a separate patch/commit (i.e. not just a new version of >> the same patch/commit), kindly add following tags >> | Reported-by: kernel test robot >> | Closes: https://lore.kernel.org/oe-lkp/202312192319.fa8f5709-oliver.sang@intel.com >> >> >> [ 61.404380][ T5947] ------------[ cut here ]------------ >> [ 61.409984][ T5947] kernel BUG at mm/memory.c:3990! >> [ 61.415085][ T5947] invalid opcode: 0000 [#1] SMP NOPTI > > This is > > BUG_ON(folio_test_anon(folio) && PageAnonExclusive(page)); > > and I don't believe that the error path fix > (https://lkml.kernel.org/r/ZXnPtblC6A1IkyAB@casper.infradead.org) will > address this. > > Matthew, have you had a chance to consider? Isn't the page = folio_page(folio, 0); just wrong? We must not do that if the folio didn't change, otherwise we're in trouble if we had a large folio in the swapcache. Maybe something like the following? diff --git a/mm/memory.c b/mm/memory.c index d995ead7a3933..3aca5e33c6f81 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -3961,7 +3961,8 @@ vm_fault_t do_swap_page(struct vm_fault *vmf) folio = swapcache; goto out_page; } - page = folio_page(folio, 0); + if (folio != swapcache) + page = folio_page(folio, 0); /* * If we want to map a page that's in the swapcache writable, we -- Cheers, David / dhildenb