From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24938C433EF for ; Fri, 18 Feb 2022 18:47:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E7716B0075; Fri, 18 Feb 2022 13:47:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8974C6B0078; Fri, 18 Feb 2022 13:47:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 714006B007B; Fri, 18 Feb 2022 13:47:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0110.hostedemail.com [216.40.44.110]) by kanga.kvack.org (Postfix) with ESMTP id 620116B0075 for ; Fri, 18 Feb 2022 13:47:33 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 2A1A89A274 for ; Fri, 18 Feb 2022 18:47:33 +0000 (UTC) X-FDA: 79156783986.15.48DBAE7 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by imf24.hostedemail.com (Postfix) with ESMTP id A648518000C for ; Fri, 18 Feb 2022 18:47:32 +0000 (UTC) Received: by mail-pg1-f178.google.com with SMTP id 132so8613589pga.5 for ; Fri, 18 Feb 2022 10:47:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=9s/ZIHrGES7feK2tz5dP1rmrFQ/RLT8GNy7zBmf9EgA=; b=f0H3TVA9AOk2uGP+1p95rEv5SaFwf75XopgpbmOxZY8zZsMWRS7/ilyAzemq42ESPm wlFR7t4VyV+eB83JWky1FqzO4CdSZjDePKhOC5uuKA42mL9nd98/EVdL9zpuiudJCRHG E/569cf/0s3ZM93xiPP35gjTOIeT6l97ECf0fifUKeerHnYhMsaBs/uZnBlqlDJvqtX8 9zyEy2gnZm6ck0iYurd/2iReR+k7ZeFKo/nzibUUGYQkf6MeYCCb7CUMpRqjEUOum+zH z0+tIlA6QCpa+mIRTL/DQP/NDl3xZeu/8IIub+8KNEX5t30zXH6yiACac5mO3G2kSuAH 2HyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=9s/ZIHrGES7feK2tz5dP1rmrFQ/RLT8GNy7zBmf9EgA=; b=GkH+JTe75erpqEN64CaV5H91aaHRXlujum0BREZKr7i/sNs69lUdwIzAqBD1h8/RAN Hz+80cyOqd/I7RdPc5zH9GW9gtZkbhX9JDibOOWWbnpX4WNa2aTr+ldpZpQwwtXGTHvb PaNsareob0XtYmEJCEPmBo+HsJO13/7sC1ksS54AT9jEGdiC21L6sKmw7rqzolX7hGvk ++gkQlLtz+RPO7gy4uiq21zXpjdLC+ZWKxGMCRoiA7prQ0XYxLN2fAUvW6E72GR4bnhn zU8QE6f9ZKxCFtbiMi5GC561urgAF93ZYIv8/GFZRbLaHX9rDn8m+3Mbg1oMuwlM9J9d 1kcw== X-Gm-Message-State: AOAM531OojXfuBHIT6Nps0TSGXM738ZJp1JAx2ChNW+a3KJYFA8OhEoC V3eHdDmASQG8gm98+nOh/CwQ6A== X-Google-Smtp-Source: ABdhPJxbZeaBnK2HPkHb7qJeePZrSd31i9bN8DyNF4o8wa3tB2DdFjfjcOKFTXhdLq/D0WfDRNYbsQ== X-Received: by 2002:a62:3085:0:b0:4e0:1218:6d03 with SMTP id w127-20020a623085000000b004e012186d03mr9053021pfw.19.1645210051404; Fri, 18 Feb 2022 10:47:31 -0800 (PST) Received: from [2620:15c:29:204:701:472c:4005:6710] ([2620:15c:29:204:701:472c:4005:6710]) by smtp.gmail.com with ESMTPSA id h5sm3534755pfc.118.2022.02.18.10.47.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Feb 2022 10:47:30 -0800 (PST) Date: Fri, 18 Feb 2022 10:47:30 -0800 (PST) From: David Rientjes To: Greg Kroah-Hartman cc: linux-kernel@vger.kernel.org, stable , Kees Cook , Daniel Micay , Nick Desaulniers , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Nathan Chancellor , linux-mm@kvack.org, llvm@lists.linux.dev Subject: Re: [PATCH] slab: remove __alloc_size attribute from __kmalloc_track_caller In-Reply-To: <20220218131358.3032912-1-gregkh@linuxfoundation.org> Message-ID: References: <20220218131358.3032912-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: A648518000C X-Stat-Signature: 5omdgueta8h4xpa9pt1xxwc9it6opqts Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=f0H3TVA9; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of rientjes@google.com designates 209.85.215.178 as permitted sender) smtp.mailfrom=rientjes@google.com X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1645210052-902950 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 18 Feb 2022, Greg Kroah-Hartman wrote: > Commit c37495d6254c ("slab: add __alloc_size attributes for better > bounds checking") added __alloc_size attributes to a bunch of kmalloc > function prototypes. Unfortunately the change to __kmalloc_track_caller > seems to cause clang to generate broken code and the first time this is > called when booting, the box will crash. > > While the compiler problems are being reworked and attempted to be > solved, let's just drop the attribute to solve the issue now. Once it > is resolved it can be added back. > > Fixes: c37495d6254c ("slab: add __alloc_size attributes for better bounds checking") > Cc: stable > Cc: Kees Cook > Cc: Daniel Micay > Cc: Nick Desaulniers > Cc: Christoph Lameter > Cc: Pekka Enberg > Cc: David Rientjes > Cc: Joonsoo Kim > Cc: Andrew Morton > Cc: Vlastimil Babka > Cc: Nathan Chancellor > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Cc: llvm@lists.linux.dev > Signed-off-by: Greg Kroah-Hartman Acked-by: David Rientjes