From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D49C4C48297 for ; Fri, 9 Feb 2024 17:20:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 639296B007E; Fri, 9 Feb 2024 12:20:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E8FA6B0080; Fri, 9 Feb 2024 12:20:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B0F56B0081; Fri, 9 Feb 2024 12:20:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3C5656B007E for ; Fri, 9 Feb 2024 12:20:22 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 09F1880323 for ; Fri, 9 Feb 2024 17:20:22 +0000 (UTC) X-FDA: 81772929084.28.11D8A67 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by imf16.hostedemail.com (Postfix) with ESMTP id ED1DB18000D for ; Fri, 9 Feb 2024 17:20:18 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=keTA0ryV; spf=pass (imf16.hostedemail.com: domain of eddyz87@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=eddyz87@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707499219; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Yb3+u+NQguLS/li+kaMHx2OU0Nns40V2ZAiikmaHqLo=; b=JX4mPcjlyF3QpmbpY7Z8t71cIq8FVdDoQ9H9SYBDx+zTQbvSYm6Ns6NSfUfwxY/+cZz80g JGWX90PYVIvmf7Drj9X/Kj5pTb6vcWxEAy+3/2UVrjRZm8imcyu7M5ZKMuRUQ9nDr0Iyw6 sbneuIvW946T7beC/HWKp1II58HHZcs= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=keTA0ryV; spf=pass (imf16.hostedemail.com: domain of eddyz87@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=eddyz87@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707499219; a=rsa-sha256; cv=none; b=hOo1tov3db7qMmNniz6BsX/i4Ef1Is+SXV+a/uyNVNagcubD7njhJki/ciOl//aQxDvJVQ dRNZkUYSR6zDKkdXZzx+ImLij/sc+BEFbo95Kwqsncsom7HKZHdZxoekiVSdvSJ5Klf9sx VYpgqrXzOpsbpqAslwf8IuO4OioQraU= Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-55a5e7fa471so1558976a12.1 for ; Fri, 09 Feb 2024 09:20:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707499217; x=1708104017; darn=kvack.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=Yb3+u+NQguLS/li+kaMHx2OU0Nns40V2ZAiikmaHqLo=; b=keTA0ryV7afI5tj1Uejomr/bJ61baREHVUGaKkgTQyIhfNxf9DJ1Q5f4/HdBHLBGMH by3naQ09EBikjAjWW4t+VMvw+niFGdx9iCOffSvgE3rMRYnt+7p9EswPzVgYqUMLi9hV dJxitusSiZU5E/aKK2HonUK9NM2uerPjSmS/4F1A846wXK9e79Q9WT3ztFT3710xcPzF 9lKg+2kB95Xo0p+Q4gp3Vk/xdq6s7Xl7IWpk18/GAj8lH7NfEaydGWPaqji46DE5w+Dq kvjvFUwxBWLNPS6rjscv6QoevJnTsXWmBwuSGY6n+KTrFPrxUjVx6JWV8BBuVxhjLKU0 tKyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707499217; x=1708104017; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Yb3+u+NQguLS/li+kaMHx2OU0Nns40V2ZAiikmaHqLo=; b=BlkeaoSMMKYly9UcdmFkrKgH2PImpc0ioYvYlN5RZIEBPUpim5uyMMPjthmzzmcLHy j6tyo866iCeATjgD+MZ3IL+g/3QE79fVwTDMucGYAzHTjL88fBawaF5pUIlV36bic5KG /tJxUTjCTj1frvRXnQXaRYPMtynuiPn5Xy7Upxl+hlmTEbLWNamqMolUgXavLInXjJEr wRbjlR34WHWiKIHnz/PHHiu+YAUTAkgP7uXT/KsOOGiWlJMhuGgWXmJJFDCb9hIzcvD4 QLIsihLy0SxRExnMj1lyD3U4mtYT2ihw54g/THjjwSFW7KDvrjyFuArAGq5zgdYCo6DW XkMA== X-Gm-Message-State: AOJu0Yz1Wy4I51eNHkGVH2mAvMRhAcZTMCnk7S4Fi/uyn6Ao+Pr4RoVY /gDbVBBTpn4OPoCsx8FajpfkWqXNSyO22upo8hCutfifQz0n6mD2 X-Google-Smtp-Source: AGHT+IGKqE8Ypo7bQgt1GIII1E+JLIobh/hSE56P169utGfYWsKNJjFvSKKYWEsJVe36HZOQVL/OUw== X-Received: by 2002:aa7:d40e:0:b0:55f:cca3:e89e with SMTP id z14-20020aa7d40e000000b0055fcca3e89emr1707673edq.21.1707499217179; Fri, 09 Feb 2024 09:20:17 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCW26FksTgcNEfWk0e8oyMu8bAXpZ5/A+42+N7NDm0kAyh+3c8FEs62LiUAFzXs0EWRgO3QICwzGjAqlfNl2zaMALmeyLrPG66e9keFVoOPdBVql8A/J6l7xNwEpBsfqP5DpP8H775kiJWLZVpgMd8I+tOH3hzA7km2+mh6uE903fkjgxW/WZlyeZaK1dOaBFqBAt7znD9ArPWhMRjfSxZn21aOnX0aeh+F3hy37SvGvaisHgVIuuNrzrsZjyjDjMjnisJPWkSVDQ7K5XQsZNdMRVPnewTAEkZp51OA8vuOEkuzy0L+vwV5SVQ49yTq+JQucnP0tSuWoPbFqseShIuR6H5V5CfBazy3Gqi92Na2kyP76C0E6YV+4 Received: from [192.168.1.94] (host-176-36-0-241.b024.la.net.ua. [176.36.0.241]) by smtp.gmail.com with ESMTPSA id a17-20020aa7cf11000000b005612ac47d85sm951380edy.82.2024.02.09.09.20.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Feb 2024 09:20:16 -0800 (PST) Message-ID: Subject: Re: [PATCH v2 bpf-next 07/20] bpf: Add x86-64 JIT support for PROBE_MEM32 pseudo instructions. From: Eduard Zingerman To: Alexei Starovoitov , bpf@vger.kernel.org Cc: daniel@iogearbox.net, andrii@kernel.org, memxor@gmail.com, tj@kernel.org, brho@google.com, hannes@cmpxchg.org, lstoakes@gmail.com, akpm@linux-foundation.org, urezki@gmail.com, hch@infradead.org, linux-mm@kvack.org, kernel-team@fb.com Date: Fri, 09 Feb 2024 19:20:15 +0200 In-Reply-To: <20240209040608.98927-8-alexei.starovoitov@gmail.com> References: <20240209040608.98927-1-alexei.starovoitov@gmail.com> <20240209040608.98927-8-alexei.starovoitov@gmail.com> Autocrypt: addr=eddyz87@gmail.com; prefer-encrypt=mutual; keydata=mQGNBGKNNQEBDACwcUNXZOGTzn4rr7Sd18SA5Wv0Wna/ONE0ZwZEx+sIjyGrPOIhR14/DsOr3ZJer9UJ/WAJwbxOBj6E5Y2iF7grehljNbLr/jMjzPJ+hJpfOEAb5xjCB8xIqDoric1WRcCaRB+tDSk7jcsIIiMish0diTK3qTdu4MB6i/sh4aeFs2nifkNi3LdBuk8Xnk+RJHRoKFJ+C+EoSmQPuDQIRaF9N2m4yO0eG36N8jLwvUXnZzGvHkphoQ9ztbRJp58oh6xT7uH62m98OHbsVgzYKvHyBu/IU2ku5kVG9pLrFp25xfD4YdlMMkJH6l+jk+cpY0cvMTS1b6/g+1fyPM+uzD8Wy+9LtZ4PHwLZX+t4ONb/48i5AKq/jSsb5HWdciLuKEwlMyFAihZamZpEj+9n91NLPX4n7XeThXHaEvaeVVl4hfW/1Qsao7l1YjU/NCHuLaDeH4U1P59bagjwo9d1n5/PESeuD4QJFNqW+zkmE4tmyTZ6bPV6T5xdDRHeiITGc00AEQEAAbQkRWR1YXJkIFppbmdlcm1hbiA8ZWRkeXo4N0BnbWFpbC5jb20+iQHUBBMBCgA+FiEEx+6LrjApQyqnXCYELgxleklgRAkFAmKNNQECGwMFCQPCZwAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQLgxleklgRAlWZAv/cJ5v3zlEyP0/jMKQBqbVCCHTirPEw+nqxbkeSO6r2FUds0NnGA9a6NPOpBH+qW7a6+n6q3sIbvH7jlss4pzLI7LYlDC6z+egTv7KR5X1xFrY1uR5UGs1beAjnzYeV2hK4yqRUfygsT0Wk5e4FiNBv4+DUZ8r0cNDkO6swJxU55DO21mcteC147+4aDoHZ40R0tsAu+brDGSSoOPpb0RWVsEf9XOBJqWW A+T7mluw nYzhLWGcczc6J71q1Dje0l5vIPaSFOgwmWD4DA+WvuxM/shH4rtWeodbv iCTce6yYIygHgUAtJcHozAlgRrL0jz44cggBTcoeXp/atckXK546OugZPnl00J3qmm5uWAznU6T5YDv2vCvAMEbz69ib+kHtnOSBvR0Jb86UZZqSb4ATfwMOWe9htGTjKMb0QQOLK0mTcrk/TtymaG+T4Fsos0kgrxqjgfrxxEhYcVNW8v8HISmFGFbqsJmFbVtgk68BcU0wgF8oFxo7u+XYQDdKbI1uQGNBGKNNQEBDADbQIdo8L3sdSWGQtu+LnFqCZoAbYurZCmUjLV3df1b+sg+GJZvVTmMZnzDP/ADufcbjopBBjGTRAY4L76T2niu2EpjclMMM3mtrOc738Kr3+RvPjUupdkZ1ZEZaWpf4cZm+4wH5GUfyu5pmD5WXX2i1r9XaUjeVtebvbuXWmWI1ZDTfOkiz/6Z0GDSeQeEqx2PXYBcepU7S9UNWttDtiZ0+IH4DZcvyKPUcK3tOj4u8GvO3RnOrglERzNCM/WhVdG1+vgU9fXO83TB/PcfAsvxYSie7u792s/I+yA4XKKh82PSTvTzg2/4vEDGpI9yubkfXRkQN28w+HKF5qoRB8/L1ZW/brlXkNzA6SveJhCnH7aOF0Yezl6TfX27w1CW5Xmvfi7X33V/SPvo0tY1THrO1c+bOjt5F+2/K3tvejmXMS/I6URwa8n1e767y5ErFKyXAYRweE9zarEgpNZTuSIGNNAqK+SiLLXt51G7P30TVavIeB6s2lCt1QKt62ccLqUAEQEAAYkBvAQYAQoAJhYhBMfui64wKUMqp1wmBC4MZXpJYEQJBQJijTUBAhsMBQkDwmcAAAoJEC4MZXpJYEQJkRAMAKNvWVwtXm/WxWoiLnXyF2WGXKoDe5+itTLvBmKcV/b1OKZF1s90V7WfSBz712eFAynEzyeezPbwU8QBiTpZcHXwQni3 IYKvsh7s t1iq+gsfnXbPz5AnS598ScZI1oP7OrPSFJkt/z4acEbOQDQs8aUqrd46PV jsdqGvKnXZxzylux29UTNby4jTlz9pNJM+wPrDRmGfchLDUmf6CffaUYCbu4FiId+9+dcTCDvxbABRy1C3OJ8QY7cxfJ+pEZW18fRJ0XCl/fiV/ecAOfB3HsqgTzAn555h0rkFgay0hAvMU/mAW/CFNSIxV397zm749ZNLA0L2dMy1AKuOqH+/B+/ImBfJMDjmdyJQ8WU/OFRuGLdqOd2oZrA1iuPIa+yUYyZkaZfz/emQwpIL1+Q4p1R/OplA4yc301AqruXXUcVDbEB+joHW3hy5FwK5t5OwTKatrSJBkydSF9zdXy98fYzGniRyRA65P0Ix/8J3BYB4edY2/w0Ip/mdYsYQljBY0A== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.3 MIME-Version: 1.0 X-Rspamd-Queue-Id: ED1DB18000D X-Rspam-User: X-Stat-Signature: k4pusgp6cs9i1n9o33dzwyjfakmkeqir X-Rspamd-Server: rspam01 X-HE-Tag: 1707499218-353559 X-HE-Meta: U2FsdGVkX1+MJMRqdaIXyil7GUFq5QhsZev/CMPxUQyVJ/y/g8+7Er+c3Yg6uZqYtPYq8wTM7B8UWZvlNuYz8iu8KWLVMbQf+1Wd5K8PvjLWpBuXsYPMot8K6/nCozGT5d2W6hvFwFXL1KTS0ELzjywSgP8yMB3mkKWKPNvkYRytx6xD/8O6Nkn+Fo91dIAC3NBP1Wf0ZuTtIKoTUTCOga3glrALZEHjioWSjVr5ctiYa3s+ZyLZEseg9LACgDnIiqXEQGOMu7EjaqIh40UQDbuZHx8D10HFyd05LVScqbE6l6TIbBHR+OK9e92mUz1lS5xaXE9A9jIba0WfC0277NQqb0NupC3q8eCqThtMWEh4CjvvfCZBVfiMTEJZVhf+z9sTdUHP1IrYeCa3IrJr8bQxrTabSFSOqKpBwXujb+snV0pWRV5HaeJ+Xw8gFELqa3Rsh8ebMAJP/BAaoA8wOkshPeff/5ZBH5uayAww44V/1HnKuvbnSKAab/B7X8Hgw+L+3tnYrQNisiLe/O+yMXO+3gjhB65k5z5iy9z6GYRt1Q7Nv0Z/+c6O8uX0QZj1zY5LpafvU+Bb1WqGAI7FPJzLGTSiIJY16/YZNMpK5OXwwwUSiCb6qMPFIYUb3jYvfQwMNMX6effhnNjJGTzKPLMVdcHs9I/clO3ERvKhpXZlZTeysnFCXgef7+YeMHbG+xJv4UlNx3Ahtc6CHqHojyc+f5Eh5iFwAyP2iTXlSNFnL5pF2Pqgp79obGSLvqxxVWUtuI17+2S0sjLiQ1530ZsPkyJ/ERsEC46EFXwl6d0SwXItgIAynQGnOzXCjaBiHupLnvx9Aex0T+0rqZPflisPtvG4UEU3IMJMsS1ZzpyTHQjK7FHa+66vRIUhyJVdTXoONvMrMFme2V7F7G8uQryHKKSNfHrJYsaxUNWeDhXJ6srkTi8J+utKMaE5Rby4SvPAGz+IXXjvgyXnC82 BLhhk5dJ jGW/W5feGa2iDThFnQnhkfDuE3ydvVry/92UF+V1FMSVK748/gwLGgbzAKiyJAD4W/JwThjhVwDk/GnhcQ4LiuMEuWnZXyiWSGkuBu1Ge17cjV4m4zZ5tOQljzx1qfi9k3IfEs+ij4lfo53AlGmUGjaodGfHbzioJ10OooNeKiXT8corx2FYuuSX3SuwHbHHhfn+z255IuVZtxPzPZnDikiENO9UoIp0C5oy7LS5xAeerofwFFi8CeRNHi3kcjEXxL3pkX0D6q7Y8/8tHI21QeKD9goU2Nejbp0x2pphzL9MBX3hOx7it/YgVrhDilAfQc73jmjF6jme49uuUjbO93PQ7RLIk4pKnB1VSpI/0AB4GbH7l8c3q47aPKgQyK3wLnJ852pndn9Y9X/CyqLKndpDHNzLrN65QeMefH2oAzqArGYe/hxsZqDIXC954HBl6Tic+J4sEa6X8TsFgLitGuaJ7GnJo2ZZq5Y+u7kmo7/unyxiLIRmlFSR+l0SyzXh0YXje3NSauO3w08e4oj0NqtxJhcS4FWfkdha3V2tX96QMcJa3cLh549xhiuy7VPpQ0uUrPnhksn+I8LG6ufQEusZ/t+WGGE2sclj7Udd03dPBhlY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000062, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 2024-02-08 at 20:05 -0800, Alexei Starovoitov wrote: > From: Alexei Starovoitov >=20 > Add support for [LDX | STX | ST], PROBE_MEM32, [B | H | W | DW] instructi= ons. > They are similar to PROBE_MEM instructions with the following differences= : > - PROBE_MEM has to check that the address is in the kernel range with > src_reg + insn->off >=3D TASK_SIZE_MAX + PAGE_SIZE check > - PROBE_MEM doesn't support store > - PROBE_MEM32 relies on the verifier to clear upper 32-bit in the registe= r > - PROBE_MEM32 adds 64-bit kern_vm_start address (which is stored in %r12 = in the prologue) > Due to bpf_arena constructions such %r12 + %reg + off16 access is guara= nteed > to be within arena virtual range, so no address check at run-time. > - PROBE_MEM32 allows STX and ST. If they fault the store is a nop. > When LDX faults the destination register is zeroed. >=20 > Signed-off-by: Alexei Starovoitov > --- It would be great to add support for these new probe instructions in disasm= , otherwise commands like "bpftool prog dump xlated" can't print them. I sort-of brute-force verified jit code generated for new instructions and disassembly seem to be as expected. [...] > @@ -1564,6 +1697,52 @@ st: if (is_imm8(insn->off)) > emit_stx(&prog, BPF_SIZE(insn->code), dst_reg, src_reg, insn->off); > break; > =20 > + case BPF_ST | BPF_PROBE_MEM32 | BPF_B: > + case BPF_ST | BPF_PROBE_MEM32 | BPF_H: > + case BPF_ST | BPF_PROBE_MEM32 | BPF_W: > + case BPF_ST | BPF_PROBE_MEM32 | BPF_DW: > + start_of_ldx =3D prog; > + emit_st_r12(&prog, BPF_SIZE(insn->code), dst_reg, insn->off, insn->im= m); > + goto populate_extable; > + > + /* LDX: dst_reg =3D *(u8*)(src_reg + r12 + off) */ > + case BPF_LDX | BPF_PROBE_MEM32 | BPF_B: > + case BPF_LDX | BPF_PROBE_MEM32 | BPF_H: > + case BPF_LDX | BPF_PROBE_MEM32 | BPF_W: > + case BPF_LDX | BPF_PROBE_MEM32 | BPF_DW: > + case BPF_STX | BPF_PROBE_MEM32 | BPF_B: > + case BPF_STX | BPF_PROBE_MEM32 | BPF_H: > + case BPF_STX | BPF_PROBE_MEM32 | BPF_W: > + case BPF_STX | BPF_PROBE_MEM32 | BPF_DW: > + start_of_ldx =3D prog; > + if (BPF_CLASS(insn->code) =3D=3D BPF_LDX) > + emit_ldx_r12(&prog, BPF_SIZE(insn->code), dst_reg, src_reg, insn->of= f); > + else > + emit_stx_r12(&prog, BPF_SIZE(insn->code), dst_reg, src_reg, insn->of= f); > +populate_extable: > + { > + struct exception_table_entry *ex; > + u8 *_insn =3D image + proglen + (start_of_ldx - temp); > + s64 delta; > + > + if (!bpf_prog->aux->extable) > + break; > + > + ex =3D &bpf_prog->aux->extable[excnt++]; Nit: this seem to mostly repeat exception logic for "BPF_LDX | BPF_MEM | BPF_B" & co, is there a way to abstract it a bit? Also note that there excnt is checked for overflow.