linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@linux.intel.com>
To: Michal Hocko <mhocko@kernel.org>, Kemi Wang <kemi.wang@intel.com>
Cc: "Luis R . Rodriguez" <mcgrof@kernel.org>,
	Kees Cook <keescook@chromium.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Mel Gorman <mgorman@techsingularity.net>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Christopher Lameter <cl@linux.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Vlastimil Babka <vbabka@suse.cz>,
	Hillf Danton <hillf.zj@alibaba-inc.com>,
	Tim Chen <tim.c.chen@intel.com>,
	Andi Kleen <andi.kleen@intel.com>,
	Jesper Dangaard Brouer <brouer@redhat.com>,
	Ying Huang <ying.huang@intel.com>, Aaron Lu <aaron.lu@intel.com>,
	Proc sysctl <linux-fsdevel@vger.kernel.org>,
	Linux MM <linux-mm@kvack.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] mm, sysctl: make VM stats configurable
Date: Fri, 15 Sep 2017 07:16:23 -0700	[thread overview]
Message-ID: <b8d952c5-2803-eea2-cd9a-20463a48075e@linux.intel.com> (raw)
In-Reply-To: <20170915114952.czb7nbsioqguxxk3@dhcp22.suse.cz>

On 09/15/2017 04:49 AM, Michal Hocko wrote:
> Why do we need an auto-mode? Is it safe to enforce by default.

Do we *need* it?  Not really.

But, it does offer the best of both worlds: The vast majority of users
see virtually no impact from the counters.  The minority that do need
them pay the cost *and* don't have to change their tooling at all.

> Is it> possible that userspace can get confused to see 0 NUMA stats in
the
> first read while other allocation stats are non-zero?

I doubt it.  Those counters are pretty worthless by themselves.  I have
tooling that goes and reads them, but it aways displays deltas.  Read
stats, sleep one second, read again, print the difference.

The only scenario I can see mattering is someone who is seeing a
performance issue due to NUMA allocation misses (or whatever) and wants
to go look *back* in the past.

A single-time printk could also go a long way to keeping folks from
getting confused.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-09-15 14:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-15  9:23 [PATCH 0/3] Handle zone statistics distinctively based-on Kemi Wang
2017-09-15  9:23 ` [PATCH 1/3] mm, sysctl: make VM stats configurable Kemi Wang
2017-09-15 11:49   ` Michal Hocko
2017-09-15 14:16     ` Dave Hansen [this message]
2017-09-15 14:28       ` Michal Hocko
2017-09-18  2:44         ` kemi
2017-09-18  5:50           ` Michal Hocko
2017-09-16  2:10     ` Wang, Kemi
2017-09-18  3:22     ` kemi
2017-09-18  5:50       ` Michal Hocko
2017-09-15  9:23 ` [PATCH 2/3] mm: Handle numa statistics distinctively based-on different VM stats modes Kemi Wang
2017-09-15 11:50   ` Michal Hocko
2017-09-18  3:07     ` kemi
2017-09-18  4:13       ` Dave Hansen
2017-09-18  5:05         ` kemi
2017-09-15  9:23 ` [PATCH 3/3] sysctl/vm.txt: Update document Kemi Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8d952c5-2803-eea2-cd9a-20463a48075e@linux.intel.com \
    --to=dave.hansen@linux.intel.com \
    --cc=aaron.lu@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi.kleen@intel.com \
    --cc=bigeasy@linutronix.de \
    --cc=brouer@redhat.com \
    --cc=cl@linux.com \
    --cc=corbet@lwn.net \
    --cc=hannes@cmpxchg.org \
    --cc=hillf.zj@alibaba-inc.com \
    --cc=keescook@chromium.org \
    --cc=kemi.wang@intel.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mcgrof@kernel.org \
    --cc=mgorman@techsingularity.net \
    --cc=mhocko@kernel.org \
    --cc=tim.c.chen@intel.com \
    --cc=vbabka@suse.cz \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox