From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D834C282EC for ; Wed, 19 Mar 2025 02:38:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 833B9280004; Tue, 18 Mar 2025 22:38:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7BBF9280001; Tue, 18 Mar 2025 22:38:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 636A1280004; Tue, 18 Mar 2025 22:38:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 40FF8280001 for ; Tue, 18 Mar 2025 22:38:12 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 249368167B for ; Wed, 19 Mar 2025 02:38:12 +0000 (UTC) X-FDA: 83236741224.21.1188670 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf29.hostedemail.com (Postfix) with ESMTP id 2D453120006 for ; Wed, 19 Mar 2025 02:38:09 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jewh22CJ; spf=pass (imf29.hostedemail.com: domain of jiahao.kernel@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=jiahao.kernel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742351890; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5uiqpvRP3XPxWm2NV0PkZWPKnAddXpi1Y8S8sPBln3k=; b=NDKG3dc/Wnn2sFVC+dH3vJzRWR1KLPuG62rzIUS+RmQNA0KVqIPKFYnWly872nB2WUQk9H kScTIFAzKCdzmyIeZn92rkAIKpSr7H7iaWS6aKvUx74mrjfPYcgTJJfJLhKCf5fI+tAEOd /IgQPP329XipP6/SeT1VMMStWCoI2to= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jewh22CJ; spf=pass (imf29.hostedemail.com: domain of jiahao.kernel@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=jiahao.kernel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742351890; a=rsa-sha256; cv=none; b=05pWr5fLN9N6R57T1GU5LCiTymOXVwktb5V6JSIapDJvmTGYygu/DY0KCuJRVCdMzuLwi3 GLQFLBt8qvbKltlkE/jhZBLZ4B6H3L95ZeoBIIWZlHuXMjpS44M2m2d5UJahXGKmKxVQYM Goo3bodFDywyfqEOWDEeZYqeI2Io+XI= Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-22423adf751so111834415ad.2 for ; Tue, 18 Mar 2025 19:38:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742351889; x=1742956689; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=5uiqpvRP3XPxWm2NV0PkZWPKnAddXpi1Y8S8sPBln3k=; b=jewh22CJGQgvGFQWkZ0MI1kYuGbu41kUfVRyTOo8/XjqvNYqWDkB2i+yXqFEEJEDoJ OUMJs8A2qt+5bJe5nFvglsClhJLNOUBxmkJumJi5nYAyaYfTaSjHf1N1DUTJs+0M0kj8 Vcnx7KO7U9Wg1BqkZhV4aLYt43M+mpzhxDNiyPT5tG2x3kvu/VtWMtVgzSp/QkaIhs17 YxNV7zSJncAb0cUQhWFz++CinTd9qfjb6rMeFuqja7XXJV2Y3dzBlZZ5HbZV3aeGdqM+ ZxCpcpvGPwBcCbNO0amUjG6s2slYWLeKhokjbFJie01/Mk3YCf/yLUSnOsI1mD2lw1Y+ ZhVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742351889; x=1742956689; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=5uiqpvRP3XPxWm2NV0PkZWPKnAddXpi1Y8S8sPBln3k=; b=XoqdKmRLM8+GmCRPjssBoOUrBhCNPowfhue9ZqTKfyIGnppgwgWpkjI7Lg1OTdMy1i hBX8VPRGK7/GkIuMKSKfWGXDPjUO4y9KFSQ0qjjnstLo0psKJ9vHOSbkLM/gwoS6+OrQ j3pUaoFEl+A4yuz+FHUJWsDojVUYF1nFJdJuuJDisPx738HVEY4bNqFAjCxYN+wJBWfV j6VHcRJjyMnZwL5Lrq8wwkynv/tQdniQrmNKM09sP7Ki2cm6wwHM2m7RHMmpdB4mlKKo O9Qe+3eIaS9tJCqOCORjTi7AlvwQWX/nx7BetC0JgW0DGvoj/k8KMrA45gSmPeFWvO/8 aHTg== X-Forwarded-Encrypted: i=1; AJvYcCVbTHJmG8wLirJKm5YEwffsl/nluf3FJLVJry6mi8bjnr4YWsuZXIf+RmBR85TqDEOZDl+wj1Fy8A==@kvack.org X-Gm-Message-State: AOJu0Yz54AFtL+MBY27m0tL8gBkm3va3CkcLObgOa9gZXuhW6jIdr5PL EQbrWTi+Uk1ENKv25J0QRwfBQj+AuiVa1VHtcUMy2hRUaUOd4Lq+ X-Gm-Gg: ASbGncta6AIHcYI+A9gwSp2enx9l+mxIK4c8kF00OSejIeyxImjpfnSjAPpqCzsuMuY GDijbZKrfmXsNz106wsq+f12i3P+QoSkfV4DiyTgZhWQ6YC8IGo6ms2lNB4d0cXet1cI8PlqJf1 yS9IjXnLoUd9COfHtmDBdcszZW6xwwYwKM1++ItZ0lyhB0QT15qOMuPNJ0PVnvyBS/mQvh1LqVk fmUVFE8ILEcHoTwXa3q4crQUXQ39d/rZumrxbUIDNLZwBMTB1r6ieSAqE0o6Cv8kihlhLja/Whx S5BHzErLEgB1+1FWu+l79MaXnr4cZLRKQAVRJfDIqZkBXKYi+9O7I34qncchDsCrbg== X-Google-Smtp-Source: AGHT+IHKyMKAM+xsXy3cTomkkroHHXDIVIxP3TgfYLDXmikYftTTRgJgKY4wnTP8KzR6XjF6fyhYdw== X-Received: by 2002:a17:902:e84e:b0:223:501c:7576 with SMTP id d9443c01a7336-226499248aamr13132675ad.12.1742351888857; Tue, 18 Mar 2025 19:38:08 -0700 (PDT) Received: from [10.125.192.74] ([103.165.80.178]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-225c6bd5a7dsm102526865ad.251.2025.03.18.19.38.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Mar 2025 19:38:08 -0700 (PDT) Message-ID: Date: Wed, 19 Mar 2025 10:38:01 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 1/2] mm: vmscan: Split proactive reclaim statistics from direct reclaim statistics To: =?UTF-8?Q?Michal_Koutn=c3=bd?= Cc: hannes@cmpxchg.org, akpm@linux-foundation.org, tj@kernel.org, corbet@lwn.net, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Hao Jia References: <20250318075833.90615-1-jiahao.kernel@gmail.com> <20250318075833.90615-2-jiahao.kernel@gmail.com> From: Hao Jia In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 2D453120006 X-Rspamd-Server: rspam03 X-Stat-Signature: 5fdktm5oebasaffrt9j4fwjjrxpaaw3n X-HE-Tag: 1742351889-946596 X-HE-Meta: U2FsdGVkX1/NAv/N3JiN3eh/+B+u58GY+GgHUFjiaCB86QjaX0fU3JUg2UYan7fdBwuME8Us7bkp2mFIefHvIpqzr5KeIY+RZBOBgl+V1qWTEdqBRnXYPRYY4Qazkw/1bOvv2NjHF/S2/X+QZLjLiVtuozwk+Yz/HAn01K5RF1Lcso1NAGbOFIspMOt8ot6zYfG/rQoAvtlc856pXKHBAcHfh/3/wXhEyToaR+3yPybBpXhDdW6X2QvoF8gz1nC3GzTq4Ih3LLiFkg2PcDbr9E7WP/+O5bo9yjKOgbcev4aLNzRZkSmJIaiS4UxWAt0J+PhqT5yM7jHVpqI/LfY7YCnsBeIPly7fFXZJ3r9z8avM1dYn/mo+mfnrdhY8t7PacDOkf/HS3EfjKHoFKkTOE9vd/cTovVdxdODDbkL6EYtZnQaOGz/SSPvAClfyrIjZei+72UTihISuLkGiIwQFaWdSjx1sSX78mQhCTeASBRarAEhZAWy7VVNXDDyD2fD+PVa1cXZXpDWbH6wOlcKWkJ9hTgLYMan+eUT/DuRWIhaf8QK0+dRNXzEDWef7QHmsCktibC2OTS5ESKUILo1Bl0H2WrgvwlxwmtPggTPrKzwN9N8luXh/0lTwEHp16cFxRgHtb549UFPBAiME1dkvdP2QSPN7XcE7wQgSzpX1Vp6FwGE4DX0SAfcnNYmsJ0MwSgCFTycdRuhtlcPSFUTdlo+QzXhAA5s2/kAb+IpZU/K0GHYYuY7XfBGIReCVP+ta75of24G6v5X4tZt09JuliwYYDYOhDcCIjHcnwXlCx1ZgSurvuiS0UV0ejIEjujPFGmh7k5C9SMIlKuWXRacQAw3uLvjlw7QfWjRwt2gQX+eILH45/rqIQcTQ7cOQVhUnToyQ/Cb3Qtd5QA+PM4uZoNlX43hlaZJoQN4kyNrBcxGF4Mu5yMIKnqgLmQBX+4PWNVCKouDdZkqDewAHm63 Thy30IC4 LT50aY8aHefu384LzE4j4HDbxLcG+inPuh85SShu6KLtlYBmt6356P0uEJBX53F052Uq35mkwScF4SBlPsXJWC09vRsnn8WjSSpJtIdHF9aBTGg2immwyoeeEJnhmqmTHxMGrkFIbjlxqwa1NnuvXLS5Zs9KXc4OMtl0rNJkvDZ4Vcu0u1zptP27D3t7omj2+mGjZcri8rHBc6uL9Q9CisxNXH6VbHWWHilhw9AFWXWAuKY7oaJsueUQ6NFjOnDsUdJuEIijzm+FHYo4COkSqf2BEvnI/yii9bdSiFM7xbdlFYk3VR4RrzpmYYq28t5w8+aEtIg9EDfZw33rc9z7dJ0jNJcA3t/HN9qMxfsx2ofkvqgZGEdNxgfA/WcyG5Kvk5HBk1NgLPmGL8vWIGKo9ViJRyYC4zzqnDweMJghQ5QOlViJIXCuvSofZajw3idC6TEaA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/3/18 20:59, Michal Koutný wrote: > On Tue, Mar 18, 2025 at 08:03:44PM +0800, Hao Jia wrote: >>> How silly is it to have multiple memory.reclaim writers? >>> Would it make sense to bind those statistics to each such a write(r) >>> instead of the aggregated totals? >> >> >> I'm sorry, I didn't understand what your suggestion was conveying. > > For instance one reclaimer for page cache and another for anon (in one > memcg): > echo "1G swappiness=0" >memory.reclaim & > echo "1G swappiness=200" >memory.reclaim > Thank you for your suggestion. However, binding the statistics to the memory.reclaim writers may not be suitable for our scenario. The userspace proactive memory reclaimer triggers proactive memory reclaim on different memory cgroups, and all memory reclaim statistics would be tied to this userspace proactive memory reclaim process. This does not distinguish the proactive memory reclaim status of different cgroups. Thanks, Hao