From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 691D3C46CD2 for ; Tue, 30 Jan 2024 13:53:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D5C826B007E; Tue, 30 Jan 2024 08:53:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D0C9F6B0083; Tue, 30 Jan 2024 08:53:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BFC8B6B0089; Tue, 30 Jan 2024 08:53:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B0C966B007E for ; Tue, 30 Jan 2024 08:53:58 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6AB1E80B96 for ; Tue, 30 Jan 2024 13:53:58 +0000 (UTC) X-FDA: 81736120956.06.2813E33 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf19.hostedemail.com (Postfix) with ESMTP id 25D981A0012 for ; Tue, 30 Jan 2024 13:53:55 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OFU7CFNo; spf=pass (imf19.hostedemail.com: domain of dlemoal@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=dlemoal@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706622836; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dHmYsQMYVH4XZybZTv5hK819ZU488gSDqcYJZ1avndA=; b=3SHb2IzBicplnNkpQ/NSNzfxgXBoAGIUn2vMntMEBmKG1iaz5TJYG5OkXaa+rULebKZZ/Q 1ASJ5GQlybtJScGhsP2P/7ovJDKnX+zPLgqXbh7Pn558X7DtcLSa4vM34DoNBnk/QI+0qP FW4Cas38sqTvmq4/dsoBXRgkPkii1NE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706622836; a=rsa-sha256; cv=none; b=6xPB14qOutQWhiWPirkJlwPB5LhFInlq2Alymym0ouVBAUzeOxbXkVP/fXqSFfm9WilRIg r4pZK1NJg/fkl1xptnmtajfBXfgW9IOoXUjtAJD7xFGHK88GNzXygcDQ6gRUdzQiEALY/P uUy7oEhYwmb+9lwP0RnyIXgVDWyHF0A= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OFU7CFNo; spf=pass (imf19.hostedemail.com: domain of dlemoal@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=dlemoal@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 8A452CE1A7D; Tue, 30 Jan 2024 13:53:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0DFFFC433C7; Tue, 30 Jan 2024 13:53:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706622830; bh=Rbw0bjfu1YktFDI3J38DN6TV3tsl1n6Ebrxsm9br8vc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=OFU7CFNorhBVGsTPusWn+2sB59iM24W5vkZAelhW2wpuZbetl9L3u54yCOub2dJNr 4tR1g6rPlZAcL3IbMmvOpicB5iUYFwNPTt3zuEXOuckwfjU4q92d9YbEJU4W/+vJg0 yT4sbK1J2OlRyJyPWINGU8yABBlFPqvJHesziCxX2i9Dg/pdNyYVISyPtXOocB6K8P HhTsWJKCHgBOBKZWmKHpUr9kdTuYLufJ3J0qIQW8kucynqyYgc1WrPtZCaLsT0O5J/ 4CEC8NxeW5fU0wNp3GsuuaZD0/Dw/oLlo0Ci4Zd0/7wqV8Rj5gGG+pYi5PVYUjug57 3OJbAaIpsws4Q== Message-ID: Date: Tue, 30 Jan 2024 22:53:45 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv5 1/1] block: introduce content activity based ioprio Content-Language: en-US To: Zhaoyang Huang Cc: "zhaoyang.huang" , Andrew Morton , Jens Axboe , Matthew Wilcox , Yu Zhao , Niklas Cassel , "Martin K . Petersen" , Hannes Reinecke , Linus Walleij , linux-mm@kvack.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, steve.kang@unisoc.com References: <20240130084207.3760518-1-zhaoyang.huang@unisoc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: hz6fg735o53fhaxmyfcy5ejojxbqu73o X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 25D981A0012 X-Rspam-User: X-HE-Tag: 1706622835-124104 X-HE-Meta: U2FsdGVkX18loZtor/y4B0t5MEIrTcLXbvNSAMPcCEpivPsubNJVhqrZqkQQQPk0eMfo5+9CMbWtaDaOP9gGaAyItwAxebesoX5TggLSuwAlLIxdB3/jvX7xwMKKoIItdhJyG1jSO5KTTVQ5gYYk29wJB+XNqNsbf9RpnBD0NTQwG4VUw1OPwCagXgVqF1v0OjdgxMa5rp6jiFIVBAWjNYVbo/6YrwjstBRdb41UVIblbuWZbg+9lyWXWmiDydA/+4Mn0qobz2mjJax7xZ2a3pufSuyPFKu7HSkWKOWFH2jZr6is9SY4YpDM/z2Avg3bHL+/dudWrp2pchTCDb3Iik7D/iNWz5Tiomp6iKd3W5EHvzZpq52ten6k2GzkKUw7Zp3LZ6Asul+a2A3wOmr7HXYpJPn4bU7gvRQoB0GfEc4ojFjyj2XvZXJXN+enUn7+1pGnWwpo69dqD/Vjmm+3tce+iZQWSKf9pmKZ+PRN/JTol2ysK/G73P8cb2Y6cpV9LXf7UvyY7TQgrVRXTrZWz9QGhXh25Ym/iXPxSo4AfQdXpB41C0JO1UJUKJKn0f8hP7N04U1ytl3EIwF+L/w5b0n3dC4ClpXNpWPln+5yl6+l4ItARjg73es4HLhARvUQJFwBPcwe7vV1pStkyIKLpwxBvAd+hIwgx67+5j18rNEVi6VxafuqATd4GsRdXQSiXdxg49b78ipjcjxdR0zA7CQZu6sIHI67N7OhS6BiOoaVYsiXzKMmi1/0wQym36QTuz8olaoc6BWQCHRFKACRhfEOJSzUCc9aXfLmIT2OyPi729pOMkeTweHjXAC3gNIyepSxWfNDbf3Q2oMy1aaBg8H3SXRZgg4NjYJxKtd1PKeW2G/F3DIwamWRtbyEUgyUxWaTvogUE2fNs8gSOZbluCifWRVH55pWylt8kEXN6OmvxXWahQdc4e7OrjpDVT+cGMr/jwqvmazUavektlW Ew7GlOYP YsTjYteHAqKFd6a4VciG5S8s4ueiXcd8qD8+EgI3pjNyzPiMR3oak7TafyHCD4JVa/plCkEMvssYKmdVuFLtDObdubKGXlGXrGiW9du/ICV3kH2ZuZdlJK30BLMB0X19cRVwQYi9ajPf99fmsZi7gKjK0zKAeJWpGm5y+9SelQcNWaVRd1CfeVczlqIoUSNA/95j0kYWrJKHhXW0mdJecAtKVIcrLo+dIXMBpXPcejGut4NEZIj6Qt5A15AfGJJdQrIfLYX5oxcvttTw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/30/24 22:28, Zhaoyang Huang wrote: >> That information does not belong to the ioprio. And which scheduler acts on a >> number of pages anyway ? The scheduler sees requests and BIOs. It can determine >> the number of pages they have if that is an information it needs to make >> scheduling decisison. Using ioprio to pass that information down is a dirty hack. > No. IO scheduler acts on IOPRIO_CLASS which is transferred from the > page's activity by the current method. I will implement another > version of iterating pages before submit_bio and feed back to the list Then why are you modifying the ioprio user API to add the 7 bits of activity ? If the scheduler only needs the priority class, then only set that and do not touch the user facing API. -- Damien Le Moal Western Digital Research