From: Damien Le Moal <dlemoal@kernel.org>
To: Zhaoyang Huang <huangzhaoyang@gmail.com>
Cc: "zhaoyang.huang" <zhaoyang.huang@unisoc.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jens Axboe <axboe@kernel.dk>,
Matthew Wilcox <willy@infradead.org>, Yu Zhao <yuzhao@google.com>,
Niklas Cassel <niklas.cassel@wdc.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Hannes Reinecke <hare@suse.de>,
Linus Walleij <linus.walleij@linaro.org>,
linux-mm@kvack.org, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
steve.kang@unisoc.com
Subject: Re: [PATCHv5 1/1] block: introduce content activity based ioprio
Date: Tue, 30 Jan 2024 22:53:45 +0900 [thread overview]
Message-ID: <b8be6eb7-05de-49a0-bdc0-b4d16dfe2966@kernel.org> (raw)
In-Reply-To: <CAGWkznHk2GBrpc6w1az5Q59xj5BoVNrCoD4c=BQ4Jqe2QmkoVg@mail.gmail.com>
On 1/30/24 22:28, Zhaoyang Huang wrote:
>> That information does not belong to the ioprio. And which scheduler acts on a
>> number of pages anyway ? The scheduler sees requests and BIOs. It can determine
>> the number of pages they have if that is an information it needs to make
>> scheduling decisison. Using ioprio to pass that information down is a dirty hack.
> No. IO scheduler acts on IOPRIO_CLASS which is transferred from the
> page's activity by the current method. I will implement another
> version of iterating pages before submit_bio and feed back to the list
Then why are you modifying the ioprio user API to add the 7 bits of activity ?
If the scheduler only needs the priority class, then only set that and do not
touch the user facing API.
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2024-01-30 13:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 8:42 zhaoyang.huang
2024-01-30 9:17 ` Damien Le Moal
2024-01-30 12:43 ` Zhaoyang Huang
2024-01-30 13:17 ` Damien Le Moal
2024-01-30 13:28 ` Zhaoyang Huang
2024-01-30 13:53 ` Damien Le Moal [this message]
2024-01-30 13:52 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8be6eb7-05de-49a0-bdc0-b4d16dfe2966@kernel.org \
--to=dlemoal@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=huangzhaoyang@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=martin.petersen@oracle.com \
--cc=niklas.cassel@wdc.com \
--cc=steve.kang@unisoc.com \
--cc=willy@infradead.org \
--cc=yuzhao@google.com \
--cc=zhaoyang.huang@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox