From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE614C3DA5D for ; Thu, 25 Jul 2024 15:43:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 16C596B0082; Thu, 25 Jul 2024 11:43:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 11D036B0083; Thu, 25 Jul 2024 11:43:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFF016B0085; Thu, 25 Jul 2024 11:43:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D02A16B0082 for ; Thu, 25 Jul 2024 11:43:25 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6F792811DF for ; Thu, 25 Jul 2024 15:43:25 +0000 (UTC) X-FDA: 82378694370.28.77C394C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 227A31C002D for ; Thu, 25 Jul 2024 15:43:22 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bBYUv8yP; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721922201; a=rsa-sha256; cv=none; b=fAmjzMDzHVvlANRObkYi8LVRlEeuruFCJG9ePchJYx+0fnmVYO5QyH5qm8GxJPNpA0K8pL UE7CPF4ysOGfW+Z/Atlq1PxhibjSAvgFMCBCKb+erzALOTPXB0TEa3Isest+5pdXhi3MmK 9N+qOJFTPVzzcnWui32rrzQqyIyaP/k= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bBYUv8yP; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721922201; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=07t/KzeCDIsGwEJfhXWmjwnz1hYHpHpqZts+FET7K3w=; b=2cwXORQXt+XFcGJWNU7cHDi3giqP7RWIWyr6QuwakRQY6t7x8+TfDLn02F419XDzqAc/63 8safSsQppUo+unD6iXnN2mTFgIYB/BRlmUkP/wjA1AgXXAYact09+ca0r0X4ObgilaZ/9m PRcoO6f+Oq585TwV5oVVDNGgwH29zEo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721922202; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=07t/KzeCDIsGwEJfhXWmjwnz1hYHpHpqZts+FET7K3w=; b=bBYUv8yPDI/+Lk6flovM5c6k3U9WBaNIZJczLgka0I2905ikCBMlNG7k1IPHZ49JFkEj4J VPqbTWzo9mcmfjcaZVMFle19e094bliYJ2biaIY2zWYizCQkkxWVoQdjF5qXpt25OrvEVZ ckO2DDhRN7WEvQ38SPd6bENpHPiu7V0= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-564-9YWlioJ7PNiTIiEmABwU-w-1; Thu, 25 Jul 2024 11:43:21 -0400 X-MC-Unique: 9YWlioJ7PNiTIiEmABwU-w-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-36871eb0a8eso613925f8f.3 for ; Thu, 25 Jul 2024 08:43:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721922200; x=1722527000; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=07t/KzeCDIsGwEJfhXWmjwnz1hYHpHpqZts+FET7K3w=; b=HicvV3QAkP00iFTo+hbe7WzqKPzIFwxGWV1SitV6e+C8y4M1uHdJgsX7DHxtSW2GGg gwb/Zceb/TiRfAYysY1XjcePaHoL50/GMRgD0ELmpuYLSXce+nSP8EzagnuKBKZPiFYC nXBRZcmYnMn4Eq9vZ3vv9pjoQeFwXJMy6tg8cigfPQDY5hQZKQMxd0dst7typpey40Z6 THXWHSJrNji+XJk7jObxd2CjM1MaXsnHmckGDEDZy/xbgZRVPUMPGiC06cj4eF1JbDSY 8wsJGGol2H1VGN5s/miFObOK5JKLfW3WoXy/NTpV5Ytl+SuReNqa2vSj91yH6X0r4S7B 59Tg== X-Forwarded-Encrypted: i=1; AJvYcCW1GmtC3F01rC96j75x8y53FLYSfsSbb2Oji5tMfJn8/Wzsp5VqDIFjfSeEpptJCThrD28MxtUv8Dh5sZuq6gQIB5Q= X-Gm-Message-State: AOJu0Yz1iRFi9HWbrnBEem198osoelRs1Utc3W/9sbqrnCjQLMiqzdbl 3Sqb5xYbmaDxVnMfxaeDFQ7300x8GzwIXX6Gr5hnU4nO6uGkX5ceKERtLDHIVRSvQOqv+XvsnXx Pcj2qx92Cxbdc+jiqqIZ55C7x7dmCmeYzwrN/LPqQIfP/+ssD X-Received: by 2002:adf:f510:0:b0:367:97fd:1d75 with SMTP id ffacd0b85a97d-36b31af5c4emr2115123f8f.27.1721922199802; Thu, 25 Jul 2024 08:43:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHleKts63pM5e6MOEPMhM6/043BCKDVzxvpLnOfG0fuWYvONuRV1RJoVlJXCZXXrZ4Gn7UEaw== X-Received: by 2002:adf:f510:0:b0:367:97fd:1d75 with SMTP id ffacd0b85a97d-36b31af5c4emr2115112f8f.27.1721922199424; Thu, 25 Jul 2024 08:43:19 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:2c00:5f6:3120:375a:3e4? (p200300cbc7062c0005f63120375a03e4.dip0.t-ipconnect.de. [2003:cb:c706:2c00:5f6:3120:375a:3e4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36b367c0889sm2603184f8f.22.2024.07.25.08.43.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jul 2024 08:43:18 -0700 (PDT) Message-ID: Date: Thu, 25 Jul 2024 17:43:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: hugetlb: remove left over comment about follow_huge_foo() To: Kefeng Wang , Muchun Song Cc: Andrew Morton , linux-mm@kvack.org References: <20240725021643.1358536-1-wangkefeng.wang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240725021643.1358536-1-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 227A31C002D X-Rspamd-Server: rspam01 X-Stat-Signature: z9ot44w5k7zrijzfh7bb8ce5w9y74r9z X-HE-Tag: 1721922202-402155 X-HE-Meta: U2FsdGVkX1/gN6X7Vcl1eQcVfFix2c5STgF9OgIRT3Gc6i3i0HuB0drMQolidCiCffsMKk1EkzF2EZk9RZcv+jlxA8FPWH67bJQ2pOvBLRHfoYzMtl4fCstC7RuzRKaoLGuT4T8Hh6MUmxERzghqxgfr8gslkCS4dlkTEP5WTdykm5FPJZSmPuQM4hU42ne+g4ckTeBV/oM0pXHuGfbJ/rw74OSWj5SdRsIgqdZEd4r2NVrhDDG9gnsxSxcR//NUYQgz4SoMB717q+cx4wAwnMCamxqtGP03igIyVTsxzlCog60oqjxS3QbLci/O/H+jkOYqtjR6epx5qsxjJygjQmPYrmYko8lBKFV6RRtPT7geVQvxQ8qd+rUZLApWLRsIZgS4yjmIxJr9yNqg9rgrHmCrCQfZJapDr3DrizJ35xcRxb0wvJsVO3oih/m5e4mdBp18ebSHPg/LOHVBSycrTqa2c/40IrOCKJVOWC0gdd5NTNzkwHB1RjJHolJ+T1+uFTcdofBiJnOG9ckqSx9ET32b/KSk9+ffStVVBQgkiToPyWTbzeFNnljD45MguA9n4jG7i9erYgmI1vKLjpNuy5VEIpY4MH1nmmCXUexEvjqENLf+V3Xcat2Xwgx0PeVC5W8HmPp1+GwCQDy1heQlvwO67sbVC/zb2nTGelE/DMCAchAP77+YZhytfQlHXIYlmOjoLIGMSESlUVEl/h3axZqZNRvcNIBMwEKfK8s0JBWDk8wtgAePPpt7sfHTPlUYuIzuE0nFaYqdDTqhrYDrH09ZSFqSRZZ7cy+GfFK5eMNiXJuDFPwOxhjzDt6kis5APjnpH1BkdryWgEvhnwWnDm85PSoFCRIun8nM9y7K7dlciCXl4mUBFpAKhIGCUYi8OuWNQvZhVKHJvEc/Qb9d/vHx6eJmqFLXgW2iRsXmybmxKmkoRU7n9HXyMoeYSXMZ2b0TYAsnENz+y9sxN2f unbJM34E bWTCX84ozZ2TBV5vHB4V6fJFOVKydb7qv4aH3gHM3W5FXzOvkj2M/J7S89b4T86KxydVeRcWBOL27Ryri76ymLUsoHaGpPcAMY4DT75nfz9J+m/6zeiDVoKLZhpuZGExDzLINbvI5L9tJSWyt7DEP+3cg0OJup52IhyKoeUQD6LuUC3Yeeztqj9U5ITdGdVNSISRdTyAb3b3T9GxaJK8x9fSEuEBYz07k5CDIoSlwOfDVsdq+loZpHqfRl1DpSDWhLUHJ2kVCO1hQEjrBRpQz4rWKncpGYFj+PCEZv1KfCrAThOfoGDQRrKl9BpGYufgje6D8mYD6H4eIMq4FHsSFSiJTrmHY1Cq7c7BsHijbPcLsqb3yF/OS0nzTwoG0G0joZ4CGR63yfkOh1IaVEDvEFXXXERp/NxKhFJ/10DtxBHg2wvQ1y0zTO7+tfW0ZhBs5ijEOoNARopQn0NKHpg7MIAFksg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.07.24 04:16, Kefeng Wang wrote: > The comment is useless after commit 57a196a58421 ("hugetlb: simplify > hugetlb handling in follow_page_mask") since all follow_huge_foo() are > killed. > > Signed-off-by: Kefeng Wang > --- > mm/hugetlb.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 0858a1827207..ba176240f764 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -7503,10 +7503,6 @@ __weak unsigned long hugetlb_mask_last_page(struct hstate *h) > > #endif /* CONFIG_ARCH_WANT_GENERAL_HUGETLB */ > > -/* > - * These functions are overwritable if your architecture needs its own > - * behavior. > - */ > bool isolate_hugetlb(struct folio *folio, struct list_head *list) > { > bool ret = true; Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb