linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>,
	Muchun Song <muchun.song@linux.dev>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org
Subject: Re: [PATCH] mm: hugetlb: remove left over comment about follow_huge_foo()
Date: Thu, 25 Jul 2024 17:43:17 +0200	[thread overview]
Message-ID: <b8b21f51-101e-4c36-825c-d391e81c5532@redhat.com> (raw)
In-Reply-To: <20240725021643.1358536-1-wangkefeng.wang@huawei.com>

On 25.07.24 04:16, Kefeng Wang wrote:
> The comment is useless after commit 57a196a58421 ("hugetlb: simplify
> hugetlb handling in follow_page_mask") since all follow_huge_foo() are
> killed.
> 
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
>   mm/hugetlb.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 0858a1827207..ba176240f764 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -7503,10 +7503,6 @@ __weak unsigned long hugetlb_mask_last_page(struct hstate *h)
>   
>   #endif /* CONFIG_ARCH_WANT_GENERAL_HUGETLB */
>   
> -/*
> - * These functions are overwritable if your architecture needs its own
> - * behavior.
> - */
>   bool isolate_hugetlb(struct folio *folio, struct list_head *list)
>   {
>   	bool ret = true;

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb



  parent reply	other threads:[~2024-07-25 15:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-25  2:16 Kefeng Wang
2024-07-25  3:33 ` Muchun Song
2024-07-25 15:43 ` David Hildenbrand [this message]
2024-07-25 16:54 ` Vishal Moola

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8b21f51-101e-4c36-825c-d391e81c5532@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=muchun.song@linux.dev \
    --cc=wangkefeng.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox