From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCCEEC5AD49 for ; Thu, 29 May 2025 15:59:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B6766B007B; Thu, 29 May 2025 11:59:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 63FE26B0083; Thu, 29 May 2025 11:59:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 507246B0085; Thu, 29 May 2025 11:59:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2CF396B007B for ; Thu, 29 May 2025 11:59:48 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C79DFB9DF7 for ; Thu, 29 May 2025 15:59:47 +0000 (UTC) X-FDA: 83496406014.14.356D96D Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf25.hostedemail.com (Postfix) with ESMTP id 54DDCA0007 for ; Thu, 29 May 2025 15:59:45 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qR8NjGsA; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Wl2zwXGd; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qR8NjGsA; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Wl2zwXGd; spf=pass (imf25.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748534385; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ygoaZkXVsuF6OucKuUJ/ojj7zlIyJJr+jLbXhb7mx+k=; b=3BQWj8c/zjrXIp30WO6rFaykn1/Zjxz6HKCMbDz/d0BatoSPntvdFLowDkMYlHE3jxZzrr Mshhn2uS/isSK+oh7k990xlKIFA2NEJ6w5wtOOLR35ZcktjEV8JEfvgq5+xtX4xNui627a XO6OXQctqycodMVPYmDOxjTSv2uyXUw= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qR8NjGsA; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Wl2zwXGd; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qR8NjGsA; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Wl2zwXGd; spf=pass (imf25.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748534385; a=rsa-sha256; cv=none; b=CUpnfA3tWjFI0Cvy8CFrsaue3DKUnAvQJ98TPc48EPemMLC8nnQVj/RYch+rbECU9OI1hA b8cRiexBCKKASqVWczvRvMdtjOMD7D6YzadBxE2kI0gr3HNGJYsjuXEFMHr+L/F9CHZuHQ hoOQIFLp2exXMa4lYtCNdL4J74AbpgI= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7731B1FD19; Thu, 29 May 2025 15:59:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1748534383; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ygoaZkXVsuF6OucKuUJ/ojj7zlIyJJr+jLbXhb7mx+k=; b=qR8NjGsAPIXrLtpQgx4h6dSVdR2ptLaZDkw2CoBItYxB+h690JhSf14zuFLS6hoyPgOKpC /cUryC87hGq/SapEigwvvtzT8P72aTqohJ9H59I6G2mYjCuUIr/zCWKOvC7X4cASPDP3JE 5TusBLrN1jk415ROUPRrpvkq5LvbKRA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1748534383; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ygoaZkXVsuF6OucKuUJ/ojj7zlIyJJr+jLbXhb7mx+k=; b=Wl2zwXGd6UlIILH5N5GJF+sF6TctyzPr+ApjO5pTB8AwYah+7KuXsnuBoZBj6i+MAAbua8 c8iAKUUMoM1daACg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1748534383; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ygoaZkXVsuF6OucKuUJ/ojj7zlIyJJr+jLbXhb7mx+k=; b=qR8NjGsAPIXrLtpQgx4h6dSVdR2ptLaZDkw2CoBItYxB+h690JhSf14zuFLS6hoyPgOKpC /cUryC87hGq/SapEigwvvtzT8P72aTqohJ9H59I6G2mYjCuUIr/zCWKOvC7X4cASPDP3JE 5TusBLrN1jk415ROUPRrpvkq5LvbKRA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1748534383; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ygoaZkXVsuF6OucKuUJ/ojj7zlIyJJr+jLbXhb7mx+k=; b=Wl2zwXGd6UlIILH5N5GJF+sF6TctyzPr+ApjO5pTB8AwYah+7KuXsnuBoZBj6i+MAAbua8 c8iAKUUMoM1daACg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6447713325; Thu, 29 May 2025 15:59:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id oyskGG+EOGhaXgAAD6G6ig (envelope-from ); Thu, 29 May 2025 15:59:43 +0000 Message-ID: Date: Thu, 29 May 2025 17:59:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] mm, slab: support NUMA policy for large kmalloc Content-Language: en-US To: "Christoph Lameter (Ampere)" Cc: David Rientjes , Andrew Morton , Roman Gushchin , Harry Yoo , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250529-frozen-pages-for-large-kmalloc-v1-0-b3aa52a8fa17@suse.cz> <20250529-frozen-pages-for-large-kmalloc-v1-2-b3aa52a8fa17@suse.cz> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Stat-Signature: j8zxqggjfpzo4w7pwc6hmdqbffqionk9 X-Rspamd-Queue-Id: 54DDCA0007 X-Rspamd-Server: rspam11 X-HE-Tag: 1748534385-738308 X-HE-Meta: U2FsdGVkX18SBH4A4/481kdVzCb2baUvvNhw8SroyeUTpHglD79ZeKftmW+Kh8aXAQHqGhO5Os0/3mPb1VABP6LKT9qruHIrRig7PXfcqvQmkGS4f5ZlV3FHHgJXxZ8d0Q4SoYti3fnzTBFNjWjMTz3wXtYHG6++ndDJKUvcL11F6oBdoN40C1BQHWeqY4s0XjmeT30k4GNRq7zGMqc9wuvT2LurpKwxFQtpXayBt7DiicKROSrdCW98qtDWAFvjmLvtchd2wPewYeYp2kUOUqlome0PByzpsyjL9Vn4IQSNBEHmQEZF6/X8yyjaytwCu53R0RCU7cEEhIz+bZYHgelxvQkErpQ45Sgs6PEyEQ14TIAsLhnjefo172IZTsowz+ju14t0r8tJp1BYD4kDvcS38sstgeyLYBjN/oUIT3+ZKeOi4nTlNKO7d1+y4r17eaGXXRuk5NRHDiWXkMfoH4Z60ql6QTbpwZ+4OD9vZmQcsBM7YhjC3ahLOYK0ZxxlrmPgNX5NMsBas18SevWEiKy7TOx6VhHcpI33fBRfO04+vV0mlB9qHdfmN673o1skbvLsOrdX2TRP80Jfw7hbQ/lhHBIUtNsWyCbFHcqpPMrHCuXfM6+u/QUMb1pG3TiM93jomq2yZAVgVL/g2YSLL9ENmTuSF8Br8pj76XtxSaU+4m2Ap8oXXU+jwUUPhJscziol/Gt2JT/LIu/p5HCQ+YHOmMuzg5ohQ6ld6MH2qCCGl9FKzsi9bb7rqPtPS/TCVqE3dxNUPdVp0iORxK2igBVVgu4B7QMODCHcrWE519oz2TBjQEopHC3qh7/ZIJPi6vMTs6zTSYkkVFK8qHhUxdJBMRwSWhjolHaolWXxBTPiqVKU0d+bPMd0q968j+aoRA2+XCfyrFFwvsyDagfL+NplYnDMB+P7Z/VYK470RRkZdEzEucWd8lSaUH4TMQhaZGsqgui71z/QMxh1sJB bvAfHKK1 cc1XFF+evMRxtTlCYqGyeYKmpI9sNOs4SkNNU/yR7bjRUfqzxlm94PEmcFipprG3zoJapCS3xLeJRj99WMzR3Tbv6MVhY90Y4Bg3tAbwNtY5unKp8lVDMGE6qjkWpfhNkT6XH66ffuhLyELypakl4AZb2VJ/QGDYINUBwNPkvwRMjgKR/hv879xMXXVa8fybQM6kJ08d5d1eGebKyEZsbyYhJwi47eYNrgR2v/UGBZFgEjK1QncrwFHw1enPwnRdS+CuO4rNTJXVnuxPCXg7/HUmSXG78iN1fis/D X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/29/25 16:57, Christoph Lameter (Ampere) wrote: > On Thu, 29 May 2025, Vlastimil Babka wrote: > >> The slab allocator observes the task's numa policy in various places >> such as allocating slab pages. Large kmalloc allocations currently do >> not, which seems to be an unintended omission. It is simple to correct >> that, so make ___kmalloc_large_node() behave the same way as >> alloc_slab_page(). > > Large kmalloc allocation lead to the use of the page allocator which > implements the NUMA policies for the allocations. > > This patch is not necessary. I'm confused, as that's only true depending on which page allocator entry point you use. AFAICS before this series, it's using alloc_pages_node_noprof() which only does if (nid == NUMA_NO_NODE) nid = numa_mem_id(); and no mempolicies. I see this patch as analogical to your commit 1941b31482a6 ("Reenable NUMA policy support in the slab allocator") Am I missing something?