From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21989C4332F for ; Thu, 29 Dec 2022 02:17:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 533CC8E0002; Wed, 28 Dec 2022 21:17:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E35E8E0001; Wed, 28 Dec 2022 21:17:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 383E88E0002; Wed, 28 Dec 2022 21:17:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 254A48E0001 for ; Wed, 28 Dec 2022 21:17:01 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DAF33C04BB for ; Thu, 29 Dec 2022 02:17:00 +0000 (UTC) X-FDA: 80293731000.20.9A38E05 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf22.hostedemail.com (Postfix) with ESMTP id D5D78C0008 for ; Thu, 29 Dec 2022 02:16:57 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf22.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672280219; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YSM6g/vZv6o7dEi2uBCYkmtJtwsRcjHRjlZBOB678vs=; b=rvk3M0S4hpLa+1869KEOsrpqUOu48vLBL+2DZAMgv599lywzGV7dfBxC0mqYRBcBwCHATu jkDxfaRSseKNIzYBMPzwZsNM+4FcrkZ6a4xdke0628iid4iamor5iF02j59Qa9LhWDQIHf SskiRbke2YzFIhoi/uU33/aovr0Ohvk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf22.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672280219; a=rsa-sha256; cv=none; b=XujUohwSDyFSgTBAZpGbv+8i0tjY7+O6I/6vXlivyw3+SByZQ4qyCx4TCFzsCdEXDLkCFk yisafOIFPRlPHI5we6sFdEp/gNFncik1stDTpV3u5CvUc/RdD3qHPPnsCppR4teetfFfYH UYG1kkeQTg9Xjun+UKoIpRR6/p66mgo= Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.55]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4NjBkM4qZkz9t71; Thu, 29 Dec 2022 10:12:59 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 29 Dec 2022 10:16:20 +0800 Message-ID: Date: Thu, 29 Dec 2022 10:16:19 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH -next v3 0/7] mm: convert page_idle/damon to use folios Content-Language: en-US To: SeongJae Park CC: Andrew Morton , , , , , References: <20221228175504.149395-1-sj@kernel.org> From: Kefeng Wang In-Reply-To: <20221228175504.149395-1-sj@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: D5D78C0008 X-Stat-Signature: uzchfuz89zjrjibba47n7fq9nr3ddx1w X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1672280217-673589 X-HE-Meta: U2FsdGVkX1+JkqHt5UzJBGOWw+31850MOY1VjCJfCvimD9mbq+Ey3NfIt07hB6C7l/u6QXIqYsw80f57j9fX27B7HVLAINS9hTynqbLHuUEaxVzBxbTSQ9aFM8evMd5jv7w2RudAdauu5XsuJJPw4wxoBrCQneJkjXi3anDxjkT44BlTNxLDKVwjOz3+OUrGavRe6H7f0wAQ9LhcDhZ1jQMEVKfRLHTmGtHQQIaYW19Ec/K/9+I9L/U2zHOv8Ltv6MbvB+54Le4Czg1ydBJsrTbGbtJXJrnX1oFpWpswb+TvA6fz70qacXZmfmxbnT7n86awRcBryR7FF60YY1UmGwoeu7hURp+CWJRC34NdOkr+pAGK1CAzW3v93R/ZFxlfp7fh3G2OJ2lLBy7JNdeCoT8+wZJtNrHzU3B90G3iNpD7y7ROwHAg+gXjj1fYKvxbfadAZUdGm6k2xUE/aHQw47JJrnqqHogCUSn9B+hSsq5U9N2VvWn/5c8pD8aHuQZObYrSL0VfVYDOLl7/mjcB+4wB6HVbI3nVakWKR+sBP8bpbBIuDDVqb179Q6nhOnKUzRCUo+daL0xXUJHZ+SOwOrIEshCD1CcUk4sAJJkI3j8F0QLNggf9sWT4fkmRZ06EF9aUjVqAlzoPNlcdV/5glphNvCoDYI5XAdyHSl06kWz4tI5mbpo46eoEGdGsAFUlwhfZl+iZj1/CJHzOm4vjpC/tcm86P99TSnH7IvBGAsV54JO4JfgQmWJ9caAemjhhCo9JQlBieIoBvsC6FsXbHrcn1HbgztT2taspdwGJ6xrDWwmUWLQHkuu02VfzH9RCz1B7EUpd1eejZAgzoLOKJMc0YYBr0JiDnW6rAomcPsNSnWo20l0RfZFbrb1s7X8SVIJXMKdDzW580+KzG1AZXFVCOIgl9qp4mt8C5SkWbd4HNlXSBNeUD1hHpJ0hqMwC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/12/29 1:55, SeongJae Park wrote: > Hi Kefeng, > > On Wed, 28 Dec 2022 19:34:06 +0800 Kefeng Wang wrote: > >> v3: >> - more thoroughly converting in page_idle_get_folio() suggested by Matthew >> also do it in damon_get_folio(). >> - address some commets from SeongJae >> >> v2: >> - drop unsafe pfn_to_online_folio(), convert page_idle_get_page() and >> damon_get_page() to return a folio after grab a reference >> - convert damon hugetlb related functions >> - rebased on next-20221226. >> >> Kefeng Wang (7): >> mm: page_idle: Convert page idle to use folios >> mm/damon: introduce damon_get_folio() >> mm/damon: convert damon_ptep/pmdp_mkold() to use folios >> mm/damon: paddr: convert damon_pa_*() to use folios >> mm/damon: vaddr: convert damon_young_pmd_entry() to use folio >> mm/damon: remove unneed damon_get_page() >> mm/damon: vaddr: convert hugetlb related function to use folios > > Thank you so much for your efforts on this work. I found I forgot mentioning > some trivial typos in the first, the sixth and the seventh patches, so > commented. I should have commented those earlier, sorry. > Oh，please forgive my bad English spelling, and thanks for Andrew with corrected word when patches are queued. > Other than those, > > Reviewed-by: SeongJae Park Thanks you very much. > > > Thanks, > SJ > >> >> mm/damon/ops-common.c | 38 +++++++++++++++------------- >> mm/damon/ops-common.h | 2 +- >> mm/damon/paddr.c | 58 +++++++++++++++++++------------------------ >> mm/damon/vaddr.c | 38 ++++++++++++++-------------- >> mm/page_idle.c | 47 ++++++++++++++++++----------------- >> 5 files changed, 91 insertions(+), 92 deletions(-) >> >> -- >> 2.35.3 >>