From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80D6BC47DDB for ; Thu, 1 Feb 2024 11:02:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E1B1C6B0071; Thu, 1 Feb 2024 06:02:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DA25F6B0072; Thu, 1 Feb 2024 06:02:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C42126B0074; Thu, 1 Feb 2024 06:02:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B06BC6B0071 for ; Thu, 1 Feb 2024 06:02:49 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7651FA0E04 for ; Thu, 1 Feb 2024 11:02:49 +0000 (UTC) X-FDA: 81742947258.07.D7D6A38 Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf18.hostedemail.com (Postfix) with ESMTP id 6ED551C001C for ; Thu, 1 Feb 2024 11:02:44 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf18.hostedemail.com: domain of tongtiangen@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=tongtiangen@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706785367; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F6YD7jN5u1vPtwtC/V3Q54Dwyp+M52TFzWIdlNOfTF0=; b=67WTHMLo7aAEQpsslL/gndoAlCb3EWKlYjz2H60iMIrfcxTjzvMD3zLPrs52CYkEQatfnE rviZ8uve4Lxq9+URSI+eGH3+jXgfMmsb6F/A/jgOmZclRZcODVbEwdJqIYkxts5e1qHhE2 TPTh6KRLGWnvZTSJtsSqFKIYOT/WcoQ= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf18.hostedemail.com: domain of tongtiangen@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=tongtiangen@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706785367; a=rsa-sha256; cv=none; b=6n3XiNyyC/+YncGPpUFJKYYDxg5tpWx4EVkMgcqB0F/7plbfrnIat8pg9M3D4ykbrOQRpg nUc0HwHsbR/7AnzliUJnixMcZ5dhWzYvtCoMydVBm/lSSwI583qr+PNh0OsYps+2T2ADl4 8ghTt5Dh5lmCBfh2YY/xXcgl2aEDjpk= Received: from mail.maildlp.com (unknown [172.19.163.44]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4TQbZB5CzVz1xn1G; Thu, 1 Feb 2024 19:01:38 +0800 (CST) Received: from kwepemm600017.china.huawei.com (unknown [7.193.23.234]) by mail.maildlp.com (Postfix) with ESMTPS id BFB5E140412; Thu, 1 Feb 2024 19:02:39 +0800 (CST) Received: from [10.174.179.234] (10.174.179.234) by kwepemm600017.china.huawei.com (7.193.23.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 1 Feb 2024 19:02:38 +0800 Message-ID: Date: Thu, 1 Feb 2024 19:02:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH -next v4 1/3] x86/mce: remove redundant fixup type EX_TYPE_COPY To: Borislav Petkov CC: Thomas Gleixner , Ingo Molnar , , Dave Hansen , , "H. Peter Anvin" , Tony Luck , Andy Lutomirski , Peter Zijlstra , Andrew Morton , Naoya Horiguchi , , , , Guohanjun References: <20240111135548.3207437-1-tongtiangen@huawei.com> <20240111135548.3207437-2-tongtiangen@huawei.com> <20240130210918.GFZbllfs4jUcd_QHL2@fat_crate.local> From: Tong Tiangen In-Reply-To: <20240130210918.GFZbllfs4jUcd_QHL2@fat_crate.local> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.234] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm600017.china.huawei.com (7.193.23.234) X-Rspamd-Queue-Id: 6ED551C001C X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: di85p1hrmk3tybkjmf55xzpp94gouyre X-HE-Tag: 1706785364-373431 X-HE-Meta: U2FsdGVkX1/TKyLRGkh55MeP+jsiSPUL0cLsz+EFH9f1PiLdy9fBT4sdqactBCrJGIK3avqVpfXCn/fQkNNXP30CbHn3TvQ/Ih5pfH9uh0RD3xnR3e1PYCtDes7hINl+NUQEsxL8pl7zBuC2ZMnn01LZA/Tgrpg+2DjfwLbCPxuPl37j/mlaGDmhe6txmfacgC5p4SDI/BKgcslaNJr5g4ahf601ABShGqNAJmB08r3u4Nxn1or4iSjemnIMLf18xtbjvAG58/26xy6RSDCVzsBgk07KRb+FacsymoQtFS23vCUKl3uX4/aFNtStr5VykS5B0hNjW8n3NbcCZ5U4kE0uY+zhCqe/tFaJziZOvI+mCcZC2eiTNXhaBjE7PFOHqtBwJ6xg9iQYnIGHfFjiYW4Y9wRiBuW/bipHh0g7F+ofje+nz2+uLAS6PmADkxs1wbrCqTEDZ9c2UJQkEwSuXGRoIGMt4sSIftFeTYzzuZ4CMe6icSUBXNbyr5aw2HpwC4ZlzZTaZo/yj2S4Ss9e7U/eBL2vktRhVEFIPmTK3que73cSIsnWnk/6b7L/QCnsmPLY4nK8naHSa4kf+m917LSw9XnHFf4u6FeuDw0YSrAqDHa8dgy9GN0zDvKMXOHb/BJsB+xFHcyBc2TScANA21IuGT7RsHPKygNMX8JIB4VYEsJrzWMoI5di/WZOHdno0it2Q8q4UVRPXyVqRQJzo7ZzAMaThYIKbgq5Bpq7Y5mIS5aPnD2P5f6so2xZeiymzWxxDwhK9P2cKqXpQNHpIvmPlP5aQVislxHDEZOvLiYuhCLfeh7r/wjh4XNufm+xcr/4bUP2urc0ZJmCs8lo4KlXoCBME0kt+S63MadIX1FJnGZF8eH3AfKgCetZZUjKCtdi6GR0eLNH9Kv674IFoOXhaBMqL1rfNRT6UyUTh45awHdWIW2jl3oM8tG87LngVm0p+ZsR6nBKXmfHLya IDHOhQab henFCCvqoHrWbF6EzVuDEa3qnbmXaeiLrXP/BTNK68SI0SpdoVV3agulC2X5EDRTtEBTLNM7pbR+jN1okgMipUtRGSNK9iiJotWLE0ju/3XWmlDpeBrxF5BikX3YLvaLI8W81Mf5fKtJOIY1UVL4n9sygO0WdWnC77kowMeRRz1jkYlBRarC2IlP4ZHX6bME4eyBfQL1mo6Atqww= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2024/1/31 5:09, Borislav Petkov 写道: > On Thu, Jan 11, 2024 at 09:55:46PM +0800, Tong Tiangen wrote: >> In commit 034ff37d3407 ("x86: rewrite '__copy_user_nocache' function"), >> rewrited __copy_user_nocache() uses EX_TYPE_UACCESS instead of >> EX_TYPE_COPY，this change does not broken the MC safe copy for >> __copy_user_nocache(), but as a result, there's no place for EX_TYPE_COPY >> to use. Therefore, we remove the definition of EX_TYPE_COPY. > > Please use passive voice in your commit message: no "we" or "I", etc, > and describe your changes in imperative mood. > > Also, pls read section "2) Describe your changes" in > Documentation/process/submitting-patches.rst for more details. > > Also, see section "Changelog" in > Documentation/process/maintainer-tip.rst OK, thanks, Improved in the next release. > >> diff --git a/arch/x86/include/asm/extable_fixup_types.h b/arch/x86/include/asm/extable_fixup_types.h >> index fe6312045042..787916ec1e12 100644 >> --- a/arch/x86/include/asm/extable_fixup_types.h >> +++ b/arch/x86/include/asm/extable_fixup_types.h >> @@ -36,18 +36,17 @@ >> #define EX_TYPE_DEFAULT 1 >> #define EX_TYPE_FAULT 2 >> #define EX_TYPE_UACCESS 3 >> -#define EX_TYPE_COPY 4 >> -#define EX_TYPE_CLEAR_FS 5 >> -#define EX_TYPE_FPU_RESTORE 6 >> -#define EX_TYPE_BPF 7 >> -#define EX_TYPE_WRMSR 8 >> -#define EX_TYPE_RDMSR 9 >> -#define EX_TYPE_WRMSR_SAFE 10 /* reg := -EIO */ >> -#define EX_TYPE_RDMSR_SAFE 11 /* reg := -EIO */ >> -#define EX_TYPE_WRMSR_IN_MCE 12 >> -#define EX_TYPE_RDMSR_IN_MCE 13 >> -#define EX_TYPE_DEFAULT_MCE_SAFE 14 >> -#define EX_TYPE_FAULT_MCE_SAFE 15 >> +#define EX_TYPE_CLEAR_FS 4 >> +#define EX_TYPE_FPU_RESTORE 5 >> +#define EX_TYPE_BPF 6 >> +#define EX_TYPE_WRMSR 7 >> +#define EX_TYPE_RDMSR 8 >> +#define EX_TYPE_WRMSR_SAFE 9 /* reg := -EIO */ >> +#define EX_TYPE_RDMSR_SAFE 10 /* reg := -EIO */ >> +#define EX_TYPE_WRMSR_IN_MCE 11 >> +#define EX_TYPE_RDMSR_IN_MCE 12 >> +#define EX_TYPE_DEFAULT_MCE_SAFE 13 >> +#define EX_TYPE_FAULT_MCE_SAFE 14 > > You don't need to renumber them - all you need to do is to comment it > out: > > /* unused, was: #define EX_TYPE_COPY 4 */ OK. Thanks. Tong. >