From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2C9DC5AD49 for ; Tue, 3 Jun 2025 06:04:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 115606B03AB; Tue, 3 Jun 2025 02:04:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C7006B03AC; Tue, 3 Jun 2025 02:04:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1F3F6B03AD; Tue, 3 Jun 2025 02:04:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D25296B03AB for ; Tue, 3 Jun 2025 02:04:57 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 42768EAD97 for ; Tue, 3 Jun 2025 06:04:57 +0000 (UTC) X-FDA: 83513051034.19.848DF80 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf09.hostedemail.com (Postfix) with ESMTP id 7138414000A for ; Tue, 3 Jun 2025 06:04:55 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748930695; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UbMeBfYBqBJ04GzMWO4CfA33wmbk7wwSAMNQdyzeXLo=; b=pwnbQJsbmtLzsv7hNKfliZp5MFH2Aj+WkneMMGgpyAv0GOIAO/Bh6/7ciEebLHeKkW6inp hemHXngeoHv+8lmWD4B9+AHfDbm8yxXTsLDi71fhZmWMKlGkK7Bek5tVaNS3f6wHQnso9w YhJCGWoHgaHKC5dypOWoQUVUloos93A= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748930695; a=rsa-sha256; cv=none; b=oFIYbzp9UpkP9BQ5HAKGkfsivFyaJybyITQ+s8dF5JHeMtQfyDQ1pU5su4w6mr9pR+rmET bAWb1zlg5iV8H5AdYjeNuJWDbNCwHYRsfo1wyDQUlTwQuk/Y5zAlWrb96aujlrwkJ7QoE9 ijscotoX/kD34Noelk/lKiZb8gRzuf4= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0486212FC; Mon, 2 Jun 2025 23:04:38 -0700 (PDT) Received: from [10.164.18.47] (a077893.blr.arm.com [10.164.18.47]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A60313F673; Mon, 2 Jun 2025 23:04:50 -0700 (PDT) Message-ID: Date: Tue, 3 Jun 2025 11:34:46 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC] mm: madvise: use walk_page_range_vma() for madvise_free_single_vma() To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Barry Song , "Liam R. Howlett" , Lorenzo Stoakes , David Hildenbrand , Vlastimil Babka , Jann Horn , Suren Baghdasaryan , Lokesh Gidra , Tangquan Zheng References: <20250603013154.5905-1-21cnbao@gmail.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20250603013154.5905-1-21cnbao@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 7138414000A X-Stat-Signature: 5z6ofah81if4waryq8xrqk3bodp4br7n X-Rspam-User: X-HE-Tag: 1748930695-789779 X-HE-Meta: U2FsdGVkX1+aGYEA09kzURRWlBqjwK1qOF89Rm76CRIMvAvuhHB+YIMr0FDzVNeDPRUyZsx0tcoUlBJIwukB9YU3ErOXzcbXZg7gaCTkX++jVS9G9WbhNdeDfBntwcO5tgmEtHrz6WUeqF/zgiBYqZVuUedbGf49N8F61LYtWPSiV0powgS3qgAJ49BIeaQuUwRlBXmvuyF2CQMeuse9udE+nkkcFi0ukV+mOqOoStUkk9sMriozTLRhj3a9raf8mIBtKwCfnwl/BMLwgRQ5TQjnupjhZzR3acvwwwHFIYQ9JSogtwoylSpU41g0OT+2J2JCIZRF/HuBpPCMiw/5qVA+H4L2VRlPvQyJ9UJfjAzN7d21Up46hQGpTOpqaVQC6YwGckdU4DeBWbdOmgWG6WhpcfbpyfRYuh+hhaurrPcVZIok9loerVhrnWZ8aH8+o9ucjoN9d1hhzK0FsFgKPx82q3tp+2vL7IX1iIZVgG6ukhpj3i8b0kQw5W96S29h+OB4ZtvYvXoFSsOgJjPVuBYt2mgusA34N1WvGyFmPm/lIbpdhVeYeM0AEVbeJnExL7DGqbpp05nGljiXxR9sCWcrOuUzdbN9yThLm9+u4KqIL3DmsQRpCpA3FGEpEeMvv/mSTC/yGSG9v+uT51Ornwlkc7v3UnpRYjCMbQWYDy1EyEBFqMWP4Hdlg0TDwqbdIur8GbEk+7CBVY4jfhXeYPRBLEhY370p57mzJk1ci+EYksJj4LrLPfT5tRXdW3MjOvRLEOWsRKvNP2ddMQuDts4YxIEw7KDsftUu+NHfHiHSL3n1ZhXjG+dpmmNa/Bv6Wyoaf/NUgfdPq7s2b8GUISPp8DGlQ9Z6cVMGXMAIPaCUb6SI7DA3zJdNjyjUj/GznLeoDki2DA8pt3SNzwtZQW30GX/mat6BimGffFoaDuOdD83R41489vZjl4SLrGbH0Hmxbm9XD6kXddSsmYO gRvYF+wU zXnhrbVfhxqoHBkyZJLGu5L1KmBuPXuh3JTnWJKcBvvDexRQinxS/6SAmEhCqxZCWJkfQOupdnFaDAqZgwUe8oD4Md6cqkvn9ZRhxJIDBAij97kvb8+MyioNZ92zPylRSjB7cyfNiatYNEaLSQvjwR2L/w+GpCbLDSQTMyAdqXNohr+ItVF/d4FTD+uEojRigw+QGgpD1nI7OFSX8+IOz9Zu58slCtnRnu4aHCxXiUSE5wfC04vjMrHJSPWTphTJ0lUDIbRVxnYFxsW/VEMwRYRN1//KoZkAegkQTl00uU1EbELe7ycDBCLKBb7nKOcoNkLo/YXrvQ77IIS4TT79LjGtqjw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/3/25 07:01, Barry Song wrote: > From: Barry Song > > We've already found the VMA before calling madvise_free_single_vma(), > so calling walk_page_range() and doing find_vma() again seems > unnecessary. It also prevents potential optimizations for MADV_FREE > to use a per-VMA lock. > > Cc: "Liam R. Howlett" > Cc: Lorenzo Stoakes > Cc: David Hildenbrand > Cc: Vlastimil Babka > Cc: Jann Horn > Cc: Suren Baghdasaryan > Cc: Lokesh Gidra > Cc: Tangquan Zheng > Signed-off-by: Barry Song > --- > mm/madvise.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/madvise.c b/mm/madvise.c > index d408ffa404b3..c6a28a2d3ff8 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -826,7 +826,7 @@ static int madvise_free_single_vma(struct madvise_behavior *madv_behavior, > > mmu_notifier_invalidate_range_start(&range); > tlb_start_vma(tlb, vma); > - walk_page_range(vma->vm_mm, range.start, range.end, > + walk_page_range_vma(vma, range.start, range.end, > &madvise_free_walk_ops, tlb); > tlb_end_vma(tlb, vma); > mmu_notifier_invalidate_range_end(&range); This indeed looks like an improvement dropping a redundant VMA look up and also opening up potential optimization later using per-VMA lock. Reviewed-by: Anshuman Khandual