From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7B09C46467 for ; Tue, 10 Jan 2023 12:06:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F0C28E0002; Tue, 10 Jan 2023 07:06:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A0A68E0001; Tue, 10 Jan 2023 07:06:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 58FE38E0002; Tue, 10 Jan 2023 07:06:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 49B148E0001 for ; Tue, 10 Jan 2023 07:06:43 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C54C6A1283 for ; Tue, 10 Jan 2023 12:06:42 +0000 (UTC) X-FDA: 80338762644.01.FAB6236 Received: from gentwo.de (gentwo.de [161.97.139.209]) by imf07.hostedemail.com (Postfix) with ESMTP id CE10C40021 for ; Tue, 10 Jan 2023 12:06:39 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gentwo.de header.s=default header.b=Q2xOroI3; spf=pass (imf07.hostedemail.com: domain of cl@gentwo.de designates 161.97.139.209 as permitted sender) smtp.mailfrom=cl@gentwo.de; dmarc=pass (policy=none) header.from=gentwo.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673352400; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j6xxcN7VDdNH6rHtka3WwgpQemGlYvGE7nIBA/hRnqU=; b=AZAA+baEe2DTznz/EZyH7byPC3NWlZpFqutLK5dC5kL31z03ZcpcNuM1o8aA7FoCn9HyzE Xvq2wc+YUifKpja1s41srC3KiRGz2dNZbuPzkfW4nG8WFNQQaBql+uqBXIGogHTHZ0Qzzd 8H4orIMIyPd5lISYBWgko6h3oknfrXk= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gentwo.de header.s=default header.b=Q2xOroI3; spf=pass (imf07.hostedemail.com: domain of cl@gentwo.de designates 161.97.139.209 as permitted sender) smtp.mailfrom=cl@gentwo.de; dmarc=pass (policy=none) header.from=gentwo.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673352400; a=rsa-sha256; cv=none; b=8S0Js8bq5S4E68qlH3EGQry9IdaT5Ofe557SD2Ty+24D3j5/VxxkfMxcTkzP4uniyYOIK3 u3kmFXfPA6CYKQjLSK8oo4knnksFs8tYdARUzElxJBpM5EP6LSmK9wrChzMqXGwPepuheU faTgm6PK6X/KoGnHPT5BMlULFjJHHyc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gentwo.de; s=default; t=1673352397; bh=1lAq3hxMorwKertNBHt6kodNs2aKb8MmxSA/uvyQtjI=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Q2xOroI33ZBTvLTbLZwgBXoIRIs84is0yynUPd9GoLmqA6ebjP/UR0zYS08ftSNrW XOnKoF5DzEnL23E+hVNwl9Vs53uU52aTtB0uMYdSP9hEGSon47b0JoRAsTz5/aaB0r tTIcK880hwzSR5/kxQeocCubyGDh4EtOsaav3CniPZBwWmr3c+uUqk75Xavl/8go0R fzN9eM+3w28PUVXRErsJHdTSiCegBrzoDYVcei18VIVh6rvT5QW+VyxGxDsXmg9tDL SO1uE+yGzu5YoPSmHq7NVvhUC4oh9+bO6DYBrtY0kCsmD8h37xK3QQpGlbipmV/jmy F1gXNMICSffMw== Received: by gentwo.de (Postfix, from userid 1001) id 438A9B0021D; Tue, 10 Jan 2023 13:06:37 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by gentwo.de (Postfix) with ESMTP id 41B09B00136; Tue, 10 Jan 2023 13:06:37 +0100 (CET) Date: Tue, 10 Jan 2023 13:06:37 +0100 (CET) From: Christoph Lameter To: Marcelo Tosatti cc: atomlin@atomlin.com, frederic@kernel.org, tglx@linutronix.de, mingo@kernel.org, peterz@infradead.org, pauld@redhat.com, neelx@redhat.com, oleksandr@natalenko.name, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v13 2/6] mm/vmstat: Use vmstat_dirty to track CPU-specific vmstat discrepancies In-Reply-To: <20230105125248.813825852@redhat.com> Message-ID: References: <20230105125218.031928326@redhat.com> <20230105125248.813825852@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: CE10C40021 X-Stat-Signature: tc7qro5dxeoztzimhft7h47kzpjio9wo X-HE-Tag: 1673352399-223380 X-HE-Meta: U2FsdGVkX1+HVEsY2fIlQgF8zauRLuyfKhcfeb6LjBKVw+JsbXA0t1GjuDIPNumWfhL6gS1F+3hvrPeeVa0JCcL3YwiomEWF3G0hqkf8xzDVPaBfn7W7trIQWb6ejduRBVtZfVBkuO3vOmyDsfT9x5L8I2BzFbx/GTSpN+oP1QAwy/PMta0Yi0RuK67sTz+q9Ea6MDaMUFrA7wvMRqdOI926g8+q2weapvciprtHBdNBOWw9eyGFgkY6aEHXUvVcDWvsxrwK0GM9qINxeM0Qh3THRcNPKgSTkqpqWECiQmdifqpJp3wOZNMNOZ8e5CX9jz3quFMrNdWXbq43ldOc6yqxC9/K4g+8SF2TwLCnHnv6pkWr2rigVgO/8/pziJw0HXUMy7ctqBlRirEFB2QcbjLjsjBu8fzGqsboMol7D7livhsZkcptANb5QDxqqvneddA6Vpy0ndOshdBsRpeiIeSzIC0e4Ttu0ekcvf8ITNmSyj9LjbiTgH8knfDdkqpW6DLvtvBxvTW0ikBSOVhhHeCbA6UAz+PJVDZRfbHUDfHroc/M2g4H1m0RJ45dzNgHm0EMYtmpXpz9ahSqQdevZ+iXDu0+7UKsldp+ORzZHZW16hedN7etnC/K+hLhWonvDKOsnqCxGofz3EkO5m2Zug3cql4gkTREDXr7eJYRYKRBQVEM89m4Mmy/OYpf35+Ldm9f3iEW0d1zaThOOEQ3ksgNKCnYeblgxuq8mtfoXWUl1RhfH+UXn3C2STq3iVIuvrerlE/N3L/PdxmqD5hwVryYXCu1+n/f4LHXBukaEkZAbIV5rk+jic0aTpSwI9pFhRkSu+uNncSFebKDjPuboe9NOfhHJ9U9UwZPooB7E1qMg2gbuEwGNf/+5zouhMQd/QhSsQIgxMNdyurhPqAVeDZ6tDgXNG8T X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 5 Jan 2023, Marcelo Tosatti wrote: > --- linux-2.6.orig/mm/vmstat.c > +++ linux-2.6/mm/vmstat.c > @@ -381,6 +381,7 @@ void __mod_zone_page_state(struct zone * > x = 0; > } > __this_cpu_write(*p, x); > + vmstat_mark_dirty(); __vmstat_mark_dirty()? See earlier patch > > preempt_enable_nested(); > } > @@ -417,6 +418,7 @@ void __mod_node_page_state(struct pglist > x = 0; > } > __this_cpu_write(*p, x); > + vmstat_mark_dirty(); Ditto. > > preempt_enable_nested(); > } > @@ -577,6 +579,9 @@ static inline void mod_zone_state(struct > s8 __percpu *p = pcp->vm_stat_diff + item; > long o, n, t, z; > > + /* cmpxchg and vmstat_mark_dirty should happen on the same CPU */ > + preempt_disable(); If you are disabling preemption then why do we still need cmpxchg? Same again below.