From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4BACC43334 for ; Sat, 18 Jun 2022 02:44:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48A096B0071; Fri, 17 Jun 2022 22:44:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 439CF6B0072; Fri, 17 Jun 2022 22:44:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B2F86B0073; Fri, 17 Jun 2022 22:44:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 15A876B0071 for ; Fri, 17 Jun 2022 22:44:58 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DD891218E5 for ; Sat, 18 Jun 2022 02:44:57 +0000 (UTC) X-FDA: 79589814234.31.21E2B3C Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf31.hostedemail.com (Postfix) with ESMTP id DEF7820009 for ; Sat, 18 Jun 2022 02:44:56 +0000 (UTC) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4LQ0bP2lY4zjXXr; Sat, 18 Jun 2022 10:43:45 +0800 (CST) Received: from kwepemm600017.china.huawei.com (7.193.23.234) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 18 Jun 2022 10:44:53 +0800 Received: from [10.174.179.234] (10.174.179.234) by kwepemm600017.china.huawei.com (7.193.23.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 18 Jun 2022 10:44:51 +0800 Message-ID: Date: Sat, 18 Jun 2022 10:44:50 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH -next v5 1/8] arm64: extable: add new extable type EX_TYPE_KACCESS_ERR_ZERO support To: Mark Rutland CC: James Morse , Andrew Morton , Thomas Gleixner , "Ingo Molnar" , Borislav Petkov , Robin Murphy , Dave Hansen , "Catalin Marinas" , Will Deacon , "Alexander Viro" , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , , "H . Peter Anvin" , , , , , Kefeng Wang , Xie XiuQi , Guohanjun References: <20220528065056.1034168-1-tongtiangen@huawei.com> <20220528065056.1034168-2-tongtiangen@huawei.com> From: Tong Tiangen In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.234] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm600017.china.huawei.com (7.193.23.234) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655520297; a=rsa-sha256; cv=none; b=FXe6FAEbhmrh1B8u0W6ofuO+/4dH3Bru8vbWdAEgBi1NiX7caVX4hABlGzRNKn7SI2PrA0 +aPiZVoik/4LSfXk28t4eZFk7044gP5l4AoK3uBzKNXd7AOVWmAqZ/YLnLwBB8qSgGxtxT Q+bDytNo9BZq05WOB7OTw7PzzhGmwd4= ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=none; spf=pass (imf31.hostedemail.com: domain of tongtiangen@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=tongtiangen@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655520297; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HQBWvyd/Pfyb8ejtE5ldqeHTRWQPrWDPJ3MA7ZjmF+Q=; b=jymu5X9NHcl7og1Grd29Pt9hnWDFiODPFA8cWKsIhwQQKj3KShWMCKucke9BZQH8Mhpjk7 DXBk73CPwm+1P6lI9dWZU9fKfMv1aJpKETPCO5jXRaCt94kUc0cB6BoD6Vpnujl35O5VQv 1xsBdva0VSQIZll5cfTak55+Qi1Gjnw= Authentication-Results: imf31.hostedemail.com; dkim=none; spf=pass (imf31.hostedemail.com: domain of tongtiangen@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=tongtiangen@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspam-User: X-Stat-Signature: ietochthi4mcda71yr8jee14peutfaqs X-Rspamd-Queue-Id: DEF7820009 X-Rspamd-Server: rspam08 X-HE-Tag: 1655520296-975689 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2022/6/17 16:23, Mark Rutland 写道: > On Sat, May 28, 2022 at 06:50:49AM +0000, Tong Tiangen wrote: >> Currently, The extable type EX_TYPE_UACCESS_ERR_ZERO is used by >> __get/put_kernel_nofault(), but those helpers are not uaccess type, so we >> add a new extable type EX_TYPE_KACCESS_ERR_ZERO which can be used by >> __get/put_kernel_no_fault(). >> >> This is also to prepare for distinguishing the two types in machine check >> safe process. >> >> Suggested-by: Mark Rutland >> Signed-off-by: Tong Tiangen > > This looks good to me, so modulo one nit below: > > Acked-by: Mark Rutland > >> --- >> arch/arm64/include/asm/asm-extable.h | 13 ++++ >> arch/arm64/include/asm/uaccess.h | 94 ++++++++++++++-------------- >> arch/arm64/mm/extable.c | 1 + >> 3 files changed, 61 insertions(+), 47 deletions(-) >> >> diff --git a/arch/arm64/include/asm/asm-extable.h b/arch/arm64/include/asm/asm-extable.h >> index c39f2437e08e..56ebe183e78b 100644 >> --- a/arch/arm64/include/asm/asm-extable.h >> +++ b/arch/arm64/include/asm/asm-extable.h >> @@ -7,6 +7,7 @@ >> #define EX_TYPE_BPF 2 >> #define EX_TYPE_UACCESS_ERR_ZERO 3 >> #define EX_TYPE_LOAD_UNALIGNED_ZEROPAD 4 >> +#define EX_TYPE_KACCESS_ERR_ZERO 5 > > Could we please renumber this so the UACCESS and KACCESS definitions are next > to one another, i.e. > > #define EX_TYPE_BPF 2 > #define EX_TYPE_UACCESS_ERR_ZERO 3 > #define EX_TYPE_KACCESS_ERR_ZERO 4 > #define EX_TYPE_LOAD_UNALIGNED_ZEROPAD 5 > > Thanks, > Mark. ok, It's cleaner. Thanks, Tong. > >> >> #ifdef __ASSEMBLY__ >> >> @@ -73,9 +74,21 @@ >> EX_DATA_REG(ZERO, zero) \ >> ")") >> >> +#define _ASM_EXTABLE_KACCESS_ERR_ZERO(insn, fixup, err, zero) \ >> + __DEFINE_ASM_GPR_NUMS \ >> + __ASM_EXTABLE_RAW(#insn, #fixup, \ >> + __stringify(EX_TYPE_KACCESS_ERR_ZERO), \ >> + "(" \ >> + EX_DATA_REG(ERR, err) " | " \ >> + EX_DATA_REG(ZERO, zero) \ >> + ")") >> + >> #define _ASM_EXTABLE_UACCESS_ERR(insn, fixup, err) \ >> _ASM_EXTABLE_UACCESS_ERR_ZERO(insn, fixup, err, wzr) >> >> +#define _ASM_EXTABLE_KACCESS_ERR(insn, fixup, err) \ >> + _ASM_EXTABLE_KACCESS_ERR_ZERO(insn, fixup, err, wzr) >> + >> #define EX_DATA_REG_DATA_SHIFT 0 >> #define EX_DATA_REG_DATA GENMASK(4, 0) >> #define EX_DATA_REG_ADDR_SHIFT 5 >> diff --git a/arch/arm64/include/asm/uaccess.h b/arch/arm64/include/asm/uaccess.h >> index 63f9c828f1a7..2fc9f0861769 100644 >> --- a/arch/arm64/include/asm/uaccess.h >> +++ b/arch/arm64/include/asm/uaccess.h >> @@ -232,34 +232,34 @@ static inline void __user *__uaccess_mask_ptr(const void __user *ptr) >> * The "__xxx_error" versions set the third argument to -EFAULT if an error >> * occurs, and leave it unchanged on success. >> */ >> -#define __get_mem_asm(load, reg, x, addr, err) \ >> +#define __get_mem_asm(load, reg, x, addr, err, type) \ >> asm volatile( \ >> "1: " load " " reg "1, [%2]\n" \ >> "2:\n" \ >> - _ASM_EXTABLE_UACCESS_ERR_ZERO(1b, 2b, %w0, %w1) \ >> + _ASM_EXTABLE_##type##ACCESS_ERR_ZERO(1b, 2b, %w0, %w1) \ >> : "+r" (err), "=&r" (x) \ >> : "r" (addr)) >> >> -#define __raw_get_mem(ldr, x, ptr, err) \ >> -do { \ >> - unsigned long __gu_val; \ >> - switch (sizeof(*(ptr))) { \ >> - case 1: \ >> - __get_mem_asm(ldr "b", "%w", __gu_val, (ptr), (err)); \ >> - break; \ >> - case 2: \ >> - __get_mem_asm(ldr "h", "%w", __gu_val, (ptr), (err)); \ >> - break; \ >> - case 4: \ >> - __get_mem_asm(ldr, "%w", __gu_val, (ptr), (err)); \ >> - break; \ >> - case 8: \ >> - __get_mem_asm(ldr, "%x", __gu_val, (ptr), (err)); \ >> - break; \ >> - default: \ >> - BUILD_BUG(); \ >> - } \ >> - (x) = (__force __typeof__(*(ptr)))__gu_val; \ >> +#define __raw_get_mem(ldr, x, ptr, err, type) \ >> +do { \ >> + unsigned long __gu_val; \ >> + switch (sizeof(*(ptr))) { \ >> + case 1: \ >> + __get_mem_asm(ldr "b", "%w", __gu_val, (ptr), (err), type); \ >> + break; \ >> + case 2: \ >> + __get_mem_asm(ldr "h", "%w", __gu_val, (ptr), (err), type); \ >> + break; \ >> + case 4: \ >> + __get_mem_asm(ldr, "%w", __gu_val, (ptr), (err), type); \ >> + break; \ >> + case 8: \ >> + __get_mem_asm(ldr, "%x", __gu_val, (ptr), (err), type); \ >> + break; \ >> + default: \ >> + BUILD_BUG(); \ >> + } \ >> + (x) = (__force __typeof__(*(ptr)))__gu_val; \ >> } while (0) >> >> /* >> @@ -274,7 +274,7 @@ do { \ >> __chk_user_ptr(ptr); \ >> \ >> uaccess_ttbr0_enable(); \ >> - __raw_get_mem("ldtr", __rgu_val, __rgu_ptr, err); \ >> + __raw_get_mem("ldtr", __rgu_val, __rgu_ptr, err, U); \ >> uaccess_ttbr0_disable(); \ >> \ >> (x) = __rgu_val; \ >> @@ -314,40 +314,40 @@ do { \ >> \ >> __uaccess_enable_tco_async(); \ >> __raw_get_mem("ldr", *((type *)(__gkn_dst)), \ >> - (__force type *)(__gkn_src), __gkn_err); \ >> + (__force type *)(__gkn_src), __gkn_err, K); \ >> __uaccess_disable_tco_async(); \ >> \ >> if (unlikely(__gkn_err)) \ >> goto err_label; \ >> } while (0) >> >> -#define __put_mem_asm(store, reg, x, addr, err) \ >> +#define __put_mem_asm(store, reg, x, addr, err, type) \ >> asm volatile( \ >> "1: " store " " reg "1, [%2]\n" \ >> "2:\n" \ >> - _ASM_EXTABLE_UACCESS_ERR(1b, 2b, %w0) \ >> + _ASM_EXTABLE_##type##ACCESS_ERR(1b, 2b, %w0) \ >> : "+r" (err) \ >> : "r" (x), "r" (addr)) >> >> -#define __raw_put_mem(str, x, ptr, err) \ >> -do { \ >> - __typeof__(*(ptr)) __pu_val = (x); \ >> - switch (sizeof(*(ptr))) { \ >> - case 1: \ >> - __put_mem_asm(str "b", "%w", __pu_val, (ptr), (err)); \ >> - break; \ >> - case 2: \ >> - __put_mem_asm(str "h", "%w", __pu_val, (ptr), (err)); \ >> - break; \ >> - case 4: \ >> - __put_mem_asm(str, "%w", __pu_val, (ptr), (err)); \ >> - break; \ >> - case 8: \ >> - __put_mem_asm(str, "%x", __pu_val, (ptr), (err)); \ >> - break; \ >> - default: \ >> - BUILD_BUG(); \ >> - } \ >> +#define __raw_put_mem(str, x, ptr, err, type) \ >> +do { \ >> + __typeof__(*(ptr)) __pu_val = (x); \ >> + switch (sizeof(*(ptr))) { \ >> + case 1: \ >> + __put_mem_asm(str "b", "%w", __pu_val, (ptr), (err), type); \ >> + break; \ >> + case 2: \ >> + __put_mem_asm(str "h", "%w", __pu_val, (ptr), (err), type); \ >> + break; \ >> + case 4: \ >> + __put_mem_asm(str, "%w", __pu_val, (ptr), (err), type); \ >> + break; \ >> + case 8: \ >> + __put_mem_asm(str, "%x", __pu_val, (ptr), (err), type); \ >> + break; \ >> + default: \ >> + BUILD_BUG(); \ >> + } \ >> } while (0) >> >> /* >> @@ -362,7 +362,7 @@ do { \ >> __chk_user_ptr(__rpu_ptr); \ >> \ >> uaccess_ttbr0_enable(); \ >> - __raw_put_mem("sttr", __rpu_val, __rpu_ptr, err); \ >> + __raw_put_mem("sttr", __rpu_val, __rpu_ptr, err, U); \ >> uaccess_ttbr0_disable(); \ >> } while (0) >> >> @@ -400,7 +400,7 @@ do { \ >> \ >> __uaccess_enable_tco_async(); \ >> __raw_put_mem("str", *((type *)(__pkn_src)), \ >> - (__force type *)(__pkn_dst), __pkn_err); \ >> + (__force type *)(__pkn_dst), __pkn_err, K); \ >> __uaccess_disable_tco_async(); \ >> \ >> if (unlikely(__pkn_err)) \ >> diff --git a/arch/arm64/mm/extable.c b/arch/arm64/mm/extable.c >> index 489455309695..056591e5ca80 100644 >> --- a/arch/arm64/mm/extable.c >> +++ b/arch/arm64/mm/extable.c >> @@ -77,6 +77,7 @@ bool fixup_exception(struct pt_regs *regs) >> case EX_TYPE_BPF: >> return ex_handler_bpf(ex, regs); >> case EX_TYPE_UACCESS_ERR_ZERO: >> + case EX_TYPE_KACCESS_ERR_ZERO: >> return ex_handler_uaccess_err_zero(ex, regs); >> case EX_TYPE_LOAD_UNALIGNED_ZEROPAD: >> return ex_handler_load_unaligned_zeropad(ex, regs); >> -- >> 2.25.1 >> > > .