From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11C5DC7115A for ; Tue, 17 Jun 2025 09:49:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC55B6B00A6; Tue, 17 Jun 2025 05:49:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A75C56B00A7; Tue, 17 Jun 2025 05:49:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 964A56B00A8; Tue, 17 Jun 2025 05:49:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 85C416B00A6 for ; Tue, 17 Jun 2025 05:49:51 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2B3131006B7 for ; Tue, 17 Jun 2025 09:49:51 +0000 (UTC) X-FDA: 83564420982.20.C45E698 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id C9362C0009 for ; Tue, 17 Jun 2025 09:49:48 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BNIwxYas; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750153788; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DF2LSLjoIDZihiRcdf30WHksttB87jWZgxoeifw/8vs=; b=NFAZAJYpAt2oNwSuMoOkJ3wlv3DdkEb+QV2oaJ5ii4aNTgR2b/sofO7Fni0rD2RGe/h1/s uQR35BYekeocMCP5I2WfaEacFxq+ygNpKlNqQcSOJmCD3Ww7AvwRQky4lODOEv1t0n5z8P wmpD3DeSI1wEcmLRmpVx2DejhrFfgqo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750153788; a=rsa-sha256; cv=none; b=P5iW+PH5TjpKO5KLbrZxwdZVj+ni046lcGociT7rygz69O2+F07QUdl29k/oMcA1IACsPr ogFOu+WIohIsV4f5Ubv3BIEN4UmmbOfy1vuZdtbW5oiskt+c6nSfzItIhKIX2q7RlopIn0 pD2LsXV6/rSH/ZQ01+6lndgO/zU+Cxg= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BNIwxYas; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750153788; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DF2LSLjoIDZihiRcdf30WHksttB87jWZgxoeifw/8vs=; b=BNIwxYasbCufquJMv8PTP3TA9tL5rbY7VE0lYOZYL2/id32vV+LlGpreXILvaTZvmpBJMj 4NeSxduxmkiPhMyxz2I9NNT2dHbeakR1VdXNzXXVo57S+qaROJigSTFpNtvREiWJYHAMhs 540Na2xZlNznF1GUCjo16CZTDT6s2wc= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-663-9pZLlwQgNyOh6tjp-ogIrg-1; Tue, 17 Jun 2025 05:49:47 -0400 X-MC-Unique: 9pZLlwQgNyOh6tjp-ogIrg-1 X-Mimecast-MFC-AGG-ID: 9pZLlwQgNyOh6tjp-ogIrg_1750153786 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-450db029f2aso26049605e9.3 for ; Tue, 17 Jun 2025 02:49:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750153786; x=1750758586; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=DF2LSLjoIDZihiRcdf30WHksttB87jWZgxoeifw/8vs=; b=H17i1qEqB3LR2ArtRSO8qWVzhB4yKJwCq5svrL5RGjnB/hnJW8jfnnJbs7XzIw2DNQ n6Sn9xkBlt0C/FM0rT029rQhuyvAwSSohszmP3SqPcUqUkE0iZXeC7Zk5l0SXLqBJlee CHZ7EMiHlDOdNJSMNB6BGg3jUQbuaxOd3/gosWj5aNExL64nAwX41ZrU+TvafD5h5Yjc mrAP8+qvyzhVrvwb+re8JWkAIiNWOmYCA/1g73zo8fogElnCRyHvbXpoSxKeI1PFVWwf ZRn5CPQBe/BwyWnSeUJDU4qQe93OwDuNMiBUSdA2O87XMDnZpJw6BwJ4JQFiFGpr2EKu DFuA== X-Forwarded-Encrypted: i=1; AJvYcCWb6KQ0NpDQOk4p7mwgTHfaqHno0NnO3f6kHjlZu0U8Tg861F9RASj7uMnugTFUAQZBKpYY/dfYTA==@kvack.org X-Gm-Message-State: AOJu0YyZw4k+rOrfWdrHfnWnu0LJvHLAC4FIAQrvKhnx8y88kCejhXmk bdlEqM2J5XOmNt3FKRAQoJVr9dxYmgkiibGCY4lPPwtV60+kPyAd8eesyxZdrmzLB4cA+QyiGY+ c+go5sKJyIzmAiZkP+6yc4rEYRSIwdgq+RWmYusLAcTwsQN9GTvJh X-Gm-Gg: ASbGncvOUfKWXbsQ5Zshqlddvw3G3gzq38Inifk2VD3RRz70FNcbJZqi0ZJe4cfWi2H Y3TEPdxf6Qu9trmejhlI6zTLkephx/Uji421gIB6xa8+J6CKN+6TlGBWIFUvLPkRNUXJDIP0Xg7 ueCpPHcLPLt7apggHJ0Nh8ObhS/5ojkH2XgyBN9DRUrNM4pb/plJGTVOHYGrGrl7EDt7yvVBI/Z UpnyOUAPNh8D94dZMVtF7PU6cmcDC5NYOVaHR+0CpGx8h599AE3AlPi88C7heq1tqL/AgwqpF4K rl1+YfLbjmBYpBmIEzLtLqn0gu0VAFDfa5THwVjd6iK7pYGbGdpMFHt7BSCydBy5+0HBzaCZO3z dhiKewoZdS4Y8YIThawsiNV1Y5uRa63hbcDREcm0MdwbEy3Q= X-Received: by 2002:a05:600c:1e1a:b0:43c:f513:958a with SMTP id 5b1f17b1804b1-453501b41d8mr46951425e9.13.1750153785833; Tue, 17 Jun 2025 02:49:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEvM94fKFQqOi6f/UiYAlYA5Dbtm0BuNIi449CTJMM+YlZg/bJp3A8qBZE/OedzVBw3uw9beA== X-Received: by 2002:a05:600c:1e1a:b0:43c:f513:958a with SMTP id 5b1f17b1804b1-453501b41d8mr46951115e9.13.1750153785434; Tue, 17 Jun 2025 02:49:45 -0700 (PDT) Received: from ?IPV6:2003:d8:2f31:700:3851:c66a:b6b9:3490? (p200300d82f3107003851c66ab6b93490.dip0.t-ipconnect.de. [2003:d8:2f31:700:3851:c66a:b6b9:3490]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532e256d95sm169069565e9.31.2025.06.17.02.49.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Jun 2025 02:49:44 -0700 (PDT) Message-ID: Date: Tue, 17 Jun 2025 11:49:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/3] vfio/type1: optimize vfio_unpin_pages_remote() for large folio To: lizhe.67@bytedance.com Cc: akpm@linux-foundation.org, alex.williamson@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, peterx@redhat.com References: <20250617094713.12501-1-lizhe.67@bytedance.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250617094713.12501-1-lizhe.67@bytedance.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: vS0Nt3H89xlhLs0nsKIgigDFkvzD5OrBwVILM2zwuo8_1750153786 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: C9362C0009 X-Stat-Signature: cot838aq6bwftcsytq3i59ziuz4kexgu X-HE-Tag: 1750153788-727526 X-HE-Meta: U2FsdGVkX19HrV9yIFJudIUd9yHrPQIrp3YHqXJP+JH1+ytam/QxYxs1i4pJxlhpyI1gJFccN5tJV+Wlv8H5OGgschbg9uPXtVAEmPr2TDE38M0UvH9ZEDrn//841OAb8pJlGz4MjuBX0Ty/ZAlBCSAD5wkDBky/CTjy6AM4WvcrbHstVMreGaoesik01+6lrzNEJoT3YpA5cZIzmiqDpjxvBQ7YpXAAdsqQ38GcxaeT88ZT7AZ35Onib/kwOm2XZF330jI1OF1kLGEROaSKailMMdkFPSlJMGT9s7VR3DalfU574jfpsvc2MRLFz57swSmi3TigpfobPW20j1fAnBt+38+AIWxQaklnMloquE35dqumUk2PBXkGrfzZXeR84Lq9Jn3w0QtZ9IWpYgGM0ACqJ3JuJZKU+na37sXd6bFzKm30+sWtKaOqoueaKMjVS2UDwGggkhuvnI7rxKNE+jdaThynJaShUu87YhTQrn9E+DkrVagOoBp9Rav7nyflGdabJ7T7GSvpYmMqKZ/FeLKe7oy+Bqyps3RBzssP03RQuFWNqHrYenifO5VSrDj15/HYCXHB3+aKoe1ilmbIgvqQujaC3i2bCBJjs2mg0vZ5kSx1Kfnbu8hW1An7PpfphBMEFORjVa0G053JPmXHUE1XKy8K3Xxxa9zdaLKqHPiZMka2UG/fIPMP94l/BKh7I1q6j2mE2uXwjlySIOqTu31bpVFcimSWix3EFdeanbDaLbjGNZDULyXWsrXhcvbFNf+dH+5MFBgpILXukDJ+ZsbNn+S1J94yM9UWVyRPLZ3ETW/faYpBhuoKYTI/6czgMEn1KrKem1Jv5A5JvycokDMQXrrMFXWgT4J2amWfJbLJAXknl4O2ylbmXM5ihmoD/e0VgpOrJwSk/p4iuP5hb2J9Zdomj4rvPxJ9qM6w33EE+oF2LLRl1NUuMG//werP6mp7AeJyr5hJK81Q6Ei sxQsDm3G XJBNn3+WKN4sEnDIX8ytJmsK4048Wntz4z72tWBgUgyNmDe2mLIzbnRDvWTnr2QdMGIpIDYFMCm6FpIS2ehO47GkAhzOyNIVwQDo8QTFxkz4a+dvu14gisAJrGtoLJINXGeuW2tiUhNKRr2ppp1xrG9GpO2ur3CD48EVPA7SwHehqdJxdHrQLQvBeIQZYMxxbzzqCuZuXYZqQRl/vgtYeeCnyNn6HDWmTMX3utTmoEukHG0nI6abh8pP91ewJHtCV47I7TZf2EjpvhS1b6eMu/kDOq2S7mXskSnakLeq99KcE1KioxYcLlrayEG7LmLPRTYsaFQBwpqMPJ/zKutwFeQkZVh31MtoKq5JZdwifQ2w3Jkh9hVjyoPkiFc0K3pmD4RfkkJNRLRacq/b2ukWNuYFH1rPny8jZ4H3b0UBAJ+RhuPLLGo1aCEoCdNScOX/6KBa2LSKCgWGfLyNnR69UtTWnKp8Nla2TVsqh4lJexsfFEPlNqqpyDJ0yJw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.06.25 11:47, lizhe.67@bytedance.com wrote: > On Tue, 17 Jun 2025 09:43:56 +0200, david@redhat.com wrote: > >>> diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c >>> index e952bf8bdfab..d7653f4c10d5 100644 >>> --- a/drivers/vfio/vfio_iommu_type1.c >>> +++ b/drivers/vfio/vfio_iommu_type1.c >>> @@ -801,16 +801,43 @@ static long vfio_pin_pages_remote(struct vfio_dma *dma, unsigned long vaddr, >>> return pinned; >>> } >>> >>> +/* Returned number includes the provided current page. */ >>> +static inline unsigned long folio_remaining_pages(struct folio *folio, >>> + struct page *page, unsigned long max_pages) >>> +{ >>> + if (!folio_test_large(folio)) >>> + return 1; >>> + return min_t(unsigned long, max_pages, >>> + folio_nr_pages(folio) - folio_page_idx(folio, page)); >>> +} >> >> Note that I think that should go somewhere into mm.h, and also get used >> by GUP. So factoring it out from GUP and then using it here. > > I think I need to separate this out into a distinct patch within the > patchset. Is that correct? Yes, that's what I would do. -- Cheers, David / dhildenb