From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 897D4D1CA0E for ; Tue, 5 Nov 2024 00:33:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9ABB6B008C; Mon, 4 Nov 2024 19:33:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C4A326B0092; Mon, 4 Nov 2024 19:33:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B12446B0093; Mon, 4 Nov 2024 19:33:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8D8286B008C for ; Mon, 4 Nov 2024 19:33:27 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3908040BD2 for ; Tue, 5 Nov 2024 00:33:27 +0000 (UTC) X-FDA: 82750166604.21.6A9B3D8 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by imf25.hostedemail.com (Postfix) with ESMTP id 673D1A002B for ; Tue, 5 Nov 2024 00:33:01 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=UALGC8Jh; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf25.hostedemail.com: domain of quic_yingangl@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_yingangl@quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730766638; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jxwPubZoadSHc6wblMN1Uev/cS67IXh45yth7yLWn/o=; b=YSffSzozm5bTLTY5rdxF9NFqgfhHk6h6oTzVPWqa0TWeskoCyYqJnPr5cJCGsZanH7CpF8 1UyVZkdTVN4N2uMJ2L1ssPli3nmXg+o0MOJbbbRVL7Z84PMIsDN/rcQA0eF7v9MdRo3eee j2ILclF3G1qDAA1IdW/GVMZ1+8DBOC8= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=UALGC8Jh; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf25.hostedemail.com: domain of quic_yingangl@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_yingangl@quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730766638; a=rsa-sha256; cv=none; b=m1lQTL8s6bp8V212NyD4e88BkW5j7dYPcpbc+nnT2ttcAFPKk+kv4jl0faxAJG3IkzcKhA Lxve/5apbO+XhjaiVPbOz/0w4uDfzLD1vamfLI6ZiUl1xEWMgM3npyMcRg7sh/5hEJEjO6 Qyb/vMCtDUCTuPevmtUyMpusQUjup5I= Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4A4LIlko027216; Tue, 5 Nov 2024 00:33:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=jxwPubZoadSHc6wblMN1Uev/ cS67IXh45yth7yLWn/o=; b=UALGC8JhkqnbbvUCMwyE6U4EvMIWfTI44ZeFyCSv vAPNLzAxA8MeESaqzwzbSvDAwwg9G04ozIQ8hFG/BApSB9SzT8bZKEkmY7VqfLIy IBDZtdeip7EcgreL56jbPhaQwCnI99mYGIUxLzSGr+iHFpA2YyHES1qc4z6S0Lxo LsKf6gOZZa4mWP+5kNKw2VbkmMtmCNHXKNliM+7QbDwux0emumw2BED7BB9l0rKK 3dUE+uRuDakart5pFC37+ds/+E5Uox3TW+p1lLPJVpKJJ501pjLGTsmjsm0nmNef DWC1gXbdVHbIRG1v5VLbQrYzhKN9kX8xQrQNwIpexvFj6Q== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 42nd8hds4d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 05 Nov 2024 00:33:19 +0000 (GMT) Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA04.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4A50XIHe029245 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 5 Nov 2024 00:33:18 GMT Received: from [10.232.65.248] (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 4 Nov 2024 16:33:15 -0800 Content-Type: multipart/alternative; boundary="------------p8a0n7r0Q4OFwL0wuUsFu2ws" Message-ID: Date: Tue, 5 Nov 2024 08:33:13 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] trace/events/page_ref: add page info to page_ref trace event To: Matthew Wilcox CC: "Vlastimil Babka (SUSE)" , , , , , , References: <20241031024222.505844-1-quic_yingangl@quicinc.com> <8418b91e-04bb-4b74-96dd-a9489fbf9ba6@kernel.org> <55f6332d-3b4c-4478-93f9-514a906e348d@quicinc.com> Content-Language: en-US From: Kassey Li quic In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: ahcrJj3E8WZJRQg9eaLY_Tb6JYg2xeog X-Proofpoint-GUID: ahcrJj3E8WZJRQg9eaLY_Tb6JYg2xeog X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 priorityscore=1501 phishscore=0 clxscore=1015 mlxscore=0 impostorscore=0 bulkscore=0 mlxlogscore=549 adultscore=0 suspectscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411050001 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 673D1A002B X-Stat-Signature: qg831aq98rmtq9pu38o5r68md9zusf1i X-Rspam-User: X-HE-Tag: 1730766781-367010 X-HE-Meta: U2FsdGVkX18EtIuhK5Fb2z9gjzFSRrYj8cSSBsFfuBaqFUb2SXN42krVIulM07d/L+UZSUcaTFjH6XMy56vz/pkDZBrHKSwWIDLPvUsXgVdX6l2wLYTOO2aAqaaHmh4nPmYWKjCRl4u+q+a4t6rcPDItmo/yMtlRXYfLz4Qhh4lPB7AtVyf1ZXutgHK3cTNuCVnXCFXHO9RRbp/mqZ5sbCKiuKR2rWKXSQ/ehZrnTV0BGVi22FxCMMIp3XCdKOibE8ncmM4tIR05uzo/sPiRUMF7Qgw5Qcd8IAQ98404bf9BUEWy47Uazl10ckmmuvpYOMiepb0RFx3+TZUCicqY6gX6i6LmAPiv8jk9S8WYVij2XrjoslrhT1EAZ3P0N12C91XNa+uvrwpms+Wtt4dzt0iFPFulZibNHLi+xnfmB3wTJJazS+ImQxK5wG6urZUt+g4EvTTQd0mY8olSwG2lyoHs83ANKhXiIiBV9Bb8VCy7MlUrq0skZvbMxy/9ZbFbZUSvuKERC7exSpKlIPnScdQqMRHGNSB7K0r8cpbVV+CpiqnPnW0lWnemjyBoicFd7J65B0n3ZXh1L31oqFTFuZxMVJk1wZqxz8TQE9nc6vnUCFugssnXFmj08ve5vO4n4Zuz8FIrRKuHxg+z1ElfTfp2uxGEZIguJIky7vbWM6j86VrAHEEyuL8T1FBcudELaQLsgrhfJWJ7Rxn/Bm+mFpD5od5XxZSn4ZlUadHOUM2ZKvBoyDQNlkpRoYZqoh1W5R8eUE1S9SPoiNlAB/PHZwmIH0drQfqndZ3aMBTM7m/OdEh99PiDFstKgQA6lSetmRispGGpkgz97i5EUaFLLxavzsTySP6zCY8ZM2JgMUEqDOsMRRzN6BQoSXp0zJprAVXHXJdRoYJDf0t0uuFo41kgm3wT0pBNhqy/CH1aWxDg1aEFrNa7wfWEHpAEeH+EvPKjHUuIwXdiDx1cls6 HN3ZG4vt iPODRRITkBhYHEGi1DuchB+rnvXpuFBqhica65BIR/aahVZOFO6Pa27Xbz+SFUmIOHiKGqGlz1mDkrbVJKdJ1ZWqnfpldxdAxsYrCbDc+FkuzVeIvI9VAgRtgTjv9b8RiEZog6YSwTaI/3ea3ZqwJcRtR35ha/U2N+o75s8nFrb90MbeNpKdUUVpNtZn00ITCzy8eQSkVO7jGr/YhXtyml7BA64IIcW9puCwCdRVzU/D5RkXo/5bhKBp2Qgi+W1AchzhtGeBr42S0GFs7RLGXMeRok6+L7hPdVGC+MT2cPnK2Cx+TZZpjIoYyyAVOV5ySt/f/VP5ZMLowI8B3HkepuHgOjVmKGdQZVzdWiwRY10TobqlbBiPeW0Kjpa9Wx16Qrz2UC5jxO5iHnrHtPTQ/1mWTBf7SzEZh4I9N1s8JDKUrVh4OzB7fw7PGuL8pmHZAWo8IOGrTxeOkWLXVLh70tlus4xfUqxal5nrDzXAHCeTUqzQxB5a9wvLPbc7WKkLypUqQPCxNKMdwCtHj9gWXOo3IpovCLTx/ZBdM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --------------p8a0n7r0Q4OFwL0wuUsFu2ws Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit thanks for the suggest from Matthew and Vlastimil. On 2024/11/4 21:39, Matthew Wilcox wrote: > On Mon, Nov 04, 2024 at 03:35:37PM +0800, Kassey Li quic wrote: >>>> In many kernel code we are talking with page other than pfn, >>>> here we added page algin with pfn. >>> How exactly would this help you, what are you doing with the trace? >> we met some problem where filesystem held the page. >> >> we can show the page pointer other than pfn in filesystem code. > Don't do that. Change the filesystem code to show the pfn, and send > *that* patch instead. thanks for the suggest from Matthew and Vlastimil. --------------p8a0n7r0Q4OFwL0wuUsFu2ws Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 7bit

thanks for the suggest from Matthew and Vlastimil.

On 2024/11/4 21:39, Matthew Wilcox wrote:
On Mon, Nov 04, 2024 at 03:35:37PM +0800, Kassey Li quic wrote:

In many kernel code we are talking with page other than pfn,
here we added page algin with pfn.

How exactly would this help you, what are you doing with the trace?

we met some problem where filesystem held the page.

we can show the page pointer other than pfn in filesystem code.

Don't do that.  Change the filesystem code to show the pfn, and send
*that* patch instead.
thanks for the suggest from Matthew and Vlastimil. 

    

  


--------------p8a0n7r0Q4OFwL0wuUsFu2ws--