From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C4B9C6FA99 for ; Mon, 6 Mar 2023 14:07:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E30B280006; Mon, 6 Mar 2023 09:07:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 16CA3280001; Mon, 6 Mar 2023 09:07:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00CD4280006; Mon, 6 Mar 2023 09:07:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E0A62280001 for ; Mon, 6 Mar 2023 09:07:57 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B259C401D1 for ; Mon, 6 Mar 2023 14:07:57 +0000 (UTC) X-FDA: 80538652194.11.AE92A1D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 41233C0026 for ; Mon, 6 Mar 2023 14:07:55 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TI0blczO; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678111675; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7YJ33VBWjw2CT0ZZFr8RJg8K/VD7WeNxaY8vu7LGjb0=; b=8lqbUdVT0UIqKZ6NCI5GgoajnlpLSyPqsHVf1wwGkrU8ek9iaan4gMuBJevgvgGbcxJ2of S3BYVRCNLAdunIsdEo054T3ouAaTIQ/9jpzTp+ZseEKQQTzyUSBzoXpKfKvBPtx3pPiz9C adkfb/khDH3OREfn9UwFiV2VUfiAMRI= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TI0blczO; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678111675; a=rsa-sha256; cv=none; b=AKaoz/om+39JwG/3nY83q0NHr5m86jZBxRbHkZ2z/QwgzEuNA5BGNxf5saL69m2VaOVl6B qs9d1lHLtYi5GllY1YDC1gZergUbIq52QAIBhR7b6sDhhVTsQltbtZHJIQvO3WA6fb0//0 ED1+nzMnqGqnEUpnwCxVCG5juzkk5Ic= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678111674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7YJ33VBWjw2CT0ZZFr8RJg8K/VD7WeNxaY8vu7LGjb0=; b=TI0blczOk7BzkKC0jqfA8p1SuCYqon29pqWKpAlMoRQkX32TXtccBIxTwDrHjfOTst62QS ARyHjgm5gBXo2HaJf3D0hzUfdjhb1/qCdfKsLWmKQirLbN5UldUnHTnEksDhheHAG/9Z0t 2wqV2e0RgUs2JmSZQZJOAP+Y6Wv8aSo= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-587-REg7AGHdNqWjovPvYuL2aQ-1; Mon, 06 Mar 2023 09:07:53 -0500 X-MC-Unique: REg7AGHdNqWjovPvYuL2aQ-1 Received: by mail-wm1-f71.google.com with SMTP id m28-20020a05600c3b1c00b003e7d4662b83so6809886wms.0 for ; Mon, 06 Mar 2023 06:07:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678111368; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7YJ33VBWjw2CT0ZZFr8RJg8K/VD7WeNxaY8vu7LGjb0=; b=MvUQWmqFCo6ImIS8bi/64gXxkVv9Bky946CpTx5ReH4EdY83UXKjSoBDSwIkHJkcDL uywc3WGZW1Q6AEVPhRt78q/gBaW8xgB6B7u1wzEk2XeKfhg0Y80PY4Xe1TX7NXWf6M3t fx3qg5jWOKvwZkh7j9KC4nS/AGm3rsfXfXQ7iTgMttaN/pAJQxetXLf3EUBEkT/rnIB1 AluhF5pDH4LdC3qIxitvkBu87iNVDSQ+3qv66rbCRb1Dx3BCc8WyovUI/5gmemSmCv+k Gh2z7dysQ9e5FErIa6V+uDwS14icIc/c2Xc56WGAs9zXT6uO+WB83rTcEzLRhTTJnHTd S4kg== X-Gm-Message-State: AO0yUKXTKWtfy3LP7eeJGnYBpaZFlAxaP1+iCA8d2zb+xi7R9/9Vhyjg BXXlL5fFWUhIntl2DkH2GPdYmCe2IlVEVLjoyBT8sPr7wwCQbH2cqdLfcaWAcQuQ8LzgaxA+kKG inu+ei/7qJzM= X-Received: by 2002:a05:600c:4509:b0:3eb:399d:ab28 with SMTP id t9-20020a05600c450900b003eb399dab28mr9282557wmo.37.1678111368196; Mon, 06 Mar 2023 06:02:48 -0800 (PST) X-Google-Smtp-Source: AK7set8UsnDqSBjgdWhLZMOVUCI8XxZWntH6OdOcD4b0pMNiP46MgSM5QIbPtcURKpqK/78/66kQ7g== X-Received: by 2002:a05:600c:4509:b0:3eb:399d:ab28 with SMTP id t9-20020a05600c450900b003eb399dab28mr9282511wmo.37.1678111367826; Mon, 06 Mar 2023 06:02:47 -0800 (PST) Received: from ?IPV6:2003:cb:c704:3500:b8a3:191c:eae:cc05? (p200300cbc7043500b8a3191c0eaecc05.dip0.t-ipconnect.de. [2003:cb:c704:3500:b8a3:191c:eae:cc05]) by smtp.gmail.com with ESMTPSA id p21-20020a05600c431500b003daf672a616sm10079911wme.22.2023.03.06.06.02.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Mar 2023 06:02:47 -0800 (PST) Message-ID: Date: Mon, 6 Mar 2023 15:02:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 4/6] shmem: skip page split if we're not reclaiming To: Luis Chamberlain , hughd@google.com, akpm@linux-foundation.org, willy@infradead.org, brauner@kernel.org Cc: linux-mm@kvack.org, p.raghav@samsung.com, da.gomez@samsung.com, a.manzanares@samsung.com, dave@stgolabs.net, yosryahmed@google.com, keescook@chromium.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org References: <20230302232758.888157-1-mcgrof@kernel.org> <20230302232758.888157-5-mcgrof@kernel.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230302232758.888157-5-mcgrof@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 41233C0026 X-Stat-Signature: oj7saqqnweb6z4b6qgc89rsr8jjx757q X-HE-Tag: 1678111675-493285 X-HE-Meta: U2FsdGVkX1+zXb0//rEErSjKvXu1wA/RPQqz5YG7Uowp4R2df8aMGwkwAHLd6J/E0XV+GJwC4Ew44aTILnGposedTuLt45MYSApbhY05cK9pvMm8F8AAvQDLi5Esob1dDxFIZNOqgqS5H4JqqM8Wve8wR746cVXJGniuC4yUkKuxU6KXEK3/8+a10in6kTBOzDmxyZl2G18jyCpehT5Y96kx3qcMzvteLF9eRFIsWvVamhmW/4QvCgq2b4teyqWofC7BQ4csNNjCQeco8Zeg88IkwavKDmuTBuk5FbzaWSQ1BiAl8rHSahCOlnX7jenl1cEnbbgxTL0z79j+x3XIMdk0JYor8AMShJQFP2+LODWd16lsQbBclgewR6QAjs2d+zW6W5mMS6OZBB3q/qEgZp6QUZ6VT6ITvSfD6we8TxEG0LYHpUufL1bmacdQC9o/5w45sYxEzQ4+NnUUy0Hj32hmbWuze6uI228xZJe1DdhLKf6bqHoXlFo2G/RRPBzpqauSXYrGcwh7+noK72vYfPGmECivy/fr7X91MozUWmeFl0fcqMInmfupyzzDs/ISy9N6q+fu53tLswAOKWlBCStcrWu7jJG/Zv/zAtDr5v92SIlbtvCCi/qc/b6y3L7Ut7L2sIWkd1z8LSlhxC1gk8tJ6psnmPTjuabjdPzvvfvipxnT1DcWsXbbrNC25JYLINhZd4LiiVSCdmyhQ47ZG8mP9SppjeJy/Xbbdq0SEjiRFGTJRqZWyRylVQDHcu4vizZtYCzY3mmry8G1q51cH1kKMN9GbhHVe62Yq2BsDNeUY5ydv/vyMTA9PweuTRW91yr4v0Zcoc+UcmeincMH1Z9dzCGbDVrqRIHLnTRfu7s3BtRJJeUFwP920t3GX8RTh4OW4c9av79Tc0GExz/u4K9cEXuj0/ceAnPONzOF8y05nsuIKTc71rhQMey1c7RVq28JVaDMu7w4EMb4Vgb zjFnnIBD 8uuW1ygq0yOijW3XOS0OpoV3H6UcITzrTJlpej07A5HWSoVXz6c+3S1eOH6wHpW6JQa96CxHZnWw5NmoGYVmmUrfjqiWusaJCSoRMadZ+M8sWjfsfBQcrgXnxrKCHhGgbwCRaDWxKd196ry3nmxsRe2Bbg2g/DF97pPt4KWZMtRceswGrm8ksFEfLWd9Y5spMfWIAdS+ZRuyghpENPYSl+SJIsS2+Ks3nJJ0Ydlx2bs+T4x9lBeKDbRrkGxbA9z4o5GVMQKoGx6YbCQawV1K7RLUaJDpaCPUTOXcULD/Gi7EO9pgqf2OrN3kOt05JgHiW9u7rjOccRs+E03c0ZZDso5gMKGwwsfKiNL/a89pTC/L90R/pspjclJNCaHxtPOI4Tfxck/kbbxHGkPwVpxEbRjBK6AQxc8Qi7E6DLdaUMkSoBk4XLn+ku3eOFTY5QlOWDG1jadUWq8q910f9ZBts6NBD9hh8PLMRfsq3/fVfVOTfjrc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 03.03.23 00:27, Luis Chamberlain wrote: > In theory when info->flags & VM_LOCKED we should not be getting > shem_writepage() called so we should be verifying this with a > WARN_ON_ONCE(). Since we should not be swapping then best to ensure > we also don't do the folio split earlier too. So just move the check > early to avoid folio splits in case its a dubious call. > > We also have a similar early bail when !total_swap_pages so just move > that earlier to avoid the possible folio split in the same situation. > > Signed-off-by: Luis Chamberlain > --- > mm/shmem.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index a5a6da51087e..6006dbb7dbcb 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -1352,6 +1352,12 @@ static int shmem_writepage(struct page *page, struct writeback_control *wbc) > goto redirty; > } > > + if (WARN_ON_ONCE(info->flags & VM_LOCKED)) > + goto redirty; > + > + if (!total_swap_pages) > + goto redirty; > + > /* > * If /sys/kernel/mm/transparent_hugepage/shmem_enabled is "always" or > * "force", drivers/gpu/drm/i915/gem/i915_gem_shmem.c gets huge pages, > @@ -1367,10 +1373,6 @@ static int shmem_writepage(struct page *page, struct writeback_control *wbc) > } > > index = folio->index; > - if (info->flags & VM_LOCKED) > - goto redirty; > - if (!total_swap_pages) > - goto redirty; > > /* > * This is somewhat ridiculous, but without plumbing a SWAP_MAP_FALLOC Acked-by: David Hildenbrand -- Thanks, David / dhildenb