From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8BFEC25B76 for ; Wed, 5 Jun 2024 03:46:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 645566B0092; Tue, 4 Jun 2024 23:46:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F58D6B0095; Tue, 4 Jun 2024 23:46:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BD046B0096; Tue, 4 Jun 2024 23:46:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2D2C56B0092 for ; Tue, 4 Jun 2024 23:46:32 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C81C3160EF3 for ; Wed, 5 Jun 2024 03:46:31 +0000 (UTC) X-FDA: 82195447782.21.1278B13 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf23.hostedemail.com (Postfix) with ESMTP id E7BDC140010 for ; Wed, 5 Jun 2024 03:46:29 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZkOoePxi; spf=pass (imf23.hostedemail.com: domain of seakeel@gmail.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=seakeel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717559190; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PX60psgZsJq8f8a6q8y+eYps4ToV1E7xz8xso3US6o0=; b=TzAews3YoTSys7h/ZzFBCj5pUTJLO+biLtt7QRUHM4yBScxXiw6cIW6DdNpTnO7qXttiik kDDgTYotynpW6DbDdEAWrSXZL0cqFxIMkwHQZ7XDIgf6w1qIzWCIPSDGV6tCRX6U6KBYRL UthvrrJFLp3ePsVV9RyJJ2+3OdY3o5Q= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZkOoePxi; spf=pass (imf23.hostedemail.com: domain of seakeel@gmail.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=seakeel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717559190; a=rsa-sha256; cv=none; b=KKiTTpXfHyG8RGm2BtzKErPOQ4UR5UjV1gGEWi2Ad2ULG+3eYm6AcajAeytY+21JU6/w/+ 9P5fCQ/PekAVGy6Z3P8pLojm2ioWnBa/KuZsUehhsZRsGvuoVWnrhK4eQIYy6PtjJ9A3fu XlDjJBPHsagPJcOvW7UOtdViRpUO31g= Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-701ae8698d8so4760717b3a.0 for ; Tue, 04 Jun 2024 20:46:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717559189; x=1718163989; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=PX60psgZsJq8f8a6q8y+eYps4ToV1E7xz8xso3US6o0=; b=ZkOoePxiP7q/IIZRu4le7heh38EkuyKf2rjn/+xsT3nKBWLGfuNUC1Q7QZwc2OVfRM zacPioekwHxU66nlWor4JE7piUYom9LRfO5VQNzVvIAMqtd1a6qKoGdF9VMs6D7j6qIC cR+Vzu1JJiHLvD4HIyQl/ELmHNwbgVzGb5eOca2X05pNKI/hpLGakSuvMOEq3pw1AFbj SgM7F9nvxz4Kp+1P2enZApXQUk3TI7tfXkOThSCpV96/ONMdkPY54zY1q8PJZWaY0fmQ IQ67U99jISHgksD37dhxF3dEA7rl0+HbYcvUmsv0WXuiKaSQ5qZzx3fkd4Hlpda+xxv/ r44Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717559189; x=1718163989; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PX60psgZsJq8f8a6q8y+eYps4ToV1E7xz8xso3US6o0=; b=RCoYsin2gaX/WlgspwE4MoRzi6ZKJhaxO92OYrHQ0fl4TNFtnobi7VLJrXwG1BRBWG rymREOfL/yCxrc7N6BrQSjcfAbs4u4yIWg6J+JxtUo5cXu0dm8OYlZyHoXrK4PCLgKAY Lz7rFvEP/EVh5hiSmzI0DUXBNjwTrL5cr6pqIq+JWyFj4JUW72eL+szN0B5v7Owuyy7r 3QBJRLcoAcX/HpkrwFFVMQG0e/h5S5rXzUww905vsv1Gn/v5ib92+Qsm9q7UuXPZ3eio 5fvVqYlUk5q52gxA2VOyE7ThcGoLNwHHOdRHfA528/AXgDmlLzzFG03tbQ8X5ls5jQCY FRsw== X-Forwarded-Encrypted: i=1; AJvYcCX/XzMNGeoAOTmBOm+f4kUHbTBxH2xLsjPY++l0aTKahVKc05zeeaLBJxlZTsywkwhH5oeGfx1ieFbYn+G8RWHZiSA= X-Gm-Message-State: AOJu0YyFZ/C2JfJKukKL/jRYQs1MIkg8x+3y/tad4IzM3PqTkP5Zmh+d aSo33OAA9zm+r8E0e8JkYMPmgCS6PR5r0hY06Axz1axLsiSQAy1x X-Google-Smtp-Source: AGHT+IFrWYR4dmEbB8SzW2qSluedSo2HfnH9zcP2BEozUSBwlRpjP7meKVaGNZmd98HHG+I50vq1og== X-Received: by 2002:a05:6a00:4b14:b0:6f8:e442:a28a with SMTP id d2e1a72fcca58-703e59e479bmr1436573b3a.21.1717559188603; Tue, 04 Jun 2024 20:46:28 -0700 (PDT) Received: from [192.168.255.10] ([43.132.141.20]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-702423e0132sm7755792b3a.67.2024.06.04.20.46.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jun 2024 20:46:28 -0700 (PDT) Message-ID: Date: Wed, 5 Jun 2024 11:46:24 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/10] use folio in ksm To: David Hildenbrand , alexs@kernel.org, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, izik.eidus@ravellosystems.com, willy@infradead.org, aarcange@redhat.com, chrisw@sous-sol.org, hughd@google.com References: <20240604042454.2012091-1-alexs@kernel.org> <9bc7eb69-47a7-4565-8672-636273967dc3@redhat.com> Content-Language: en-US From: Alex Shi In-Reply-To: <9bc7eb69-47a7-4565-8672-636273967dc3@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: gbiuw6n53ry4ua6ki913yptjn61g1cz6 X-Rspamd-Queue-Id: E7BDC140010 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1717559189-843527 X-HE-Meta: U2FsdGVkX18U8m/BQbO3LohpYcy1884Y69/F5HhDFO39uFQ4kDH7ujQE0XNVIcr5ba4aFc+DJ5fitJkGH85fuiyXjb8ZZZNta7S4hrbZ4hGT8izRV2X4xCsXsHlE4x84AwAVllahPr/qo+mF15/v67PPHfQNul7dhL4w+evFdpZElP74+cNuStc+8avEmr5gaWHUnJRDD48JXnoyyZehfnTOCT+PJNc8daBSnwWZwbtZ7eE9blUAh/yMcYo9XYgeikdTKAH3vp3k2o+9MIxKzw3O99TThWV82kxpAveSk6kuAIcxma5iv2xPAt/9nnapThGwAVphrJ18+UJpJCNIx9yH7ixqY8AcKatBSDzfkh9OJij8w6NvIxqDeNuYgqd9PHv6DBIKAZm+o4dYp43RGCHSwAoN2JEjAMmpLYC98Bq46S1gWj/WNHKp8KD5c+zY1TAJQbKl5Qi95UwXEWi5JHVnnwhnx30AyxPy4eAuEc3zL7rcEq04+oyWjrfRxtK1cZ0e+T6bKtMYsjuDB4kEnV2wU3Z8Hf8MwfuODIVn1eAsEQ/Gr3taiYsiEPaoqpTDP3/v0DUMv4vhgvCWNGbyt7G0+cLFSHTyd3iS+pLfiD5D2coQhlTxqk3/5kDDekrDCWjAwNIq/5X64bzEy3a3/FG6Obe+m23lm/JD8Ph7YBk/vlDt3a1pxlGtzDaKgS2Zqf3ODOYsB95duqmduY2ZJBdYHByVD2yvbKGaSwWpUiAbBJK+h02/oFRfXIceqe1IZ5ZYhzIKo3y337dcLeCdMKg5c7orLBtgSDCHZH/Qc0W6mTYjzpJAJ3VeSMZK89k/wNv7MHINxQlXVI/M+yQdS0s/X5h02eKocES4/7iRzGHix+50FGA10vO+FeoURaOQuwdmXBJAJ107UWYSflG8uAsSrLARxtfi05xEejI/ecZRxwgchJ0EP3efTdVl/wr8VtCzbeenooxbQOGXypp bPSJkGC5 w1HecbAXsVTShRhpEl9AEqWPoKa0Q/iqXg0LM22XWy+F6S4o4UeXfWBqhqRCVEKYUJ3rHfKyAKCQPdWsU5osu17c11m7YyBGHQ+WZdZmTy8H8/jSzvstP1J/q6wdcpFnBrUwBSqlBll1vtPrqNI1FmBW9kjD4jp5p8IjtAry/T+MA7OONWoe/ODPjH4tpFDtfM4Oqx7Tf3KlEbjneYHR9sHckMwOXRLwZc5bHCPMvQIgX1z8dugu+gA3YL1+pXu58Qvp6UsYubeAMwhd7sl/8TBxi2Q8ox05WFvhZVTwDwOPme0TgJRAAEdPaRKjn60l8mgHKh7fHLQ8lCXM7cu4afUp2NxDKKCMmJLGFiDqd9xYwJs/i0LHu37rymxCtzaVQXvqpdqOQNsZThYJ7wotBm20/f8mH/no590AbC42koqs2lfvKxEti7PmfgMeAN9WVT95r5SD4Bmj8a67NxH65/v8JPjU8ENddk5odiC46O5wri5otC0X8vvm5Ewf3w+haZ7kkVck5KzUtmJomEbaxPBUmwL82pQTjihOU6mYRkenYuGw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000242, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/4/24 9:28 PM, David Hildenbrand wrote: > On 04.06.24 06:24, alexs@kernel.org wrote: >> From: "Alex Shi (tencent)" >> >> This is the 2nd part to use folio in ksm, it saves 82kbytes in ksm.o and >> passed all ksm testcases in kselftest. >> >> KSM still split same folios to single page if they are good to be KSM, >> but will skip the rest subpage checking if a folio couldn't suit for >> ksm. >> >> Alex Shi (tencent) (10): >>    mm/ksm: reduce the flush action for ksm merging page >>    mm/ksm: skip subpages of compound pages >>    mm/ksm: use folio in try_to_merge_one_page >>    mm/ksm: add identical_folio func >>    mm/ksm: use folio in stable_tree_search >>    mm/ksm: remove page_stable_node >>    mm/ksm: use folio in unstable_tree_search_insert >>    mm/ksm: use folio in try_to_merge_xx serie funcs >>    mm/ksm: calc_checksum for folio >>    m/ksm: use folio in ksm scan path > > I skimmed over most patches, but I'm afraid you introduce quite some subtle problems. > > Part of the rework should not be do convert things to folios that really operate on pages (of possibly large folios). > > We really have to be careful about pages vs. folios before we have KSM folios. Only then, we know that we have small folios only. > Thanks a lot for your reviewing and comments. Let's if we'd do it better with your comments! :) Thanks Alex