From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EECAC54F30 for ; Tue, 27 May 2025 11:43:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B683B6B0082; Tue, 27 May 2025 07:43:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B193A6B0083; Tue, 27 May 2025 07:43:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B9CB6B0085; Tue, 27 May 2025 07:43:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 779986B0082 for ; Tue, 27 May 2025 07:43:11 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0C8B71208A0 for ; Tue, 27 May 2025 11:43:11 +0000 (UTC) X-FDA: 83488501782.11.4CB4662 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf09.hostedemail.com (Postfix) with ESMTP id A84F014000E for ; Tue, 27 May 2025 11:43:07 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=cADj5qwm; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=IEoWWOA8; spf=pass (imf09.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748346187; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S4L/rpbpWYswqgznr3alcCVMIEOhx+kWFot0wvXPwH0=; b=jtqqkCLAu3U6ZlQqU3N9g4a5i1w99LQeewP8tdiE6wkdjmGZTHsTzsgu8pSr382HgZfPOF WzQ7m4Ma1pWs5UZEMJnfgLYsq1QKOCP7g7zGuqPmvsJlJDCDy+t4PsX7ZcbBr8VhTyMG7R yUWBaMFoZ8gGuiPEDx5BB2hXn31h9SI= ARC-Authentication-Results: i=2; imf09.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=cADj5qwm; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=IEoWWOA8; spf=pass (imf09.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1748346187; a=rsa-sha256; cv=pass; b=kDbXXtl+G5ZOhpTikLrWB+LTPRMKrPXWsjF0A/E8x8fJH5Dfr/5zmbRNlGW24s2shY3YJ5 T3jRco3CEsdjuyfUVP3UIem7HcHRMKqPZ454C23mLO7FXsh/3LZLP5m7Lt7D9X1KcoQPej jIZ4lw8eQjEP876hsUnFvSzYaw06NJE= Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54R69YYd007325; Tue, 27 May 2025 11:42:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2025-04-25; bh=S4L/rpbpWYswqgznr3 alcCVMIEOhx+kWFot0wvXPwH0=; b=cADj5qwmevN6n6H8TqU2/WJd426K/bBa3r R9pDIo5HpjhLOr8PNWjeTsa/CxcoMlgvbKtAqg3NDlVMniRECR9hEsS5aijEpM7/ H2FZdcZZANAqfRcjjPAqJwwDtIppNmQ4lxY8pseOrOo6vsG8vw7l5OoTVZyfiUGX nFY0R10lbCG83QGUzoeI24Pnxk/+hx3L262QrvZ0IzSgjQYIESIPnE1asG14IGNO B5k0kP8TilCsvNSrZWTwB2MF+wa8sSBZYWTqQhCnQd/gV9RGv6r/4HqvcY0+XVsK E93rpFK6O+z7jyLx1KM3+i9u0TzJzvmLu0bjmcKOXNk121AdZu1g== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 46v3hjtwjf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 May 2025 11:42:45 +0000 (GMT) Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 54RBbvFV007248; Tue, 27 May 2025 11:42:44 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12on2077.outbound.protection.outlook.com [40.107.237.77]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 46u4j90ag0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 May 2025 11:42:44 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SHQ/WfzskLk5FJhCTQSZc9VkAuhAQmCqa44pxlZVujqg/+HjkGurJACeS5GucxWtv+z6QVtZrg2tU4yWQkl4mufHLV1xF6Icdbetg7qyGG+/hltGFtVxfNL3EzA60xH+wiZ43lZOIDpRUoGGmryh7ilhprlb4qxW0HxgyJVYnFqGIYteZmGfRZ89LYXSM/Ax8JkCu4aTBvTSKM27/9X2X+FdNcgGrCOikz5Ezngr3QkJw3HXZ5afRhn31+VVElKw1w4WlqaJfB64y95zN9Dpoa9z5cbi6W/wUeNjAoiG4SqWoddddLH4mukcAKlwS6Ocn66S74t0NfdapzEBdTijLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S4L/rpbpWYswqgznr3alcCVMIEOhx+kWFot0wvXPwH0=; b=Esh+qQg8VEyeH6uPoK9Mc8EPS9M98105qByducVnMJv2jjrbiz3nE65uUTIWq0ft+49GPWIIULnnuLmVs+uraTgzsFNiP3EzUkurMI5pFzPHxIHpJKnveWJoNiXaowvemGfMKe7P6KiXUil3FUjucn7OLRhlAR/CA1kGG98K2wEhVkEPX8DO5L+BsT45vneMu5BNd0D3NDrq4IxBbKGKPzyzvgqtsE7b6X4bO15N19HUMDssh8S2huy0cVOVcVcW/9QE4X4XHlLPTL8Rz68JvY5YNm5ghamcoE/tzzyTfnESMKY2qoEodDO1IDQl09SZCb02G7q/F/06xWmSBhcZKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S4L/rpbpWYswqgznr3alcCVMIEOhx+kWFot0wvXPwH0=; b=IEoWWOA8eA7Dolz70foRZEvnMHwSX35ZYcjFwZTAo4hm5qVjSkw1GnsSZ4eoS4OERLjQS5NgDoIj2s1TMXVgFHhqlxUgDy6F/BUkKFJsOd4F6p+y17OtXVpFX9n2pIgUjZwyrocm7RlVCTqq5scK2VLwz928PmaLx3epLilZ4fI= Received: from DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) by SA1PR10MB6414.namprd10.prod.outlook.com (2603:10b6:806:259::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8746.40; Tue, 27 May 2025 11:42:41 +0000 Received: from DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2]) by DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2%5]) with mapi id 15.20.8746.030; Tue, 27 May 2025 11:42:41 +0000 Date: Tue, 27 May 2025 12:42:38 +0100 From: Lorenzo Stoakes To: David Hildenbrand Cc: Oleg Nesterov , Pu Lehui , mhiramat@kernel.org, peterz@infradead.org, Liam.Howlett@oracle.com, akpm@linux-foundation.org, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pulehui@huawei.com Subject: Re: [RFC PATCH] mm/mmap: Fix uprobe anon page be overwritten when expanding vma during mremap Message-ID: References: <20250521092503.3116340-1-pulehui@huaweicloud.com> <62b5ccf5-f1cd-43c2-b0bc-f542f40c5bdf@redhat.com> <13c5fe73-9e11-4465-b401-fc96a22dc5d1@redhat.com> <4cbc1e43-ea46-44de-9e2b-1c62dcd2b6d5@huaweicloud.com> <20250526154850.GA4156@redhat.com> <06bd94c0-fefe-4bdc-8483-2d9b6703c3d6@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <06bd94c0-fefe-4bdc-8483-2d9b6703c3d6@redhat.com> X-ClientProxiedBy: LO4P265CA0208.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:33a::6) To DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR10MB8218:EE_|SA1PR10MB6414:EE_ X-MS-Office365-Filtering-Correlation-Id: c633517a-b8cd-4dd6-5aa5-08dd9d13965b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?4Q4Bzm8U90Srd/ACUrT0aFKYM74STsccRM1rnG8snwi9SJuSwz7O9ngcBYdD?= =?us-ascii?Q?oz7ye7JJ9+d2kSmg7R5UMjd8BayJA2ShXQwFOk1pV77pjXuKhRKvoA3MYnxX?= =?us-ascii?Q?7KKzq3Dj58XkHBiZsVHX1ZLo5+oh95yksnMEfqrAghXumY73bCXupqVi/Hah?= =?us-ascii?Q?cvkuz4has5WKyywLMTjUm7l+pp5zW9Vu8NeD1qxPc68qpiem2J+tzoi9tO3u?= =?us-ascii?Q?Kr9cBjqfQUwtZWSm1ciWGoHXBDhcS6NE2jZIP419o4Xt7UsAqmeSr/Lcb0CP?= =?us-ascii?Q?C+GQm+m4DxN1XNq3qWt63iKvaDrHAJ7Fn8URQjh/VJ4B5BWMgiRDI93sRbvN?= =?us-ascii?Q?+JUjWriaccQgK0badhBcQ8mVld4KuS1IVRxrwIAAxmFt06ldU4u7kQ5vGa/k?= =?us-ascii?Q?/CvjC0hecyzMitRChWo5HF2UfHXakve1C6Qvuaxd5Ft/oXWuYVPEo/WHf4SX?= =?us-ascii?Q?RwoTWTo8ADHro/IZBsS8Z9kcECEd7n4kGp8mIb4jvoy+FU4ObotKVdCz9rTp?= =?us-ascii?Q?FCqPlwDij1q66BFARtbaKAxBZE/B99yYrpywhKV6TuGuUDyL5R0SnAoIk1EP?= =?us-ascii?Q?trmDYwPMgN2JXE2VrCSish67mED0mu/IesugwnHfABFIzJ9m63jy5Qmz/X+P?= =?us-ascii?Q?PhZzK5d0wNvC2PkmHw9AWJ5wUSZCmNpqHDPnRgrguJ+FCgR889pJiD6xIMfv?= =?us-ascii?Q?CDpTFQwzEvVaSsPgPjRR/pCFSraxdFBFF43wnP2sSshCn5pErUTp+xBEZFVl?= =?us-ascii?Q?7y4QM/RWs7AboRIvXYnlQpK5KeWGqA88lm3ESnWYTSKrXSTzCs83uUrv9PIU?= =?us-ascii?Q?+wTdMJ4E2s6NHQd3yzivwk5n6NpQA+nb4p7tjZxn78l1d/mmszFwPctBSW2K?= =?us-ascii?Q?cw06Sz3F2I9kRbmcVbsXYOXQgJgHVOH/XYIhTOcxANbEKooKNoV2ytJIixZJ?= =?us-ascii?Q?4f2Dt/Al+WP6qpaBdLeZW/H5klE5NN9tFpuY4jOHvq8ef52R8MFlLOXhnDMj?= =?us-ascii?Q?gTXLu9LaLM9vIiOb8RjLuj1LLwLhITzc6JEgK2F9uMweGyjiX4uqE/iqwDv3?= =?us-ascii?Q?eTZssMXdRvgbeI0vW1UnuYi70QldFjZqeXbsI6wGFSi4Xc7OGJJbEzh/LGtb?= =?us-ascii?Q?a73uYZCQ3v3TPMBbl0w/aby1Dqy5qVZlfp4Qqj6aD0fCgwbGi6VEfuQBe8uG?= =?us-ascii?Q?vJej79XLSSnpByqDh9B5bVBdSJ/Fx2vyjv02nWEsLY3flEjJI0xgk2nFwJ+b?= =?us-ascii?Q?rN649UmFdpOCMOv7DdGvwEsBevSOKivDE/wwoI8OerrjIdMri6cLubNdb/H5?= =?us-ascii?Q?p0JpQ03r9/nLVp0NnOKCKEXPB0Yil56X4VtoUt1uUh7AYvO+T6OV3iQdJued?= =?us-ascii?Q?+9hL+3NkLCIOmubYkgtaZzSiLHjrH/TImML744qFb+8iDq940AiaTND8hXI5?= =?us-ascii?Q?kNcFlt1vxCI=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR10MB8218.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mntvWboC86kr4MXB7B0WH/gHT5tySUjOvH+Pvdzfz7T56Rn+tyQXLkIiKtIs?= =?us-ascii?Q?PmqPAmx8tki/Gk49C8I0V57LM2hiTctdKJBu5fUfxafiWDbjffV+ofr1Xodk?= =?us-ascii?Q?NQp8bVyjZo4Q3ZOCum7UYp9ZOcyjjrUu1Xa0LWCdFrRXOYNcGizGs3k1GiwJ?= =?us-ascii?Q?iQszD+oo6jwchPx1kB0NoBSCA+0Xx6wargp8DaKmhVJuSNcGclM3ZfRaH/G8?= =?us-ascii?Q?dC4ukOorw2xPm5GgKnTk/83REqOeZ35615rjbhJc2NsxXHubjAs5B3jfJJlf?= =?us-ascii?Q?IMQ9HodErB43iFkeWoB1ga/BKOVLQz0y5B/ykGKCd1yNJjqA/WGCxdVGdKI5?= =?us-ascii?Q?KMCWrxpyoz8dz2nt7TAL7Ns/vjXe7pdOMUe6B5yTXrl5IHwB54EoeT6ID/Wx?= =?us-ascii?Q?/Xg1UsHIbZDts5sHUfJKndPQzVhfO80vKpHOGfYe5QvwfaBjbHsCpXNuIScN?= =?us-ascii?Q?cNqCvU7lCjnfXbmH7rOjxs2Th0QeVw3A8jCDbLfzBt5ZkepaELDPelHmkCvK?= =?us-ascii?Q?C+MCBErARZdWjQxe7jfHtNWgPbcxpxXOZjBmGY8ojrEbDIbDQo117/JP0Uxr?= =?us-ascii?Q?gJveuWZBOUZb+FmYkEES4B2k4i4b6SNhQoKZTQuFqE86Ai5MEfWA9n8RVBEc?= =?us-ascii?Q?Rf/g+vAWNByeGF9x+nqBxH21S8h408er88KjnkfLr+LYjmRl11VILH5oi3P8?= =?us-ascii?Q?jawQdov+o2J2LKP+y2LvFz4LMTQn5XUV7fDsiiC7hiismZaw9voCpRyJbjZc?= =?us-ascii?Q?+VCBEzIg1KMZ7XyX0KG7yX1Cf9pY9GA0qN/HMox4sAwGDdIUI0wmw3mhvzq1?= =?us-ascii?Q?d02HXXkJC7k2RpATWTlMn45Wullshpi4/ZAX23JvSw+0Q/buFpNUgkzSwWlY?= =?us-ascii?Q?UQiYPUyQSJ8dKuI7e2lAKm69Zl2674mrmb6zNAenCijRZ8lrEknvooY8KvdS?= =?us-ascii?Q?Edd3diKCIFKMuHobOMqxGes3iuxPHyxcTdN8cBqncV19mUhwLrhjPMYpOZhf?= =?us-ascii?Q?yE3OWQcLreEIBJSqBOV1pl2e1w6S9huF/pGiB2b/tBinfcfPWo1Hxhm6UAa0?= =?us-ascii?Q?EcSE5SkgjspGdZmBuhum11pXtTP5MzDBniLQCpaY0f2kebXGbnGo0JCG5lD7?= =?us-ascii?Q?WnWvJDPeIUyOgkiV2+MAr75wGKt2Hj48oUk9xoIHLgJsBS7fRkenL8hmm+pJ?= =?us-ascii?Q?qk2veaOykHJoPCpWinpDzDYkpC7SzycD1vrn16ER+QXSboHdPjCg488cKSKh?= =?us-ascii?Q?kHLpxZZ6sxp/0u57SlnPtzC2URdUrFBHduPFj3BBDDXMtRCKG5l2gJGBwlWu?= =?us-ascii?Q?thUjoUvZ79u84gmjqAmZhdi3H8TpOfxlnzjRSGLzSbiPh+dgQymAZGZFnWrH?= =?us-ascii?Q?HbfD3vM5dH6QYt6LVoxTpPDgA5dILx6ZJ4L+VBUVlUT7JNsuuCUj9nWW433F?= =?us-ascii?Q?08pA2UbXQa8+jk8G8WHUEDTKJz8r9m1A9+JIAWn12HLtZ0+83u1JqQ3xPdH6?= =?us-ascii?Q?Dm2WEhaFo0V2YZejUtQk+QOnRLYYPq9paFoWvr9rt6VfryMl/EcxtpGgNYfF?= =?us-ascii?Q?R9Jhu0ZHq8JoFQLTDVfXAy/PEX9qhq5GVGRNl1swaAEyaYJuWsd6M7hvDS1m?= =?us-ascii?Q?sA=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: YiNb3htDGdIqX++8x1/QWc3EHbK18uLXRDCaFeeIq5la7lZX8tAupi8lXMIaQOfO7NFHmVL637gffgX7MGo5YfUQMc1M4sLU2xxsDuTKIw/5AMkjcHduwolSqTiOhyUSoM8BXWIXLbiLB4eXNizzgsnqGAKbHuI8t7+SXl7F9n3PHr7sbvA+UUDg4Zwt+3rWftHFHkTLCRM2gexfskjnAM5U35eUD6qWGA6PbiP1ZfBlcqPMMSVT8iJSw5wrXhyvJen1huG1XSvAHwUn/IHMV96v2w53jCdIim9FZIW2BbRFjLtIS3IDW0MUiHXyOIl5mdg06cCUUWt7pUG9Mky+fB+WMdWosl+iClYuJYyw+0mudUedo7nZpGVj6O2Xry5Z0WX04Hcgs74EmzX/fXleO2wN3+N1TAZdRrY6d57UmrqwjNx2ACLfHy2iKlpy0ub7zBonjUZgEN+6ttAmz/SOsAUJJ7DZuX2UYHMZkwhNJf0KJ94t7dMMOXczGF8i8vfBI0kki3n6ENF9nBaon3Y5obXYt4nJB3Pum2Y4Apuu/+R0CmH2Rf2u3lpAZzotGtATFEbIuUMIqSKfJQHkUWCLMoeqKPcdZ/50m/Hrpg+Mo7c= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: c633517a-b8cd-4dd6-5aa5-08dd9d13965b X-MS-Exchange-CrossTenant-AuthSource: DM4PR10MB8218.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2025 11:42:40.9805 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NCUt/HhCQ4AomSnftXWeTmTk6JSdfnTR2bKQvH+VWZDnjE29C79beb0IFfUqNvKbTaJcqeYmpmi/SRDUISm2hj48g2Wi1OS5y0o+QeZ6FaQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB6414 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-27_05,2025-05-27_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 adultscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2505270095 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTI3MDA5NSBTYWx0ZWRfX1uuus1xbAq8k D0JoNJni5U0zhgYYZX8qSg5xR6xvxg/DRC8NBa8ih4mq5W7leG9GboMxYa5GIycOUPAefPtiM6D fU/Sx+KS/hSr7nAAGXI/Ckfe0RlVoSvSsUi33jW+V7d+MtcdRpDjZX2oKvDYZjWdFaALU1t5d0w wJWN42FJGZpRGzfbLArBTYVspPkR0VXkqYjvNx1vD9zzSvet8nECyagToAT5IwmoMIXZxUXcKEL ZD0nUWDySzbkxcLV57DxKxdnWxU87P2LBwIcCsmZjbAKStDRNgI+FlEwcg/39ShSEgIa4vgvZjT wMdpEiKQwnaQGuwDemSWR56g+giy+vrfB2GZWsmmyRTSm7hMRBKYqR5tIrqbHrzbPiDFMot8sT4 mEhLt2l9SOsnvuYYCZNdVNUXwbQRbBpImW+kxWRqxJG6kopLWTzSACE4EWsOUc1BHCV1RbWI X-Proofpoint-ORIG-GUID: zeMbgBQOZAB3djGk8aa3jdKML_xcF4PJ X-Authority-Analysis: v=2.4 cv=CcAI5Krl c=1 sm=1 tr=0 ts=6835a535 b=1 cx=c_pps a=WeWmnZmh0fydH62SvGsd2A==:117 a=WeWmnZmh0fydH62SvGsd2A==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=dt9VzEwgFbYA:10 a=GoEa3M9JfhUA:10 a=ql5gkLrcWhyoymD4w1oA:9 a=CjuIK1q_8ugA:10 X-Proofpoint-GUID: zeMbgBQOZAB3djGk8aa3jdKML_xcF4PJ X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: A84F014000E X-Stat-Signature: 4a8t1qtx4f57scx68c5d1zguro4ebfun X-Rspam-User: X-HE-Tag: 1748346187-67375 X-HE-Meta: U2FsdGVkX19FOQEs1vSSCHWYHCcycMrX8KECQmdYMS9f30C6LlfkEl2QblXYse9ZBVGIEVtI33yx8cYPiuUDvNrN5aBGhiKEHvb5MzcUEMpshSDKG9NhN+lMmhLGptA348bOn53piWMcOrob7IQaTEqZ2wYK/o3lPZ7ceDXCVMRDqxouRCDrr3AznNu08IfYtyuxBeYpcbduolrrQ9MVuLSKpH1X28O5EVQ27zjm74lKckTRuYgJLep/29v8zIfHrh8N/K04LJ2MKSwm4MQgjlBw7O2r4Ice58rGL5xY3sgwSpplyK7kcMmi8Z7hKCP2KgObeEXDmaer0V7xiMgD/AV66jkOwIR1/fcAxxpUVmg58+ay+e/wYDsJtJwuagcZ/e7lgNflJFCOMXXX/+lrU10OoT8VOOdFKkCEwPN9YuaUqjpghqboLDnNecz8mb84EXH0O6Hulu09XXnr+IGKbGI+sM9FPfAghQ72tmMNMmWW4Tvjp7qHSzrfHPmjG6zjfZJAdPWeH7LK9jPkhXzePed1sGzzeG+1OVygP9q1fFlnZohXK2M87WTDPDWmZs+eA/cwKG3P1v4zvW6ZEFXdpkltHdTqVjmk0Mq+JHjKkVVRNCD8zjqWBMYS9eYcFZxucG3QW5yg7uM7Kz7H5hJtfWoFNmbZdnezHEHsXxYUZjwh+aS7x1BcDxOWyJHAVA7mbTpdI+I2GcbDXSXT2n6vNLWlScuk7ZvtdNq0rQXjGQcdH/Q54NDEFEZhw/Gd4h+FkRxmOADm7KnKBak5mJTQk1mto/hgD6TkGEMwx5Ha4zd5Uu7p04dROBgz+Hcr1WIFoLCpO/Jx4CB2PjwmBtOuPazUD0jk+D4BjVa6+2XNFXVtQiDoHKR0XBlkEsNqMd/dG14KfvDG3rIaxSB4jD053M8sG87enTb/lTB+AGG+HvXVOBMHfynDU8LFB2Uoq86f6fUP56o4ouDHtUjP2pk x73AMatw RZeFxR3id5kEv5VXOhfv+DHZU71ZXwPMTWtHFUVNQZlvSoui9eYzlfBwDQUMKtc3SXn5AguwLa0H6ued0OTAuxN5Fjp5iyzvf3KpXknN8Y3bf8tcjhjPDZmrIF4sl0HrWnB3OV+xhcJ08LgbhKDexl5FvVpZ91WwyUonyDay9AkD01ppPgSWfIALfRa9iodGPAFb+HQMk03V2gcFgB2ViFw7vHur+9hzPzo/pwfeD+JR6aF1t7ZUfJ6erZQREuVHe6xGxH4aps9xSK/JMfiGO4VA6RlvqZIAO9YKWvYht2gJJ35OWnh+U7NM1xUYCpYbBSqbvh3bo/4hhoIHiVQBHuK8SmqxUUkVI4y2Oo5axNIseMrvggt+2wjquTlPCUcpNyYtqENVP/vIEej9CmdA/kS1lP0kBl9Gy9CQ9Om1SgKVFSjRoTQg9iEIiDzNAjhwpYKQwibfzhiLylzYcedxKxIW5TL5vyo3mT889YkEy3Es7KD+j6J4MK4r3OCySk8KyVt9Se4YxnEDszXlcpGaUk+AVw/E8O5EJJ2Se+S0BJW7Q7ctZH6Yh4kuGB7uq7qCBokXKBI591O6ebJ1uMmfc1o4MUhbenLgMnaQ2BzYSB83kJIbLMHIYq8VeYoEoy02YnD3tolaxWWZTMtMy8ikqQ7ieTHV1JnyZI3gx04inGtYoq/AH/Bs9aBoQlQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 26, 2025 at 08:46:07PM +0200, David Hildenbrand wrote: > On 26.05.25 17:48, Oleg Nesterov wrote: > > Hi Lehui, > > > > As I said, I don't understand mm/, so can't comment, but... > > > > On 05/26, Pu Lehui wrote: > > > > > > To make things simpler, perhaps we could try post-processing, that is: > > > > > > diff --git a/mm/mremap.c b/mm/mremap.c > > > index 83e359754961..46a757fd26dc 100644 > > > --- a/mm/mremap.c > > > +++ b/mm/mremap.c > > > @@ -240,6 +240,11 @@ static int move_ptes(struct pagetable_move_control > > > *pmc, > > > if (pte_none(ptep_get(old_pte))) > > > continue; > > > > > > + /* skip move pte when expanded range has uprobe */ > > > + if (unlikely(pte_present(*new_pte) && > > > + vma_has_uprobes(pmc->new, new_addr, new_addr + > > > PAGE_SIZE))) This feels like a horrible hack, note that we also move page tables at higher page table levels _anyway_ so this would be broken by that (unless uprobes split huge mappings). If it's uprobe code that's putting the new PTE in place, then this is just... yeah. I'm with David's suggestion of just disallowing this scenario, I really dislike the idea that we're ok with an invalid condition being ok, only to cover off this one specific case. > > > + continue; > > > + > > > > I was thinking about > > > > WARN_ON(!pte_none(*new_pte)) > > > > at the start of the main loop. > > > > Obviously not to fix the problem, but rather to make it more explicit. > > Yeah, WARN_ON_ONCE(). > > We really should fix the code to not install uprobes into the area we are > moving. > > Likely, the correct fix will be to pass the range as well to uprobe_mmap(), > and passing that range to build_probe_list(). > > Only when growing using mremap(), we want to call it on the extended range > only. We might be able to implement a simpler version of the proposed patch though which might avoid us needing to do something like this. Having a look... > > -- > Cheers, > > David / dhildenb >