From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9E5AC369CB for ; Wed, 23 Apr 2025 07:22:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 912876B0008; Wed, 23 Apr 2025 03:22:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BF4D6B000A; Wed, 23 Apr 2025 03:22:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 712A66B000C; Wed, 23 Apr 2025 03:22:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4D4C76B0008 for ; Wed, 23 Apr 2025 03:22:32 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C9ADB5F3A6 for ; Wed, 23 Apr 2025 07:22:32 +0000 (UTC) X-FDA: 83364465744.24.A8575D2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id C8DDF18000D for ; Wed, 23 Apr 2025 07:22:28 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="AaiaP/Aq"; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745392950; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EBuSEig5jIqMR64muBvbm2+Uy3ppV9YN4GVnlvKWBjg=; b=nX+45Lk6fw+X78aGIsZyViv5ZPzWHQp3aO2N726xrTlg/BJbqCfr5rYNAHtyEoHSrwSNt0 6bVK3uOt4CpmwYyu09F6Dmx1XCgzv0T9fWotkKZBoOa4dJWzbC5tmuMBK3Bc9sL+2vU+VN Jqq/MfofBZhtSaojQoeI+OzBsn4e9pU= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="AaiaP/Aq"; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745392950; a=rsa-sha256; cv=none; b=k3bmu7kuE8vdJF+Ol+a1nKFn8aAb9dR6WuDU5X9lWqM2efej8hihgjoAOknsnXiMExZYDb fGcAhThlzVdtTvnGS/IlqD6ZeqW7Fcl1iPD6Vno4QprWCN0/qSshT8cN2VF7fhq11QbRZN wYVWEnJ25JrRzkCLl+QTMBPVMPQV8hQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745392948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EBuSEig5jIqMR64muBvbm2+Uy3ppV9YN4GVnlvKWBjg=; b=AaiaP/AqlkBVB0Ws33NmwAI6QDLGHAYvlFjUnxj6uEXDPdGFRJvbn2GWaq4AEeHiiuDbid njj3dIX/jMkclVFNrjDJq//k9dy8YqShVFWxW+Ze+qylkCvwocFbM3ray+FNQlJKOsjgQq zf/9UQhBbfbz/LLyNMlWsHy+nWFKY58= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-8uC6K-hzNqulzFmj765SNQ-1; Wed, 23 Apr 2025 03:22:25 -0400 X-MC-Unique: 8uC6K-hzNqulzFmj765SNQ-1 X-Mimecast-MFC-AGG-ID: 8uC6K-hzNqulzFmj765SNQ_1745392943 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3978ef9a284so1705988f8f.3 for ; Wed, 23 Apr 2025 00:22:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745392943; x=1745997743; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=EBuSEig5jIqMR64muBvbm2+Uy3ppV9YN4GVnlvKWBjg=; b=MurQypQMjlDELrsGZIgVVCkBT5iY/n0tj1fdV3sgQ3qvPt7MU04OkvNKDghL2ppDSw OmTqFWVo6VLjffbkTVAxmDzQwxnb5osmJ5ZMp1SUXFHXYQxkalTBqMhJDHAk2ExUM0Vu jeUUeaawaCbyp1VpcVclwcoUejMwW5YTLxRSA4GbL7DXWNJd1KQVXH9WXg0E2Kli12C9 n5LFCB+w3R1WjmKrs0xbFbYAw1wG3eB+Lb5PrPc+kP3kJXmnmwnWDhUiK5oqq2ZBWEkB ZlKzeIdgv+T/e2fN/mm8Fb53ISKE+iFYj8xSMrzD3e2BhydaLm4xn0qFuxnMNg7jipr3 QxLw== X-Forwarded-Encrypted: i=1; AJvYcCW2FUN1iLeTaNUHAQcXznuRqfUkjo8qrnhoKnD8chQEdedrW+k1NfFRnxoQCIjQUC9BHuACo2TO+w==@kvack.org X-Gm-Message-State: AOJu0YzSJKsG5e4qjWGejjY1BGKtrzkIXwm1FDLSbV2nTAOYSYhSk8OJ svzT+akeCQJfg8quK5b4h2TQyCqZMRlBvwy91NKJE5PIjEQvTf81JJ861QuVqDBiIKk4JDiu/Mh 88BlPCn0gYvyjUt7mf7i0IXPOia4VqyQzz6l1CEl7Zuc3gaJw X-Gm-Gg: ASbGncvPTIZI2KI99UY9wZZoyjWNfMSCRSWTEdFf78iFg6loIZSz4Azti51gHrzlKOl z0Yb1LwkeLt4DPt5OZ2XWi4dx/wilfqJrWzMH/cT/yFRq9EsWwnsmzGUfLdvnmhZKDq3/rLHfnM rnc4pT/sN2AEpssFKTvh5QHo2gGEAaIU/UDexs8M6ON9aEkgv/ULRnhTZPIMQpCQpH9sNBdPVbF 2ZkjdjvAIf4mfqgV3nZiGSo4g+QglmSwsBvxlaMvXJpmOHyNvCidy6mtPESKQfR7HyAKUBMcLxL B3WTxfvt6oRmY5ljT0+AC0LHUUjEMd5tpxO2F4o88MZNvx1tMzp71c2dXP2rHSVLj0T61WxeZpP GEvOKgps7h4MQZ48tLqgsuRddJRcUIKsMP4s1hv0= X-Received: by 2002:a05:6000:2403:b0:39c:1f04:a646 with SMTP id ffacd0b85a97d-39efba45f64mr14384417f8f.13.1745392943469; Wed, 23 Apr 2025 00:22:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHfuffIV3TY+UzXqaQPu8SArla1wmKpBhdro1DmTQpmv7CTh3OUFOqEwNH2EmpXzKZL4H+UUA== X-Received: by 2002:a05:6000:2403:b0:39c:1f04:a646 with SMTP id ffacd0b85a97d-39efba45f64mr14384397f8f.13.1745392943118; Wed, 23 Apr 2025 00:22:23 -0700 (PDT) Received: from ?IPV6:2003:cb:c740:2c00:d977:12ba:dad2:a87f? (p200300cbc7402c00d97712badad2a87f.dip0.t-ipconnect.de. [2003:cb:c740:2c00:d977:12ba:dad2:a87f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa493255sm17918781f8f.69.2025.04.23.00.22.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Apr 2025 00:22:22 -0700 (PDT) Message-ID: Date: Wed, 23 Apr 2025 09:22:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V4 1/2] mm: add folio_migration_expected_refs() as inline function To: Matthew Wilcox , Andrew Morton Cc: Shivank Garg , shaggy@kernel.org, wangkefeng.wang@huawei.com, jane.chu@oracle.com, ziy@nvidia.com, donettom@linux.ibm.com, apopple@nvidia.com, jfs-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzbot+8bb6fd945af4e0ad9299@syzkaller.appspotmail.com References: <20250422114000.15003-1-shivankg@amd.com> <20250422114000.15003-2-shivankg@amd.com> <20250422164111.f5d3f0756ad94d012180ece5@linux-foundation.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: yjcfPIY7h3We_1lwP7QcivTWmcH0flV0l0DYh4yHSvE_1745392943 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: dm6xjukcb83jhx8we9oms3ot751axi5m X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: C8DDF18000D X-Rspam-User: X-HE-Tag: 1745392948-766309 X-HE-Meta: U2FsdGVkX1865r9NzbVS0ezonLPjSrS/Gh5C0CSzZGOXk2OwG6z2gIryi5Ro5UMTbmgnyX4jghepQYJFrpu31Xc3ion3O+dpXbjoaKcj0+9Yn15hraBIydAcOUFRoLbWgqQt8UqE8qzyGOVfvnPIKQi6y25Z6ILoEX+NG5kuHwHSIGozMrXdD2fmBGXFoPAVEyORbK2NxQruIjw529wnWbdepp0Qc86LAesMkfZkojRm4rbi8evvZdjqYjA9c59BwyRJ0lnBDY/+0zdSDkW+ffuXPQ35pi7xHctt71LifAHZalnm2a7rSXRCgf6TWkTlnXWA/tMFDmanQq25qDU1fZabvYlxqFEzSQB+7cFTXaXfOieJ5PYkAOntoOTLi4kUYa3Zfmnf68JtL09Rk6IPO/509bTtDzqBNSzLOUUKeVnxCQG0p1FjX9sNfkX0N22ajW3o8dsNVIN0Lt+SX9QRedkwdEquKIgzyGkqNr+K4NiVf9594qmvZb/o470KxatLIFagyyne/uh1TFltQXS3fp4abpWaLY7ES62veZS4KuZ+ERCaW+K+XxnXTa9sLV5evkLTbiAve9zRzDDsY5niQX/d7+wC7Buyf2EplNf3I/EjZwDiOpRDG6zoPZuBeUTmzSwAjXXsZ8gQ3pdwnSNI3V0AcM9ZHc4E/kAhTW7jmYceAoXz9SFE8o9/s2gCdcik63EeMEtr89gRo0UfG1gVXLXYHeoCuKhwYft+yx3Nlvd3IcntbJ2l1yGy1f1T8aZU2WhiHJ2VMmJfFEQZnPbaqAOsIYDSkfRSBpEOWVSpzVfJ2LIjjVPl+etKO3p2zUDzWdBfQn0rGv5oy52hcOsrS1qPe29x2UBXxyGxNtdz4tkPK2GXwlD1xECSYUTkUIw6LGCmxS52P7PjZkVgOMThIoUcAWePvOmtIR/ur+0Jxo4YaD4L0b6reQSUUmQ6GryjFh89G+KSW/G+Rs+fIO4 JkDb15HC qgRWnqy0W9IcT3zMHQq9uiBHLx6R0Cc3bksHZFVyPwk60nSRALvpPrjwUUBhLR+N244LrH5JQZJPuzxtsI3ByoYkOX2Dn0i3ikw4HEWAmk6CPaR9dgT1JJbZhGz1TV31BsoxqrrpX4FjWZZ+QnzlqodwtVR5FV/HmvHTeMmhHF60H4HZ4RMCB8BA0Gz1+VKkTo+f9NOF3UviLwAaUgdvlh/nPu7Y3WdrsdNpjuLka8pqJ8KJBxgcLbunToU7Dqg8jQfJRqZCeNVAw0koYuKorqgziK+kF1+Qukq5GKANyljS94HkKt5geF5qmfXfv3G9mJmITJsJiWL5ens3R+mC4FDwMMBjVLWs8Nhl31Kl/0/X+5VO9kmKqSCd0U9NdE3A6lwyQjUYtcx3O3cl6KGmZW1AUdy/uh0NxeMkC2A7ltl43TMdEk+McwlI5ZyGIIUGCW/MUJdx1Ueow4CxKcRx2WJyGj4gY6uS6RyG5D/+kxkOQJNe1Uh/r6trTTm7TK68K7iMx2o3CQS5WSUzIH0rg2Khz6fUKbFqQqTGxsc9QOIJjZlc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 23.04.25 02:36, Matthew Wilcox wrote: > On Tue, Apr 22, 2025 at 04:41:11PM -0700, Andrew Morton wrote: >>> +/** >>> + * folio_migrate_expected_refs - Count expected references for an unmapped folio. >> >> "folio_migration_expected_refs" > > Please run make W=1 fs/jfs/ in order to run kernel-doc on this file. > It'll flag this kind of error. > >> It's concerning that one particular filesystem needs this - one >> suspects that it is doing something wrong, or that the present API >> offerings were misdesigned. It would be helpful if the changelogs were >> to explain what is special about JFS. > > It doesn't surprise me at all. Almost no filesystem implements its own > migrate_folio operation. Without going into too much detail, almost > all filesystems can use filemap_migrate_folio(), buffer_migrate_folio() > or buffer_migrate_folio_norefs(). So this is not an indication that > jfs is doing anything wrong (except maybe it's misdesigned in that the > per-folio metadata caches the address of the folio, but changing that > seems very much too much work to ask someone to do). > > What I do wonder is whether we want to have such a specialised > function existing. We have can_split_folio() in huge_memory.c > which is somewhat more comprehensive and doesn't require the folio to be > unmapped first. I was debating with myself whether we should do the usual "refs from ->private, refs from page table mappings" .. dance, and look up the mapping from the folio instead of passing it in. I concluded that for this (migration) purpose the function is good enough as it is: if abused in wrong context (e.g., still ->private, still page table mappings), it would not fake that there are no unexpected references. Because references from ->private and page tables would be unexpected at this point. So I'm fine with this. A more generic function might be helpful, but in general it is more prone to races (e.g., page table mappings concurrently going away), so it gets trickier to document that properly. -- Cheers, David / dhildenb