From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B42ACCEF170 for ; Tue, 8 Oct 2024 13:06:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39E5A6B0083; Tue, 8 Oct 2024 09:06:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 326D46B0085; Tue, 8 Oct 2024 09:06:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 179686B0088; Tue, 8 Oct 2024 09:06:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EAC666B0083 for ; Tue, 8 Oct 2024 09:06:31 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 704CC408A7 for ; Tue, 8 Oct 2024 13:06:30 +0000 (UTC) X-FDA: 82650458982.06.435117F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 4947640009 for ; Tue, 8 Oct 2024 13:06:29 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZcAkuCaK; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728392746; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qR1UZ3ptlV1Q3PKNLC/ya1lH+GCtB5j8K5Uybv88IhA=; b=w5WCuMdyKrxL9M51KVmaCIa8GrFERf/0n/nKjkKfMaUzifH5/rmpAXmtJHIAs64w95qX3F rL/SQfkskLq7kQL9X/NIShxjfxiSjHZYpK+bpVSEAcCBIS7STlNvYBjn8QVX3vo3aPLVs9 l1JWLlr4f9fYgED3UE5Gpspg1S4EbYk= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZcAkuCaK; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728392746; a=rsa-sha256; cv=none; b=YG34rOgfmkBe+elpPH6Vgh2XS29DLbnrW1q4BZOAJmPUtRVHjMp8XBpV3/gS4T7SjGZbNe TXQ/JNgz6714fOmkUFyOZR2cNJQ+WkoKfJH+fLm9kgIrDUdYKh8qMuJ2vNWgpndqWk89U2 T/pt4Q0iQ+fzBG8cFH3FxEBiZoGDoks= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728392788; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qR1UZ3ptlV1Q3PKNLC/ya1lH+GCtB5j8K5Uybv88IhA=; b=ZcAkuCaKeMUmas7KzaiztQUN3rhIvY+IENTU03aJGLOR75WS4jktbzK9RV/zlzGB81D2oy nTHsWYjY9H8U+pbiVSnB71QNgHPqoAs2N8bjMLsHpSRoHpw70XIB0dcfwjdNkUJv5kNwi/ /ov4ntW0j3eI6uv1BVghkB9aa/g9c+c= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-370-KkdiTyfpOFC3EnCHU00kCA-1; Tue, 08 Oct 2024 09:06:27 -0400 X-MC-Unique: KkdiTyfpOFC3EnCHU00kCA-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-42cb808e9fcso36200145e9.0 for ; Tue, 08 Oct 2024 06:06:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728392786; x=1728997586; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qR1UZ3ptlV1Q3PKNLC/ya1lH+GCtB5j8K5Uybv88IhA=; b=YZPb19x0bjB9tDm+zpFlkeuODXu+tw2nBj8CUD3ipxSyHIocBDNMbkt9bDgSWZb0JT Grwpijfjgh47PXF1JFSoYsa0slFpX4duLj1+/1e+fXPtZnONcNY4q8GSiKFZ+ybHVgu9 EgFn2TrlVbXEi6h6kZ4U2N1mExZLBe+E8n6Ba3npm4oSaBFFhovOch4qgSoRY/NvD9+T WLIcTZmMGA0a289fVfLgEd7ScD1J1GNHXq1tEAjYl4isMENdAL8Yuj7UX/JbgxkKU9kY KbLaZR/y4MLm8fLAomnsQgEK1lcae9erPN6hIQUR9HeniU6ZQTJTY0/FLRUIDpAPAY59 uPSw== X-Gm-Message-State: AOJu0YxG+Fb/PMqIZrzJZuijzMK3zah20Ft00PChnXe7XYuIg6wG42BY FnX2DZC5xIwdIrpwwaBQMdCmkcMMSCHvPPIw4ILyg/OIDJCrQqFZgv6/Keb131R65fqF7oj/6dV rGQmtW8U0IqxwIIvT2AtpOEXGf6VoyAcAhPbpZwC6eGjZtpeM X-Received: by 2002:a05:600c:45c6:b0:426:51dc:f6cd with SMTP id 5b1f17b1804b1-42f85abebdcmr101987145e9.18.1728392786111; Tue, 08 Oct 2024 06:06:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFE7IvtgKJRopcQJvNbp61W3JZHbPRBkLE5HixWlNZQuBdnwj2pN8DkvY0pE4hqZUfxj+rmeg== X-Received: by 2002:a05:600c:45c6:b0:426:51dc:f6cd with SMTP id 5b1f17b1804b1-42f85abebdcmr101986775e9.18.1728392785661; Tue, 08 Oct 2024 06:06:25 -0700 (PDT) Received: from ?IPV6:2003:cb:c72f:c700:a76f:473d:d5cf:25a8? (p200300cbc72fc700a76f473dd5cf25a8.dip0.t-ipconnect.de. [2003:cb:c72f:c700:a76f:473d:d5cf:25a8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42f89e8334bsm109654325e9.7.2024.10.08.06.06.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Oct 2024 06:06:25 -0700 (PDT) Message-ID: Date: Tue, 8 Oct 2024 15:06:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] mm: avoid clearing user movable page twice with init_on_alloc=1 To: Vlastimil Babka , Zi Yan Cc: linux-mm@kvack.org, Alexander Potapenko , Kees Cook , Andrew Morton , "Matthew Wilcox (Oracle)" , Miaohe Lin , Kefeng Wang , John Hubbard , "Huang, Ying" , linux-kernel@vger.kernel.org References: <20241007182315.401167-1-ziy@nvidia.com> <9e4e3094-00a2-43bc-996f-af15c3168e3a@redhat.com> <84D24C40-AC10-4FF7-B5F6-63FADD523297@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: uj1fqh595ydkgyhegxu44mkb8qnrahm1 X-Rspamd-Queue-Id: 4947640009 X-Rspamd-Server: rspam11 X-HE-Tag: 1728392789-118853 X-HE-Meta: U2FsdGVkX1+HN9wrKxjqVdpK35sx1fOvaW2QaSZOyFl2lkUTQaGZQG1y8XDZxSwW16u1XP8BXqacC6fI0AbElMoJ4TRGJI4M+txRVQfF0JnJRtIxuHBtDSd18Gb2vf17hX3ChJzVaA+02xHxWi2AINGMEh/sK5ZqdT/KoZ/BJUtAPPm1BDOBETRMxMSmBQDWe/Y12KU9jwX6hAmmviMTANMs78Ak9HWAOl9urCrQn3kp21nSDZENSXjRINeuL1OuusqZIVmx78+SWR1tIfr24P6zESg5h+oNwRzx3I0Vys9z4O5V/nKPsCXH2/wQfsSinqpmtMeglvlyPfGJ1rBsmcGlWcRX7qgb4JAdPt6BWq3J1JelMH16TiBscdSlyPAPYuxPQ5WUGMGJeKx8HNGwuJ2v8a2DgxruuXie6F7vjWlW9MSAy9JQhgybN2Zt8ijJyXdoMIm6P3eN4zv0uTYQ9Iqz1U982a1RizcYAD+plAA2Sekk+8GEkAtwWSiYejt97/dCfRoDg0Ae26SnghsUFABLZ7NY9QmYvhOtM4wg5k0ISCot4d8OzHJRYjq8NBPD+ZEdKA1zsPtHuoqe6hoM5E6BHokxEk9PrLr/5LqEG1tAc6GalrOhUbgQ+JeZBGhcxd2mRunjN3UvSCH1vgyVNGaSMBbXj8LvkduCGTjoS8KGP4GjJH9BssEAnnhAdhD8hTAFIg6MGb8HfRdVcIufTEl/uVuh1NTM/Zd5AOnwvKYqotUysg07CE9EwILNpuVFlnVlbooDvdNUnyvoV7KQFtLBveupje6iVPqafGVij/BMus+9UlNwD6FkOIpAC5Qju6T0Z8ToQLWQiQ1Y27c3NP5U8NrOAovWCkuaP5wLe+cPVJ8cgjYXCWDjUNrFjAXm7qYV4Wagya840GI4bI1vkKeSXkirWxmtg5Tyr9kYbK9EJ0CDBeJWn3ZkNCbHX+aHi0Az4XJxZ8M4+c78xID gIQIcWHs vpqeYJ52eOU58k7f+BKidMr7NGuEnb7HVx5humgGrqcJYIYkZfuCj1SNcDjSi+PxfGdcR9Q5fB5Uhr60CikMqyCxelDfy8MH+Az3djIVq00bIRC1bZjaqngBRjz/TGQ5xHPJ/qoxglrKPrfKmwQGt3qF5E1FnBXkyx8vAje2Sh5dQMjStxFeRlyTgIjQ4JqUHX9fvYOadgBdGfD6lmCb9xdTz6IRMGiJXxw7I+CZ5mTnmx7BhIg+7NZCxZ56RHy9zcQNOp9f9+lfRF3MziSxgJuWZcA/Qs78LwKRTMnufbJsftfwPlwL+mqi1Bt9COIorduCGsEUa9fGa2/yQ1lhKCXnCSo7eZ99liKgvSkhyWXdzdngkcLV8+X1YRADNwW7RE3X3GE7qO+wh3XXJj6FJM5CkqmrqHPhYUdtBY69/i4wLwbx5qcGBfd9NstQEh2WAT2zglB6rlQBxaoOkzq89vRbpUQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08.10.24 14:57, Vlastimil Babka wrote: > On 10/8/24 13:52, Zi Yan wrote: >> On 8 Oct 2024, at 4:26, David Hildenbrand wrote: >> >>> >>> I remember we discussed that in the past and that we do *not* want to sprinkle these CONFIG_INIT_ON_ALLOC_DEFAULT_ON checks all over the kernel. >>> >>> Ideally, we'd use GFP_ZERO and have the buddy just do that for us? There is the slight chance that we zero-out when we're not going to use the allocated folio, but ... that can happen either way even with the current code? >> >> I agree that putting CONFIG_INIT_ON_ALLOC_DEFAULT_ON here is not ideal, but > > Create some nice inline wrapper for the test and it will look less ugly? :) > >> folio_zero_user() uses vmf->address to improve cache performance by changing >> subpage clearing order. See commit c79b57e462b5 ("mm: hugetlb: clear target >> sub-page last when clearing huge page”). If we use GFP_ZERO, we lose this >> optimization. To keep it, vmf->address will need to be passed to allocation >> code. Maybe that is acceptable? > > I'd rather not change the page allocation code for this... Although I'm curious if that optimization from 2017 is still valuable :) -- Cheers, David / dhildenb