From: Anshuman Khandual <khandual@linux.vnet.ibm.com>
To: Michael Ellerman <michaele@au1.ibm.com>,
Anshuman Khandual <khandual@linux.vnet.ibm.com>,
Vlastimil Babka <vbabka@suse.cz>,
Christoph Hellwig <hch@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Define KB, MB, GB, TB in core VM
Date: Fri, 9 Jun 2017 08:24:20 +0530 [thread overview]
Message-ID: <b819bdda-10ac-01be-9198-c2323ecd142a@linux.vnet.ibm.com> (raw)
In-Reply-To: <87d1as6ifk.fsf@concordia.ellerman.id.au>
On 05/29/2017 04:25 PM, Michael Ellerman wrote:
> Anshuman Khandual <khandual@linux.vnet.ibm.com> writes:
>>
>> So the question is are we willing to do all these changes across
>> the tree to achieve common definitions of KB, MB, GB, TB in the
>> kernel ? Is it worth ?
>
> No I don't think it's worth the churn.
>
> But have you looked at using the "proper" names, ie. KiB, MiB, GiB?
>
> AFAICS the only clash is:
>
> drivers/mtd/ssfdc.c:#define KiB(x) ( (x) * 1024L )
> drivers/mtd/ssfdc.c:#define MiB(x) ( KiB(x) * 1024L )
>
> Which would be easy to convert.
Sure, will take a look into generalizing KiB/MiB/GiB instead of
current proposal for KB/MB/GB.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-06-09 2:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 11:17 Anshuman Khandual
2017-05-22 21:11 ` Andrew Morton
2017-05-23 7:02 ` Christoph Hellwig
2017-05-23 8:38 ` Vlastimil Babka
2017-05-23 8:40 ` Christoph Hellwig
2017-05-23 11:19 ` Anshuman Khandual
2017-05-24 6:40 ` Anshuman Khandual
2017-05-24 14:31 ` Michal Hocko
2017-05-29 10:55 ` Michael Ellerman
2017-06-09 2:54 ` Anshuman Khandual [this message]
2017-05-29 11:07 ` Geert Uytterhoeven
2017-05-23 11:13 ` Anshuman Khandual
2017-05-23 6:41 ` kbuild test robot
2017-05-23 7:24 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b819bdda-10ac-01be-9198-c2323ecd142a@linux.vnet.ibm.com \
--to=khandual@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=michaele@au1.ibm.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox