From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 840CDC27C53 for ; Fri, 7 Jun 2024 15:29:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E51206B00A0; Fri, 7 Jun 2024 11:29:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E01416B00A1; Fri, 7 Jun 2024 11:29:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC8326B00A3; Fri, 7 Jun 2024 11:29:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AE6216B00A0 for ; Fri, 7 Jun 2024 11:29:28 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6139180234 for ; Fri, 7 Jun 2024 15:29:28 +0000 (UTC) X-FDA: 82204476816.05.C4ACA2E Received: from out-188.mta1.migadu.com (out-188.mta1.migadu.com [95.215.58.188]) by imf19.hostedemail.com (Postfix) with ESMTP id B98901A0008 for ; Fri, 7 Jun 2024 15:29:25 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=RCFPzykk; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf19.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.188 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717774166; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UAtyDHoN42s2SICjC1kSRt3AHu7WTv3/bhxAklvJG0M=; b=bWwpOkM6uBntBJNU7nbHCJ7n8X31Ahx3GFaiuu1sQWVNULEPef2P7+o3Enrbeq4ZJ3Eebb UKhrB488sUcSgANl8exAm5FRzvo7VGXqmmNy6xGN/7K1AQzTg7S4hJQ02bVgdzEZm9/+h3 tfBnSx06gedgWqijsa1fAklq7Q+20go= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=RCFPzykk; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf19.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.188 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717774166; a=rsa-sha256; cv=none; b=o60DoJwTvTCN5FqVb7soKo60v644PEvL4K8q5NYKZiTbSYeHG8DCnfg3DeSqT4hLcCM7XG TUTJQeUeQfoobhdJgxd3o/qHv/3sHHJgJxBCAdBGe1IKqXV8WonElh1xYvEZSOCw4IttKf +vDyTaBgf1g2/53cVbQi78dQjQOFjwY= X-Envelope-To: akpm@linux-foundation.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1717774163; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UAtyDHoN42s2SICjC1kSRt3AHu7WTv3/bhxAklvJG0M=; b=RCFPzykkL+F2+d2EfoMzgJ92c240N9+uvkYQb9Nt8V7e8rbo6Dx57KYTdzSObyfKrAHzLS CSIJhJop/ds2/LmmBgzW8XWBJZSYZ+s2oy4sOQ9DUPF98h8SaB8MWUWKfgHT9SqO7Qm1lJ cF0vONxTJR30aNlQGK3KpYhFx9RV0e0= X-Envelope-To: roman.gushchin@linux.dev X-Envelope-To: muchun.song@linux.dev X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: willy@infradead.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org Date: Fri, 7 Jun 2024 08:29:20 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Andrew Morton Cc: Roman Gushchin , Muchun Song , Johannes Weiner , Michal Hocko , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 00/14] mm: memcg: separate legacy cgroup v1 code and put under config option Message-ID: References: <20240528202101.3099300-1-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240528202101.3099300-1-roman.gushchin@linux.dev> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: B98901A0008 X-Stat-Signature: 4g165rh1adgi38nmqhmbbpexfb8cpbdw X-HE-Tag: 1717774165-205405 X-HE-Meta: U2FsdGVkX1/ka0ZzMN74/VVqElckO16HiAH4CrQx+FFgWliZgtfNjV0NTbSdQ/pCw4uPkx4h/rUHCYE9+UnxPqAZWU9MlqNBxSC7z11Re9ig0pO5/n8Vatigtrpe/gwkXacIZerxtI4J+VgrXhyR3g1e0nBFIljmki63Tlw1SfjoiBT0FYOhsDxkYlghBEMpuz+DxEAgL7F6fjLAFcfC5YTnDyUf/x2hMJsybrL5RyssR8Mfu1UxGWEyyEeMwkiXoXpkjkkxOKiHnKD64NaoDBTy8QuJBW8QURHYZZ/NKhyDOelCyRAAoei0h7tNK8Co39h7wcqnxC7W21LDfRtoPHSDYhUbrPmwU18z79fsSfYpbCLjZNLR4/2U4iD2AQuVTuGlqXbiDiRANpK5kIjxzkCPHcoBVE/d9ApwPgxCp5INYG4h7bLaNbVL67+C0UzEgiGl0zBzNa0Bj2EToj+Oj1JXdyIM9wwdukgLFWkTHeRu7ygXWUqX7euaf6kDihVY0WsGQtcGeNpBN8hwCA9K1+PzztuXmzFY/G3UkupVT+V4ghyH3fmPQ1hBXmLUHS4XwkxwcCPMXCkhj8TeWm8BsrdQzitOEr9BDKrHd+HsLBaLHe0l0CnnNQAl86nXORjdxrQ6ERXDeKgcs+hs+AvX7OSbgeWv0YrzfM1RlcpdJORlYmMKISRGdh9yzFHP6mxeboCcmOig4VqfThZXiHorK3f9bZH427RDS95fRt53lCZO3U45FOiw10cZK0qCn+aq6+JUks1OFiUZUu1uPdX4YRa6JI4rDG6FXIlFnC7wLLwB9sOm8RqtiF0AVrzv8j4M3XyQsPmyDzRnP5Jwe76KFG8CytyIFAbvHEEhU4yQlxsx/dcJRCCweE3+TCaXSMArYtJMk8m9Mx8IAEeh5RXjVsNvIQDiSdtvyI5xXYdJFUG7Qjv7HLvPP8vsvHmqUXwEVgBml2I+VE8y/kWKLTE rC/2Bxk7 AwSfBhnVMbbSrbdT9k41+bU87oyixF5EmIObuDZ3Jsdio8hwZ3BaLQwbFWJKksDc2yx+r1qmG4qgBQ4VKwu+LWMG5zDhe5i/ESmPDT82AHGbXMtkbAfv0K7QB5UhwlMU7Z0DjCI8OGIwcc8DmeG+cEjiFx4q3oH5gBFMyM4WKZmATpkX25HPixEVQdl14ZOKQ/EmyMwFkF+8Lz1yolDtVv8K5fQzckiq2zz5E X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Andrew, can you please add this series to the mm-unstable? Roman and I plan to add more stuff based on this series, so it would be good to get some exposure for this series. Thanks, Shakeel On Tue, May 28, 2024 at 01:20:52PM GMT, Roman Gushchin wrote: > Cgroups v2 have been around for a while and many users have fully adopted them, > so they never use cgroups v1 features and functionality. Yet they have to "pay" > for the cgroup v1 support anyway: > 1) the kernel binary contains an unused cgroup v1 code, > 2) some code paths have additional checks which are not needed, > 3) some common structures like task_struct and mem_cgroup contain unused > cgroup v1-specific members. > > Cgroup v1's memory controller has a number of features that are not supported > by cgroup v2 and their implementation is pretty much self contained. > Most notably, these features are: soft limit reclaim, oom handling in userspace, > complicated event notification system, charge migration. Cgroup v1-specific code > in memcontrol.c is close to 4k lines in size and it's intervened with generic > and cgroup v2-specific code. It's a burden on developers and maintainers. > > This patchset aims to solve these problems by: > 1) moving cgroup v1-specific memcg code to the new mm/memcontrol-v1.c file, > 2) putting definitions shared by memcontrol.c and memcontrol-v1.c into the > mm/memcontrol-v1.h header, > 3) introducing the CONFIG_MEMCG_V1 config option, turned off by default, > 4) making memcontrol-v1.c to compile only if CONFIG_MEMCG_V1 is set. > > If CONFIG_MEMCG_V1 is not set, cgroup v1 memory controller is still available > for mounting, however no memory-specific control knobs are present. > > This patchset is based against mm-unstable tree (b610f75d19a34), > however a version based on mm-stable can be found here: > https://github.com/rgushchin/linux/tree/memcontrol_v1.1-stable . > > rfc: > https://lwn.net/Articles/973082/ > > v1: > - switched to CONFIG_MEMCG_V1 being off by default based on LSFMMBPF > discussion [1] > - switched to memcg1_ prefix (Johannes) > - many minor fixes > - dropped patches which put struct memcg members under CONFIG_MEMCG_V1 > (will post as a separate patchset) > > [1]: https://lwn.net/Articles/974575/ > > MAINTAINERS | 2 + > include/linux/memcontrol.h | 156 ++++--- > init/Kconfig | 9 + > mm/Makefile | 2 + > mm/memcontrol-v1.c | 2933 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > mm/memcontrol-v1.h | 132 ++++++ > mm/memcontrol.c | 4169 +++++++++++++++++++++++++++--------------------------------------------------------------------------------------------------------------------------------------------------- > mm/vmscan.c | 10 +- > 8 files changed, 3794 insertions(+), 3619 deletions(-) > > Suggested-by: Matthew Wilcox (Oracle) > Signed-off-by: Roman Gushchin > > > Roman Gushchin (14): > mm: memcg: introduce memcontrol-v1.c > mm: memcg: move soft limit reclaim code to memcontrol-v1.c > mm: memcg: rename soft limit reclaim-related functions > mm: memcg: move charge migration code to memcontrol-v1.c > mm: memcg: rename charge move-related functions > mm: memcg: move legacy memcg event code into memcontrol-v1.c > mm: memcg: rename memcg_check_events() > mm: memcg: move cgroup v1 oom handling code into memcontrol-v1.c > mm: memcg: rename memcg_oom_recover() > mm: memcg: move cgroup v1 interface files to memcontrol-v1.c > mm: memcg: make memcg1_update_tree() static > mm: memcg: group cgroup v1 memcg related declarations > mm: memcg: put cgroup v1-related members of task_struct under config > option > MAINTAINERS: add mm/memcontrol-v1.c/h to the list of maintained files > > MAINTAINERS | 2 + > include/linux/memcontrol.h | 156 +- > init/Kconfig | 9 + > mm/Makefile | 2 + > mm/memcontrol-v1.c | 2933 +++++++++++++++++++++++++ > mm/memcontrol-v1.h | 132 ++ > mm/memcontrol.c | 4141 ++++++------------------------------ > mm/vmscan.c | 10 +- > 8 files changed, 3780 insertions(+), 3605 deletions(-) > create mode 100644 mm/memcontrol-v1.c > create mode 100644 mm/memcontrol-v1.h > > -- > 2.45.1 >