From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A500BC77B61 for ; Thu, 13 Apr 2023 11:21:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 299016B0072; Thu, 13 Apr 2023 07:21:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 221D36B0074; Thu, 13 Apr 2023 07:21:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09E60900002; Thu, 13 Apr 2023 07:21:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EB04E6B0072 for ; Thu, 13 Apr 2023 07:21:06 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AA7781A020B for ; Thu, 13 Apr 2023 11:21:06 +0000 (UTC) X-FDA: 80676126132.25.B7F1E64 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 6A4538000E for ; Thu, 13 Apr 2023 11:21:04 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JDOOxtWb; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681384864; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jSfTt/FpZ51XsXOxa366XVa7DCOmNmyBB//s/oWzTsk=; b=of8GGriL0cqZ8jkzF3+iq0dvFa+PCkpWb5GstlxBhElSjbJU2D8zOinFuoou0NkOv2tfxL HEWigjt3n6mA47wk2QngfXnLqctxKIOoB8teMlK4t/WKQL1I6mNIdYnU7i/Oap8jQ+6QM7 ki6QOZxRKqMlkDDpBkqcIwSOL9KblUE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JDOOxtWb; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681384864; a=rsa-sha256; cv=none; b=725UcXZ3x0x5xa+cMx7JdnEYfFUcLgtzN8ORjpEaqq+FBe4LOFrIeK4VMCGtNpejV3R+t1 E3nPp+uYlCr8aupTQRVeEmWIFXbGBraAMs+MXvCCjfdUGUi81wZ4fGeoq3qoFW//cRd0gT RZV78S6MxlvLiA2SYzuqukDGKC8QjQc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681384863; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jSfTt/FpZ51XsXOxa366XVa7DCOmNmyBB//s/oWzTsk=; b=JDOOxtWbitDg6ieKXAAtF1fKPzvtcwi5u7mhzpeUSH/kuacWvPM1GRBQzKKEHtQUgTdCh3 /WPG9Fd115PYJOCRVcneUMcynSWcYdlBKtFPlI2zJDftCkf6fEycJ/2OsLZOci3dM0Itce iHtzY1nRR3+avE0TUsvBOKTQN4F5QiQ= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-403-6LvIZbKpN5mDQxpRhzAELA-1; Thu, 13 Apr 2023 07:21:02 -0400 X-MC-Unique: 6LvIZbKpN5mDQxpRhzAELA-1 Received: by mail-wr1-f72.google.com with SMTP id l4-20020adfa384000000b002f4585d0ec9so1187224wrb.15 for ; Thu, 13 Apr 2023 04:21:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681384861; x=1683976861; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jSfTt/FpZ51XsXOxa366XVa7DCOmNmyBB//s/oWzTsk=; b=Akhd0Y+OtwOOLFAQkCivRLC03G4IFXOY6Cg51bBxLxk/BDRix7KJ0wp+knCURXLUIg 9TJyIX+O1yzvuyftJTdWMa37P0nlfLD2MHF9VkarOMcY1f6RyCIy4ooBjDROfvSpUszT bZ/WS/cmSiI+s2pf7mqALbsPj0xx+ATEIKiQmyOklVO0CWdPGXgKhc5nrLnjAHbWH5fn zMgmWoxZnCplS9gAhvCxW+9TwQ0ugVkn6zxJFzEkxwT+PfV/unL1DxNeTFqZoj3sp0Hd u/Xl++RZa1j658Tdnm//rs5T4+N3HoeizcLivIZKvpQPaG+5TAYqnUSVZdYkPPEKYWC9 R8iA== X-Gm-Message-State: AAQBX9d5/fkASelO4N2JXPoBDJYREpaHmOjJXZ4Jali/QmubT6v/VHQF mbFxkXF52gjAJL/6D7JLsvXeZsnVN/F42Xpf0H4eyZkpHo0T7yh99ASdOzevaI3w3JZk1Cgiswk GarYIIG1TOZA= X-Received: by 2002:a5d:4748:0:b0:2f4:bc68:3493 with SMTP id o8-20020a5d4748000000b002f4bc683493mr1179289wrs.34.1681384861481; Thu, 13 Apr 2023 04:21:01 -0700 (PDT) X-Google-Smtp-Source: AKy350aqjI6Q+vFzM2qin74WRIRynSqW3dUlzZ+lzWRnT/FaK8OWoaXuG4EWNsNhSjPY7wORElSWBA== X-Received: by 2002:a5d:4748:0:b0:2f4:bc68:3493 with SMTP id o8-20020a5d4748000000b002f4bc683493mr1179271wrs.34.1681384861121; Thu, 13 Apr 2023 04:21:01 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id f4-20020adff584000000b002f008477522sm1086917wro.24.2023.04.13.04.20.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Apr 2023 04:21:00 -0700 (PDT) Message-ID: Date: Thu, 13 Apr 2023 13:20:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v6 3/3] mm: vmscan: refactor updating current->reclaim_state To: Yosry Ahmed , Andrew Morton , Alexander Viro , "Darrick J. Wong" , Christoph Lameter , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Matthew Wilcox (Oracle)" , Miaohe Lin , Johannes Weiner , Peter Xu , NeilBrown , Shakeel Butt , Michal Hocko , Yu Zhao , Dave Chinner , Tim Chen Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org References: <20230413104034.1086717-1-yosryahmed@google.com> <20230413104034.1086717-4-yosryahmed@google.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230413104034.1086717-4-yosryahmed@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6A4538000E X-Stat-Signature: qcn4bw4hxymcizw6gfeeseymucj7otyw X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1681384864-923148 X-HE-Meta: U2FsdGVkX1+V40vzIzXhJihf2cbsX6DXaExBXrSqU4MQg7NgMtabrhbsoHSU7vp8ReNpS0ZnOFLI2WWAlqmk0G9zlUJeUNQPV0QFQujSZ8fd93az3jSURzPj7Oqg0k9RsbM6TWaScoor8Lq9hjZHUqqpQNWkHOX0SobEjMzWad4RMWk/76DyvK05OGlRCqs6MXUNTeNcjwEXUp4QdXArjRfc1xDBJxWW8iikbjXaIHNDQjL8rgxY8NK+vtSHkZ9EZdsf2Hi0tNsfS/8gB/hLqkps+gTjRecLKs/KuiD5FajQ+gfjQSjgmXro4z97xiqilF/6W4FnncOwDfH9lB5A7pEOVh4cSf+dM1alrBJFozaAH3zUg4D9wlLEP8CmKwJ+Ca5yZ9odzLPmfzQwiE4vkiKofFD+hHkUT37CWkiQ3NQ/jzoIl0x6E3zKQeMLq4OKkZ9NA3YsQNN6F8wIoQ3+MfIRl4FLFY2eHu944PPY2v0NgyXGdTfY+KuckbVhMQ+FQFSvulAhdMZ8xPr9eYoLGYkZbRxENm81ozrskMDdel4f2YYwbKvJHc9I6eCmYQh297w0tvKGIQfnZiI5YWfwYVJypZjgi8+Znlrz9Mg0QqjejDhteXLBGSY9+VJBknp5e2xRMc4fuYdGhzZJ3CRBAflSU/7ZsURWac+g8AzamuXo+iQj0E+F1DlUyuCN+wsPBH3kPwYdQ2aSPfR1orWChWJoQn1OJbzCjNnxbcG0fDyT6Iu9S2NdpajADyRKIgPmyeKvkMsxyRlh7Vp4qbqWi46o34+0biA/z/IPyLRK5cwhQBHMebGrfmNk8RV2jrWCT3bmYO9mnfhHJnIYR8sFwZ/VFr4oymIUtjJW0x0A32jeW4EFfILhW04xwXiTrWAIC9+9TcS3Smk+nFjT8DSxNvEjaT3REzFZjw68VtlznuJ6ssoF8IOrH8Dh2I9VxOwfwOdxGRz6aTAtD+wnRys FNdaksJR YfkkNcnjMfBphBCe4imaCuYuTAgig1FwTUXpEwZOdNtBwN2TndzOFOJCcBdh6D/xpb5lnHas/FGHwBMbfKtc7dTzVc3YQiMhgwKrwA6AelHtHscwXPF7h+8o9sOg2I5XoWmroPNLBS+ZIIeRsXK6zpPFNafLaA8E48KBBmBzBICO5vJIzsMa0obAxQ25Gwku5sbBpMCbmW1rgD+HFeFGXmH0rirkLuaJl3dDbCo/fGAhsTgwlNZyl+w6UQrOwRpT3eOkVZ6lYQIFTBqn7XY37K6Sj1E6yL+HEORMx09NuN7Zg7ANxsGUiRHVV50J9ukIx6n3VXhaL69lGRoDWhcmyHIns1oA28ci7KmpNACNbKb9m4/VYM9JEI4kPLQf58viGrun+D7PSlrHvmW0ytbPQb5JKr1w/6yQIg6AOFPy+chH52m0GM2s3VG49qmRHwjVujKVtdCr04CjrddxP117rjHjVHQCCFUIe6J9tRacS0UK1mpseZbS5gHB9nEc3oRS1s21Kj8f/m/M4o1Fnh6Zm3CLi/bjkxFHbewtYeQjE2PXIbkbAOBoDYEI//th49A27lD7u X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13.04.23 12:40, Yosry Ahmed wrote: > During reclaim, we keep track of pages reclaimed from other means than > LRU-based reclaim through scan_control->reclaim_state->reclaimed_slab, > which we stash a pointer to in current task_struct. > > However, we keep track of more than just reclaimed slab pages through > this. We also use it for clean file pages dropped through pruned inodes, > and xfs buffer pages freed. Rename reclaimed_slab to reclaimed, and add Would "reclaimed_non_lru" be more expressive? Then, mm_account_reclaimed_pages() -> mm_account_non_lru_reclaimed_pages() Apart from that LGTM. -- Thanks, David / dhildenb