From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02535C54E7C for ; Tue, 14 Nov 2023 20:31:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 56F596B031D; Tue, 14 Nov 2023 15:31:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F8186B031E; Tue, 14 Nov 2023 15:31:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 372F86B031F; Tue, 14 Nov 2023 15:31:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2662E6B031D for ; Tue, 14 Nov 2023 15:31:09 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EFB7E120363 for ; Tue, 14 Nov 2023 20:31:08 +0000 (UTC) X-FDA: 81457704216.28.10A9C0B Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf13.hostedemail.com (Postfix) with ESMTP id A10F42001B for ; Tue, 14 Nov 2023 20:31:06 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=bz0Tanb9; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=U1sGsexk; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699993867; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K8/NrlXrx7sKxKw33qQLGmJG4ajpbjlsvtZQ38cozIM=; b=33Mk/lcX3MbUdNeRfwqz2uZqaKwUjOAgjytf/6IYZlVgfyBv7+oNifUPRL705Wzn/tjRXb 3IERRlPOdwFxOcrwGqGvdB7q0r13kZupD1buA/OJ6ljFEc+LIMoEjB9YtE89tGSZ8TdcOr LlY2vlCiAgj4aqLy8hq/zSAfvk14IDQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=bz0Tanb9; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=U1sGsexk; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699993867; a=rsa-sha256; cv=none; b=zhDe1+gzkISkdM2ZRIE18kJdk5ruvri2cB1buK0VJOPHqHe3I6sXEzs3GA04O90UW4l9os GNwUvPLfmDHwlEDTb+eIsWLB+mAYYzyUz7npEdUjkn+yab4+vBcCvOUHEzNfzI5OO5EWAh VFKA+IF+mi1GBRqDLz9jwAJV18LqxSk= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4C50F20430; Tue, 14 Nov 2023 20:31:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1699993864; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K8/NrlXrx7sKxKw33qQLGmJG4ajpbjlsvtZQ38cozIM=; b=bz0Tanb9Y3cak62EKwozN4JZtM1EhTLHsjIgv5TckwMI590xRU45d3JovLa+6SFsyKvs2/ o5ghKFRI2Y8Jt/HtZSGjcqLB0NdyBPycLAuFkWsrld6TjftB3Te5iuFxaH5IMLpjpcbgk5 VW+PGp8qKkuMzms6pm7UNipMPPKskTs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1699993864; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K8/NrlXrx7sKxKw33qQLGmJG4ajpbjlsvtZQ38cozIM=; b=U1sGsexkSCenG1J6TMRPFw6R8GIAzJNbVkcOX/AeR665x0R5K/WudYp5YDQciPcjElgvrx ek9r1bVuNVNQjcBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0337013460; Tue, 14 Nov 2023 20:31:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id O8kbAAjZU2UpYQAAMHmgww (envelope-from ); Tue, 14 Nov 2023 20:31:04 +0000 Message-ID: Date: Tue, 14 Nov 2023 21:31:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 18/20] mm/slub: remove slab_alloc() and __kmem_cache_alloc_lru() wrappers Content-Language: en-US To: Kees Cook Cc: David Rientjes , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Marco Elver , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , kasan-dev@googlegroups.com, cgroups@vger.kernel.org References: <20231113191340.17482-22-vbabka@suse.cz> <20231113191340.17482-40-vbabka@suse.cz> <202311132048.B3AADC400@keescook> From: Vlastimil Babka In-Reply-To: <202311132048.B3AADC400@keescook> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A10F42001B X-Rspam-User: X-Stat-Signature: qbeu4wyp163p4iajfhadxnd5mhyxtfj8 X-Rspamd-Server: rspam01 X-HE-Tag: 1699993866-816266 X-HE-Meta: U2FsdGVkX1/oWZhey08vk1x8EmrtR1RMNvE0wVwF5Zg8rPkuH1ikp4vaC+2XKDskdIJVoWgeDh2XHVrcBJQnVFrdtuNYg31ZckvP/PvltERDTRmmLJ6NhsOmIRl8Sm+kK7+RaXhONK+koWFB5dKSpjv0OZOl/E5cpXmGR9QLVrcchithGJ3X24JqFHGMQONKrtR0YmjOL9NCxb8jYPjLljQcPYiravgma0cNA1YC8A8L2dY3EJlQLMYWgLw/n5RXO2xPEOP4F4hTpeaGYg9N8pZgbTJ/yoeAncbQ1SqETZXLrlus0vTclpupVllUFGGl/v5AXsyRaI8OL/bvbji2Ar42w81SCYnIm61v5Pr7L8TO2oLVFFMzwFoq27ItgkAVYSG5Z3cDgVIrVDHffS3+UfZAfDYMVjf1E+ftuc34IIvbon4lRZo/OZJ427XzdfpDkfv7bxGXG544msUubygMenOAbHURq9VI/GsmD73WD1cu5hOdNYV5+I9gzpMBffEpgSY32xupobQxaOFqbaZ5M9EUv80tETLcIhRNMKxY9T3iBju0XoIBxpoJSegG/y2dXF1smr6GuSHR1kKnRe3vQ0WSjn+56OcNkkcI26cgssTNXVZOydyWhyFXrxVDgBqFHwya3mpAUZJ+ECCMVaZtEXfuBvL5oArliiXSFklp8V85VFE15IdOUKGlyZzSR/+VapNQymqE6kZL9narb1j7L87pIuqtgXIc9Z3DRG43PywbzVjZbyP+T5h6nJqVQrSAU8nBHPbCGBQYkeaOVdpuUf63OehOWU9R2fpXIo+HCJo1kW8NNurbDYhfuLtM8koBgTEx7MMbZnoylGGp4COK3O0ArosYtPAHSygXBCexCZDrVQrxGyPk9QLMYT/3U9SxRIi7Wl5E44aWGQrPwKJs3DUcAQUHTIN7WNSfVpyKbniX4EAlI9Js/bIZp7mcneD8xaozO+OHXItaug1d0po t9+BfUIV /0DyDN3RMdQksLbytrZ2s/r81vnf9uZPPNj9M84mrCye4es33xInngQY62x/D4JYZfZhf8SxkdAFluL2FbdcRd+nAbT8UumCZKWG7s0fpO3ErBt4gl75dREjbGiipLaeQYORW2Zn/hUNDS6u4aypCeTfA6Jwrp/dL78xBF5syXM9si9MWZb0Wp6K28hlsTh1jxE5kH3/iKnfhwNbBLNE+OVC0Fl7f58Z+Y3dJUrBkocn7r/HV2E5FjKDYvN0hiyFAkSXlZL77jxdZIlJsm22MtPFl/YHMTilP8MbZ4u+MaBcPtr6uafvq94zw6fXlH4nVNueUmSNuV2qJhFH9oiu6OjyqE4RVrE+ozmb3xfVv9lAGsYAaQtLpDKDiqw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/14/23 05:50, Kees Cook wrote: > On Mon, Nov 13, 2023 at 08:13:59PM +0100, Vlastimil Babka wrote: >> slab_alloc() is a thin wrapper around slab_alloc_node() with only one >> caller. Replace with direct call of slab_alloc_node(). >> __kmem_cache_alloc_lru() itself is a thin wrapper with two callers, >> so replace it with direct calls of slab_alloc_node() and >> trace_kmem_cache_alloc(). > > I'd have a sense that with 2 callers a wrapper is still useful? Well it bothered me how many layers everything went through, it makes it harder to comprehend the code. >> >> This also makes sure _RET_IP_ has always the expected value and not >> depending on inlining decisions. And there's also this argument. We should evaluate _RET_IP_ in kmem_cache_alloc() and kmem_cache_alloc_lru(). >> Signed-off-by: Vlastimil Babka >> [...] >> void *kmem_cache_alloc_node(struct kmem_cache *s, gfp_t gfpflags, int node) >> { >> - void *ret = slab_alloc_node(s, NULL, gfpflags, node, _RET_IP_, s->object_size); >> + void *ret = slab_alloc_node(s, NULL, gfpflags, node, _RET_IP_, >> + s->object_size); >> > > Whitespace change here isn't mentioned in the commit log. OK, will mention. > Regardless: > > Reviewed-by: Kees Cook Thanks!