From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70ACEC48260 for ; Fri, 16 Feb 2024 09:08:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F41B78D0019; Fri, 16 Feb 2024 04:08:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ECBE48D0013; Fri, 16 Feb 2024 04:08:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D44618D0019; Fri, 16 Feb 2024 04:08:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BF6338D0013 for ; Fri, 16 Feb 2024 04:08:02 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 754A3A038F for ; Fri, 16 Feb 2024 09:08:02 +0000 (UTC) X-FDA: 81797090004.22.850B6D1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 36FE94000A for ; Fri, 16 Feb 2024 09:08:00 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Fyj/55Yi"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708074480; a=rsa-sha256; cv=none; b=BduB+NglH7ZSvb+gc5txknzjkqAOe6vytPem72TGxHCU/JaePilsu9Z7kv9lVvEOXJhLFM DU0ECIawrhgHBuPTVSRDCJs0GsKv1qFXHr5XHPoYyo4fi4NkpyxAI1lOqfC1nyU08fKZRF b6Bc0YVMg+06JX3//QtQPLg0eAS3HAY= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Fyj/55Yi"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708074480; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nZitMWe+tPaHyOlddPHAfwqLwys1/LvTwfEIL/HS1ek=; b=tFzl+6rCIo7KU0XHwZYd9laSdUKrBmA+6jpSY77bS99a/qyAdwiIe16IKOoOjxG5b/OxPt mL8CUyJLV7q2ckVDEKJjBLrOouny5duSjs2fj7zeUIoSZqypUeOaGSoo8mt3xfWJKlVDgT QBn1d4Jx12yDybd5qLKGPdEqwripO3A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708074479; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=nZitMWe+tPaHyOlddPHAfwqLwys1/LvTwfEIL/HS1ek=; b=Fyj/55YiXFZpzxsfIcAuphU54pnHpeCAjnAw3gWrobM5SV8igqriQb1qtJtu+PjCLVhv0l 2+NbVROZlBUqLmzwynBuTI/SEN6oUCWw/qq+EZEcwe7Fvi8HpQ5UjelmJV0kPAM148npUm aWHmpRdq9SV2DscKsv5hzKVqjZC5arw= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-507-TXbDg208O-mlEfvMFYX1_w-1; Fri, 16 Feb 2024 04:07:58 -0500 X-MC-Unique: TXbDg208O-mlEfvMFYX1_w-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-51145df2a08so1016241e87.1 for ; Fri, 16 Feb 2024 01:07:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708074476; x=1708679276; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nZitMWe+tPaHyOlddPHAfwqLwys1/LvTwfEIL/HS1ek=; b=RMvTxJjjr275tqqRb9B87YDatfbKPpQbgV2TzeZ1J/QZuQwNS4Piilnf/INmaIckxM 0Hhy7Lg5zZx6jnRat25nhEXdiHOp6S4efGl0eLv7qnZIw/GUYfr9Hs/qB9YoDAMmkTAx d2foXqod4xG9shpAsKCgJVm1YblSWA8ZvcmXUs6I10gHvb3fcMiO4e2sqbS52h3NVsjn N7Vyd9N15z2zT5WaEe7btcpB76zdXFH6BGOo3o/0MvfmmWcoo8oW+yu7FCVMEQcRvvU/ mEKvuQSPu7OvGvwQ+KPpMK2XH9uogaF99tjvHKpNm0HuztE3/DFv7d/G00ulYVQz6ECp cn4A== X-Forwarded-Encrypted: i=1; AJvYcCWlqRF1DVwZ3t5jMknXIyYldp9c5ceH5inmAeFyw9XXyxc/PcM9faUpl2XAxKpGW3HtCj0ysmLQrbzugm2NPpA1XW0= X-Gm-Message-State: AOJu0YyjEnSZ5uE8rsVLJdOAWEmnyQ6fdUZi/VwH75cunGwDh8cABxNA v8GuCuW8qXMtTdrPJv/2ICpgKHmFNdMErJJ6mYaTMz7GgsiYFnettfYpFfyPBq6V9LdlDNuYIv2 4p5MfunDYyW2ds233FaTeiwEhUR8ChS7VGiH7qjYYaN0zZObP X-Received: by 2002:a05:6512:3a85:b0:512:8482:a7e0 with SMTP id q5-20020a0565123a8500b005128482a7e0mr1633163lfu.33.1708074476635; Fri, 16 Feb 2024 01:07:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IFRmxUki7Suc5I/78almuAPevH2G9vaTICnUFr00lsv2dp2nHb7Tv9xubh64Vh932zCSKlWBQ== X-Received: by 2002:a05:6512:3a85:b0:512:8482:a7e0 with SMTP id q5-20020a0565123a8500b005128482a7e0mr1633137lfu.33.1708074476142; Fri, 16 Feb 2024 01:07:56 -0800 (PST) Received: from ?IPV6:2003:d8:2f3c:3f00:7177:eb0c:d3d2:4b0e? (p200300d82f3c3f007177eb0cd3d24b0e.dip0.t-ipconnect.de. [2003:d8:2f3c:3f00:7177:eb0c:d3d2:4b0e]) by smtp.gmail.com with ESMTPSA id 20-20020ac24854000000b005115e1d1998sm543119lfy.59.2024.02.16.01.07.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Feb 2024 01:07:55 -0800 (PST) Message-ID: Date: Fri, 16 Feb 2024 10:07:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] sched/numa, mm: do not promote folios to nodes not set N_MEMORY To: Byungchul Park , mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, akpm@linux-foundation.org References: <20240216073340.55404-1-byungchul@sk.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240216073340.55404-1-byungchul@sk.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 36FE94000A X-Stat-Signature: 1rqiw9qcd4r9mtgar9q5qabc1kqg3twe X-HE-Tag: 1708074480-810221 X-HE-Meta: U2FsdGVkX1+7lqIYIVroi6y5Rj/v0Qq0DwF6+G6/ulj4Hiu/q4uMATqie14WFn7+uJSVsD7i7u1S+ah9mb4je7FGzjaVMkp/RxGNNi86nvIuD5tq2EJGBx4jmuPZYs+DL2pxnfsqLjZSVUH9Y5TKBSQa7P/ui8SvajJgaINwsp6KKEvrY+lNEIQsl8v3VClNojRlRpXOsM7WVD9p3bsYN7FZjG3o0Ata6T/4OS2xV67q5RU3Y1mK9jtO/ZR7Is29FcRmd+xZ6mYEP9ah2sZVF495FY+6nfTJHRgjyZY7BgO/MuW4oovv3y+0lSh1Z9154JHSBvEI6mz6JuZnYV5jXnJAWma0I/QujzhjHG7SWXzNLfeMFNHTvWxPYV+xFMAI0UWno/GPYe+zSCL2kZ7oq/nyoyRrCWZbwEfEXkEU9MV7ECw0vnpa6P6a3Yg7+kMES1GcgHxUzG2y0efthvMIeQhwfRrSZLAtFZl0LgnxvN2RquX00Vadb+/fcKaqwPm5/EwOX/1tYUNe0mjK+SpGHryACj/B+d4TmhF0f+6LrV6+Bi7DREFkHd4fwfWxmkWP/Z3AJCj3dscNcc/jBnx3ZlqatZarKrEi22n4NwNyzAFyYkaGk6f4TgXgC67MOal7/pThMsa53Zb9ygqs0aBWfz1X/YrrVAUqx4adaKX6imNU34h4zpou099wozA1lmuZnkD677h/fu7o9cUYnV+x1aQ457zNoO07NHTZCb6CVfA7gD4DXLOke2IIOavRrd4aYaMjcsMCFbrEIRbgEXxazijbLFZRMsJFVz3LwBiPvE7Jr2UOqaINLiJG5WamzSLzdW70Lq+NAErc3QOgeCx0n7NrcMsjhq170ItnHx6+pbhWkQ3X2JvaS0hVXuGYXuyCq/ZUHSyFs01fLVNDqUNX9XCETvHWYdNyL0FaxmZmNK+Gx3/Jd3KlLw0sk35Nsz9FaxBLeek5QKQjf3XK+v3 d0D3jorJ 3KpsclYp+D5AepQN2qANSAsJRl5lp8/FOcBWM7S7zEzRKMoqwmvW8trRl9TCCBbd2qHCVwgtvNupqC/YAL/dACIBEha+J8C0o5Lz4k7LyLV3rEkCT8iyaYNDj7vsfLHyQlACrXaSUSoczcLb/5YFD5mktEZuxP6jkZLF1auDJcXBRWsI9bL9HRDbhal2ODEifHBti5X6DBF1bRWnHBXXro2uFeQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.02.24 08:33, Byungchul Park wrote: > Changes from v1: > 1. Trim the verbose oops in the commit message. (feedbacked by > Phil Auld) > 2. Rewrite a comment in code. (feedbacked by Phil Auld) > > --->8--- > From 6830b59db267a31b78f6f09af12ae0e3132b4bca Mon Sep 17 00:00:00 2001 > From: Byungchul Park > Date: Fri, 16 Feb 2024 16:26:23 +0900 > Subject: [PATCH v2] sched/numa, mm: do not promote folios to nodes not set N_MEMORY > > While running qemu with a configuration where some CPUs don't have their > local memory and with a kernel numa balancing on, the following oops has > been observed. It's because of null pointers of ->zone_pgdat of zones of > those nodes that are not initialized properly at booting time. So should > avoid nodes not set N_MEMORY from getting promoted. > >> BUG: unable to handle page fault for address: 00000000000033f3 >> #PF: supervisor read access in kernel mode >> #PF: error_code(0x0000) - not-present page >> PGD 0 P4D 0 >> Oops: 0000 [#1] PREEMPT SMP NOPTI >> CPU: 2 PID: 895 Comm: masim Not tainted 6.6.0-dirty #255 >> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS >> rel-1.16.0-0-gd239552ce722-prebuilt.qemu.org 04/01/2014 >> RIP: 0010:wakeup_kswapd (./linux/mm/vmscan.c:7812) >> Code: (omitted) >> RSP: 0000:ffffc90004257d58 EFLAGS: 00010286 >> RAX: ffffffffffffffff RBX: ffff88883fff0480 RCX: 0000000000000003 >> RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff88883fff0480 >> RBP: ffffffffffffffff R08: ff0003ffffffffff R09: ffffffffffffffff >> R10: ffff888106c95540 R11: 0000000055555554 R12: 0000000000000003 >> R13: 0000000000000000 R14: 0000000000000000 R15: ffff88883fff0940 >> FS: 00007fc4b8124740(0000) GS:ffff888827c00000(0000) knlGS:0000000000000000 >> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >> CR2: 00000000000033f3 CR3: 000000026cc08004 CR4: 0000000000770ee0 >> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 >> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 >> PKRU: 55555554 >> Call Trace: >> >> ? __die >> ? page_fault_oops >> ? __pte_offset_map_lock >> ? exc_page_fault >> ? asm_exc_page_fault >> ? wakeup_kswapd >> migrate_misplaced_page >> __handle_mm_fault >> handle_mm_fault >> do_user_addr_fault >> exc_page_fault >> asm_exc_page_fault >> RIP: 0033:0x55b897ba0808 >> Code: (omitted) >> RSP: 002b:00007ffeefa821a0 EFLAGS: 00010287 >> RAX: 000055b89983acd0 RBX: 00007ffeefa823f8 RCX: 000055b89983acd0 >> RDX: 00007fc2f8122010 RSI: 0000000000020000 RDI: 000055b89983acd0 >> RBP: 00007ffeefa821a0 R08: 0000000000000037 R09: 0000000000000075 >> R10: 0000000000000000 R11: 0000000000000202 R12: 0000000000000000 >> R13: 00007ffeefa82410 R14: 000055b897ba5dd8 R15: 00007fc4b8340000 >> > This sounds like we need a Fixes: and want to CC stable? -- Cheers, David / dhildenb