From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BBE6EEAA62 for ; Thu, 14 Sep 2023 18:47:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA5416B02D2; Thu, 14 Sep 2023 14:47:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D55BD6B02D5; Thu, 14 Sep 2023 14:47:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1DDC6B02D7; Thu, 14 Sep 2023 14:47:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AF6C66B02D2 for ; Thu, 14 Sep 2023 14:47:33 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8F7A780EF4 for ; Thu, 14 Sep 2023 18:47:33 +0000 (UTC) X-FDA: 81236086386.18.DD7B4F5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 69BA6C0004 for ; Thu, 14 Sep 2023 18:47:31 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=H8v7pz02; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694717251; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=91ItEaA48PaYp5ILUtPQ0EOz3NpWw/JFlwU7DDokP0U=; b=Cr/qwUpr2x2D4f1X3h/vOQm0DVthrPxsn9W3pfNK5E6eY7aEbtkKSqXu52QHA53ErldEs1 HsoDR13z5I8/T+XL8Yct82JCL8xjgKgGejd8w62F0V6b+oxdk+M3zttX4ORSTDCWFLytV6 2q6MC9kJv8Q38n33TfgBrPrVsMNUxQ0= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=H8v7pz02; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694717251; a=rsa-sha256; cv=none; b=H/tN8QP5e7ILjnzd7z8RG0nOLE1wXHClKC2IqJjFK1kCLUT558NVqd0DnBvTuKUm5C7Ax5 SlvKJuCW9h6foYkScGohkvYotrGLw2x3P6GqDqnl2ORE4rhbJwfTaCSRTf9iAaU13VikJq V9OTnS/i1HPGpg6Kuw9OQa1UU0scvhI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694717250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=91ItEaA48PaYp5ILUtPQ0EOz3NpWw/JFlwU7DDokP0U=; b=H8v7pz02M0YZQq83o6gHy+7Qxt9FBnoE/sk4FDzjyVAuH8UqbKVj44u5TCz8FUOd4cN40s /RzHppus6yrBrkPMUChcAe5vP9xBFPuzDvlZR2KdZxuvMMYBOXKAWhGoZLYKQDupUQOwF+ MUltAVVxCiFMTM6NjZR9GiRI2voDs+s= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-374-96ur5m2cMO2JrElhoBG3rg-1; Thu, 14 Sep 2023 14:47:29 -0400 X-MC-Unique: 96ur5m2cMO2JrElhoBG3rg-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-317d5b38194so585874f8f.0 for ; Thu, 14 Sep 2023 11:47:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694717248; x=1695322048; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=91ItEaA48PaYp5ILUtPQ0EOz3NpWw/JFlwU7DDokP0U=; b=jQH9pPTN+7OiADDaczsTyYNkBARnfeB85psYH74imA7mZD9NOcZACCuXwQ86vqw54t Acjuer4x32qsB1ONW3CyG7EtnZc0tOpMeqTtQv8LV2MFr+bsmZSdPDEqxDuqKOwYHJcs tP44rp+NqxNf2Ykb8zCcVM8eK34PbV/gW7tXKjomGuxc6krjnZOrhOWub7TctjUyY3Pk 5DGOq9ANiZLif9EZnYyWPEY0H+y2WyiwAGimQ0pzbGHDj+dAk0/VeaJc8Al/QW7tUmfi ZfcT6zOVP5cVeQguFmlgCFqFilZuHTpclILLo4nh8sr2pMbpa7wGf/bivyqxOhBaDrjQ Ubuw== X-Gm-Message-State: AOJu0YxHRJ3Xn//VFDMxKuE4RFlyCfA6TPHdUlSTfLYK6ZsSLbRVAVvK M0jKxyNXPk5XKCantSZ9KM/J3Ma7nXxNy3T0abbo3+YnzLRwfDCLNxxT+TTYohfo1TJtwLu0zmd P9epSKDddGDw= X-Received: by 2002:adf:ef09:0:b0:319:6997:9432 with SMTP id e9-20020adfef09000000b0031969979432mr2074738wro.1.1694717248106; Thu, 14 Sep 2023 11:47:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHy12DLRCd8OQHn+OojnAwrycBjGv1lx9Cp32vLLh8AHV2EYYDMTmO3oDXfBhNoF1kAoqLVgw== X-Received: by 2002:adf:ef09:0:b0:319:6997:9432 with SMTP id e9-20020adfef09000000b0031969979432mr2074717wro.1.1694717247674; Thu, 14 Sep 2023 11:47:27 -0700 (PDT) Received: from ?IPV6:2003:cb:c71c:600:4630:4a91:d07:7095? (p200300cbc71c060046304a910d077095.dip0.t-ipconnect.de. [2003:cb:c71c:600:4630:4a91:d07:7095]) by smtp.gmail.com with ESMTPSA id e11-20020a056000120b00b003196b1bb528sm2456394wrx.64.2023.09.14.11.47.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Sep 2023 11:47:27 -0700 (PDT) Message-ID: Date: Thu, 14 Sep 2023 20:47:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 2/3] userfaultfd: UFFDIO_REMAP uABI To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com, lokeshgidra@google.com, peterx@redhat.com, hughd@google.com, mhocko@suse.com, axelrasmussen@google.com, rppt@kernel.org, willy@infradead.org, Liam.Howlett@oracle.com, jannh@google.com, zhangpeng362@huawei.com, bgeffon@google.com, kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com References: <20230914152620.2743033-1-surenb@google.com> <20230914152620.2743033-3-surenb@google.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230914152620.2743033-3-surenb@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 69BA6C0004 X-Stat-Signature: 4i979bihmyhbgpq3wpotuqu85njgkj45 X-HE-Tag: 1694717251-804321 X-HE-Meta: U2FsdGVkX1+x6Pwr3zGShvYrFeO7gt8L2dv8rlExx2+u1SzjW+1TH+cpg6hIDyDrdHA2Nxqz8o6zziPMhUKIVJWexXvfF4EwE5AOM1kaCBczakwxjP8VYTa8eIQETIF7bltgvq68OgXHNNK2ejBJW8aOwChm7MtKFoiaLduuf9/exJk7TJ3dKxWuB2JrMjEkyaAsBXGOyTp61vRWtW5w7gx67vVhiQz3XvE6blIb5Vg/FoXPqecKJbVG+rOfdBfbNqIYpO76MX02JF65sp/cEP7BdtPuCK7j5CbUniwlNu4JF0/8Tnkfmye8S6A2g/eHUmhzcvgtllElP7sPZTnSOp6dXhps0MZGIvP2o7jOoNALYtKqqIHMo7XvpVnYw+iO7n1G3pAMQ7qyxD6/NSp0u3HrqssyUS6zoQGSbjf4GIme73oCjoxZVR/WH7Z5JLhgNmfgar6Frr5z+wq50taXVwxfacXJeMQABWGqJYEMhHpB8zpLapkDpkXwGRJm1WeTEvHdK69Yshm4Q51PIANpTPpZy6XuZ5KyVkE6ynsXxPrFisBu4NSL43Bulrl9vhDM2xi0Skca02udIqHELqVratWvTo8y23jwC7SYcZHXvaiSwnGuYwfDJy7hBZ1bYyoIvPqKxNxVA/J3lvkV6oYLsyfwl5vzS/YH0fWSHAiiJrzl69PgiIkLtLu15MJa+IhIq3KlJEWwIKBwdioiA3AIsE6sIzx86EpHEj/1resUDC8QIPaFZH6rWr4aBeVuP3BHC9imp/gu5foZsCeWKFJwv/TC6SkOZAAY4RWxqqbhSuzYoADfPB7tyvBr9lenm1meRjQjmt3e677QPYHCm6NmKqmw/rNwYC8fGEXXOp0b6falb/TU4HffHvOd6JRHHoZZUua91eoU9WDV/C2JLO3wHhVVodgogRAJmkMhVH+D2c2Zewwkdy49FtQ5GT8u36yxzYCApJuri9NVNgGVREv 5r83Emld teaFFjSF3tnyDWqYJ5ZXO4bQruBPOvz2kzZnFVUlf8AzC26s5ItjSwTZunsH0fc1F/kA/9TER0kofyr0cpBseUJ5q7EfrR2fld/JQYv6TQIid3lFNkljtcPx/dvK1TA12JTRnFqJxH+C9Y9L9Iv3Rfki6uZn2l17bH/DJdaL1EsmnFhMUCNhW9uutIhgD3HuIpE4IfTD8uxiUZ92GDkbYqd6emmbHiJLa1fQfcp0y9yB918eC6OUAG25YBRikNCZMc+t67onWULBQOu707wDEJN7SBF168nTVb3r+thzjyR/5PAG6hRRS40EHIkZYHApLPDQNkRQjblc0IYwN44BkJHCBgsQK41gdSq5U3qgYX/C9XUMS/EhTlSfi+nLOZdAZdJktChxEB405zyqlMBGhVopxZQab2WvLG/GAS17p8UlhitlGtD4gIz0GCTKjTzCaKRW1EJeIvPWKA8SFzIKv0Z37gG5BQYl12NQx X-Bogosity: Ham, tests=bogofilter, spamicity=0.012204, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 14.09.23 17:26, Suren Baghdasaryan wrote: > From: Andrea Arcangeli > > This implements the uABI of UFFDIO_REMAP. > > Notably one mode bitflag is also forwarded (and in turn known) by the > lowlevel remap_pages method. Sorry to say, but these functions are unacceptably long. Please find ways to structure the code in a better way. -- Cheers, David / dhildenb