From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89BD9C0219B for ; Tue, 11 Feb 2025 15:26:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 079E8280002; Tue, 11 Feb 2025 10:26:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0028C280001; Tue, 11 Feb 2025 10:26:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D70DA280002; Tue, 11 Feb 2025 10:26:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B7622280001 for ; Tue, 11 Feb 2025 10:26:35 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0E79B42376 for ; Tue, 11 Feb 2025 15:26:35 +0000 (UTC) X-FDA: 83108040750.29.16351BC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 76FC140025 for ; Tue, 11 Feb 2025 15:26:32 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cyOIHDUJ; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739287592; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yJFisimVCrAD8NJ5dVFzQHU+IRhS6nek7fGYum4KYIY=; b=Z3dGhINpnVQOE9Hv4EF7GePelxzHcwLyFh761lUm9dHIWhFTHiGFeHP/+CzvPZIITmBcWw BsN3cj4cEujJZTR2u1ri7inCw1eD9g0AgSAR3nVcykmM/Yid6KWIriXa8Orzv7ItpIWAcF xrMa4Xo7OeWCtTxsmEh7vFWf6u9le2Y= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cyOIHDUJ; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739287592; a=rsa-sha256; cv=none; b=EUQ0Vlk8aJpyWtP6vEi1339xPecbx3k55CdPM6PdqhmUDzHx+kszY0IgR2buljmmspoPN/ 7EYI9EjUWc0kTay8dgBD6bD1QBtFowCuiZCNY8G1LLBUzyQ9L7arprPw8cxzotFXFRTjbL kXWaTpEUphJjtIF0k/oi3G4KabnDUMg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739287591; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yJFisimVCrAD8NJ5dVFzQHU+IRhS6nek7fGYum4KYIY=; b=cyOIHDUJHsUJR1sG1jnTvY4YlTrR/SRBXitEtEHXroeWiBP82EuppqEwASxTazYIVFVRc0 MsSEtMsBU9JDN1O1G9pG5x48MDuUjMYHUJTKYADgEkHhNPjDivDN8gCZFu9KW9h7FBlpei 7lA//EuU8XVFctXEm3w+D85V/u5LcBo= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-216-YcDdUiBfNgelMXBSVr4EGQ-1; Tue, 11 Feb 2025 10:26:30 -0500 X-MC-Unique: YcDdUiBfNgelMXBSVr4EGQ-1 X-Mimecast-MFC-AGG-ID: YcDdUiBfNgelMXBSVr4EGQ Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-38de0923dbaso972870f8f.0 for ; Tue, 11 Feb 2025 07:26:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739287589; x=1739892389; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=yJFisimVCrAD8NJ5dVFzQHU+IRhS6nek7fGYum4KYIY=; b=Oz4m5Pz++TwyQhb3w/cABrVKEeGMQ4AtKI51nbz4n5KriF0N8SuBdKAjnLLEU0l6Of aBL1m8lJNLJTg0N6BVqd8hDGq0NmSXQrJqHJSjA36Dn8L9HJOtv3iy4YHE39L0Sxnbue TTz+SjIIOxEvRHtWUOMYIkwOA+J3r7ul5yvbkgW4AKD/sdWOho+J0tmOyzYx3wuAToh5 XJ7Q1Cj8iiIWwlaVaT5nAqezhoyyn9GqR4cNFFflhwy3PhomiW/5n0jgAJCanuLTzdnG FAAQd+CRYWb3vd6YM6LmaAZY/1NqKwcOSNS8xGmMg2E3KqTK2sZhYdEMPw+DIjKG3jtv H4Ew== X-Gm-Message-State: AOJu0Yx6wLrJUM/GbYLFbKZsZNunNKamEK81dye/c1Oz3qdH5wNWkC8F 1E1BktrIzSIMD0bG0ApSj6J5Zj7fyrKxv1D9zv+M1MacUBZXc+u4CkBUNA9Gt24tYpOaOdzjWjQ c/Sh7XmEpo3Ob1uHIJeg1cB7kfi8RtiKusdStH91f4osojpem X-Gm-Gg: ASbGnctXGsed1MEgqo0MpV+B94qOaZ+63vNbqp5QUcOI8hAlDbhmepGTPc+YXyUlF86 RORtPW2kca+9r+IdauTgplEIa8rEyaGVhUt6KrQcK9Qqf4MXJcOHKnXvUd0YWiYbMMGpbXD8R5U QOMWIjjd8PAp8RMmeJla/XCIlsK09/VrEuy0lw2d5Ro4+9AXLoW1Gr+tqsl/RoxVu++FUBb7sx4 k/zmfPrkC7/ii87/MvY6LvXbG8YeQLoDT06LBQhC6c1TSIUCViA/vnQwYgxqRF/xNCVkG2PQ7Aa d8zT0KZfesFix/lkTsvRaKlhG9eSRBf+z8AZAj/VIyqi+w== X-Received: by 2002:a5d:4bcc:0:b0:385:e30a:e0f7 with SMTP id ffacd0b85a97d-38de418b0e5mr3048600f8f.22.1739287589017; Tue, 11 Feb 2025 07:26:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IG3RYGYagZq7cE8wRTXOqV6DZVAI+yo+kb2MQKo95lLrcU84Q+LoRbf7zhWx2bNM2NOO7hIrQ== X-Received: by 2002:a5d:4bcc:0:b0:385:e30a:e0f7 with SMTP id ffacd0b85a97d-38de418b0e5mr3048585f8f.22.1739287588688; Tue, 11 Feb 2025 07:26:28 -0800 (PST) Received: from ?IPV6:2a01:599:929:885b:12c0:a824:1abd:41c4? ([2a01:599:929:885b:12c0:a824:1abd:41c4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38dbde0fd23sm15057508f8f.71.2025.02.11.07.26.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Feb 2025 07:26:27 -0800 (PST) Message-ID: Date: Tue, 11 Feb 2025 16:26:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/mm_init.c: only align start of ZONE_MOVALBE on nodes with memory To: Wei Yang , rppt@kernel.org, akpm@linux-foundation.org Cc: linux-mm@kvack.org References: <20250211082900.10877-1-richard.weiyang@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250211082900.10877-1-richard.weiyang@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: MN380q3p1yOL4xC86PiegNxsJux3MAJelNu0-q1ACZc_1739287589 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 76FC140025 X-Stat-Signature: k1panpr3zf1n8f7g9f6ur6eycbww6f5d X-HE-Tag: 1739287592-739333 X-HE-Meta: U2FsdGVkX18VBqZRAx8y1Yli4LfAAikjy9+ABF54lM6LSJAqs3Hrg8QbsTYWN2u39pgR+8MU4v/YC7kseJFWt4fg7V9hheEw2XQv7/uagxAGPNj/V/mAMjYEkr2g0wpqGzK4xQfnZqOxK2HVK39Se8UEC8mPRc33ypYRpeIKIJJOaYmt5w0y3ScPqqIiJeUb/o36kJq8C0KA5sYg23HX6EC4QX/k/PbfwCXR0tP9o4Mur+FN5fvd+2gXAy0422hkCVExYdGqtdjoshnhY97pRc3CaONspyemFDtX/R/ZS+DAH7WBp7enTGQHlGEAsNJ+PJWcVP0OKfsvBg9YAdgX7NaMizYGZt+MRO7s6XrVH3eF3oviTffr9rauAe+oqgfXQ2IDwt8pcg6+26rxuIt4HntDxIzbRnC4xalYVrGR6B8299mouHr4eCcebDokRuaMTaeXgxjKmw3ow93TFw2XZt3vGREwXiVIIwD81KHZNkJjfW3dBIItnDG6u3Lboe9l5tF/dHrBZTZqNSJ+Hf2rgU5ZZRSDOcUlzikFQ17AfPqtwBuaGnvSHvCRvaN+X0hoz7fSjhdzZWbJ+9xC2kLey1CXQzc421yj98c9SsJM/+S1KjpVf2WTDSXZ5trdgqVovckefp3KsIT/KVEKA2kx1YcBX8TbpqGEDY6TXFIE7NQXH7/zjpSfx0xmNxlPe64Q3IxOis8uxYolj11JMwGAP+JScwt99FtatUSiYL7Pxb1EBlqLvuSlRTDbRANLFQQHnC0NUCnE71P37uIT8HVKqMBi9PPHgw5H7+D/fJVjFNYAIvBh4V8vaSl0Q4FxVWUZXE42jtmfXtH9Lmg0XrdRXUWncHW/FhfJ1wNAK+2y8tjtIhNYOBp5J3DZd91f7h9bQLSh3/wGSYAlZObXdmqBDgpDGWPtZqWsFsvolp5HXJdY9l6jKpIVNdHJSj7RFMnRA1c1NhdFKFIdaDjqnYm QCQKExoP HZuAfbHoxuuy9XcKSOSlehfQc2IMzZUYpQ50FY+hph1ifLnPU6d3NoKPICRVXCrrL7mAXg8DFF/GUs3UBSFAdoQuMGDVmEadOHoJvm1GMdmsj0JYSgvUx1GDJnaOzHBRQRJwlKPeDfneutAzaXzTTwsV0tfUeHVgIqZi4syYw3B7jT+1JbQutoen/ZoDKKV/mo2Rp2VTgQapbceSt0pDmAf3/qEHrdfqRTuAvH7hiIhTJUewMlM7Df5H6g9OUIKIwbYVr/Vz0ytjELLqxhAy6mwDeyzxVa4D89EcuNRi1LUQSutCFfwT2xdwPQZKfe25EZiRJ4iA8GrcHNxcTJbCkmzSlr4yg5zZG+Ssmi9gJrOlzCPATswGD1hMMn8y6i/OxzdE0nBZBEipcWg6UHiJYmCqD36HvXYsTtTogNFbgnd6/FEHrdI9V96tlMi8zs/Nd+1JepjFaiVlJcI/aWqyx5B1ur53dZ9CXNrStqNK4MBjSy6/1iioJO4wEZQ54A14xbvaS1Daf+jJw/7T3DhaUG2hxwowviMfEMMN+Wzk4VDXfHCRGxLSpg6T2FCh1kACYKAWibtc2iiSX194= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.02.25 09:29, Wei Yang wrote: > At the beginning of find_zone_movable_pfns_for_nodes(), it has properly > set node_states[N_MEMORY] in early_calculate_totalpages(). > > Instead of iterate on all possible nodes, we can just do the alignment > on nodes with memory. > > Signed-off-by: Wei Yang > --- > mm/mm_init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 35754a8ae6c0..3ec50b5fda12 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -547,7 +547,7 @@ static void __init find_zone_movable_pfns_for_nodes(void) > > out2: > /* Align start of ZONE_MOVABLE on all nids to MAX_ORDER_NR_PAGES */ > - for (nid = 0; nid < MAX_NUMNODES; nid++) { > + for_each_node_state(nid, N_MEMORY) { > unsigned long start_pfn, end_pfn; > > zone_movable_pfn[nid] = I think this should work Acked-by: David Hildenbrand -- Cheers, David / dhildenb