From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64840C001DE for ; Mon, 31 Jul 2023 16:03:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C424B6B00D7; Mon, 31 Jul 2023 12:03:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF24C6B00D8; Mon, 31 Jul 2023 12:03:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A936A28006D; Mon, 31 Jul 2023 12:03:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9C0556B00D7 for ; Mon, 31 Jul 2023 12:03:54 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1A4E614049A for ; Mon, 31 Jul 2023 16:03:54 +0000 (UTC) X-FDA: 81072377988.12.88C9AA6 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by imf18.hostedemail.com (Postfix) with ESMTP id 3AD361C031F for ; Mon, 31 Jul 2023 16:03:15 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=kYzWRu4k; spf=pass (imf18.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.48 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690819396; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wjX9vqrNZsVo8pAJHyJfBfDqvLmz9Q9LwcwZTP61/cs=; b=t7P2JY4vqyqjeAn1XuI8IXt0muGOnMQ9yuhsQaR8jGpA8o8Ze/IRce8mIK92sB0/Zn88aB MCp0adbRpsKDm+0G5HiUDBYqhBzMxU6vBNTaa8/9gIDYOGrG9pxa7bCby57tIKh2Dvm2So 4aF6vCyklrlAqB1JYNIrOIrF/c9smzI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690819396; a=rsa-sha256; cv=none; b=8J2ygSyVjjCwP2748Pkp4a8bbfa4e+OxeBrdQBV3joq0SknesU9B82GrvMbTJ7KH/S2oxO wfto5m5bUEbdPN21AMIDG+0nHzHQn3845og/SIMWX+7mt/Wf8xElWh6BHNmxK/3iyFfCLm nmgb1wmayk9OW5vW8h4NVpTCBrSqABE= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=kYzWRu4k; spf=pass (imf18.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.48 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-3fbc5d5742bso52012265e9.2 for ; Mon, 31 Jul 2023 09:03:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690819394; x=1691424194; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wjX9vqrNZsVo8pAJHyJfBfDqvLmz9Q9LwcwZTP61/cs=; b=kYzWRu4k1QcGoE6XKlByF3TqlwnnuXUy4dR/Gmke34HiIojnc6bDt5mnmDrOMIanBC QUevvvfek0A0kIhfRLCo8R/86BFpovIiHnnInbzwZivWg2DRSm+X5e15n19MoM8ITjcG /+J6EfoaBtyNvPh2Yg2/K4Zf7rrxdQB0bQhvIF9F1h5QqrkpNHuKfSzod4rrLRa1ifOB nEUhBA9+KaGfeeecCMie9MebsjXRqYzaUgOSq09dmjhabu7gzNjGo+iXkB9N7h9h4gTU J2wpszV9xtd4d81pKysjcOiYL/WmjuQhdAci9fviFugAru1L92cwlrTrGrXfizKWktqj yppQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690819394; x=1691424194; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wjX9vqrNZsVo8pAJHyJfBfDqvLmz9Q9LwcwZTP61/cs=; b=Zwv9+8YLTW/S+hOW4GUGV6WukwI49onoFRzJEG67qtsUQ1RBGmz+4iNXyqpkUNs9Ln YNWeWf0ZeymvTvM8wXh/TUHGfPX55eTeuX1ZU/YyDydFzIQoIGG5YPt0YyaqKCudbmIN mrucAb2hyAiRgAwa9oHgthQQNCaBx00Yn2J5uOrFTP8HAxcuD3zQH/XOC3i2PUgkURCy T2jcR0j+noeJKm5mbWZPOH7J82yjn/RyUEkvGl5cmemh52kCrDX6/9Qf+fKHGfW+pNZ2 0ZZI7hcRT8tJM7q9FDGQbbZ7XpYD5PRhN8iSSHZplVeegxJa/RLUd28k+X406hxlzqSs SfBQ== X-Gm-Message-State: ABy/qLYTY6XmEAQnW1ZD0EvA7jm+lQfMwCtiEWZU8VP5HGC1Mza1jph5 CuGgY+GFDHu0Ugduo1jzkPnLvw== X-Google-Smtp-Source: APBJJlH9s43EMKigyuVBab9J9RMVZV2UplPMJan+41yuvFpRsQzS559KIDbR9x9cZ2CPnZZf/f6ReA== X-Received: by 2002:a1c:7505:0:b0:3fc:2e8:ea8b with SMTP id o5-20020a1c7505000000b003fc02e8ea8bmr295454wmc.28.1690819394291; Mon, 31 Jul 2023 09:03:14 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id v18-20020a05600c215200b003fe0bb31a6asm8872643wml.43.2023.07.31.09.03.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 09:03:13 -0700 (PDT) Date: Mon, 31 Jul 2023 19:03:04 +0300 From: Dan Carpenter To: Steven Rostedt Cc: Valentin Schneider , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, x86@kernel.org, rcu@vger.kernel.org, linux-kselftest@vger.kernel.org, Masami Hiramatsu , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Andy Lutomirski , Peter Zijlstra , Frederic Weisbecker , "Paul E. McKenney" , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Josh Poimboeuf , Jason Baron , Kees Cook , Sami Tolvanen , Ard Biesheuvel , Nicholas Piggin , Juerg Haefliger , Nicolas Saenz Julienne , "Kirill A. Shutemov" , Nadav Amit , Dan Carpenter , Chuang Wang , Yang Jihong , Petr Mladek , "Jason A. Donenfeld" , Song Liu , Julian Pidancet , Tom Lendacky , Dionna Glaze , Thomas =?iso-8859-1?Q?Wei=DFschuh?= , Juri Lelli , Daniel Bristot de Oliveira , Marcelo Tosatti , Yair Podemsky Subject: Re: [RFC PATCH v2 06/20] tracing/filters: Optimise scalar vs cpumask filtering when the user mask is a single CPU Message-ID: References: <20230720163056.2564824-1-vschneid@redhat.com> <20230720163056.2564824-7-vschneid@redhat.com> <20230729155547.35719a1f@rorschach.local.home> <04f20e58-6b24-4f44-94e2-0d12324a30e4@kadam.mountain> <20230731115453.395d20c6@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230731115453.395d20c6@gandalf.local.home> X-Rspamd-Queue-Id: 3AD361C031F X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: fjtwaeype9xxmiup8hgeufokpjdj7jhu X-HE-Tag: 1690819395-253042 X-HE-Meta: U2FsdGVkX1/R//m+YkUd8WkyGc5CRLjs32EOUEx3RYnIjq6xDymtyKuTLwLIbpgUjZZe1EE0MCcoH1C66WQp3K3ZsKoG2FTeIyrKOh/bOpbJPjOf5amY1OrTKLORb6Z/KWZNyeLrBiTDQ2JpcwsFr3deqrSrIoLWwkQ5tGQAbSCL58dTU1GLPNaCrQ1LG5+p3aw1w0pTG4zgjCXvMVMALd7xRA9mtGBbuUIH8HThCDfT+BTSNcAvqVsz7x12V6ZcMYK+T3uNATiAt8fOPT+/ZIxEs5kjQInYiR148ItK9MrIIEDIpfzFdhmssIJs3mW98bX14scrVL0khIC5L4/pyEqGip1TDd1p1PskPOJivxQHNpW1DDSs/bYWQ5sx9ZAU9fdoiwqNFvb5AQngWbK+0sGnHxiBw8C2WEaAP2RuuMHRTRiDbsa4M+QQePkKsQU+FKcyxqFzG+FpZDAISTbZSPOPUhyVq6doVgg/lDSZ07lrPM8ReE0GP4vyqsbfJQzLL0VX95bsjrNwWMBKLuBYtR9lRg+zefVH7hsJ5V/UKO8Sb2YuWPp6F17r5tcCAfDv8UIIlrbAR1830QbuAkHxBdrzeu5BzypD5on2HNxMsxwrJEUOiaRxtovHSXTjeebcCWkgdGFJaO81mjyXVKpi89wThZIlV5bzZdJ1GgBnaw3KMMt/wpSpjfZTVBuOuwsEcIuOEh3+90mJ+FSFb+9MQbosoD83b9NfqQjBVXPPkma52ovHPfQFKBkOjCNYa6d3ittpNGN+3dLuiLSFvTESLvG99x8qV03xIEm47Byj3ZH02tr9zlQ3psQ2mQSJ4lFEmZMQxT5J2tVom9TNg1NUif6DatkEXo1GIexIUa3K03qDRgRn1I+oeGfCKqeL3sLRYa5D0uVvbGCbjEIYg6j7f5om2J6N92qYOqYLeX51E2KcWJeWIbK1lL7oqALYa/0YJrelNgNbTABttwG462c brigbENg YpXa0EgGMaPqdV8smNNWmhG3Vx3V/dFCRS/U2I2BQk2tCUSvkyH8gJXG3ouNflZfLQuvDvnkOzqDVdNWbxRXBcc+Vce9sp0+6XKzuVsDILJ+/Fqv2GyxDTq9gNLwkgZQ8bD002oD61RSI4EJSYKpVMOimjOm/jLtMhnH8Lw/ln/G6k1PwJFg17FHBU2LDaSfG/yDXWUca4Hkp2qhVeAc6XVDILiyLX32+RpOOXK+FkRmA4/acFSJbz+mrrrUg5BzE7KCdmMHNC7sLsQNhF6bzN8q0h5KtJaxrVzMNHri3nvFoKR4McIqVL9b19JLaP1vaTAZQh8joF/7sILaDVYuHqWmP1EKdLHsMsFkuQ9tA/QRz7noS5Rl5Ju66OpUkV+bvtlumnYEdW7JIyI5vosmhJv3Ru+k0DwKl/IcGEVu0nxSrpNhDxzzSMmqW8APZh4hQ7rgPFgFJPYqH1yMXJws0RDSS70yKUheBSZAiWOdN/E8+y5um/Xa20kFd3g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 31, 2023 at 11:54:53AM -0400, Steven Rostedt wrote: > On Mon, 31 Jul 2023 15:07:52 +0300 > Dan Carpenter wrote: > > > On Sat, Jul 29, 2023 at 03:55:47PM -0400, Steven Rostedt wrote: > > > > @@ -1761,6 +1761,11 @@ static int parse_pred(const char *str, void *data, > > > > FILTER_PRED_FN_CPUMASK; > > > > } else if (field->filter_type == FILTER_CPU) { > > > > pred->fn_num = FILTER_PRED_FN_CPU_CPUMASK; > > > > + } else if (single) { > > > > + pred->op = pred->op == OP_BAND ? OP_EQ : pred->op; > > > > > > Nit, the above can be written as: > > > > > > pred->op = pret->op != OP_BAND ? : OP_EQ; > > > > > > > Heh. Those are not equivalent. The right way to write this is: > > You mean because of my typo? No, I hadn't seen the s/pred/pret/ typo. Your code does: if (pred->op != OP_BAND) pred->op = true; else pred->op OP_EQ; Realy we should probably trigger a static checker warning any time someone does a compare operations as part of a "x = comparison ?: bar; Years ago, someone asked me to do that with regards to error codes like: return ret < 0 ?: -EINVAL; but I don't remember the results. regards, dan carpenter