Re: [akpm-mm:mm-unstable 272/272] include/linux/stddef.h:8:14: error: called object is not a function or function pointer

[Shivank Garg <shivankg@amd.com>]

On 5/2/2025 4:29 AM, Andrew Morton wrote:
> On Thu, 1 May 2025 22:52:30 +0100 Matthew Wilcox <willy@infradead.org> wrote:
> 
>> On Thu, May 01, 2025 at 02:13:04PM -0700, Andrew Morton wrote:
>>> Should this new JFS migration code be wrapped in #ifdef CONFIG_MIGRATION?
>>
>> Yes
> 
> OK, thanks, I'll try this.  Maybe there's a way to reduce the amount of
> ifdeffing.  Warning, contains bonus whitespace tuneups!
> 
> --- a/fs/jfs/jfs_metapage.c~jfs-implement-migrate_folio-for-jfs_metapage_aops-fix-2
> +++ a/fs/jfs/jfs_metapage.c
> @@ -152,8 +152,10 @@ static inline void dec_io(struct folio *
>  		handler(folio, anchor->status);
>  }
>  
> -static int __metapage_migrate_folio(struct address_space *mapping, struct folio *dst,
> -				    struct folio *src, enum migrate_mode mode)
> +#ifdef CONFIG_MIGRATION
> +static int __metapage_migrate_folio(struct address_space *mapping,
> +				    struct folio *dst, struct folio *src,
> +				    enum migrate_mode mode)
>  {
>  	struct meta_anchor *src_anchor = src->private;
>  	struct metapage *mps[MPS_PER_PAGE] = {0};
> @@ -199,8 +201,10 @@ static int __metapage_migrate_folio(stru
>  
>  	return MIGRATEPAGE_SUCCESS;
>  }
> +#endif	/* CONFIG_MIGRATION */
>  
>  #else
> +
>  static inline struct metapage *folio_to_mp(struct folio *folio, int offset)
>  {
>  	return folio->private;
> @@ -224,8 +228,10 @@ static inline void remove_metapage(struc
>  #define inc_io(folio) do {} while(0)
>  #define dec_io(folio, status, handler) handler(folio, status)
>  
> -static int __metapage_migrate_folio(struct address_space *mapping, struct folio *dst,
> -				    struct folio *src, enum migrate_mode mode)
> +#ifdef CONFIG_MIGRATION
> +static int __metapage_migrate_folio(struct address_space *mapping,
> +				    struct folio *dst, struct folio *src,
> +				    enum migrate_mode mode)
>  {
>  	struct metapage *mp;
>  	int page_offset;
> @@ -249,6 +255,7 @@ static int __metapage_migrate_folio(stru
>  
>  	return MIGRATEPAGE_SUCCESS;
>  }
> +#endif	/* CONFIG_MIGRATION */
>  
>  #endif
>  
> @@ -629,11 +636,13 @@ static bool metapage_release_folio(struc
>  	return ret;
>  }
>  
> +#ifdef CONFIG_MIGRATION
>  /*
>   * metapage_migrate_folio - Migration function for JFS metapages
>   */
> -static int metapage_migrate_folio(struct address_space *mapping, struct folio *dst,
> -				  struct folio *src, enum migrate_mode mode)
> +static int metapage_migrate_folio(struct address_space *mapping,
> +				  struct folio *dst, struct folio *src,
> +				  enum migrate_mode mode)
>  {
>  	int expected_count;
>  
> @@ -646,6 +655,9 @@ static int metapage_migrate_folio(struct
>  		return -EAGAIN;
>  	return __metapage_migrate_folio(mapping, dst, src, mode);
>  }
> +#else
> +#define metapage_migrate_folio NULL
> +#endif	/* CONFIG_MIGRATION */
>  
>  static void metapage_invalidate_folio(struct folio *folio, size_t offset,
>  				    size_t length)
> _
> 

Hi Andrew,

Thank you for addressing the issues with my patch and fixing the errors.
I appreciate the cleanup and the CONFIG_MIGRATION wrapping.

Best regards,
Shivank