From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB179C433ED for ; Wed, 31 Mar 2021 18:45:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5B69461055 for ; Wed, 31 Mar 2021 18:45:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B69461055 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 894F16B007E; Wed, 31 Mar 2021 14:45:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 86BA66B0080; Wed, 31 Mar 2021 14:45:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70C236B0081; Wed, 31 Mar 2021 14:45:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0020.hostedemail.com [216.40.44.20]) by kanga.kvack.org (Postfix) with ESMTP id 55D336B007E for ; Wed, 31 Mar 2021 14:45:26 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0B6E18139 for ; Wed, 31 Mar 2021 18:45:26 +0000 (UTC) X-FDA: 77981047452.31.A9840C1 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf08.hostedemail.com (Postfix) with ESMTP id AF6BA80192D9 for ; Wed, 31 Mar 2021 18:45:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject: Sender:Reply-To:Content-ID:Content-Description; bh=foqFS80zPOxuSFemW+uOI8Rh0rNdKKPnoCESHBhVtec=; b=rLaTSHz/edMFCMAm0d8R9GS5dT mzZd5Z683y2gSfufpO6MSi8aCCn+CslJugFCy+o2M2xLpjzsTc/iXp5FfrOq0vBLlmPi9PjXaIPZr 50eghi+2A+eM6gsSwEfkHDExnMVy8lt5/rqpyUDq2kqL60CZ2uG2VDv1HYJZl6qFyEPhOtGi1vYJU LPDaRgLsffbfSHe+VCeOG+ZCDy51UefrT9MdH5imqG8+HlfOGJh76PvSHRgTZ/RNCw8oiVOQjtfyu 8oth72Zg/wbJvxIE5t9vRKwgIBMLDKjW8QfXralXKcJAWpXjbFfg6iglwgY0i6OagwCVwUULhyPJc +H3vYPJw==; Received: from [2601:1c0:6280:3f0::e0e1] by desiato.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lRfp0-007J0X-Gx; Wed, 31 Mar 2021 18:44:06 +0000 Subject: Re: [RFC v2 01/43] mm: add PKRAM API stubs and Kconfig To: Anthony Yznaga , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: willy@infradead.org, corbet@lwn.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, rppt@kernel.org, akpm@linux-foundation.org, hughd@google.com, ebiederm@xmission.com, keescook@chromium.org, ardb@kernel.org, nivedita@alum.mit.edu, jroedel@suse.de, masahiroy@kernel.org, nathan@kernel.org, terrelln@fb.com, vincenzo.frascino@arm.com, martin.b.radev@gmail.com, andreyknvl@google.com, daniel.kiper@oracle.com, rafael.j.wysocki@intel.com, dan.j.williams@intel.com, Jonathan.Cameron@huawei.com, bhe@redhat.com, rminnich@gmail.com, ashish.kalra@amd.com, guro@fb.com, hannes@cmpxchg.org, mhocko@kernel.org, iamjoonsoo.kim@lge.com, vbabka@suse.cz, alex.shi@linux.alibaba.com, david@redhat.com, richard.weiyang@gmail.com, vdavydov.dev@gmail.com, graf@amazon.com, jason.zeng@intel.com, lei.l.li@intel.com, daniel.m.jordan@oracle.com, steven.sistare@oracle.com, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, kexec@lists.infradead.org References: <1617140178-8773-1-git-send-email-anthony.yznaga@oracle.com> <1617140178-8773-2-git-send-email-anthony.yznaga@oracle.com> From: Randy Dunlap Message-ID: Date: Wed, 31 Mar 2021 11:43:52 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <1617140178-8773-2-git-send-email-anthony.yznaga@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: AF6BA80192D9 X-Stat-Signature: 1gh11paz1qggwmiuofre69agi87hmjbp Received-SPF: none (infradead.org>: No applicable sender policy available) receiver=imf08; identity=mailfrom; envelope-from=""; helo=desiato.infradead.org; client-ip=90.155.92.199 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617216323-45236 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/30/21 2:35 PM, Anthony Yznaga wrote: > Preserved-across-kexec memory or PKRAM is a method for saving memory > pages of the currently executing kernel and restoring them after kexec > boot into a new one. This can be utilized for preserving guest VM state, > large in-memory databases, process memory, etc. across reboot. While > DRAM-as-PMEM or actual persistent memory could be used to accomplish > these things, PKRAM provides the latency of DRAM with the flexibility > of dynamically determining the amount of memory to preserve. > ... > > Originally-by: Vladimir Davydov > Signed-off-by: Anthony Yznaga > --- > include/linux/pkram.h | 47 +++++++++++++ > mm/Kconfig | 9 +++ > mm/Makefile | 1 + > mm/pkram.c | 179 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 236 insertions(+) > create mode 100644 include/linux/pkram.h > create mode 100644 mm/pkram.c > > diff --git a/mm/pkram.c b/mm/pkram.c > new file mode 100644 > index 000000000000..59e4661b2fb7 > --- /dev/null > +++ b/mm/pkram.c > @@ -0,0 +1,179 @@ > +// SPDX-License-Identifier: GPL-2.0 > +#include > +#include > +#include > +#include > +#include > +#include > + Hi, There are several doc blocks that begin with "/**" but that are not in kernel-doc format (/** means kernel-doc format when inside the kernel source tree). Please either change those to "/*" or convert them to kernel-doc format. The latter is preferable for exported interfaces. > +/** > + * Create a preserved memory node with name @name and initialize stream @ps > + * for saving data to it. > + * > + * @gfp_mask specifies the memory allocation mask to be used when saving data. > + * > + * Returns 0 on success, -errno on failure. > + * > + * After the save has finished, pkram_finish_save() (or pkram_discard_save() in > + * case of failure) is to be called. > + */ b) from patch 00/43: documentation/core-api/xarray.rst | 8 + How did "documentation" become lower case (instead of Documentation)? thanks. -- ~Randy