From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94A93C83F10 for ; Sun, 27 Aug 2023 09:22:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DD20900004; Sun, 27 Aug 2023 05:22:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 18DF1900002; Sun, 27 Aug 2023 05:22:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07D27900004; Sun, 27 Aug 2023 05:22:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EC935900002 for ; Sun, 27 Aug 2023 05:22:55 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BC467140185 for ; Sun, 27 Aug 2023 09:22:55 +0000 (UTC) X-FDA: 81169345110.12.0914FAF Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by imf11.hostedemail.com (Postfix) with ESMTP id E856640002 for ; Sun, 27 Aug 2023 09:22:53 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=TRDcu2p6; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693128174; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qNhqWs/d0zkyUeFSgfgWVmmoGxegzXBKnT08Gh1c21U=; b=w+5BFP+6KO52cTIpofrTEWUkDPwgA6ZIIQZN+DTxzMbNq24iFVZWBOFD/DNtq5N3oJD4d4 C8g8EQuqwDOzeDzGsPPD8zEl1hPAxKR2a/MHs3AFfjEr98OBny84xyvOP225pIaInwnrCq gkhCt4w3jssVJOCcNu8ki/xWnS9n4oY= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=TRDcu2p6; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693128174; a=rsa-sha256; cv=none; b=ecjD4d1oWIgpSdZGK5VPadsubuLRFw2nBiEyYOr+cwa4MQ/LiwjQ0hfnLV3LL5NTx+KwJp IEtn3cQItJA9NDO1VHAL76yjWcM8s4WbCrSr3msHcaz92oNWqOxC5Mh9qzOJMU4B82fhz7 ewzzgeF+Ok0HJlgI6qJBncE3FHuxrfQ= Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2bceca8a41aso33409351fa.0 for ; Sun, 27 Aug 2023 02:22:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693128172; x=1693732972; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qNhqWs/d0zkyUeFSgfgWVmmoGxegzXBKnT08Gh1c21U=; b=TRDcu2p6lschq1Tr9TYlFU3kqmn4ckpf4LNGfD0jskd8xacu5jBlJ+sbTrzYJQ7RJT J2LW5SvXE0C6PMS8Wwfh7Q/Cf/hdapvji53XkkAlkeHIUVSAMlBONfkvjBJ0gg9jkA+6 5W8xt9C1PZ7BRkU2pFkHP+d7e0oceBP/GzwxF2apDsZ1vVnZIy+skBfxDEhp5xarqBfJ YVw0Gaf8RZtwNlfz8IHue7LsbDXXTjymWRp3xXtfVoDTb+igvJhGIEwPgDu92DQk/9c+ tFiTNl8GfhSbmdG2NbpR1wZH8e5OCwcSAmSrxvupqcrK4OxgUvVPQcRoRvgy9RhAJ09f 2qgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693128172; x=1693732972; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qNhqWs/d0zkyUeFSgfgWVmmoGxegzXBKnT08Gh1c21U=; b=Oa1Q07RbyeOqT1jy7YDkuD+TOIGHNPgZo4HMAe1UP6CjfCTV6+m4j36ffr9V9NZYOa 7FO9SFkinoJu2RJYYe96e2G14lXpbNnAqbMGejtxqPgjGNqlTDVhB2Ik8w5eRE3ksdhL bzCHh3o6bG8dloVGNB+N7ZgclCKVw2h7ESN14G/+nOlvGy+/AW8TaRKaOy5AUkaDcSsS ghxGybg08543GoF64vGurYpGB4QbJi1oOw2umO1fas8+9/VaYMxG3tq7NY/3MZOEKGRZ haR0Gbrgj19+f6HMbR2eRsLKwufXE3yjPC2+wAPorfddSEbzxqz7QOM0OfBHt2CIEN7e mjZg== X-Gm-Message-State: AOJu0Yw377blQXDygbQTibnZrnnreBY6ywFs+4+PXhP04wZ3jNmDyD6R Ed9Kg+lLtYLlTA+aGMrVeCo= X-Google-Smtp-Source: AGHT+IHA9IBI45SyYxSnIrWkF9Z0Z+HdS3NdyqFb7QvWI1T4E18iK8P2Qo8KEi8w/Y/UINyHKwJLQQ== X-Received: by 2002:a2e:a201:0:b0:2b5:9d78:213e with SMTP id h1-20020a2ea201000000b002b59d78213emr16430998ljm.22.1693128171815; Sun, 27 Aug 2023 02:22:51 -0700 (PDT) Received: from localhost ([2a00:23c5:dc8c:8701:1663:9a35:5a7b:1d76]) by smtp.gmail.com with ESMTPSA id y1-20020adff6c1000000b00317e77106dbsm7013798wrp.48.2023.08.27.02.22.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Aug 2023 02:22:50 -0700 (PDT) Date: Sun, 27 Aug 2023 10:22:50 +0100 From: Lorenzo Stoakes To: "Joel Fernandes (Google)" Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, Shuah Khan , Vlastimil Babka , Michal Hocko , Linus Torvalds , Kirill A Shutemov , "Liam R. Howlett" , "Paul E. McKenney" , Suren Baghdasaryan , Kalesh Singh , Lokesh Gidra Subject: Re: [PATCH v5 3/7] selftests: mm: Fix failure case when new remap region was not found Message-ID: References: <20230822015501.791637-1-joel@joelfernandes.org> <20230822015501.791637-4-joel@joelfernandes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230822015501.791637-4-joel@joelfernandes.org> X-Rspamd-Queue-Id: E856640002 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: sx6i3cwjicu8guybfbgg5o6tqhpun1ej X-HE-Tag: 1693128173-990599 X-HE-Meta: U2FsdGVkX19slWjOdZypexLzprxUXcdz9xrLOXdTu25MsXxys1LRCpyZ5wqcBKI93SEfHBEwayyaFJI3OXPBqjOlMMB3bLDpO4mHPErzSBhwV6a183Ybf2Jg3b+4Wrk0ZRNrEeADM06e3lcTkospXyin/hVioeXutBkCu7yd+ENEjRr0RvNgaQE7iXSE108jgcXluLVNb5+TfJyaFe0fzqHXHmVl3BzZczbl1EmF4k6rbGrIAOkXotE/GsRkdbZFmdEedEnND4mxq6IUWGUW9C0LucDnPt5vJG8MosiZ1jdDd2KB5LFqTnNcbc85AuxGk1reJXZrjJLeZs5FDCQ+qhFRyAXf7eK8UqMJ49jmnsT4bDyreu/DuvtJW5O7woQ0BILsmG1G5/cu1YlQnAU6I8ec66hvAv6YNxRhIACxtKl6HzBM8zyvXlNyRTb0A2EDBHYdz3IxFrN8Wj894Q6sYQnjom9QO3v4Hs/2RWp2AcUDifWSfg/QCzIeQhSChyXby2LJpMssDpOFyzuKkRf7UVuc4XgJuNR3LNz02SuIQfH5gYVJr3V3Rou+Xpp7r1qSQjav5csSMKjAa0JEOKD2IDguCf23y7lBKK5qpk3wdkyLpS5qaQz/YAvBz7AoNiwnY4MipCno3oO4dzmDe8YhqMVHdPC63RMbF/gcFn8V/UxV2NAK5T2ATT+fTYBOZ3LRcp5zoI0REKoZjjOAF7tXXnS/S6QaLrew1cE0ZqhTSw7hS1D8aC4hJggTTfpIbfhIsmzUj5RuyOAKmPQDbe6RPMtUdg8iF0y4IAkxWpQtaUEmBKdMrohSi0j5wEZGNEtJDKx5uEdy8fDAY/vXrVGpgRiGZJNSMoJKlF+C9HBLEaiSmVsJ3SXy78oXB26nErT+3dv2r3ZueQ6SsxU6DOhhfyhDcAQS04hpEaS/fHZxgd29PnDeQ+3gASWdSSEk3jRDs9nKeBNUdfd4Xm5ciS9 k3xkrGgH U+kjuCZ9hVpq7/axp+ucOZ7dAHEz02d1wdydD9rqQbZThd6+WKihdEmcWSMgsWvudJYLE6Hdr25ZYZwgsfGjcoU7IpyqP2shK7ZEHlWWDuzmqJPm0jHoBW3Knj0TR/p0Qe97KkC1u8fuvyWgdUO4S6Cr+gmhB+93zWku0YcE68qtKvXdW+WHp40S6Qwe93V/4ddW7FIYdM9BkRtUvBOBrJ32QtG370ZzNSIC13eMQl8p5tv7pRgNYAcB2ErFm2Tn9fEEIz+VGl2ioQ6VMNR+quH2AW0E4WNmUWXt8bj4jpyJN8bIcoMV7hAfuyL8kh5Rzr/ivYy/5qbTOL+ZB/JbD+NKnEjbC6Diu/qd+R4y3ukD3VwHEO6QLAyyK/YxKeixSH6DRUUSlVX7nbAXmeVT+RDxyp7DvBgBWNhzK2NnthsJ5iOS06NFtdtBTmdC1JLoYYhWOmZK+3vFIfpY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 22, 2023 at 01:54:56AM +0000, Joel Fernandes (Google) wrote: > When a valid remap region could not be found, the source mapping is not > cleaned up. Fix the goto statement such that the clean up happens. > > Signed-off-by: Joel Fernandes (Google) > --- > tools/testing/selftests/mm/mremap_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/mremap_test.c b/tools/testing/selftests/mm/mremap_test.c > index 5c3773de9f0f..6822d657f589 100644 > --- a/tools/testing/selftests/mm/mremap_test.c > +++ b/tools/testing/selftests/mm/mremap_test.c > @@ -316,7 +316,7 @@ static long long remap_region(struct config c, unsigned int threshold_mb, > if (addr + c.dest_alignment < addr) { > ksft_print_msg("Couldn't find a valid region to remap to\n"); > ret = -1; > - goto out; > + goto clean_up_src; > } > addr += c.dest_alignment; > } > -- > 2.42.0.rc1.204.g551eb34607-goog > Nice spot! Reviewed-by: Lorenzo Stoakes