From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51C99C433F5 for ; Tue, 11 Oct 2022 17:15:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA27F6B0071; Tue, 11 Oct 2022 13:15:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D52446B0073; Tue, 11 Oct 2022 13:15:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1AEF6B0074; Tue, 11 Oct 2022 13:15:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id ACD146B0071 for ; Tue, 11 Oct 2022 13:15:04 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7AEAC16033C for ; Tue, 11 Oct 2022 17:15:04 +0000 (UTC) X-FDA: 80009318928.21.2E59393 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 16DA618002F for ; Tue, 11 Oct 2022 17:15:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665508503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MnvCQgz6H0YpLOGZ3RFU26i2x7EAPQhf8onHHyzectI=; b=MLcTwYn0oVz32PF5S4bbM+L+nQCVLFBAV0TApsL0xkhLHXNG2wzPMJi5Uj9hhGG+tOJi/F wCnXaNM48rzmJRW5Y+LH9Zq8SPrupMBv/X3uHaWd7rq+wyA+3rxf1341FgQweUBEEUhLRW 4W/PWDBGpLp/E4OdZos83RvhZwB7qpE= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-168-fhvcurG1PIO_86zyIJwZNw-1; Tue, 11 Oct 2022 13:15:00 -0400 X-MC-Unique: fhvcurG1PIO_86zyIJwZNw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 41E6F38041CC; Tue, 11 Oct 2022 17:15:00 +0000 (UTC) Received: from [10.22.17.56] (unknown [10.22.17.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6D1F740E992A; Tue, 11 Oct 2022 17:14:59 +0000 (UTC) Message-ID: Date: Tue, 11 Oct 2022 13:14:59 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] mm/memcontrol: Don't increase effective low/min if no protection needed Content-Language: en-US To: Tejun Heo Cc: Michal Hocko , Johannes Weiner , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Chris Down References: <20221011143015.1152968-1-longman@redhat.com> From: Waiman Long In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665508504; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MnvCQgz6H0YpLOGZ3RFU26i2x7EAPQhf8onHHyzectI=; b=b5vLS/NNPTJN5sEK8ikQJNFJ5AVTJheGnJ11ok3f0hlZPTCK4ThohrFfewiYYRa04NhrnQ OdzNlndxICVeq1IjI86N+jd37e4QEUu0kfapGnHmfPkS0iXVglLiE2zJHnZHEsnCE9fg4f v2VY7UBYLKvmd+rzupq7c3bQwb6NyqY= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MLcTwYn0; spf=pass (imf24.hostedemail.com: domain of longman@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=longman@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665508504; a=rsa-sha256; cv=none; b=h0pRi7+Hqsg6LniR/CEUYglRChEGXgkVPp+WnMGlo0VVFQBUZpvzK3xNJGbhpOVvTgzKgx h2XVde1c3qKAWD17stM9EEMc3M2j4RC3ZtqOppou0zTeO9dPpZc4anotvmlmcxg7FY/Jp0 8J8EvOJx1hySZcncXkkdMjwd8G5sX0w= X-Stat-Signature: wxr5r4c6yhcot58ji6f9t5to1pr3sorp X-Rspamd-Queue-Id: 16DA618002F Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MLcTwYn0; spf=pass (imf24.hostedemail.com: domain of longman@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=longman@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1665508503-867270 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/11/22 13:04, Tejun Heo wrote: > On Tue, Oct 11, 2022 at 01:00:22PM -0400, Waiman Long wrote: >> You are right about that. An alternative way to address this issue is to >> disable memory low event when memory.low isn't set. An user who want to >> track memory.low event has to set it to a non-zero value. Would that be >> acceptable? > Wouldn't it make sense to fix the test? With recursive_prot on, the cgroup > actually is under low protection and it seems like the correct behavior is > to report the low events accordingly. Yes, that is another possible way of looking at that problem. Will talk to our QE people of doing that. Thanks, Longman