From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08E70E77180 for ; Tue, 10 Dec 2024 11:35:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B4656B018A; Tue, 10 Dec 2024 06:35:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6642F6B018B; Tue, 10 Dec 2024 06:35:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 552B76B018C; Tue, 10 Dec 2024 06:35:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 376B26B018A for ; Tue, 10 Dec 2024 06:35:57 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CB9411C72C6 for ; Tue, 10 Dec 2024 11:35:56 +0000 (UTC) X-FDA: 82878844482.12.270B607 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf02.hostedemail.com (Postfix) with ESMTP id D3B3A8000F for ; Tue, 10 Dec 2024 11:35:08 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of chenridong@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=chenridong@huaweicloud.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733830534; a=rsa-sha256; cv=none; b=8dwfy+iLXwPAjFm9L5SGFDr+4EDslx2ZCavm1VW/VHdyNbeOgkljed5e87SzG+QUc9Od0L FxL5ntPOI3qL3Xit47t3P/63v08Y0nD7zMdQDb2gbTkJ03XLrkzVK5agBepzQJwp5q96cX bptE2CwuKme11+8rGAWxfVhRF05VudE= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of chenridong@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=chenridong@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733830534; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zg4+H/5F9eHhMuDqeTDYD4ViSPhXqsHmzLjodc/AAn0=; b=Ap0hK6+UH55l5KCMXt6OuB6DMbJFrdxDZCaFhVpac99F312B5ASUZYWdUp6M2Tp/e7OI7i 3RuWnLTX+5OaQGp0UJfqj7JPi1vlXZ5bhDj9kR76edTnnQNO3p13YurG/GbwDS5jlWd0mE 7VVvY6ny8eOk/4+jcHm+PJ7iLxjEDXg= Received: from mail.maildlp.com (unknown [172.19.93.142]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4Y6xVq1ZqFz4f3kjw for ; Tue, 10 Dec 2024 19:35:31 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.75]) by mail.maildlp.com (Postfix) with ESMTP id 6D9BB1A018D for ; Tue, 10 Dec 2024 19:35:45 +0800 (CST) Received: from [10.67.109.79] (unknown [10.67.109.79]) by APP2 (Coremail) with SMTP id Syh0CgC3Y+CPJ1hnBTauEA--.27259S2; Tue, 10 Dec 2024 19:35:45 +0800 (CST) Message-ID: Date: Tue, 10 Dec 2024 19:35:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [next -v1 3/5] memcg: simplify the mem_cgroup_update_lru_size function To: Shakeel Butt , Hugh Dickins Cc: Yu Zhao , akpm@linux-foundation.org, mhocko@kernel.org, hannes@cmpxchg.org, yosryahmed@google.com, roman.gushchin@linux.dev, muchun.song@linux.dev, davidf@vimeo.com, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, chenridong@huawei.com, wangweiyang2@huawei.com References: <20241206013512.2883617-1-chenridong@huaweicloud.com> <20241206013512.2883617-4-chenridong@huaweicloud.com> <897b04c9-dba3-44ae-8113-145ca3457cb3@huaweicloud.com> Content-Language: en-US From: Chen Ridong In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CM-TRANSID:Syh0CgC3Y+CPJ1hnBTauEA--.27259S2 X-Coremail-Antispam: 1UD129KBjvdXoWrZw1DZr43ZF4xJF4rZw4DCFg_yoWxtFb_Wr ZYqFsrKwsxXanrZw4kKrnY9rWkXw4jvFnrAry0qFsrZr13CF4DGFWDGr4xZrZ8KF4vkF13 AFWrJwsI9wnrCjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb4AYFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwV A0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW8JVW5JwA2z4x0Y4vE2Ix0cI8IcVCY1x02 67AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267 AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80 ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4 AY6r1j6r4UM4x0Y48IcVAKI48JM4IIrI8v6xkF7I0E8cxan2IY04v7MxkF7I0En4kS14v2 6r1q6r43MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrV AFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVW8ZVWrXwCI c40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267 AKxVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_ Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU17KsU UUUUU== X-CM-SenderInfo: hfkh02xlgr0w46kxt4xhlfz01xgou0bp/ X-Rspamd-Queue-Id: D3B3A8000F X-Stat-Signature: w61dzc9y1cp6aqeqzh5ixqmjpe1yhcq5 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1733830508-651491 X-HE-Meta: U2FsdGVkX1/s126jG8dF9SQU6Ncjue7sy97Wq0Em2QclIjsInuzO31N+na+ynY0m1Av6SGKBg2GXtagYfJRHsujW6qRB5zKx/80yUm1S8TpE/vM/csoc0TQNfzVk9S1b6wj+LxK+aVkZsv5jLWQEJygsU12wxqSftNfueALWVxfXbfjfXFkX7Y89W89cQQjAlOwQWyW2GwIJbt26ohQy/SPZ4mTx1HFnDbUBhPBviLHAuFfxtXS4VKyHYvFK/AZvD1XVRBuNahBqtIh6yXT1MoV1ifW/E0JgGVkmHK0hj7z6IbtKiJums+1rT+ZgeFMGbEm5/JKlafU9gu4ohn8ybkybL5wQxcfm9m6g4JOIxYavlbuQw9tteC358goCwk/0i8LGL8/ljkR4eOqxuFQin8fBRxRdeT03l8JXsV9hiS8N22RX1az0RVjgk1bZGoWbqEZ9mwfLQbjnBScWArGB8eMb+pnYEIiEuR+sjzVcHYLpluxYYt22OVaoC1s+OZeOQyzGZrk6TwJqT9TGBkz5a21pDFv4fuYbxntWgvLsd2LVCZqloxbDRCc88CXYRVruLy3uscDvLdJ/ZXusCcwnPv6jm4c5TawTbPpqGcsccTt+uulXhvWCGdFPSnwBWdSkC3WbMrzIxLtLf4tjsdGpLsukpeok/D0IiT5ICBh9usm0QtXevxhfB925JeChZiMLrmD0SnMJnqb5/v13YzZjxmtPxvAofQV1OjLZY5nKo15rMvSMA4mamUvt0KfwLR6YBKpy2WcNnQTZ/S5YP1ZMcSOCVPtPm60nGra3qfYdDBDElXh00YqBFauHg5r1Vl3bhnkiPgSnQrLY/2HeiQG0RaYIqdT35pHvPJROq4h/5z1DVKwbJfhsnXV+JdNFAYz6xiQqcAtxGhz3fCxBA70F1KvzeCPJrrQOthVHfWsrW2PINi0qG1327SMUwl0qPhEr49h6UD2ebmgbUz9RaMQ 1c/J7I05 e3bwZC9Tf0n4cZMfDveRFeCvxc+8r35jjp8F+wJtMABNgq3JyGS0LRAmK8aOWz+H+j213CxBeIOvlJykdSSHVlCWm/vBAP4oMJtYIGwFo9hpEcQCba1WtJea0UZGHpZZu+aZ13WNFrcDIwOTk4lsLg3sBALd/nPcvaH2BUsKQHFaZZpZI2JlTsU+EMEoDIII2OeL0kb9/rCL3WTU1m4M937STnA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/12/7 5:20, Shakeel Butt wrote: > On Fri, Dec 06, 2024 at 12:24:54AM -0800, Hugh Dickins wrote: > [...] >> Another thing to understand: it's called before adding folio to list, >> but after removing folio from list: when it can usefully compare whether >> the emptiness of the list correctly matches lru_size 0. > > I think one source of confusion might be that this "emptiness" check has > been removed by commit b4536f0c829c because of maintaining the list size > per-zone and actual list is shared between zones of a node. > Agree. Maybe it doesn't have to distinguish between "size > 0" and "size < 0" now? Thanks, Ridong >> It cannot do so >> when adding if you "simplify" it in the way that you did. >>