From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52D08E7D249 for ; Tue, 26 Sep 2023 07:49:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8A708D0072; Tue, 26 Sep 2023 03:49:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C3AE88D0005; Tue, 26 Sep 2023 03:49:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B028A8D0072; Tue, 26 Sep 2023 03:49:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 92C478D0005 for ; Tue, 26 Sep 2023 03:49:27 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 54FCFA0845 for ; Tue, 26 Sep 2023 07:49:27 +0000 (UTC) X-FDA: 81277973574.16.D5594DE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 2EA45140006 for ; Tue, 26 Sep 2023 07:49:25 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BM5xbB5J; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695714565; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TYUMFabCqShOqg91SXlnQ/MBxB7SPueU7zs/KEePW1U=; b=Y9dnU4zUbqFgF6YC4uGBmG7/KAMQ3sKpZ/rviiLdS1JSjskibIBZXqEA09uN+IdV8FQfyB Vq/nqVdpUOr0HVkQOgET6Z1z/+Dk4h74LNBscsEKWzCyCrR75kcq0TGLqESFb8DHBOgTBx LxNb3wwwoVkUcRObZaVUpVo6A8S/9h0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695714565; a=rsa-sha256; cv=none; b=pBH9H6CMd10lhXg1KSyc1v0jK58wGkOxepSmA8bFxyZ7C/m6tEFNwT1jxGBkW6kZgDD0on d8Ug0fThp/iPSnQoqN0uhbD9czcG+DzDHVhWDHlKmFeLfuNijY2aQBkRhfRQguGxnOlsW7 YLIa0fEAkpH1dalz+Uqb1UnDQUCPWJ8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BM5xbB5J; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695714564; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TYUMFabCqShOqg91SXlnQ/MBxB7SPueU7zs/KEePW1U=; b=BM5xbB5J6Dsow/SQ/15oYVbFiKXXPTeuIzSDy1k+4NBCZ75iRxsXTVFKj9BCg8QJ6VoAWl GfnpsBVmHhT32rdn2fclGOfaRA8zcu4rXS8Q2G7AYjH/NWFPwHYZlcLN3o7CzoBU0Mjt3s FQPVPCPqRGyiH6XWexElq1DITWBcGyY= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-610-SEDp6VVFODeEwQaDxRUyKw-1; Tue, 26 Sep 2023 03:49:19 -0400 X-MC-Unique: SEDp6VVFODeEwQaDxRUyKw-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-323334992fbso1328960f8f.1 for ; Tue, 26 Sep 2023 00:49:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695714558; x=1696319358; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TYUMFabCqShOqg91SXlnQ/MBxB7SPueU7zs/KEePW1U=; b=iOBHosbY15uuiZzvvqIn4ruxJ/8NwfQcYoaYL1eKIVn3Pm9fz40KrnIrjd/6c+jaXZ mMONrg/7D22u/WLo/Oz4nEnAOu7cY3y2l/0tq210BrVefhbnKMLDQdVZd803X5GLkXUo NuMNL1MJXF+CK/FLHcLPC+VU0rRQlYCs2Qv3dgExvE/88WwBe3vtHK4rkZ3fkLN0WZxA CWTDSHd8E/WWRXWaZOwcwdK1cNhpmjuhO8OvJktGiY8rSPCL3ZTCSzbGiFtu9IIyPQqg KDobMm2D6+Nv3rDkLR244mZJ34eX72bQ2IkNLas/wX0Bk4K+xumQdslEN+Yr1bcsQ+HZ KZYA== X-Gm-Message-State: AOJu0YzD3VIaV+6TsRzOqP98omD82zfsCkbxEwzJGEURYdz7TgT/SGSD kCNx8ZJ2mEHLJOxx1j1bKbjSF8+2LdwV+wc4eKyDHijdkHRgTtYTIx/SXG4tLKtN6dSKCb/KefQ rK+dvDEY20u4= X-Received: by 2002:adf:cd81:0:b0:319:755c:3c1e with SMTP id q1-20020adfcd81000000b00319755c3c1emr8170019wrj.11.1695714558557; Tue, 26 Sep 2023 00:49:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGExJDSP5L0Rs54wrMlcjvXXpaJBWHcVuvht4vXnT5kqrem65CKuIyx4A5vO7PM+ZqBaoWCdQ== X-Received: by 2002:adf:cd81:0:b0:319:755c:3c1e with SMTP id q1-20020adfcd81000000b00319755c3c1emr8170001wrj.11.1695714558169; Tue, 26 Sep 2023 00:49:18 -0700 (PDT) Received: from ?IPV6:2003:cb:c73f:600:933b:ca69:5a80:230d? (p200300cbc73f0600933bca695a80230d.dip0.t-ipconnect.de. [2003:cb:c73f:600:933b:ca69:5a80:230d]) by smtp.gmail.com with ESMTPSA id z9-20020a05600c114900b004058e6379d8sm5661368wmz.23.2023.09.26.00.49.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Sep 2023 00:49:17 -0700 (PDT) Message-ID: Date: Tue, 26 Sep 2023 09:49:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH -next 8/9] mm: page_alloc: use a folio in free_pages_prepare() To: Kefeng Wang , Andrew Morton Cc: Mike Rapoport , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ying.huang@intel.com, Zi Yan References: <20230926005254.2861577-1-wangkefeng.wang@huawei.com> <20230926005254.2861577-9-wangkefeng.wang@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230926005254.2861577-9-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: ksoowkcbnjkdgqnb5cuhw51dcxcr9a1s X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 2EA45140006 X-Rspam-User: X-HE-Tag: 1695714565-652502 X-HE-Meta: U2FsdGVkX19VKBVQFO+3NWpFPyw4E4rIov/CEUX8wOTIUGYQYStVUoygh6dt6M09lR0Nj8mMO06FH9h0ZITheGsgOkWhWOmkZndKxU7kG+s0I+Go7sNx4zisXWY3jnsA4wXgigUaJgu3pOiklKGYY6vtCAsu9uY6xnjJTBp7gCp01Mu/G9XPvy9HLGaDAX9aNivCONA3feXUiu+NdLfmE8tpcMSb5H9qjn5i/uUpLLwBKvhJAXzQ9GXq6bI2ktTgNhyH2rWGhRYLpn0YiWO4f+gm6HzVph37zaj3DrhcTqXgc/5fFyRkdfXT4i+hPNYE1bv2JlEdHw3gT3qsiweJva2RD59zt8EL2raXBMSyvMlNNpD+jKvTN1jdKMOi1MpZkvPAA1xq76v0YoTCE5WVcbxNK5kgeg6+9jfWD2za4l12U0wBeKwRc51IjuI6hVSQBCvnrzAVfVcGeqWAhTyjp+bb1UT4QQQfLZAgvzYUxFCjDZc01xJNA9Zdwpyc/u5Do02IDSYaeahSl0eHXXAfAyfYD4GmmmtUQ+jGTZhKJ0Y023XlVwbt0vA3RydzxR3Ol8N/IwurlnS/lMnYdtxZO6aW1azmJPcs+O1hpuBQkqccBFhBu8ZYDKhBJmIwVdg7E1RXdm4rsmmhnVMeIDzU6AT7zyOWVv/I/93mamGDy/SRqNSYaGkQgGFsOTYE0P/nQyvJQTRm9hV3X1Uv9Dw9QmyGp0mrqyX4TXbnviNX8P5+ZOs6s6EFm44WO4ngooGqxr/hQOsOXsdXbXqlOghlIQGb/nvbHqTsyyFJtno8CdGHkk+alF5KhXZdXwSOY5aWVmUXu3sJrIOUdZlHoE/ONT62Egq/U3FjZzG95ssIZZjs7dWgBgW75e9oCrPazm/XelxRaLbvFM8CvtoK+Dzu7fxHzi6QXkqwFhDttrv0ZSw65429DR3Z6ZFRYbDUYKb9QgPMuORklT+AJei3FPw Cjq3p4Pf jWihhKG1mgGCcsmZYxen3zd/9jebmP2dql5FpsvDwA68duEsDeUC8/1ehLMcoZbGSBRQNouyvydkxxZ6KHhHBqgdlUAosNkXEvln45EsoAD1OlICC5/5r/0mC0pmtQbEISARsC3A8Q5TFj06MQoXYrSu1T+RG5gOuy6tBuqKIzs0kyGLcuQRX7pPzy70gZIpFTrbkoqNXb4vPNSlsE/wJBR+DWYoEktygyUDH57E1ygwK4fWGY5MQMSa4+5vwcJ+y1uXWNNiAWzj/J84l23yqhte57ouzO0px+ithFNppsWv9kfcZu/1ky0SaVsQIlBsXik6dE7vWsZp3VcP8Nlv2i8/Ox6jSuDGDSMl1R+5IxI4MMX47LlzIu+vd3ltj9VMQDvibR/1xHHN5ZxT3nk8mIZwqEbyLWKxnOR+6pasMBP2ZsIeor9Twnbknxr2a5YrswJx5EfmHPTbzJ0M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 26.09.23 02:52, Kefeng Wang wrote: > The page should not a tail page in free_pages_prepare(), let's use > a folio in free_pages_prepare() to save several compound_head() calls. > > Signed-off-by: Kefeng Wang > --- > mm/page_alloc.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 06be8821d833..a888b9d57751 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1070,6 +1070,7 @@ static __always_inline bool free_pages_prepare(struct page *page, > unsigned int order, fpi_t fpi_flags) > { > int bad = 0; > + struct folio *folio = page_folio(page); We might have higher-order pages here that are not folios (not compound pages). It looks a bit like this function really shouldn't be working with folios in the generic way, for that reason. Wrong level of abstraction in that function. What am I missing? -- Cheers, David / dhildenb