From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66012D78780 for ; Thu, 21 Nov 2024 15:37:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF8A76B0089; Thu, 21 Nov 2024 10:37:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EA6F66B008A; Thu, 21 Nov 2024 10:37:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF9B16B008C; Thu, 21 Nov 2024 10:37:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id ABD856B0089 for ; Thu, 21 Nov 2024 10:37:32 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6298B1C70AE for ; Thu, 21 Nov 2024 15:37:32 +0000 (UTC) X-FDA: 82810506240.29.9824F4C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id CF9B414000B for ; Thu, 21 Nov 2024 15:36:49 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="G0d5vox/"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732203357; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eS7bGCy5YRnQF1VVX3hqmSIuG3NddVnWmPFA2i7JUNM=; b=DVte7ypg1V/heAPuF5Gci/WUQeuUp1tpQOyQAPLvfiqVsPKMOMMtqq0MmVykUaX666hi21 k/HSK7CcSpvR+M+rHxn6Ph/JCk+/wa34iPEeWpindlkLb0rrvHAQaMJJDuGynDek8dKsj/ 1SIxhim6FUHUuPG6gJLbmTkGIAki0C8= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="G0d5vox/"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732203357; a=rsa-sha256; cv=none; b=cx8zEquTtrv1pQgt5X1zW1UrXAlLW1nn8WZHKFnNAGW3Nmncme8mFZ9gz8/ev9lyaj2q4C NlkthEH6+9IqJqh3e+Ei01/Qut0XmepkTfGm+NC/6Aaa/F7hn2FbwUqKRuhc01unmpc2uo QnUIXivJXT0j8VFy7YqXLBtZMIk0F00= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732203449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eS7bGCy5YRnQF1VVX3hqmSIuG3NddVnWmPFA2i7JUNM=; b=G0d5vox/YZvI4HoyhYRlGw5JFjVU8p/iiFKFG+LN4+CkSkNYDUIK29YDqJz6CRRuvhHEB+ pW5qrwTOKFaMQNzM2rsLjXldVjVFzAcvMt64hW8tqlP7G/bc4Exp894XgDQGweSXWpioKt z1CqnYTkbxfolnnyinzyUeIk6CBqTwU= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-228-wqttq-wPNvOYLZIkl1b06Q-1; Thu, 21 Nov 2024 10:37:27 -0500 X-MC-Unique: wqttq-wPNvOYLZIkl1b06Q-1 X-Mimecast-MFC-AGG-ID: wqttq-wPNvOYLZIkl1b06Q Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43159c07193so9418375e9.0 for ; Thu, 21 Nov 2024 07:37:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732203445; x=1732808245; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=eS7bGCy5YRnQF1VVX3hqmSIuG3NddVnWmPFA2i7JUNM=; b=Nzn5cLZ9xGUWhaDuCj2U3rOARuysV10m1nHFef3xjn3aCzrMEhbw1fZv6HbXLbcwiu 24P0nrDfiFnTp7cFQz1g7Cm4MsYRgEad7LLoKA3bVIU6xmXGj+JYzEFnSf/wv7xM1Nb9 72jkT4l8Oa3bFpHYRzCX3cEYrvGbgvfHsiEMtsZBFvavkl5rNlr8b08B94mhNRdPIhw9 Abk887vGTErjxFPGoLymZUVIIsYCBccEBS37HYHmU98Q3+6OCzPm/NdghEXiqXlYmXjp 6h6g/JV+ppfRq85n6h/5rZSlqAwWk8VT6QuM7hGRowCWVfsEd4FR8JfE/EVNAjJ0vqog NJFA== X-Forwarded-Encrypted: i=1; AJvYcCVK7dDdCq/Nn8ujsC659nDaastrNq03y8yO7qSWgFi4pp5mw0f5WTDSQN0kIiHWT2LotOOvHeHhlA==@kvack.org X-Gm-Message-State: AOJu0YxOEsAqHzRv6VTf9zN0Qr5vQpehc6g4geTxROXvHRW6Ilr+IlS4 Qrhda05XsSK5/4bw+Pis4g/0ech4N+aUDZMjBvVdcUKlbhRWVTlmUuo9cLkJRe2PexEsvSpP9I2 qDj8JXKiDrZgmtiTNMlzRd9BdgNJZuKvxcCCzbE4bWpprS8wI X-Gm-Gg: ASbGncuYN0uu89WF79fDSE/ujYsSXHDMqvZ0iz51M7deicrGrGtBkFhhFm8Jn8OGe8K Wj86nX9AJ01OKiDmWbIRXXmgBTBjS79aDzS4U9/fiauPlc0DGaVtdwAXdWlcN+NvKQ2xRU8MEsr z38mHwtunMoO5DtxLXrTlJXbeZGYo857SJOmf5UzqAcGwQgxaLcPRG2Q3LdHcDteEqt6uw6nqZh LuRypJzS5LwKd2HOIahH2ZAjmrRh4jS+/Mhdp7cX1MUBduQ0YSgPFwllNeaH9HAkRM1n7FJm7pY qhfx81PxiWE5BYEtGeJDhjXekROhZwTnSRO43WAq5dBWjQlM6GCp9pCB0mlDotlTfhKewbqP6qI = X-Received: by 2002:a05:600c:1d93:b0:42b:ac3d:3abc with SMTP id 5b1f17b1804b1-4334f01548dmr68139605e9.24.1732203445502; Thu, 21 Nov 2024 07:37:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IFcWfaRMIf30Hgg52d+hIlcLWUuMutdNfVmMqgbxuJi7boGn2lsfYZzyLLvkfHTbZQW2nzANQ== X-Received: by 2002:a05:600c:1d93:b0:42b:ac3d:3abc with SMTP id 5b1f17b1804b1-4334f01548dmr68139385e9.24.1732203445201; Thu, 21 Nov 2024 07:37:25 -0800 (PST) Received: from ?IPV6:2003:cb:c70c:de00:1200:8636:b63b:f43? (p200300cbc70cde0012008636b63b0f43.dip0.t-ipconnect.de. [2003:cb:c70c:de00:1200:8636:b63b:f43]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-433b45d16f8sm58469525e9.2.2024.11.21.07.37.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Nov 2024 07:37:24 -0800 (PST) Message-ID: Date: Thu, 21 Nov 2024 16:37:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 04/11] fs/proc/vmcore: move vmcore definitions from kcore.h to crash_dump.h To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, kexec@lists.infradead.org, Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Vivek Goyal , Dave Young , Thomas Huth , Cornelia Huck , Janosch Frank , Claudio Imbrenda , Eric Farman , Andrew Morton References: <20241025151134.1275575-1-david@redhat.com> <20241025151134.1275575-5-david@redhat.com> <120bc3d9-2993-47eb-a532-eb3a5f6c4116@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 8p6CcAT5H25f2jbUc_QpgxMPJNQD77f6djuuKxeasR4_1732203446 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: CF9B414000B X-Stat-Signature: jze5tnoaxt34eqf8fjcsh3zuqr93xxu4 X-HE-Tag: 1732203409-46192 X-HE-Meta: U2FsdGVkX1840lq5UGiPog0eIC4zI5dkBNKSYCt9QOvnyv7wuB6QAOlLsRH/3nIkkE3r437T47FRJJW0f4489Ta1UGKrvhDCvl+UVCuCCs0ksIuv289Ej5n2OSUI8VyHhxzYLnuajpnwoC53q5fJt5IWtbGbCMJqC1WOedAF/++lkzJNOd5XHyK6osC7aqU1td7Y8sXISV/UgeYJ3NMm9rcGuIe2R1lr/nPDaAwXpiqPbqDZMxSjLnzpjCr0I5TKe+f5H/DyJpHr8PzFeD2ZRr8FgeOqCiQd6wcxkqDFd1GbKsGTfPITijXzirdMEQMIK/VMfZmZuyG8/dc4p/PugnCkWcO4SQ6nqsCW3tOG9J51JkOqGRFv2WdcM1Ci2zJToHj4T2bzWrrH/4ouRKVJW4y/y3an2b1uTJ0by9UUqO5/thPPimbydxZAxy7aQ64mSsgUxy4DhmDjbzDJ+4SfiiAvHzjrS7BXnp2aebVLYV6vOZUjmIE1utXox38PHqRwHf6/vhQXajHe0hoIhMhHM1bSofJVHs2snmHexJhqD3tu1mJ9Gvo3bPGwmMZulItczQ8sYgCVscw7F7/5UcKP8Yxk5ewSLGH0aWxEilcJEm6CVHiG1bxlOlKRWRjEydWQhpZ3L8I2oGEb7LwezycagQ7RZu6NIVd/S/9Uujc4ody8lKbt2ZD8S1Whv9PI347KkkV4dxzLLeMTsiCZ8TwvMqZzTBPV9P65l7Gy2TlsbahhmyhhQAyw8xo9DsYnvyKu8vq65ISdHYAHw10JvY/Wrd4CCLmma+qUxWUD4tZTVENbLzC1yLoe6kJjZSZ0gHl2+U8xDoDpy5fba2IEMMNi9ALRppo9BGVMj0TE8G9Ufo4xZSAUQ9xhoMYDyUJUmFBPyAXdn+qCtbYmtPd9VjNSaXPFef0B35tBq7y6xMbymzHXRE0wsnPnYxGanSSsJyRFN9NgBJQMe2rERB9VSwK z5kIjRno XfUlnsrlenK61J7sXvQw6arp8o1WE/buLTPorj0HYgBrID94/lCPj93C9jN3+0GLphayLDAFt9czS4uYeICjJzIBuBHzSMlv9cI5ts2DWFgTVasc8fQfW/KkVXnHN9PXXPCh6oYluhBB3XgWYJewCWCtZX49PlAN94rQ+UIW/52nhVR63M/KfkZoZYSiuakpxUUPbwxIdDNgE1OKkeI0IQ24+k7lQSXZDicXjhcvhiCVDgYW0xfgcQo4VSew3Y1ETtWOQ/UE7iTFIynJ0dK/jyQ8tJZi8QeiKevjzzfodv48LOGyfOoLO+YxAlWE6FfQxPFl2e9wtEsBIsXI5ByQ8lNLeXxeEeImmfOFhIekFwfaJjQNHQ3tjhnIhBfn7FHe5eQU9ptGnpTvd7Px8oPj+ZJfh+tDAV3HzeQ9yDAA4dqhcP/uN1ugultkNWkth19Q6V3p6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.003510, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >>>> If there are strong feelings I can use a different name, but >>> >>> Yes, I would suggest we better keep the old name or take a more >>> appropriate one if have to change. >> >> In light of patch #5 and #6, really only something like "vmcore_mem_node" >> makes sense. Alternatively "vmcore_range" or "vmcore_mem_range". >> >> Leaving it as "struct vmcore" would mean that we had to do in #5 and #6: >> >> * vmcore_alloc_add_mem_node() -> vmcore_alloc_add() >> * vmcore_free_mem_nodes() -> vmcore_free() >> >> Which would *really* be misleading, because we are not "freeing" the vmcore. >> >> Would "vmcore_range" work for you? Then we could do: >> >> * vmcore_alloc_add_mem_node() -> vmcore_alloc_add_range() >> * vmcore_free_mem_nodes() -> vmcore_free_ranges() > > Yeah, vmcore_range is better, which won't cause misunderstanding. > Thanks. > Thanks, I'll use that and adjust patch #5 and #6, keeping your ACKs. -- Cheers, David / dhildenb