From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 379A5C433ED for ; Wed, 19 May 2021 01:39:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A00B8610CC for ; Wed, 19 May 2021 01:39:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A00B8610CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2B5508E0065; Tue, 18 May 2021 21:39:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 265118E002F; Tue, 18 May 2021 21:39:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1309C8E0065; Tue, 18 May 2021 21:39:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0061.hostedemail.com [216.40.44.61]) by kanga.kvack.org (Postfix) with ESMTP id D54F38E002F for ; Tue, 18 May 2021 21:39:57 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 7BF518E68 for ; Wed, 19 May 2021 01:39:57 +0000 (UTC) X-FDA: 78156274434.27.890D561 Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by imf07.hostedemail.com (Postfix) with ESMTP id EEA38A000383 for ; Wed, 19 May 2021 01:39:55 +0000 (UTC) Received: from dggems702-chm.china.huawei.com (unknown [172.30.72.60]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4FlFpq3PQ0zBvSp; Wed, 19 May 2021 09:37:07 +0800 (CST) Received: from dggeme703-chm.china.huawei.com (10.1.199.99) by dggems702-chm.china.huawei.com (10.3.19.179) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Wed, 19 May 2021 09:39:53 +0800 Received: from [10.174.176.110] (10.174.176.110) by dggeme703-chm.china.huawei.com (10.1.199.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 19 May 2021 09:39:53 +0800 Subject: Re: [PATCH 5/5] mm/swap: simplify the code of find_get_incore_page() To: Matthew Wilcox , Andrew Morton CC: , References: <20210518135352.3705306-1-linmiaohe@huawei.com> <20210518135352.3705306-6-linmiaohe@huawei.com> <20210518141304.c09cd8762e3f3d16a722444c@linux-foundation.org> From: Miaohe Lin Message-ID: Date: Wed, 19 May 2021 09:39:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.176.110] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggeme703-chm.china.huawei.com (10.1.199.99) X-CFilter-Loop: Reflected Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=huawei.com; spf=pass (imf07.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Stat-Signature: 6bak4r8jw4jnzjdfo9sbzoem677cczbu X-Rspamd-Queue-Id: EEA38A000383 X-Rspamd-Server: rspam02 X-HE-Tag: 1621388395-636190 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021/5/19 5:34, Matthew Wilcox wrote: > On Tue, May 18, 2021 at 02:13:04PM -0700, Andrew Morton wrote: >> On Tue, 18 May 2021 15:33:54 +0100 Matthew Wilcox wrote: >> >>> On Tue, May 18, 2021 at 09:53:52PM +0800, Miaohe Lin wrote: >>>> pagecache_get_page() can do find_subpage() for us if we do not specify >>>> FGP_HEAD. No functional change intended. >>> >>> Please, no. This interferes with the folio work. >> >> In what way? Can't the folio patches simply revert this or suitably >> alter it? > > Of course, it's just software. Anything can just be modified. I don't > see the point of putting in a cleanup patch that creates a conflict with > important work. I could hold this patch out until folio work is done if you ask for it. Thanks. > . >