From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0011C021AA for ; Wed, 19 Feb 2025 17:56:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D836440175; Wed, 19 Feb 2025 12:56:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 38831440156; Wed, 19 Feb 2025 12:56:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24FCA440175; Wed, 19 Feb 2025 12:56:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 046DC440156 for ; Wed, 19 Feb 2025 12:56:02 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9D030141412 for ; Wed, 19 Feb 2025 17:56:02 +0000 (UTC) X-FDA: 83137447764.19.6FE139C Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf28.hostedemail.com (Postfix) with ESMTP id A2BA4C0009 for ; Wed, 19 Feb 2025 17:56:00 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739987760; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RdxL0QjtpSzii6bnhHM3+A+LMFUQLavbvxSp98Wszow=; b=NUTze4ZkEVYhRqXRz1gUB8ah/Yyna/VBj/KMWZwnrPtLZ/KDYe6v2ONghauu9mrGw2YZ0j 2Sg3ymLATns9Peak3P2YuYlSPbcIURUEb/6U8sBUY8ChRm3VNdyB3J4p7KHZUH1ELuvldF eKRirvf2ZMvNeCJ7d/gjf2Vl9ECLRWs= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739987760; a=rsa-sha256; cv=none; b=cmOXwiKnrOqBfDRH/dooJGhUtsfXNDS2HtrWEjuOAn7yPsLRWhxKLdo07XmXUq8TMJWOJG cEPKsdx1tAi+gV5I/W6nsbGHEGzVkILK4/6eLkKRl+PAryZ2Sb/nY4yHZaO1UbcilXNFHE j7NHQLCV6mcorJueL7/Yvf/MXv6fxNE= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tkoFk-000000003Xr-0mcr; Wed, 19 Feb 2025 12:52:56 -0500 Message-ID: Subject: Re: [PATCH v11 04/12] x86/mm: get INVLPGB count max from CPUID From: Rik van Riel To: Borislav Petkov Cc: x86@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali Shukla Date: Wed, 19 Feb 2025 12:52:56 -0500 In-Reply-To: <20250219115626.GMZ7XG6s-5ftg1XLoZ@fat_crate.local> References: <20250213161423.449435-1-riel@surriel.com> <20250213161423.449435-5-riel@surriel.com> <20250219115626.GMZ7XG6s-5ftg1XLoZ@fat_crate.local> Autocrypt: addr=riel@surriel.com; prefer-encrypt=mutual; keydata=mQENBFIt3aUBCADCK0LicyCYyMa0E1lodCDUBf6G+6C5UXKG1jEYwQu49cc/gUBTTk33A eo2hjn4JinVaPF3zfZprnKMEGGv4dHvEOCPWiNhlz5RtqH3SKJllq2dpeMS9RqbMvDA36rlJIIo47 Z/nl6IA8MDhSqyqdnTY8z7LnQHqq16jAqwo7Ll9qALXz4yG1ZdSCmo80VPetBZZPw7WMjo+1hByv/ lvdFnLfiQ52tayuuC1r9x2qZ/SYWd2M4p/f5CLmvG9UcnkbYFsKWz8bwOBWKg1PQcaYHLx06sHGdY dIDaeVvkIfMFwAprSo5EFU+aes2VB2ZjugOTbkkW2aPSWTRsBhPHhV6dABEBAAG0HlJpayB2YW4gU mllbCA8cmllbEByZWRoYXQuY29tPokBHwQwAQIACQUCW5LcVgIdIAAKCRDOed6ShMTeg05SB/986o gEgdq4byrtaBQKFg5LWfd8e+h+QzLOg/T8mSS3dJzFXe5JBOfvYg7Bj47xXi9I5sM+I9Lu9+1XVb/ r2rGJrU1DwA09TnmyFtK76bgMF0sBEh1ECILYNQTEIemzNFwOWLZZlEhZFRJsZyX+mtEp/WQIygHV WjwuP69VJw+fPQvLOGn4j8W9QXuvhha7u1QJ7mYx4dLGHrZlHdwDsqpvWsW+3rsIqs1BBe5/Itz9o 6y9gLNtQzwmSDioV8KhF85VmYInslhv5tUtMEppfdTLyX4SUKh8ftNIVmH9mXyRCZclSoa6IMd635 Jq1Pj2/Lp64tOzSvN5Y9zaiCc5FucXtB9SaWsgdmFuIFJpZWwgPHJpZWxAc3VycmllbC5jb20+iQE +BBMBAgAoBQJSLd2lAhsjBQkSzAMABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDOed6ShMTe g4PpB/0ZivKYFt0LaB22ssWUrBoeNWCP1NY/lkq2QbPhR3agLB7ZXI97PF2z/5QD9Fuy/FD/jddPx KRTvFCtHcEzTOcFjBmf52uqgt3U40H9GM++0IM0yHusd9EzlaWsbp09vsAV2DwdqS69x9RPbvE/Ne fO5subhocH76okcF/aQiQ+oj2j6LJZGBJBVigOHg+4zyzdDgKM+jp0bvDI51KQ4XfxV593OhvkS3z 3FPx0CE7l62WhWrieHyBblqvkTYgJ6dq4bsYpqxxGJOkQ47WpEUx6onH+rImWmPJbSYGhwBzTo0Mm G1Nb1qGPG+mTrSmJjDRxrwf1zjmYqQreWVSFEt26tBpSaWsgdmFuIFJpZWwgPHJpZWxAZmIuY29tP okBPgQTAQIAKAUCW5LbiAIbIwUJEswDAAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQznneko TE3oOUEQgAsrGxjTC1bGtZyuvyQPcXclap11Ogib6rQywGYu6/Mnkbd6hbyY3wpdyQii/cas2S44N cQj8HkGv91JLVE24/Wt0gITPCH3rLVJJDGQxprHTVDs1t1RAbsbp0XTksZPCNWDGYIBo2aHDwErhI omYQ0Xluo1WBtH/UmHgirHvclsou1Ks9jyTxiPyUKRfae7GNOFiX99+ZlB27P3t8CjtSO831Ij0Ip QrfooZ21YVlUKw0Wy6Ll8EyefyrEYSh8KTm8dQj4O7xxvdg865TLeLpho5PwDRF+/mR3qi8CdGbkE c4pYZQO8UDXUN4S+pe0aTeTqlYw8rRHWF9TnvtpcNzZw== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.3 (3.54.3-1.fc41) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: A2BA4C0009 X-Stat-Signature: 9t33ghbwma65ucz38dctx6hn1qirbknc X-Rspamd-Server: rspam03 X-HE-Tag: 1739987760-794591 X-HE-Meta: U2FsdGVkX1/lC/027V/hnAZfbpziVY7EJhhzHG5xSNxB3n+bH9csfd+Fi6bhz1S3lBEMl5QFMY1Cq/96S166VcXb/pvTjmJ1Z5e7P/zC6whyqEhJyhqK4y6jH8TyQEb926hbJG52Fgq6K2U1IkhcpCTd5e1+OMYvfsq8cKy+txgBMcqrs2xziP2TDnjKdvJfAAPenPEZ6W7dtuMe1hivHGNuSMpg6KbH0lD9bKWPCFDiAwU2iYsk2fQblvBznBiTLgQM0OUSwC1BfW6COPWkWaMfYOw9DQ+RZ2VM4DujUf63ACGT94y/wf2AdcH3Ej2FRvepCIvfJe2yeXE0FZddGH/zNnhtmknYY4vl78OzkbXm7bMYy5mDp8uMczsm2+nMFTTLPIdkU+QxBJ8R0b8gxmS5T4FO9GBD+HDByTZey4cZhRNSADYul9syB7Az8OKcHmI5G0/iPHBGrH6kXWu7KjF9njwgTPV8eBUCGbDUaU4EoYkbX1jSO1pgUSIoyD2VvJ3qEKS15gVtbMshI2OHNXqVDJ/vPUwcHe/aFfKNTSea2w4CiI/Ea6am7terx5Du16gS5jMLSxMLz+brLqg98AKixdqvcjQRxPpH1+5U0pPRxdSuJhJJF8PK+z+RNM3GJUsY3hwfWg5kNxZABFCppSZgVdYTmCjhW4mCn7PQSDMaM2qJbVxDF4M6NGXmY65p2kAL32Hu19dBHsce3ReJSsJeRVN3jgkUk0+HHKOFB11qGQsUAeqVIWI50kwoeCS/7RKBTu2NIn2TN83yAoqSmsopnQzPn6N6lQ5RdVIMiFKncWbMuaOjBEW8/VZgbzIfZXBOT32c41Cb0f58dZvliDWjR+ReF/MsLkRUtZ0TfJeWbZM0FFUyXZzpuKsIeSnewFRgrKkTdyzGRNhCNYzCZx37Rwd7tc8ts3zbzyiQYZHXoj5C7Ag6rw4hXKsvIy94SKm1dDmkI1ar47ozNYj 9shH2rVH VzZkZTFdKEAvUxsp+N53mN11PgBH6ZyAkCGMdfzzomJVxUIL9W9+yRVGhg7KGQyunl1qWwMNVtIHywlVViMgC0UlzRh4Ut3j9BHi83BATnbp19XMZc0JmpVDctGHqux1aY+jY5fxnQFjD3pd3lhmvUS30nH6taRKIUEXzHkCSaNFzl2AcL8NGr4/s1WJIYZSQD+KZp6gX8RddSLugmkmYDqYpVMbhJE/xSNLVZ3lJ8tBAZIRPbvJoPPLYBIHoNrIEYREGJihTRujRS/aOs0h3Hv6UEzN5/b5OXavC1xRekINLs+Edl9LoWquR3y77Rbhy9+ElCHWXiLG1JxkdRM0BSpoZKAXPj8Nlc/V9umCIsvDbZbhGknJLdLsHoXHN0gXgT1lTipA7UYLKYewqokN3kWEho0GSFL2Z4SO7hmydwKWlIBzuUUzk4+tTqnEg67gwzvKdRVjl0VXw3PJeHvduZBAi3A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 2025-02-19 at 12:56 +0100, Borislav Petkov wrote: > On Thu, Feb 13, 2025 at 11:13:55AM -0500, Rik van Riel wrote: > > The CPU advertises the maximum number of pages that can be shot > > down > > with one INVLPGB instruction in the CPUID data. > >=20 > > Save that information for later use. > >=20 > > Signed-off-by: Rik van Riel > > Tested-by: Manali Shukla > > Tested-by: Brendan Jackman > > Tested-by: Michael Kelley > > --- > > =C2=A0arch/x86/Kconfig.cpu=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 5 +++++ > > =C2=A0arch/x86/include/asm/cpufeatures.h | 1 + > > =C2=A0arch/x86/include/asm/tlbflush.h=C2=A0=C2=A0=C2=A0 | 7 +++++++ > > =C2=A0arch/x86/kernel/cpu/amd.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 | 8 ++++++++ > > =C2=A04 files changed, 21 insertions(+) > >=20 > > diff --git a/arch/x86/Kconfig.cpu b/arch/x86/Kconfig.cpu > > index 2a7279d80460..abe013a1b076 100644 > > --- a/arch/x86/Kconfig.cpu > > +++ b/arch/x86/Kconfig.cpu > > @@ -395,6 +395,10 @@ config X86_VMX_FEATURE_NAMES > > =C2=A0 def_bool y > > =C2=A0 depends on IA32_FEAT_CTL > > =C2=A0 > > +config X86_BROADCAST_TLB_FLUSH > > + def_bool y > > + depends on CPU_SUP_AMD && 64BIT > > + > > =C2=A0menuconfig PROCESSOR_SELECT > > =C2=A0 bool "Supported processor vendors" if EXPERT > > =C2=A0 help > > @@ -431,6 +435,7 @@ config CPU_SUP_CYRIX_32 > > =C2=A0config CPU_SUP_AMD > > =C2=A0 default y > > =C2=A0 bool "Support AMD processors" if PROCESSOR_SELECT > > + select X86_BROADCAST_TLB_FLUSH >=20 > CPU_SUP_AMD selects X86_BROADCAST_TLB_FLUSH which depends on > CPU_SUP_AMD which > selects X86_BROADCAST_TLB_FLUSH which depends on CPU_SUP_AMD... >=20 > Why do you really need yet another Kconfig symbol? Just whack > X86_BROADCAST_TLB_FLUSH - it'll be enabled by default on everything > anyway. Dave specifically asked me to do things that way. >=20 > > @@ -1139,6 +1141,12 @@ static void cpu_detect_tlb_amd(struct > > cpuinfo_x86 *c) > > =C2=A0 tlb_lli_2m[ENTRIES] =3D eax & mask; > > =C2=A0 > > =C2=A0 tlb_lli_4m[ENTRIES] =3D tlb_lli_2m[ENTRIES] >> 1; > > + > > + /* Max number of pages INVLPGB can invalidate in one shot > > */ > > + if (boot_cpu_has(X86_FEATURE_INVLPGB)) { > > + cpuid(0x80000008, &eax, &ebx, &ecx, &edx); > > + invlpgb_count_max =3D (edx & 0xffff) + 1; > > + } >=20 > get_cpu_cap() already reads that leaf. You don't need to do it here > again. >=20 Should I modify get_cpu_cap() to store c->x86_capabilities[CPUID_8000_0008_EDX] ? Currently only the EBX data is stored there, while invlpgb_count_max comes from EDX. --=20 All Rights Reversed.