From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 134A0E77199 for ; Wed, 8 Jan 2025 20:15:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9109A6B0085; Wed, 8 Jan 2025 15:15:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BFE16B0088; Wed, 8 Jan 2025 15:15:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 760E76B0089; Wed, 8 Jan 2025 15:15:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 58DC96B0085 for ; Wed, 8 Jan 2025 15:15:01 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0A35E4592D for ; Wed, 8 Jan 2025 20:15:01 +0000 (UTC) X-FDA: 82985388402.26.A264C34 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 50B121C0022 for ; Wed, 8 Jan 2025 20:14:58 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=D3SPSsFa; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736367298; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/FTD7VRKbyo76kjBrHHQrkzkeyLU3UKrwKjjg/o7AY8=; b=XukNsHU2w/4iRHt0knrB5iWeybSueVQmizAytmO81vifUSJJl6GvL7y2p1OOCuYZSq5htl r6yzWpj+76XbjsfhJKtmVI6uAUWuDqLot9pWT/eIzFPZ96sSgBBlZLLRa2YlK5lIuKeLHc qbNjVukEBFIDW/tisKyoQNcor9p64k0= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=D3SPSsFa; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736367298; a=rsa-sha256; cv=none; b=0Mld17vZK/BLe7gsM0qbN9TO0Jsk4PY/yPnqvyJUj4FH59rQfvnGlVp2yCnmudGx6r9urD NH/ymvc9/iLbHPZMtSA3mxcI8g1Os1zCmTh5TJK2Ned6jUqgalpGl78udQVGyEA6pR+KRF qJS9rNMIir++X/4OzSnJjIQbSvBUDJY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736367297; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/FTD7VRKbyo76kjBrHHQrkzkeyLU3UKrwKjjg/o7AY8=; b=D3SPSsFamn0DOy5cSxZQ1sJud2NwfBiyydTH6vj0xPvxKsAvV6kAPxkBJor7cqY4ET55h4 HLygnh8LpOWNy6v4aJEFGwE9WB9jgYafijQVL6wGgIH4msLuCsB4PdfbUNPvi+yJUuBVgz lZ1ioAXb/Xd9KaZAIpcG/9RjgHvxMsg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-116-wMCxZVk1OpiWKYTD-P3KaQ-1; Wed, 08 Jan 2025 15:14:56 -0500 X-MC-Unique: wMCxZVk1OpiWKYTD-P3KaQ-1 X-Mimecast-MFC-AGG-ID: wMCxZVk1OpiWKYTD-P3KaQ Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4359eb032c9so1344815e9.2 for ; Wed, 08 Jan 2025 12:14:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736367295; x=1736972095; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=/FTD7VRKbyo76kjBrHHQrkzkeyLU3UKrwKjjg/o7AY8=; b=G2lQBeL5QOtWRirRGdjwp3+AxDZp2Z6PSpjCDN3n0BMCWZaU/nqv/iZj7H4ggBkHr+ QNQd+y/4JoWgErKDyD9Ut2SVip1RIQrarY9hYe2rjdUArVf3BUpgBz594siTWBQKxCKc l9rWrAj2RwewkDuHTqBGbWBZG1Z8atOGDmXMmAfcv/3m3qwRsAC71liMlXi+r2F5ePmO zNktamSAIgzNX2+1YIVXX08Gxlc4aoZAGYnsCZ05tPAdr7Um7CHVrzlmNYP0S5jsq3rG +OjaEfsG4ECRVTRIVwWIyoxGC1FOiB4c6iu9U+XC6FSaEXSxL4cAbtviX+fkoV9ep8wS ALUw== X-Forwarded-Encrypted: i=1; AJvYcCW2d+ABT6M6lSQPScLViDKYMDAXKSATfD8ZqnSIMkTZT+qilPoN+1b4lXGEbtLImMpzcokgwIoBAg==@kvack.org X-Gm-Message-State: AOJu0Yw1z6B6bq3CM5qhhs8cICDRnn2lbhx6fEs9o8jrcoBsmJn7n6n0 NH4VFD86aehkoU9FUzWYuyYoJxWyCogUxT61q9MSQ7xDgsQnoK2Xlgt7h7G2MsIVNvfGAtr5Xee xzdSHJQ/OMukkkJA8V10XmxFNotXv6RGLYezhTWBV+5PGvJCML6lnoG122xU= X-Gm-Gg: ASbGncuHxJzAJrRlwpy6/80MitI51E0MAEtxyel1MYHYAbBbSBAkRicOZ5hn4YBS2Ip Yir41E4XN8wOrKYxX/UeCCZyUZqLuu6nGsgAiw/L4pQib6RnwBn/fRVLKdxG3jhXNz0Y6EAoCe4 Cr1wtX20Lzhr17vos/ttPYkqlPVF78pB78kmHD08s4MH6oyvvgKCcHX+IDv1WY2CGr+2E4gauI3 e8ycOUE7g17AWO/l2mWcVGxwofR2VQmeg/AtIs6qnCHPcZTzG3qk0EmXYcifSM83hGdXN2IozC7 +7wFHEo9Ng== X-Received: by 2002:a05:600c:6c0b:b0:434:ff25:199f with SMTP id 5b1f17b1804b1-436e2707f07mr32749355e9.26.1736367295120; Wed, 08 Jan 2025 12:14:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IEVFDRF8uyV2miULA6zaJOdskG6eSwfM6v3gJrBasiahKbvULLcZ0puYwfPtWfZ1vGxo8PORw== X-Received: by 2002:a05:600c:6c0b:b0:434:ff25:199f with SMTP id 5b1f17b1804b1-436e2707f07mr32749215e9.26.1736367294777; Wed, 08 Jan 2025 12:14:54 -0800 (PST) Received: from [192.168.3.141] (p4ff23c51.dip0.t-ipconnect.de. [79.242.60.81]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436dd11ddfdsm38278365e9.1.2025.01.08.12.14.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jan 2025 12:14:54 -0800 (PST) Message-ID: Date: Wed, 8 Jan 2025 21:14:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 3/3] fb_defio: do not use deprecated page->mapping, index fields To: Matthew Wilcox , Lorenzo Stoakes Cc: Andrew Morton , Jaya Kumar , Simona Vetter , Helge Deller , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <1e452b5b65f15a9a5d0c2ed3f5f812fdd1367603.1736352361.git.lorenzo.stoakes@oracle.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: emm5uBgi730sI5j7YRrYoN--YjVn6_ILNGWLBwCiEcU_1736367295 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 50B121C0022 X-Rspamd-Server: rspam12 X-Stat-Signature: sjpeo4c5kqnhg8dphm46x6pg5c5h9b3g X-Rspam-User: X-HE-Tag: 1736367298-669906 X-HE-Meta: U2FsdGVkX19RXo1tDOdcH4+Hnrpm77g8McycVo6fUVWD42Z5uepArcJ5Tu79atnZkyGbAelERp1iI9zCLmf951+4KLHSflUPy8mU2d/CgCmqGJiMPocQvpo0t7uGidSLHEoiWNR8/9NQk1Kvk1q0PkecghFtpTJ/HocwREj6uSJrCbHyH2Kmi3A/gtbVYm3OwmM75fxlCV+PSPV9F3FxoPGspvPT364mSd7GCn+6qHpPpRswNbPv/6wezMFPECp2X8FQWFKstVASsaUj+59kZnHDRjariyvSM5sR31L9jLhJkbbVBNfXVwRqf3iodm/wzspaLFeF+PNXu8BoteqNz67BsQ4DVounH0J0Btpkf8/aFT2CNCUtcKmIdh/sAdgqHGh+5oriOPrHes/rgZDeteCKegQcuPUdxWfqCdHjlNz0hwC57TY/akESkRNGnq03hbATkKcOa1zbYuBYgJkIaiAecIR8z3Z0qW0gK2oJCs/HsGwOwDmvYkg0jehbgLV8QjoznbTRu0xtCoblWo7T2s9cEIKiQiFB1+xnbFPcBgY2Q9e2hygIVjdMlOpEW/KR7kQs6Dkgh6geKhn5zLtoEcsejOBsQf41eSX45nQEqCxJgo8tCaW7JB/Cr+LcZzxZJ6zc51OpNIvgVrQlbjHNpN8pAzSA37OqEhNAhX28RDJECS+skdQMgcPVABqAaOVETIuy+LCcwDEnn/tz6MqckGpK9INPkGiFvRD87xYPRutWs3cW7qKYfV4VYQW+NEQTUUf/d3XN68lgGXQn0JD/ak5dHHWTbm58cNfnDJSljXmYd0yy9ypS+91z8JH+o4YfR44PjiERxtai/wCSlA3SCcuFUtUFJ9iH4SAnZIk+E0N41VM0RyJGila5huR0lGCto9qdFSLZicHgU78uLI7wP7WcKpjMgi6eklK/YcmS/uKwn/b3bYuU4q93TSXhENyYY1vQnnVfGc13klD+NDr SGUfoO0p +Bp93C1Sk7Mihug9VDrXHtVE+0rxV8qYPxWBgGDZ8pHColzugQUcsvNhM2SM16Jvc7hiGwtAUMWpQALBqbiwVWDYoRAPUPp0tGy6PtzOTUUDCng/d16d8nvd3wzNEEx5Q24+SzzVWGV7o2iO7F+2XmA0RWMJSFh4bBi9AL+gKC3lQPslW0sPNpf1hdfu3NZXPXQojprJ1r15TYzP+1vJmWCuUqWtTBGPyvbvOazkmtM448s2IUxQpY6sw5CYgEb0sNsSBjxf8FTVxjEMt54K0IhiynUi/mQLWO6oYBkZiYYAMysAFrBdhulqX5NXh8RVLqHLXXTZl9rFAwDc26xEmmyNxLMSQX7pJVYbHUlxemwla7arS+mviiR49XI/F+sRdJBSP/RBiRZ1DQG6RJJeZXe6ymrz+NwbOOFQqlzUDIxofcXBlmkyA+KzYDqgr2OGXbQYAoXIo8UEtcbc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001252, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08.01.25 18:32, Matthew Wilcox wrote: > On Wed, Jan 08, 2025 at 04:18:42PM +0000, Lorenzo Stoakes wrote: >> @@ -280,7 +269,10 @@ static void fb_deferred_io_work(struct work_struct *work) >> struct folio *folio = page_folio(pageref->page); >> >> folio_lock(folio); >> - folio_mkclean(folio); >> + rmap_wrprotect_file_page(fbdefio->mapping, >> + pageref->offset >> PAGE_SHIFT, >> + compound_nr(pageref->page), >> + page_to_pfn(pageref->page)); >> folio_unlock(folio); > > Why do we need to lock the folio? (since this isn't necessarily a > folio) Can you clarify the "since this isn't necessarily a folio" part ? Do you mean in the future, when we split "struct page" and "struct folio"? Doing an rmap walk on something that won't be a folio is ... sounds odd (->wrong :) ) -- Cheers, David / dhildenb