From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F38FC83F1A for ; Thu, 17 Jul 2025 20:03:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3CA886B00EA; Thu, 17 Jul 2025 16:03:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 37AD06B00EB; Thu, 17 Jul 2025 16:03:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21BF86B00EC; Thu, 17 Jul 2025 16:03:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0BDC36B00EA for ; Thu, 17 Jul 2025 16:03:53 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9FDC5160227 for ; Thu, 17 Jul 2025 20:03:52 +0000 (UTC) X-FDA: 83674832304.21.FEDAA98 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 3E15A40002 for ; Thu, 17 Jul 2025 20:03:50 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dcFKsM91; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752782630; a=rsa-sha256; cv=none; b=SVp5od2fBQ4Zkq3hpA9NsYKUXoUJLdw6YZ+LXTwPzRhNDkB9jRdAJa9YaZlfr8JbFLFfW6 M4U8Cy3pMoNUm8Q1APulnDkkA8iIMfMWFLWaWrEKclCCIEMIWSoc3HRG9UZS87ZtaPtqpj KhRm6KqId2Dsa8lYqwPQSK+6GQZzGwY= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dcFKsM91; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752782630; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ClNVtTZhZp5gAwQFZwS1SAbGnOFesIfcYAsTrAvuVJw=; b=qwNMi7AvVbspi6P7rYs6WwgbleKS8ZDLk6yVZYEV6d803S4L5huxrnMIUQS/qTCpDzOhsJ FHVgcXgpLbYWrmRXw+LqZ+fSMh6oqL/BSxx/LLvw+P2o5xwciRxWsAkBMGf2SEL1YjzTE8 fx2ixE4kM1fboFcuSwjs9jdCas0FULM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752782629; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ClNVtTZhZp5gAwQFZwS1SAbGnOFesIfcYAsTrAvuVJw=; b=dcFKsM91n4VTmDbIO+9k9Y4ZZbkDObUbM3wD1XFO8n6ydE3Mr35wdoPiHSEebnAKV2h6Ct cwFfPKF4mC9tb1pkNzLtjO86MauaXp26YQcBhy3lnPJN64F9+J2Tmh+9Q95N/Q8hUP35z+ FoFzlV6wSEeQ1idltVsWFbJL83eO3+U= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-1a0U3JeMPPqj-Vl8xW3JWQ-1; Thu, 17 Jul 2025 16:03:48 -0400 X-MC-Unique: 1a0U3JeMPPqj-Vl8xW3JWQ-1 X-Mimecast-MFC-AGG-ID: 1a0U3JeMPPqj-Vl8xW3JWQ_1752782627 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4562985ac6aso13872925e9.3 for ; Thu, 17 Jul 2025 13:03:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752782627; x=1753387427; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ClNVtTZhZp5gAwQFZwS1SAbGnOFesIfcYAsTrAvuVJw=; b=Jz61vd/8IMl4r51JI2zt699U39k13Sl143MM+R9D134bQyp0/r6q1TuJ1gE2eKeRBu 7AYAkrQv2HG7MmH3IiL7dQVKKz3rb3CdivXmZAr9DSSqmvJIrww14yTOZCe1QfdWRepO /S2/9JUHd9Qu3aS+EvIchy5adZE9cnyyf+HGjaYv3hXmIw61j+JFLazXkbEti3CjRpfJ 4S6Vs20DSzenJH9Vc0NRB1r3qXiUJkd2dv7tG3y0TkNmXgEsl9WI/JleRZRcXmBiOpaK szyuFFS9EMt1DmNfAPl0KzJcASxb1/CwoWX+yIHyQV2PQIBZiEHQ9rke3wvo9kWQiX8N LJGQ== X-Forwarded-Encrypted: i=1; AJvYcCUVo6bktvo45PUiHKvvVL13+fUbeK8FYnLGVjgTfJjXwjT5MTjUk0XIEjvPcfBiT2uVTP6M91H4rg==@kvack.org X-Gm-Message-State: AOJu0YwmqvWIAgKkGkTATOeYyUFXd4K7OKRvyLvD0FItOQQCGWuo1BYa vJV+TH2kE4lG66aeCMqgyCtYaX3QCCMlWn6fnPcEVsFB9XwQTLVX6Qjo2KkxA2xmxZs/RajImG5 t2SOh/b9ajMaAI5JFeH9PCqi8BebC8rXoWA/Ek6UfyosrgFRL7uPD X-Gm-Gg: ASbGncso2Y1/a82ARTcc83Db6LmUV8iKkKK4L7Surhq8OrzDHRcY+HxN9ZnRhYTprTB PJONwk6TQ0j204cFJKqybKY7qCwjBIzVj/KUzJDvWHVzYoYiOl2EuPFfTcZnRPpheY9Fm7+EupE efszZPjv7CNhPZ+MyVBJMQ/E2pq3g6DBYumJ1CWixwJDZJwhH0e+NMk3jYqJFct8pHTNajmn4wX RcTulMgsEcrG58hgy5d0mNgsd1TFfuMC17LvmrJgwU9vUSZJTTPXu0/94zUafB2W7UdOV0vhCUG JuxR1JNtfAYrzUOgbU8Y5OE63WqujhGoHeKWpEGewTY8704fTHSmNGdBRLfEfWkbX6BOYmxM1Kj nA6fohr52eKTyufn8PbD5CUgXIRMbo7cZ7wWAg8tvTrHEVjlc87AB9IZFkFek987W X-Received: by 2002:a05:600c:3481:b0:456:f9f:657 with SMTP id 5b1f17b1804b1-4562e3c503amr79746035e9.27.1752782626937; Thu, 17 Jul 2025 13:03:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHITXVfZtwqa7P8f0u6oWcFw1NazxQtB99hClGfTnR+mgLoVDMe7M6pKVDkyJRWFMthviCSvw== X-Received: by 2002:a05:600c:3481:b0:456:f9f:657 with SMTP id 5b1f17b1804b1-4562e3c503amr79745695e9.27.1752782626423; Thu, 17 Jul 2025 13:03:46 -0700 (PDT) Received: from ?IPV6:2003:d8:2f35:2b00:b1a5:704a:6a0c:9ae? (p200300d82f352b00b1a5704a6a0c09ae.dip0.t-ipconnect.de. [2003:d8:2f35:2b00:b1a5:704a:6a0c:9ae]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45630ec9129sm49616075e9.29.2025.07.17.13.03.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Jul 2025 13:03:45 -0700 (PDT) Message-ID: Date: Thu, 17 Jul 2025 22:03:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 7/9] mm/memory: factor out common code from vm_normal_page_*() To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, xen-devel@lists.xenproject.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, Andrew Morton , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dan Williams , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Jann Horn , Pedro Falcato , Hugh Dickins , Oscar Salvador , Lance Yang References: <20250717115212.1825089-1-david@redhat.com> <20250717115212.1825089-8-david@redhat.com> <1aef6483-18e6-463b-a197-34dd32dd6fbd@lucifer.local> <50190a14-78fb-4a4a-82fa-d7b887aa4754@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: <50190a14-78fb-4a4a-82fa-d7b887aa4754@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: NOshnFtPwJZGQEPclaf7zuLA0sDhRK1Tw9MCJrB8kHA_1752782627 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 3E15A40002 X-Stat-Signature: n9yfy33mhwpd3piemprj7oe4xuiqtjwy X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1752782630-745954 X-HE-Meta: U2FsdGVkX19ImJDgcNnk+C+Oj2pCef6CotuO1ed8zeMo5ndT6OZQHX2nB8Z+UnstLKoil5CgV++OAgyTgr4wEayYVEebK6AIW9hvpJ3dCBg0qp8GYfEdRHIMjTQywhptPH9yIwPcHW225KEYWbbtLyy7UCE10L2+rSmsmntjYtE9o83n94U5fkmKx07BU/I5qtwBmWz9rLP4r4/Co4PdWGGx9LI/yUxainLYspo2HoZiODSJGK8dkQU8jAodRVb2bKaklj/Ia6gOQ8u4aSShQYssoK7+FerAi/1TD2XFLcY9I172X4QKgIpQ9T91KDf6aDfYjn+kuN5NYNCvMLDXuMoM0zz9czqiN7hHe2VGCpm7h8kQmiKJCbsHNPCv2J/VDWDnGABD7f3CnibuatHMRlieCgyNNFkDxQHq8/t7XOazx9HSTZbxlsjmbOLRdTqiBjZ7UoOsk9Ip8nV+OkL65OopzLTF0vk1LgSZ3nRzBYD3s+BaHJ0FoEg2yaGZUwnLTged1pgQJbiLVNFrt34AA1LtnXpUwRrzFqYKjml63UpKJhaibQXXsl6UT2xdNA20w+cpAeyv7O9rKqqvOvOooIoY3d9yDpcrneYrxhHA+pcVyXBP9dbgVkP8HNniZux65e5BSGcfnx6AthapJ6J58lw6VIwSx11kxnBfJ5PRSsmuJa+hb36cdk8Lw04l1UUVPcMdntSPSHfzrkJmS+MZ2RTmS1toZ9yF4SX1y54mEyW4U6BIa3ZfoCgdeKIS5uHVG4XNG8a3ppVJaGbp2gXWr2hf3FVcSLUH79vzEHozoufupg7rbdKqpwSYQz3C08ee3hIeRQ8oHfKNdibE1PaYw/JGHdZme9YYIkiySCtrqehp17PaWP0irIf4XUpSXrDkiPkNHVtEpFl0cm5TM+F5qpIKSgcswNqBKgTgaGsKsUTKwrlq3yYSPxKVeFZOA5QPyfn47XI01tED01j86Ln Bg/dArb+ UDggF274O6fWqm2cRn8WuFBV3sSX4XKytlJA/AsMkPHJJFt10zF+thUuaHzLTOs8TctYjWOJnvwJR9RGrpYHYH/VjEADwU8rQXc8naOVHjme59J6hGUU9sfQyZSyY+7D/KlJOLxpdoY8XpqPiS0BpMHEyIkaP5AavFaHEO1o/JJMkffA9RfiI7vaY6I0jSyW24pJbM/bVlX9YilTHiGa8l6zhrSvkqD3WdyMQRwwcpxvE1yVku72glf9nfZV5sIJ/rRzGqj1b4nUR1k271aEmQpOb+P0g6WOe+eP4OAauQVTNHdQO84tQQoFRNUenwi8Bi3DbHdjb89FQrtPjrs/aw2YqW0EZAMVM9dpkEkI+LHnchPhm0LXFUOlxR3CxPxtjT1YQoRhusIDoo5J35GQ5mTOt0RXb8eKz95OTKa0gdqRgh2uKq5us+U4q69po3/6R+nQWpLOvuo5d60KhayGosKEi0w/kHhLI6E9Buh4W+NTLNiL35IPodLQqEQTHpVIYJqhScUkE7ViwJL0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.07.25 21:55, Lorenzo Stoakes wrote: > On Thu, Jul 17, 2025 at 08:51:51PM +0100, Lorenzo Stoakes wrote: >>> @@ -721,37 +772,21 @@ struct page *vm_normal_page_pmd(struct vm_area_struct *vma, unsigned long addr, >>> print_bad_page_map(vma, addr, pmd_val(pmd), NULL); >>> return NULL; >>> } >>> - >>> - if (unlikely(vma->vm_flags & (VM_PFNMAP|VM_MIXEDMAP))) { >>> - if (vma->vm_flags & VM_MIXEDMAP) { >>> - if (!pfn_valid(pfn)) >>> - return NULL; >>> - goto out; >>> - } else { >>> - unsigned long off; >>> - off = (addr - vma->vm_start) >> PAGE_SHIFT; >>> - if (pfn == vma->vm_pgoff + off) >>> - return NULL; >>> - if (!is_cow_mapping(vma->vm_flags)) >>> - return NULL; >>> - } >>> - } >>> - >>> - if (is_huge_zero_pfn(pfn)) >>> - return NULL; >>> - if (unlikely(pfn > highest_memmap_pfn)) { >>> - print_bad_page_map(vma, addr, pmd_val(pmd), NULL); >>> - return NULL; >>> - } >>> - >>> - /* >>> - * NOTE! We still have PageReserved() pages in the page tables. >>> - * eg. VDSO mappings can cause them to exist. >>> - */ >>> -out: >>> - return pfn_to_page(pfn); >>> + return vm_normal_page_pfn(vma, addr, pfn, pmd_val(pmd)); >> >> Hmm this seems broken, because you're now making these special on arches with >> pte_special() right? But then you're invoking the not-special function? >> >> Also for non-pte_special() arches you're kind of implying they _maybe_ could be >> special. > > OK sorry the diff caught me out here, you explicitly handle the pmd_special() > case here, duplicatively (yuck). > > Maybe you fix this up in a later patch :) I had that, but the conditions depend on the level, meaning: unnecessary checks for pte/pmd/pud level. I had a variant where I would pass "bool special" into vm_normal_page_pfn(), but I didn't like it. To optimize out, I would have to provide a "level" argument, and did not convince myself yet that that is a good idea at this point. -- Cheers, David / dhildenb