From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C4FAC197A0 for ; Thu, 16 Nov 2023 19:04:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E0C46B048A; Thu, 16 Nov 2023 14:04:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 88FC06B048C; Thu, 16 Nov 2023 14:04:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7585D6B048D; Thu, 16 Nov 2023 14:04:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 656876B048A for ; Thu, 16 Nov 2023 14:04:04 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3A9C91203DD for ; Thu, 16 Nov 2023 19:04:04 +0000 (UTC) X-FDA: 81464742408.28.8C3FD7F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 08A6F140038 for ; Thu, 16 Nov 2023 19:03:59 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DLtlxHgV; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700161440; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=noFtgqazCBC+/n+W0RzmjdI1W4IMXkcCumNBFAtwhRo=; b=SS4j9gcS36OiE+2YDG5uVnYs0WhDh1K9NTOmF6hKK8jDP06HY9HAxLKWeN5eOfUaLFRBBE akw/wzvWyb95JBedWoxFSGP4LrZOUrsoLErwkier5ghvvxC2A2P1TB7/v8J/XifGegir+T bkMjfbulIsMMBos4/Cn9p2x5x4GM1k4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700161440; a=rsa-sha256; cv=none; b=tSaL5OxWPweZLfgfnRnqbUCtKnYl8H9VX7ra8CFGFPgcCLMx1/kqUqsQ9j5iXtShxTRS0d a/Br0b9f1DfNkNtZcP3eZcPE6dSINaSqowpnO8SD3aFj7JAG1phHXTRYeRaeVfc7aShrHG DoJr9xtCnFq4vyy2MRWXKpFfhkMXnrg= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DLtlxHgV; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700161439; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=noFtgqazCBC+/n+W0RzmjdI1W4IMXkcCumNBFAtwhRo=; b=DLtlxHgVBBdIz396cip6Vz2EcAFRld+cGzBbMcgtk8vtXBmIq51IP7x+ij2tY8OxLvZFgt TJYHoF8xF90hfRYvbUXqFURYqZ+yUAbe25xv+0s7DXCNm6KAQmrMQfAldM4t1Bu4gl5WFF UMgu/k9HqCDOIoqRQZfvkECdWjL9SIc= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-121-5GfecsdxMyquAWI_6Tk-5w-1; Thu, 16 Nov 2023 14:03:56 -0500 X-MC-Unique: 5GfecsdxMyquAWI_6Tk-5w-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-32dc767e619so611712f8f.1 for ; Thu, 16 Nov 2023 11:03:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700161436; x=1700766236; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=noFtgqazCBC+/n+W0RzmjdI1W4IMXkcCumNBFAtwhRo=; b=TDPjv8vc+0jif/cgeoupC3O557Q6AhTJTfQO0x8j/o60jRJQaUIvR/HVgSBXpdIFtl WYJch+tXFYTaqwDVN18DIkdvTfAuFh6rxarxbhRWCz7HB42NYwWiUF8RRi6FyrCyaVkP txpKJnsT8MqMTP+G4mDFp7aIYBZAROgfVHep/V7VSNVoP3b1F9EIozQ4VEzF4lG4f1g9 tkDqtNgpGzbFjXjPy3ht9ZMXlj2xD5xtW5etHL2jolkHu2me088UjSU7knhIVtV2/EAX qoJCXpExoodEkBaNgroc/+9L45FvIhhJ8HFiARjMxJx/Op3MYr3o16Krw4sp9EAk1Q1S jP6A== X-Gm-Message-State: AOJu0YyeiSpawOeaSXddQIk4/V/s3wIpJ6ZWg4ec1UgrSNeFJt9Oy97W q4sOQ3PNuaOJ0ASwXClb6amdXA8ylZ6Z2TMT6NXI1g0MKGYR4DzWEfXegfV94zBrg8a3DtSIGh3 CQ/A7+tS39pQ= X-Received: by 2002:adf:f9cf:0:b0:32d:14c5:643d with SMTP id w15-20020adff9cf000000b0032d14c5643dmr11981611wrr.5.1700161435770; Thu, 16 Nov 2023 11:03:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IGkeF+BhJMVhRUT0hTwF3xsLQX+bV0T7VMFgJrY68XUtb3ZDoOrmg4VK/IBwjz+J3pf8mXkoA== X-Received: by 2002:adf:f9cf:0:b0:32d:14c5:643d with SMTP id w15-20020adff9cf000000b0032d14c5643dmr11981594wrr.5.1700161435301; Thu, 16 Nov 2023 11:03:55 -0800 (PST) Received: from ?IPV6:2003:cb:c714:e000:d929:2324:97c7:112c? (p200300cbc714e000d929232497c7112c.dip0.t-ipconnect.de. [2003:cb:c714:e000:d929:2324:97c7:112c]) by smtp.gmail.com with ESMTPSA id j10-20020adfff8a000000b00326f0ca3566sm162043wrr.50.2023.11.16.11.03.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Nov 2023 11:03:54 -0800 (PST) Message-ID: Date: Thu, 16 Nov 2023 20:03:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/8] mm/memory_hotplug: introduce MEM_PHYS_ONLINE/OFFLINE memory notifiers To: Sumanth Korikkar Cc: linux-mm , Andrew Morton , Oscar Salvador , Michal Hocko , "Aneesh Kumar K.V" , Anshuman Khandual , Gerald Schaefer , Alexander Gordeev , Heiko Carstens , Vasily Gorbik , linux-s390 , LKML References: <20231114180238.1522782-1-sumanthk@linux.ibm.com> <20231114180238.1522782-5-sumanthk@linux.ibm.com> <7c85bd39-8b34-4b09-b503-b0a2f2e58b88@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 08A6F140038 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 8gkupfe64sj1i8jnw3tya65ee9gi8c7t X-HE-Tag: 1700161439-328048 X-HE-Meta: U2FsdGVkX1/i6TLSIfKwAcZXIEsTvRwAs6MoaqLZRT3GZJyDZvZn4yAyxxCWNr4Bcsq5hjqZsMcugxYZuu1nbXnBqoFT7jhtyMinHO9NA+3xgm2Ukfts3txGKmaVHPF4mrPlXJ5Kqv7NNfya5p4pyB1chugtXSyWcPen4inl4kKUERKoEM1mBdVpr7Mtg128GxbvXQbAw16L3c56TTYCdU7NoXkicwA1cfhI9jK8jpeCePQXaxgTKq/ROyCZj3UkbT+NF7EwJDpIIwzA9VgPeDMEZ9qH0e4c51gj2EkF7Ov216CMs/VvFZ9Y8OzTHNaiHaDHK2A3kqCIyPY0Wm7ixzbX0RlYc0eTTvupPfnCgC0aOBXxf+WA7jU2tU7TcIzIUvPYz2fESvU8VZR6XrrooF21H6JiY+PSBTRYFDySUBfAicloXXWSeAHQeYQ9tgLiBgasavejykQPmZFab1Km25YcqDu82vKX53X6DSj8bTQx+WOT/HEV7GNrSqDQq9zU/bfInGL4Y2WO5G5nRNp7xyjGtrjgdTH3CIYYSG+gI33lY2bUsVDK3NthaXZXhcMTEvG5FLKrlH3n17FC6LJBYGLxx4nAqiDMmymh6nP+JoNOGgEkc5KqWx/wlo52mzO/gIgHzUChHxlYJ7t5ipeuhWgbz8y9gh7SRGrM9lRYAiCo3t2Jo0HiWSw555aUbT1zf8cBr7BWBwhvltp6h+LHod8haX3Oqd7Bcn9U5CHrGP1S08XYpJPRoli1gzBKOZb82YA2CXu93eSWmbZ6wPvZDpRPHoVw9X8r3VMFjjaVTnmDF9Tb2rTlzb823yRPd/fkL6PAkyPhDzpbGzQ6L+qj8VX1QchIPD5i18gsks1ez9E5w31Cv0bcFe5W7tUkTaqKYCao0HaDQcTzRUq89TIv8LgdJfk58ghlB+yHd0W0viWbmMB6dhLBe8Klil/OLRRCRuSCc9aYgicVXBQbVa9 oDD8mvxj qumzLE/0AZEjmwbV+h8BpDJJ+7U5bxn5y9De2NoR0htjbydFcZulMVIBer27laQDsvTthqVHAGIEM8xllsaNSUe5Fz9LazAbsaUqI3s19bG+wCkq/es1VkuIu0L06fc84BXEMiz3hNjZTIE9Wlh8aoZrarHGQ8VNAoCIbhIk7OmVWvB17th/GyCJafLOfH2NVbdnxZodEcBIrOwn7ngCrxa6wHC4VMxk42y74kO3oKY3AC4wIVdOONCyYAQFDJvIb2Tb9CIxz/V7U+GWf2wJwJBY5SIwQvmxVoZmnYldXYV0f4trP+lBajsbmOtjuiiCkH8rdQzaHPzS1Q79eE/2e7A+J7iMykrZwMEnXd4Hu9Hw4JfAZxjhs39U38a8jnSbjvUdgACp5D1MaHP+idayYWtDyDAC5bazl6+coCNdi2eTYlZZDyiGud+7+ELERsWCdqibc3470P6sF8LsSACV6TZkoMg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 15.11.23 15:23, Sumanth Korikkar wrote: > On Tue, Nov 14, 2023 at 07:27:35PM +0100, David Hildenbrand wrote: >> On 14.11.23 19:02, Sumanth Korikkar wrote: >>> Add new memory notifiers to mimic the dynamic ACPI event triggered logic >>> for memory hotplug on platforms that do not generate such events. This >>> will be used to implement "memmap on memory" feature for s390 in a later >>> patch. >>> >>> Platforms such as x86 can support physical memory hotplug via ACPI. When >>> there is physical memory hotplug, ACPI event leads to the memory >>> addition with the following callchain: >>> acpi_memory_device_add() >>> -> acpi_memory_enable_device() >>> -> __add_memory() >>> >>> After this, the hotplugged memory is physically accessible, and altmap >>> support prepared, before the "memmap on memory" initialization in >>> memory_block_online() is called. >>> >>> On s390, memory hotplug works in a different way. The available hotplug >>> memory has to be defined upfront in the hypervisor, but it is made >>> physically accessible only when the user sets it online via sysfs, >>> currently in the MEM_GOING_ONLINE notifier. This requires calling >>> add_memory() during early memory detection, in order to get the sysfs >>> representation, but we cannot use "memmap on memory" altmap support at >>> this stage, w/o having it physically accessible. >>> >>> Since no ACPI or similar events are generated, there is no way to set up >>> altmap support, or even make the memory physically accessible at all, >>> before the "memmap on memory" initialization in memory_block_online(). >>> >>> The new MEM_PHYS_ONLINE notifier allows to work around this, by >>> providing a hook to make the memory physically accessible, and also call >>> __add_pages() with altmap support, early in memory_block_online(). >>> Similarly, the MEM_PHYS_OFFLINE notifier allows to make the memory >>> inaccessible and call __remove_pages(), at the end of >>> memory_block_offline(). >>> >>> Calling __add/remove_pages() requires mem_hotplug_lock, so move >>> mem_hotplug_begin/done() to include the new notifiers. >>> >>> All architectures ignore unknown memory notifiers, so this patch should >>> not introduce any functional changes. >> >> Sorry to say, no. No hacks please, and this is a hack for memory that has >> already been added to the system. >> >> If you want memory without an altmap to suddenly not have an altmap anymore, >> then look into removing and readding that memory, or some way to convert >> offline memory. > > Sorry, I couldnt get the context. Could you please give me more details? See my reply to Gerald. In an ideal world, there would not be any new callbacks, we would get rid of them, and just let the architecture properly hotplug memory to the system when requested by the user. -- Cheers, David / dhildenb