From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8480C48297 for ; Mon, 12 Feb 2024 14:19:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 434186B0074; Mon, 12 Feb 2024 09:19:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3BD986B0075; Mon, 12 Feb 2024 09:19:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E8736B0078; Mon, 12 Feb 2024 09:19:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 06C1E6B0074 for ; Mon, 12 Feb 2024 09:19:22 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C5C4614099D for ; Mon, 12 Feb 2024 14:19:21 +0000 (UTC) X-FDA: 81783359322.06.9C0182B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 87D848000C for ; Mon, 12 Feb 2024 14:19:19 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gTOx+dVv; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707747559; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KdQyq15dmu/vW742NSYA7eol+qHrc++m5aFpTBakKcc=; b=o4bjLJK88dZ90QPgl17jsZYF0AOcr+lMT5/P7Rs7zjsv3JUG6425ESyYB9gUtiFd/wCW4s YqWUGgWU7bSS0yJnws2tfClobEYgIkWWUOj082H9gPcredyvSTZdB7+D2YlG1Ck/XG/ZZ1 +oL6ao9GzhQv1BiMYjPa2JPVUXm25ug= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gTOx+dVv; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707747559; a=rsa-sha256; cv=none; b=a1qgGwMRiqAO5HXY6ChLCmYHn3vC9wnWQMr37G5MaRiphZGOPjhzRzw0fhzaCnaL3W9EHO vk2bB0bxVVRsEzeHN0aoXhMRu9iDJVBngkIf2Z5qV2F1XtMf4z1kip948Sxl5Xb7sMC2F4 ZDm1I0pHrsVdoWnoKGn4w5YAozhp8ys= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707747558; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KdQyq15dmu/vW742NSYA7eol+qHrc++m5aFpTBakKcc=; b=gTOx+dVvz5xn8hLo5DiyHujDwxNxyNiezcHqFr3JxR3qhQPVEHSBItUPGN3nYIqHaxjR8w v0tkBaiBvr0MLrxBaVAkDzMHZRIl2ZXVDv1ihPjMBkSKi00ak4Dy12KSoVo8QQ9GPRhhKb KfGcbDUF+3AThYHfLFP5GiW6DApSWQs= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-151-AcBlD_7LO3uOrB1qz4tb2w-1; Mon, 12 Feb 2024 09:19:17 -0500 X-MC-Unique: AcBlD_7LO3uOrB1qz4tb2w-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-337bf78ef28so1143042f8f.3 for ; Mon, 12 Feb 2024 06:19:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707747556; x=1708352356; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KdQyq15dmu/vW742NSYA7eol+qHrc++m5aFpTBakKcc=; b=JKgwUPf7NA7uPceyllG9Kajt4+bflWR9BJB3JzAYE8H5A9MbHc02kpjdFReEZBsVSL IAorLFdso3InHWB0Ip3+hSMP8xi0C0JH0GjJBBE4JIY/jlsXGAaYL+DfIrbNXxxX4MOE /2mYbAknFf+FiscIKea/jXb9KsXqBtfXz6hgtDrmTnqBckVHAjt99SkySiR55MuLSktQ V9IbArf3wUwNKGGBKVEcQY1fYX7J5tAIrUuVHx5K6Wht+Epgc02jUHKuVPjNGuvu7HAI 3th+ejwHZl6VaqZ28vyDmyrWAvVdwYH8RGVH4PhZFO/ngAl4/Vk1iUGrq8oewdxrNIAK D/iA== X-Gm-Message-State: AOJu0YxgAuRuvHsAfse0sQ5tJRlfX/l1YvzEoSlS/UFiJexSAUTCosEc gsxVVZ7xpyXXSH4ddgDzMYuyUr6GezmbIEcHk390ygusQqRG10bUmeV0+fwP/mMD5Kkq4Tihmyn espD5N1F5wj7A4mmtLzfISdhi+5gqevavx8S2UY54r+gHutcX X-Received: by 2002:a5d:69cd:0:b0:33b:4ac7:224c with SMTP id s13-20020a5d69cd000000b0033b4ac7224cmr4637494wrw.13.1707747556148; Mon, 12 Feb 2024 06:19:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IFDVRzBzkFQ83bEbY+lChHQ7exeRhG46Lx2P594IWjJkzAXyhqGvCydJzGmcxdEyNo3ehdTmQ== X-Received: by 2002:a5d:69cd:0:b0:33b:4ac7:224c with SMTP id s13-20020a5d69cd000000b0033b4ac7224cmr4637479wrw.13.1707747555785; Mon, 12 Feb 2024 06:19:15 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCU9Trjf3o0USZ05XJLpdaUPsAbut+JeqrWqUdZRtiQDFi17Otuah6pvaV0j01E+tXRzFzghY2xWPwBF1ynjFzshvStCGJzEqOhjMKoUXQXPA3sxOLGXPE6mfQg/QiWEuhw3qNb2qstFvAsdMqsdKO5+5ba60JhcZGEFHEWpk3rPXxxMLlS3clcME2jVLqlmX7mQHfOHQjVg8GCra9eqgp64Nzt3UBwGiKGWkh+nsWqhgJ7PUcOCvg1gdeOWS0/4eI8DoRCdh/XxIgbHzN6jAJX1TKF31TTdYtZRVE7x7w== Received: from ?IPV6:2003:cb:c730:2200:7229:83b1:524e:283a? (p200300cbc7302200722983b1524e283a.dip0.t-ipconnect.de. [2003:cb:c730:2200:7229:83b1:524e:283a]) by smtp.gmail.com with ESMTPSA id n14-20020a056000170e00b0033b5b5033b9sm7047109wrc.18.2024.02.12.06.19.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Feb 2024 06:19:15 -0800 (PST) Message-ID: Date: Mon, 12 Feb 2024 15:19:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/hugetlb: Move page order check inside hugetlb_cma_reserve() To: Anshuman Khandual , linux-mm@kvack.org Cc: Catalin Marinas , Will Deacon , Michael Ellerman , Nicholas Piggin , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20240209054221.1403364-1-anshuman.khandual@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240209054221.1403364-1-anshuman.khandual@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 87D848000C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 8zbhxwaknphjbk1czqofm7o8pemdyb9p X-HE-Tag: 1707747559-792772 X-HE-Meta: U2FsdGVkX18KDZckID2O126x8tONKo6ckw69EznH7Efc2CqOf87uBQzwtuzC2hUxt0yf+XhG5fzSlbJ0BUvlSwkvHga49qXObJB4J2GoAoxUc9muk6hCqBxWafdoBODZHDsVrPU02zstG4MLQuqydwKB20QgN+P9slDKvCqANGfv9XMtSAax48izsKX0gPMPauQRKl+izykrrhMLBJN+pb6UFdc8mluIiZUebJPWXKMv46dC69lstk8a0kPDCa/flZZP/5UEPHCAlJ/90txqL+kZx0A7yr+EUYDsI7RU1tqA76afExLN4gHOFXS8X9k/S2eLG4NxtSPju66QPlzS0+lqGyoSO+Nv2jJWB//FIBAUiGPHhDIxwVmj4doWnwEhgGt+FspPR+SOY+Da3UWixHg+R/JZsB15vA/LbSDi0UbwAwsf4BycLF44JNon0Pf6jtmyF3S5ZlaHBEm2Y0wZg/1csFzdUH0r1OFc/cgZvT9dMzxnz6s9m88X7wUqOPkSfNR0BKZ6IYfyzFh8E1ez92WTnde45TQ2J3SsY+rPlhLEKYDZuVhCxcjic2PT7s8wkgXh0LpqniaGe2vxGuhSIWeEtPwOb5IliWMI8ew7JUyTxWMvzAZ3jG2uJjNUImRbnyZ7nNBW7t/cw2fESX46cf0FP9x7bWhAqzF/CKLbW/pDF3pZueHKrIXkk8jQC+K0wfiaBr0aZ4hTZ0Z6qBiYWHCTxqvs1wOY20VjBb6AN9L+ZAscL8OpXyx9A+TIWH97t9rGdmfI4IaDklFtT+eiNbspXxe44Q7q8MHugj6/QFzCTzB0RKYqi/NO/UM1Sx0IjoacnMaHvX2+CK0kEiT+C+Zo1TlKpUn96bRmkNeTX/Bqj3SKd6clrA7yeuhefc2AT4JkY6p0hKQCQA7Nvf4aHjofFq+lNX9ISFv1orXNcfqwNVDojAtWnSOdTi9pTQDJU1iXbClm/U90m53L4AQ 3Q7s4zji +PAlcIwWI4R/k87W2R8t572d5D5VF/4se07XR800Jp71YOtKEB4gd9u9dZCiwZPxXgPS4aUdjDj4cdQcZssgeVaXfRHiv6dgslpFnWShahjjpCJvotIY00cmqueFIxUbjv47BHgY0RLd/wKjqG4LYBMGHJLz3G3sttKE3ku6EXuVwk36yTcQrgmCvzmHJeIzmF268n/qPxo9qOaoDRDaKzR9u2g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.02.24 06:42, Anshuman Khandual wrote: > All platforms could benefit from page order check against MAX_PAGE_ORDER > before allocating a CMA area for gigantic hugetlb pages. Let's move this > check from individual platforms to generic hugetlb. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Michael Ellerman > Cc: Nicholas Piggin > Cc: linux-arm-kernel@lists.infradead.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual > --- > This applies on v6.8-rc3 > > arch/arm64/mm/hugetlbpage.c | 7 ------- > arch/powerpc/mm/hugetlbpage.c | 4 +--- > mm/hugetlb.c | 7 +++++++ > 3 files changed, 8 insertions(+), 10 deletions(-) > > diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c > index 8116ac599f80..6720ec8d50e7 100644 > --- a/arch/arm64/mm/hugetlbpage.c > +++ b/arch/arm64/mm/hugetlbpage.c > @@ -45,13 +45,6 @@ void __init arm64_hugetlb_cma_reserve(void) > else > order = CONT_PMD_SHIFT - PAGE_SHIFT; > > - /* > - * HugeTLB CMA reservation is required for gigantic > - * huge pages which could not be allocated via the > - * page allocator. Just warn if there is any change > - * breaking this assumption. > - */ > - WARN_ON(order <= MAX_PAGE_ORDER); > hugetlb_cma_reserve(order); > } > #endif /* CONFIG_CMA */ > diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c > index 0a540b37aab6..16557d008eef 100644 > --- a/arch/powerpc/mm/hugetlbpage.c > +++ b/arch/powerpc/mm/hugetlbpage.c > @@ -614,8 +614,6 @@ void __init gigantic_hugetlb_cma_reserve(void) > */ > order = mmu_psize_to_shift(MMU_PAGE_16G) - PAGE_SHIFT; > > - if (order) { > - VM_WARN_ON(order <= MAX_PAGE_ORDER); > + if (order) > hugetlb_cma_reserve(order); > - } > } > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index cf9c9b2906ea..345b3524df35 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -7699,6 +7699,13 @@ void __init hugetlb_cma_reserve(int order) > bool node_specific_cma_alloc = false; > int nid; > > + /* > + * HugeTLB CMA reservation is required for gigantic > + * huge pages which could not be allocated via the > + * page allocator. Just warn if there is any change > + * breaking this assumption. > + */ > + VM_WARN_ON(order <= MAX_PAGE_ORDER); > cma_reserve_called = true; > > if (!hugetlb_cma_size) Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb