From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1F7CC433E1 for ; Wed, 8 Jul 2020 05:10:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 48ACE20720 for ; Wed, 8 Jul 2020 05:10:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 48ACE20720 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6ED5E6B000D; Wed, 8 Jul 2020 01:10:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 677336B000E; Wed, 8 Jul 2020 01:10:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 53FE76B0055; Wed, 8 Jul 2020 01:10:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0029.hostedemail.com [216.40.44.29]) by kanga.kvack.org (Postfix) with ESMTP id 3A5626B000D for ; Wed, 8 Jul 2020 01:10:14 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B4465181AEF0B for ; Wed, 8 Jul 2020 05:10:13 +0000 (UTC) X-FDA: 77013732306.27.suit61_5f0223f26eba Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id 8F63A3D66B for ; Wed, 8 Jul 2020 05:10:13 +0000 (UTC) X-HE-Tag: suit61_5f0223f26eba X-Filterd-Recvd-Size: 3404 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Wed, 8 Jul 2020 05:10:12 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D4242C0A; Tue, 7 Jul 2020 22:10:11 -0700 (PDT) Received: from [192.168.0.129] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8DB5C3F71E; Tue, 7 Jul 2020 22:10:09 -0700 (PDT) Subject: Re: [PATCH -next] Documentation/vm: fix tables in arch_pgtable_helpers To: Randy Dunlap , Linux MM , LKML , Andrew Morton , "linux-doc@vger.kernel.org" , Jonathan Corbet Cc: Mike Rapoport , "linux-arch@vger.kernel.org" References: <02ee60d0-e836-2237-4881-5c57ccac5551@infradead.org> <13943665-f1c8-dc34-37cc-a1f56ae57a5b@infradead.org> From: Anshuman Khandual Message-ID: Date: Wed, 8 Jul 2020 10:39:38 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <13943665-f1c8-dc34-37cc-a1f56ae57a5b@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8F63A3D66B X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07/08/2020 07:36 AM, Randy Dunlap wrote: > On 7/7/20 6:22 PM, Anshuman Khandual wrote: >> >> >> On 07/08/2020 06:37 AM, Randy Dunlap wrote: >>> From: Randy Dunlap >>> >>> Make the tables be presented as tables in the generated output files >>> (the line drawing did not present well). >>> >>> Signed-off-by: Randy Dunlap >>> Cc: Jonathan Corbet >>> Cc: linux-doc@vger.kernel.org >>> Cc: Anshuman Khandual >>> Cc: Mike Rapoport >>> Cc: linux-arch@vger.kernel.org >>> Cc: linux-mm@kvack.org >>> Cc: Andrew Morton >>> --- >>> Documentation/vm/arch_pgtable_helpers.rst | 333 ++++++-------------- >>> 1 file changed, 116 insertions(+), 217 deletions(-) >> >> Do you have a git URL some where to see these new output ? This >> documentation is also useful when reading from a terminal where >> these manual line drawing tables make sense. >> > > No, I don't have a git URL. > You can go to > https://drive.google.com/file/d/1FO6lCRKldzESwLdylvY8tw10dOBvwz84/view?usp=sharing > > I had to Download the file and then view it locally. I couldn't get Google Drive > to display it for me as html (only as text). I could see it locally as well on a browser and the table looks the same way like those current manual ones on a terminal, so looks good to me. > > I understand about reading tables at a terminal. > This file could have been a txt file for that, but it's not. It's a RsT file. Thats right. All files in Documentation/vm/ are .rst type, hence would not like to have a .txt type in there. > > If you want to leave it as is, please fix these warnings: Thats right. Can not have in both ways. Lets stick with .rst and change as required.