From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A9FFC433F5 for ; Thu, 19 May 2022 11:35:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C2B56B0072; Thu, 19 May 2022 07:35:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 672DF6B0073; Thu, 19 May 2022 07:35:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 513116B0074; Thu, 19 May 2022 07:35:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 436146B0072 for ; Thu, 19 May 2022 07:35:53 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1245460BA6 for ; Thu, 19 May 2022 11:35:53 +0000 (UTC) X-FDA: 79482288186.20.503060B Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf24.hostedemail.com (Postfix) with ESMTP id 3FFF5180004 for ; Thu, 19 May 2022 11:35:41 +0000 (UTC) Received: by mail-lf1-f47.google.com with SMTP id p4so7205004lfg.4 for ; Thu, 19 May 2022 04:35:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz-org.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=oxibleWjg5piZBF2UIB37tPZ8A10UXKI4apmU+0ZgSE=; b=8EB4pJ5d6ls+vf8cvcPsR22q2RxCetm5Iw2kafSsbt/+95CKUc0uKp5QkBhyrST1rt 6lHoRg71vpeaZsk1OKWJUv5oDbc4vDrSGqQayY++4QB2v5fjP99+fSXmZImkVJclh3kD S1+iwmP44Yu9mSMNikOkMHFLdC3dG6TZF/UUW33LiEmsmu7kReeJyjxE4ExaolC+/IpH eH7yaRloZsgKADBBLdppr1XLrzBvtgj/QwFOf1FheHSdwvtFkYTpryFD3a22LKiRtgsl X3bN8EENiOaDuYZghe5I9Doa8KS82H/H0bFJUhUloRLebbtVRhn8zx7Rx4i4I3udKAvb vEVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=oxibleWjg5piZBF2UIB37tPZ8A10UXKI4apmU+0ZgSE=; b=E2dqEvufXJMvvzCO0EGP/u/y0Z7Mmeu3SOoIox6YqfNj84h2qILABdC+gyNfQAva7t uEeIZK1b+tyzh4V3erUCE4kkKZ8TTYpn4k5Ntd8T1PU9P9b4ZjVp/ZB3uYFcpD4aofAf mZYaf9KBVFmreKAWZ3KLHKKNlbjzX+QJjw0smJp84gXw3TFT4+tr1O2J1AxAHma6ZxAr 0m5kjJaODu0DubpcH/ZlfX54cQTgppNwh9tlEmNEfoXuxstKdflTuYqaU1WAATqNc/34 yR1b39ciCMLuiXLxEgaxbHk/MdogJ1GIWthEmV7KOoAxlUaVM0orICKsAjPBFQ9HzSfA wNNg== X-Gm-Message-State: AOAM531fXgTcioPBx9Li8/NwAmPA1r6OnxTmznLnw/Zp3X43j60BmZe7 Xnlj1xhdhEsFdxhetQKYirebkA== X-Google-Smtp-Source: ABdhPJyBQ4HZaR0d2ga1ci2zALQ/cTNDEyY0EG9kBXrlEqKR9WuzxRCVaJLz8zEcc0SL+lFTe1PQeA== X-Received: by 2002:a05:6512:686:b0:473:9d94:372d with SMTP id t6-20020a056512068600b004739d94372dmr3000734lfe.623.1652960150032; Thu, 19 May 2022 04:35:50 -0700 (PDT) Received: from [192.168.43.196] ([185.174.128.243]) by smtp.gmail.com with ESMTPSA id j5-20020ac253a5000000b0047255d21163sm260922lfh.146.2022.05.19.04.35.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 May 2022 04:35:49 -0700 (PDT) Message-ID: Date: Thu, 19 May 2022 14:35:46 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v3] tracing: add 'accounted' entry into output of allocation tracepoints Content-Language: en-US To: Steven Rostedt Cc: YoPOhRctb8wwbmY5@carbon.kvack.org, Shakeel Butt , Roman Gushchin , Vlastimil Babka , Matthew Wilcox , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Muchun Song , kernel@openvz.org, linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , linux-mm@kvack.org, Joonsoo Kim , David Rientjes , Pekka Enberg , Christoph Lameter , Michal Hocko References: <20220518160447.20a7b96f@gandalf.local.home> From: Vasily Averin In-Reply-To: <20220518160447.20a7b96f@gandalf.local.home> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: wbcz69ho5fixhz6tfcptccxjpetz7ou1 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3FFF5180004 Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=openvz-org.20210112.gappssmtp.com header.s=20210112 header.b=8EB4pJ5d; spf=pass (imf24.hostedemail.com: domain of vvs@openvz.org designates 209.85.167.47 as permitted sender) smtp.mailfrom=vvs@openvz.org; dmarc=pass (policy=none) header.from=openvz.org X-Rspam-User: X-HE-Tag: 1652960141-900494 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/18/22 23:04, Steven Rostedt wrote: > On Wed, 18 May 2022 09:24:51 +0300 > Vasily Averin wrote: > > FYI, the subject should be something like: mm/tracing: > Because "tracing:" is reserved for tracing infrastructure updates. Thank you for noticing. >> @@ -33,42 +35,46 @@ DECLARE_EVENT_CLASS(kmem_alloc, >> __entry->bytes_req = bytes_req; >> __entry->bytes_alloc = bytes_alloc; >> __entry->gfp_flags = (__force unsigned long)gfp_flags; >> + __entry->accounted = (gfp_flags & __GFP_ACCOUNT) || >> + (s && s->flags & SLAB_ACCOUNT); > > Now you could make this even faster in the fast path and save just the > s->flags. > > __entry->sflags = s ? s->flags : 0; > >> ), >> >> - TP_printk("call_site=%pS ptr=%p bytes_req=%zu bytes_alloc=%zu gfp_flags=%s", >> + TP_printk("call_site=%pS ptr=%p bytes_req=%zu bytes_alloc=%zu gfp_flags=%s accounted=%s", >> (void *)__entry->call_site, >> __entry->ptr, >> __entry->bytes_req, >> __entry->bytes_alloc, >> - show_gfp_flags(__entry->gfp_flags)) >> + show_gfp_flags(__entry->gfp_flags), >> + __entry->accounted ? "true" : "false") > > And then have: "accounted=%s": > > (__entry->gfp_flags & __GFP_ACCOUNT) || > (__entry->sflags & SLAB_ACCOUNT) ? "true" : "false" Unfortunately this returns back sparse warnings about bitwise gfp_t and slab_flags_t casts. Could you please explain why your variant is faster? Thank you, Vasily Averin