From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93CE7C4167B for ; Thu, 2 Nov 2023 16:58:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED0838002C; Thu, 2 Nov 2023 12:58:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E59AD8D000F; Thu, 2 Nov 2023 12:58:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C85BF8002C; Thu, 2 Nov 2023 12:58:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B16D68D000F for ; Thu, 2 Nov 2023 12:58:35 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7D531140DDF for ; Thu, 2 Nov 2023 16:58:35 +0000 (UTC) X-FDA: 81413622990.20.5161234 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 143E940012 for ; Thu, 2 Nov 2023 16:58:32 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Xjrv6OSn; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698944313; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+uoFRKZcdXYVW2Lyv33oVxI1QleXZjyePdsYRiwdcgo=; b=zQcCvLLOMjzYJv4m3+eUREOmyRIxMHNF02K1HdAKjqxDCAcc/S6IrSo+btzbJlnqjA9gcU INF1uoD5KomDaozj8fAFFtkwDc5rMcsdomk/qGeOXCA1VnMfzux0om2lwBZjan3Rs9CfKm MIDPDe/sVeUREmfvIMbdr4/i/O+ISUk= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Xjrv6OSn; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698944313; a=rsa-sha256; cv=none; b=nfWmf3Lo/radTFSL0SKxxq3L9mESTL8gYnoOjOzJRaln6N7VZJWyDuBvrMCRsEbSzrTyXG KCVfnqsioz5822mrU3JhTWB61CAHnYy9a7jWbcJEWB8Z2YGN9Mk7XzfiAlTLVH7BYXRKSE ReWiYM2jyijyVgGpSHDzoQFIHLp1ADw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698944312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+uoFRKZcdXYVW2Lyv33oVxI1QleXZjyePdsYRiwdcgo=; b=Xjrv6OSn/xKVhVdyVFpQxRN4v5soSKKKl4CJf9aqLn9PSNVokSdvXhz82uuqRhU4H4s57b jSdrsJoY30ju7s8Jv/Kt89iSGR0OhMX5EPqUQyVbDrTFtRMNPG1zTlxYLSDeFqcHoSA5Bx aIzU0YKR/hW2X/8vxKTnY62JWJn8SAM= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-121-u4qqwzuCOsOWfnUrgh8hMw-1; Thu, 02 Nov 2023 12:58:29 -0400 X-MC-Unique: u4qqwzuCOsOWfnUrgh8hMw-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-32f5d49be0aso516937f8f.1 for ; Thu, 02 Nov 2023 09:58:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698944308; x=1699549108; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+uoFRKZcdXYVW2Lyv33oVxI1QleXZjyePdsYRiwdcgo=; b=TSfaVthA7YDA3XoItaxg7sD74cQHV5lqM+WYITrFshM8IQflrV0KnGQBySwNATnwz2 /J3a4/2e7UuBYqpHoeL4pVD2W9cLs0XmcChDyyqDi6DCqK1to+EyQonjmIwjzVDeCplF 4ocIe8Km2XPSnRsTLRoEgnSsCTyPRugCp3rJWHsLzyy12hjdBI8/M6/GADqwPcG2h44J lBUZOc5O3NoJxIsXWe0RmkqWvQVFDj+MMUZEBpyJkxK+6POgvvfdA3LoMYRsoh4FidBK B6g2E0IqqjxyS5Nx82PqPn027QL6cV6kfTl0xPKTk4jCQK4MRibukewgPCYKN514RPBL 4ipg== X-Gm-Message-State: AOJu0YwNV+rmldvsMeNAgpJ3PGaM3ujjzocq1YkkgZTOfdqftpgdPiHd hpbl9/17x49jFK+HFbnLzQ+VsbD4lfZahbAVMFg7nCxin6rRviXWI7pruroWL+j1+cnV/totjSE syTLtK93SfRI= X-Received: by 2002:a05:6000:1788:b0:32f:912d:2a3a with SMTP id e8-20020a056000178800b0032f912d2a3amr9421000wrg.61.1698944308614; Thu, 02 Nov 2023 09:58:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHpBlFmDtaXIpJHLhWL20bOlrCmnDsTZFkmLhX39O0OZ8qYE6XdOn989JUUwkUaTrd3RFMoYA== X-Received: by 2002:a05:6000:1788:b0:32f:912d:2a3a with SMTP id e8-20020a056000178800b0032f912d2a3amr9420977wrg.61.1698944308080; Thu, 02 Nov 2023 09:58:28 -0700 (PDT) Received: from ?IPV6:2003:cb:c716:3000:f155:cef2:ff4d:c7? (p200300cbc7163000f155cef2ff4d00c7.dip0.t-ipconnect.de. [2003:cb:c716:3000:f155:cef2:ff4d:c7]) by smtp.gmail.com with ESMTPSA id y4-20020adffa44000000b0032dc1fc84f2sm2963828wrr.46.2023.11.02.09.58.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Nov 2023 09:58:27 -0700 (PDT) Message-ID: Date: Thu, 2 Nov 2023 17:58:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/1] mm: report per-page metadata information To: Pasha Tatashin Cc: Wei Xu , Sourav Panda , corbet@lwn.net, gregkh@linuxfoundation.org, rafael@kernel.org, akpm@linux-foundation.org, mike.kravetz@oracle.com, muchun.song@linux.dev, rppt@kernel.org, rdunlap@infradead.org, chenlinxuan@uniontech.com, yang.yang29@zte.com.cn, tomas.mudrunka@gmail.com, bhelgaas@google.com, ivan@cloudflare.com, yosryahmed@google.com, hannes@cmpxchg.org, shakeelb@google.com, kirill.shutemov@linux.intel.com, wangkefeng.wang@huawei.com, adobriyan@gmail.com, vbabka@suse.cz, Liam.Howlett@oracle.com, surenb@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org, Greg Thelen References: <20231101230816.1459373-1-souravpanda@google.com> <20231101230816.1459373-2-souravpanda@google.com> <1e99ff39-b1cf-48b8-8b6d-ba5391e00db5@redhat.com> <025ef794-91a9-4f0c-9eb6-b0a4856fa10a@redhat.com> <99113dee-6d4d-4494-9eda-62b1faafdbae@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 143E940012 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: ay4zm9ty7k3gfwbf8ocsuu6qbgukdt1q X-HE-Tag: 1698944312-952041 X-HE-Meta: U2FsdGVkX1+/bTm9s1i2Ebgzm/ypR8Dg/M7BdO5qCo8NavFL3ubgE0nggVSZ5C1Z101M04v7XpFwF/oA9SuQRzqhYWBmUANdIEbLMl9sOS93yC1r2uSr3Q1akfHc7zpfHgCAH0tn64TwK5dOh0mE1e3Vfa8oVXymGZzW/mi+S4n1ftHfCiR4dVV1SKNLGAO3nppHNuplOh8H+cLIbmmZAp6me9+4vgdOlPCGvfRLrtgFsw0x0PJIkk/c8tMNW4Nl9T6yXh+JlAQNGCEqbaqtBd7Z99Df9LwrwhsKXCjiojUBtH9agRkdmOFSILUvFhzhcStfKJpb7ZXHLazDZfuki5Le6lNuoJJtolKvrxVDp2bfd5xiMSawbcJqC6/1WXxVHljon1IlJgUQdckIE+6XeKQkwSh7yrzhrXOlVL5gDApGWeGGYN1AUNBjsl7SM09bmgocqWtz0q8CUNT72PzqJaDCMUIgYQxg2XmkK9uU6NiBeEKLd1AF3XnKV5vSFyxec5yFtFUee+v0HNIuKbzBUG3WbVsKCdRRE/+W22gKkfX2tXE49z3tTHGjlnxwxVoMdYin6TCq68BRuAXMpxdvTytCs1bAgMCDxlQpTetJ4Sz854AV9cTbOxwPtb8c6RUTvFI8P+U0/dyMpwGW7kI6THLADr8WxQidPHM7ynXQFGgAS/Vc0UcaiZDQEce3/hNqaiVP71UuMrR0TQSyGUy4UfJpwLdAsL/YNOwre5f0Go0xaCE8P+dP93oO0mDenAlzCPTUcQultka9kldbrhM9OAay83vA5qOHEqgAUo7VCtLAf0ESoCzL11kNRufZ8Prf0O1rO6ESbVd8eB5wjtmlQmLXIg14QPnZtgvwxs+4/WKpJbXz804+MdaPlEm3wc2++vGsA/Jb2gN2vsMvH6HgYptie7xGTXLuOl5F2EjeoQZI3Wt8quDE9luCzx5h+88bfGS6Bdq9wT17fLiQK6X K5aHdd/c 280Ju5DsiSsB7050gwOFR1WhZdIqJLpaHbELn1lrdVQbqFMVRn+I/rscHoJ+6hHLD3Z+I5oqwQaJRdA4DjehHxNtC2Z34kqWJX5Ipl4EkYpwNgLE678+os1+7GZRJlPda139bDLXk50z+i0G/EQh3T3dSrx6c4DX7yPTqz78cxxSDNlbU5I+SRKFRh36vul0OGqNKODUVM6kk6qgZkXSXx+2KaeKb70nnaFmUvH58YW0oYpFwEkCANecJ57UZDrgHSMrKFp+IkdupXjm7uN4+4eKsB5l9EiVsK+7FLGbwyDbDx/EID4xZDpNGDRxEoHXe1QwmVbienpS46yYAmfI9EYbSPE+mf4A5xUyeFw3qkllhs1IXKg5WTFcQS9w+jmUluDScvGcV0FIuC6DI8/GS7rojaVnkXsaldLy3fcLen9a2fjU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.11.23 17:43, Pasha Tatashin wrote: > On Thu, Nov 2, 2023 at 12:09 PM David Hildenbrand wrote: >> >> On 02.11.23 17:02, Pasha Tatashin wrote: >>> On Thu, Nov 2, 2023 at 11:53 AM David Hildenbrand wrote: >>>> >>>> On 02.11.23 16:50, Pasha Tatashin wrote: >>>>>>> Adding reserved memory to MemTotal is a cleaner approach IMO as well. >>>>>>> But it changes the semantics of MemTotal, which may have compatibility >>>>>>> issues. >>>>>> >>>>>> I object. >>>>> >>>>> Could you please elaborate what you object (and why): you object that >>>>> it will have compatibility issues, or you object to include memblock >>>>> reserves into MemTotal? >>>> >>>> Sorry, I object to changing the semantics of MemTotal. MemTotal is >>>> traditionally the memory managed by the buddy, not all memory in the >>>> system. I know people/scripts that are relying on that [although it's >>>> been source of confusion a couple of times]. >>> >>> What if one day we change so that struct pages are allocated from >>> buddy allocator (i.e. allocate deferred struct pages from buddy) will >> >> It does on memory hotplug. But for things like crashkernel size >> detection doesn't really care about that. > > "Crash kernel" is a different case: it is kernel external memory, > similar to limiting the amount of physical memory via mem=/memmap=, it > sets memory that cannot be used by this kernel, but only by the crash > kernel. Also, the crash kernel reserve is exposed in /proc/iomem via > "Crash kernel" range. Agreed. > > Page metadata memory on the other hand, is used by this kernel, and > also can be changed by this kernel depending on how the memory is > used: memdec, hotplug, THP, emulated pmem etc. And then, there is the "altmap" for dax, where the metadata is placed on the dax memory itself. I mean, it's system RAM (or NVDIMM or whatever) used for metadata, but not managed by the buddy. There is now also the "memmap_on_memory" feature for memory hotplug, where we do the same for ordinary hotplug memory (but some memory aside for the memmap and not allocate it from the buddy). We'd have to account that one as well as metadata, I think. I don't think it would get accounted under MemTotal (because, not managed by the buddy) as of now. > >>> it break those MemTotal scripts? What if the size of struct pages >>> changes significantly, but the overhead will come from other metadata >>> (i.e. memdesc) will that break those scripts? I feel like struct page >> >> Probably; but ideally the metadata overhead will be smaller with >> memdesc. And we'll talk about that once it gets real ;) > > The size and allocation of struct pages change MemTotal today, during > runtime, even without memdesc, I just brought it up, to emphasize that > this is something that we should resolve now before it gets worse. I don't quite see the immediate need for action, but I get what you are saying. It's a historical mess, but if we want to tackle it, we should tackle it completely and not only sort out the metadata accounting. > >>> memory should really be included into MemTotal, otherwise we will have >>> this struggle in the future when we try to optimize struct page >>> memory. >> How far do we want to go, do we want to include crashkernel reserved >> memory in MemTotal because it is system memory? Only metadata? what else >> allocated using memblock? >> >> Again, right now it's simple: MemTotal is memory managed by the buddy. >> >> The spirit of this patch set is good, modifying existing counters needs >> good justification. > > Wei, noticed that all other fields in /proc/meminfo are part of > MemTotal, but this new field may be not (depending where struct pages I could have sworn that I pointed that out in a previous version and requested to document that special case in the patch description. :) > are allocated), so what would be the best way to export page metadata > without redefining MemTotal? Keep the new field in /proc/meminfo but > be ok that it is not part of MemTotal or do two counters? If we do two > counters, we will still need to keep one that is a buddy allocator in > /proc/meminfo and the other one somewhere outside? IMHO, we should just leave MemTotal alone ("memory managed by the buddy that could actually mostly get freed up and reused -- although that's not completely true") and have a new counter that includes any system memory (MemSystem? but as we learned, as separate files), including most memblock allocations/reservations as well (metadata, early pagetables, initrd, kernel, ...). The you would actually know how much memory the system is using (exclusing things like crashmem, mem=, ...). That part is tricky, though -- I recall there are memblock reservations that are similar to the crashkernel -- which is why the current state is to account memory when it's handed to the buddy under MemTotal -- which is straight forward and simply. I'm happy to discuss this further, if that direction is worth exploring. -- Cheers, David / dhildenb